ecdsa_ext 0.3.3 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 14a1e1194f60d4d1bbd5d82d77c0d628b76fe3e9ed2efd9dccd5b213fd0506c1
-  data.tar.gz: 5f832b9a184acb52c59dece9f2db7fef06ba1535e118957100c36ba0895718b0
+  metadata.gz: 125f4595851c77d460e1edfa38919c125aa3c06fc469135fc1ba5fe16191a760
+  data.tar.gz: 609d0345ac21dde9f6274db647b7fac1c4a3c9a45cc7fe7a9b9864605cf1b01d
 SHA512:
-  metadata.gz: 8ea53f7ce5d08ce1766ec5ed7b9030416fb4bb70b9de4db9918656d66869fd1f7c36cff4f06e35bb5aece48e8e0f2ca8a292346b43a30c82c1115196a0d37e7b
-  data.tar.gz: c7fd59188a641436c3878254299487bd8369565f72625aeb376ae058d9c728b091109ac6b6c87c830ae2f743dba1edcb02a193a29e6ff93c1d37b1d3b084f53f
+  metadata.gz: e38986f4f0ecd76a1ab4ac495e1e1d745bbdb0ccb66d81a672e3d8331b8a47b5d4fc726ea716d2f50db6ae91cbe09ed89a01e5bc612fe7467b5485e2adad7326
+  data.tar.gz: 15d1f967986650ce026dc8e6bec695035d2002f69238f96db1324b4ffe736d1adbe653ee1d3c90f4bd67e80a69fdf47d65b6f39f2f4c9fcb3e103dce542c1fab

data/README.md

@@ -82,4 +82,13 @@ affine_point = projective_point4.to_affine
 Jacobian coordinates have been supported since 0.3.0.
 
 When using Jacobian coordinates, use `ECDSA::Ext::JacobianPoint` instead of `ECDSA::Ext::ProjectivePoint`.
-In addition, `ECDSA::Point` now has a `to_jacobian` method that convert affine coordinates to jacobian coordinates.
+In addition, `ECDSA::Point` now has a `to_jacobian` method that convert affine coordinates to jacobian coordinates.
+
+### Apply jacobian coordinates to existing ECDSA sign/verify
+
+If you want the existing ECDSA gem to generate and verify signatures in Jacobian coordinates,
+add the following code. This code is a monkey patch to do the existing process in Jacobian coordinates.
+
+```ruby
+require 'ecdsa/ext/sign_verify'
+```

data/lib/ecdsa/ext/abstract_point.rb

@@ -41,9 +41,8 @@ module ECDSA
       end
 
       # Create infinity point
-      # @return [ECDSA::Ext::JacobianPoint]
+      # @return [ECDSA::Ext::AbstractPoint]
       def self.infinity_point(group)
-        # new(group, :infinity)
         new(group, :infinity)
       end
 

data/lib/ecdsa/ext/jacobian_point.rb

@@ -28,14 +28,25 @@ module ECDSA
         return self if other.y.zero? || other.z.zero?
 
         unless x == other.x
-          if z == other.z
-            return(
+          new_point =
+            if z == other.z
               z == 1 ? add_with_z_one(self, other) : add_with_z_eq(self, other)
+            elsif z == 1
+              add_with_z2_one(other, self)
+            elsif other.z == 1
+              add_with_z2_one(self, other)
+            else
+              add_with_z_ne(self, other)
+            end
+          return(
+            (
+              if new_point.y.zero? || new_point.z.zero?
+                JacobianPoint.infinity_point(group)
+              else
+                new_point
+              end
             )
-          end
-          return add_with_z2_one(other, self) if z == 1
-          return add_with_z2_one(self, other) if other.z == 1
-          return add_with_z_ne(self, other)
+          )
         end
 
         return double if self == other

data/lib/ecdsa/ext/projective_point.rb

@@ -25,12 +25,18 @@ module ECDSA
         end
 
         unless x == other.x
+          new_point =
+            if group.param_a == field.mod(-3)
+              addition_negative3(self, other)
+            else
+              addition_any(self, other)
+            end
           return(
             (
-              if group.param_a == field.mod(-3)
-                addition_negative3(self, other)
+              if new_point.y.zero? || new_point.z.zero?
+                JacobianPoint.infinity_point(group)
               else
-                addition_any(self, other)
+                new_point
               end
             )
           )

data/lib/ecdsa/ext/sign_verify.rb

@@ -0,0 +1,76 @@
+# frozen_string_literal: true
+
+# A monkey patch to allow signature generation and verification of existing ECDSA with Jacobian coordinates.
+module ECDSA
+  def self.sign(group, private_key, digest, temporary_key)
+    # Second part of step 1: Select ephemeral elliptic curve key pair
+    # temporary_key was already selected for us by the caller
+    r_point = (group.generator.to_jacobian * temporary_key).to_affine
+
+    # Steps 2 and 3
+    point_field = PrimeField.new(group.order)
+    r = point_field.mod(r_point.x)
+    return nil if r.zero?
+
+    # Step 4, calculating the hash, was already performed by the caller.
+
+    # Step 5
+    e = normalize_digest(digest, group.bit_length)
+
+    # Step 6
+    s =
+      point_field.mod(
+        point_field.inverse(temporary_key) * (e + r * private_key)
+      )
+    return nil if s.zero?
+
+    Signature.new r, s
+  end
+
+  def self.check_signature!(public_key, digest, signature)
+    group = public_key.group
+    field = group.field
+
+    # Step 1: r and s must be in the field and non-zero
+    unless field.include?(signature.r)
+      raise InvalidSignatureError, "Invalid signature: r is not in the field."
+    end
+    unless field.include?(signature.s)
+      raise InvalidSignatureError, "Invalid signature: s is not in the field."
+    end
+    if signature.r.zero?
+      raise InvalidSignatureError, "Invalid signature: r is zero."
+    end
+    if signature.s.zero?
+      raise InvalidSignatureError, "Invalid signature: s is zero."
+    end
+
+    # Step 2 was already performed when the digest of the message was computed.
+
+    # Step 3: Convert octet string to number and take leftmost bits.
+    e = normalize_digest(digest, group.bit_length)
+
+    # Step 4
+    point_field = PrimeField.new(group.order)
+    s_inverted = point_field.inverse(signature.s)
+    u1 = point_field.mod(e * s_inverted)
+    u2 = point_field.mod(signature.r * s_inverted)
+
+    # Step 5
+    r =
+      (group.generator.to_jacobian * u1 + public_key.to_jacobian * u2).to_affine
+    if r.infinity?
+      raise InvalidSignatureError, "Invalid signature: r is infinity in step 5."
+    end
+
+    # Steps 6 and 7
+    v = point_field.mod r.x
+
+    # Step 8
+    if v != signature.r
+      raise InvalidSignatureError, "Invalid signature: v does not equal r."
+    end
+
+    true
+  end
+end

data/lib/ecdsa/ext/version.rb

@@ -2,6 +2,6 @@
 
 module ECDSA
   module Ext
-    VERSION = "0.3.3"
+    VERSION = "0.4.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ecdsa_ext
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.4.1
 platform: ruby
 authors:
 - azuchi
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-03-07 00:00:00.000000000 Z
+date: 2023-03-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ecdsa
@@ -52,6 +52,7 @@ files:
 - lib/ecdsa/ext/point.rb
 - lib/ecdsa/ext/projective_arithmetic.rb
 - lib/ecdsa/ext/projective_point.rb
+- lib/ecdsa/ext/sign_verify.rb
 - lib/ecdsa/ext/version.rb
 - lib/ecdsa_ext.rb
 - sig/ecdsa_ext.rbs