eaternet 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9a0ddbd370e7b0031ec01be4326651038c0c39e0
-  data.tar.gz: a79d320f380f19320389aba560df3e5d7b82360c
+  metadata.gz: 928eb7167530d756d5a7b031388d09a511bb0bb4
+  data.tar.gz: 9f692333174312985c4cffc6904402afe7f7d199
 SHA512:
-  metadata.gz: 883b37c06d500ffc1465f37dba5a4682dd848cd32450db73d0e4ddbff4dd8b50043f79ae0501fb97926be527e69451300f81c8090a2f9db024219eb34c9ef24e
-  data.tar.gz: 4908a880ffd3a97430789da41652ab611246b30ea2635013872ad657c80cbb6d3ea1796f93cc78f9e939dacb34f874b696c4e45fc227137d73308787337f0704
+  metadata.gz: f08b598e00b84458f74914bd436d5104c2b3c964312dbd728a340aa68fcea6f60ea13659180640cb58f662cf3ac53c0211a54f93ef16f3a94d8b5230a12bb699
+  data.tar.gz: 5cf0c325b95f29bc3bd205ebb137c9f9ad5bcf38fac647327680b03bbba0a153f7f82533f8aca5e79d44e989ba5ef68066837cd4a087a081a96ab2fdaac865b9

data/.gitignore

@@ -18,6 +18,7 @@ mkmf.log
 /vcr_cassettes/
 /test/vcr_cassettes/
 .minitest-perf.db
+log.txt
 
 # IDE's
 *.komodoproject

data/lib/eaternet.rb

@@ -1,14 +1,16 @@
 require 'eaternet/agencies/multco'
 require 'eaternet/agencies/nyc'
+require 'eaternet/agencies/sf'
 require 'eaternet/agencies/snhd'
 
 module Eaternet
   # Make the actual adapters easily available
   # to the application-level as:
   #
-  # * `Eaternet::Multco` — Portland area, Oregon, USA
   # * `Eaternet::Nyc`    – New York City
+  # * `Eaternet::Sf`     - San Francisco
   # * `Eaternet::Snhd`   — Las Vegas area
+  # * `Eaternet::Multco` — Portland area, Oregon, USA
   include Eaternet::Agencies
 end
 

data/lib/eaternet/agencies/sf.rb

@@ -0,0 +1,86 @@
+require 'csv'
+require 'date'
+
+require 'eaternet/lives_1_0/adapter'
+require 'eaternet/lives_1_0/csv_parser'
+require 'eaternet/loggable'
+require 'eaternet/util'
+
+module Eaternet
+  module Agencies
+    class Sf < Eaternet::Lives_1_0::Adapter
+      include Eaternet::Loggable
+      include Eaternet::Lives_1_0::CsvParser
+
+      def businesses
+        convert csv: 'businesses.csv', to_type: :business
+      end
+
+      def inspections
+        convert csv: 'inspections.csv', to_type: :inspection
+      end
+
+      def violations
+        convert csv: 'violations.csv', to_type: :violation
+      end
+
+      def feed_info
+        Eaternet::Lives_1_0::FeedInfo.new do |fi|
+          fi.feed_date = Date.today
+          fi.feed_version = '1.0'
+          fi.municipality_name = 'San Francisco'
+          fi.municipality_url = 'https://www.sfdph.org/dph/EH/Food/Score/default.asp'
+          fi.contact_email = 'contact@sfdph.org'
+        end
+      end
+
+      def adapter_name
+        'SF'
+      end
+
+      def zip_file_url
+        'https://extxfer.sfdph.org/food/SFBusinesses.zip'
+      end
+
+      private
+
+      def business(csv_row)
+        Eaternet::Lives_1_0::Business.new do |b|
+          csv_row.headers.each do |header|
+            b.send("#{header.downcase}=", csv_row[header])
+          end
+        end
+      end
+
+      def inspection(csv_row)
+        Eaternet::Lives_1_0::Inspection.new do |b|
+          csv_row.headers.each do |header|
+            b.send("#{header.downcase}=", csv_row[header])
+            b.date = Date.parse(csv_row['date'])
+            b.score = csv_row['Score'].to_i
+          end
+        end
+      end
+
+      def violation(csv_row)
+        Eaternet::Lives_1_0::Violation.new do |b|
+          csv_row.headers.each do |header|
+            b.send("#{header.downcase}=", csv_row[header])
+            b.date = Date.parse(csv_row['date'])
+            b.description = fix(description: csv_row['description'])
+          end
+        end
+      end
+
+      def fix(description:)
+        # Remove bracketed violation facts, non-conforming to LIVES
+        return description unless description =~ /^([^\[]+)/
+        $1.strip
+      end
+
+      def csv_reader(path:)
+        CSV.new(open(path, encoding: 'ISO-8859-1'), headers: true)
+      end
+    end
+  end
+end

data/lib/eaternet/lives_1_0/csv_parser.rb

@@ -0,0 +1,40 @@
+module Eaternet
+  module Lives_1_0
+    module CsvParser
+
+      def adapter_name
+        fail 'Override with a name for log output, e.g. "SF"'
+      end
+
+      def zip_file_url
+        fail 'Override with the zip archive location'
+      end
+
+      def convert(csv:, to_type:)
+        csv_map(csv) { |row| try_to_create to_type, from_csv_row: row }
+      end
+
+      def csv_map(filename, &block)
+        csv_rows(filename).lazy.map { |row| block.call(row) }
+      end
+
+      def csv_rows(filename)
+        csv_reader(path: File.join(zip_dir, filename))
+      end
+
+      def zip_dir
+        @zip_dir ||= Util.download_and_extract_zipfile(zip_file_url)
+      end
+
+      def try_to_create(entity_type, from_csv_row:)
+        send(entity_type, from_csv_row)
+      rescue ArgumentError => e
+        logger.warn("#{adapter_name} LIVES adapter") do
+          "Couldn't create a LIVES #{entity_type} from #{from_csv_row.inspect}: #{e}"
+        end
+        nil
+      end
+
+    end
+  end
+end

data/lib/eaternet/version.rb

@@ -1,3 +1,3 @@
 module Eaternet
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
 end

data/test/eaternet/agencies/sf_test.rb

@@ -0,0 +1,87 @@
+require 'test_helper'
+require 'eaternet'
+
+class SfTest < Minitest::Test
+  # Instantiating as an app developer would:
+  @@sf = Eaternet::Sf.new
+
+  #
+  # Businesses
+  #
+
+  def test_businesses_returns_an_enumerator_of_business
+    VCR.use_cassette(SF_CASSETTE) do
+      assert enumerable_of? Eaternet::Lives_1_0::Business, @@sf.businesses
+    end
+  end
+
+  def test_businesses_returns_lives_attributes
+    VCR.use_cassette(SF_CASSETTE) do
+      b = @@sf.businesses.first
+      assert_equal '10', b.business_id
+      assert_equal 'TIRAMISU KITCHEN', b.name
+      assert_equal '033 BELDEN PL', b.address
+      assert_equal 'San Francisco', b.city
+      assert_equal '94104', b.postal_code
+      assert_equal 'CA', b.state
+      assert_equal '37.791116', b.latitude
+      assert_equal '-122.403816', b.longitude
+      assert_equal '', b.phone_number
+    end
+  end
+
+  #
+  # Inspections
+  #
+
+  def test_inspections_returns_an_enumerable_of_inspection
+    VCR.use_cassette(SF_CASSETTE) do
+      assert enumerable_of? Eaternet::Lives_1_0::Inspection, @@sf.inspections
+    end
+  end
+
+  def test_inspections_returns_lives_attributes
+    VCR.use_cassette(SF_CASSETTE) do
+      i = @@sf.inspections.first(6).last
+      assert_equal '17', i.business_id
+      assert_equal Date.new(2012, 8, 23), i.date
+      assert_equal 100, i.score
+    end
+  end
+
+  #
+  # Violations
+  #
+
+  def test_violations_returns_an_enumerable_of_violation
+    VCR.use_cassette(SF_CASSETTE) do
+      assert enumerable_of? Eaternet::Lives_1_0::Violation, @@sf.violations
+    end
+  end
+
+  def test_violations_returns_lives_attributes
+    VCR.use_cassette(SF_CASSETTE) do
+      v = @@sf.violations.first
+      assert_equal '10', v.business_id
+      assert_equal Date.new(2014, 7, 29), v.date
+      assert_equal nil, v.code
+      assert_match /^Insufficient hot water or running water$/, v.description
+    end
+  end
+
+  #
+  # metadata
+  #
+
+  def test_implements_feed_info
+    assert_instance_of Eaternet::Lives_1_0::FeedInfo, @@sf.feed_info
+  end
+
+  #
+  # Other
+  #
+
+  def test_handles_file_encoding
+    refute_nil @@sf.businesses.to_a
+  end
+end

data/test/test_helper.rb

@@ -8,7 +8,7 @@ VCR.configure do |c|
   c.cassette_library_dir = 'test/vcr_cassettes'
   c.hook_into :webmock
   c.ignore_hosts 'downloadtest.com'
-  c.default_cassette_options = { record: :new_episodes }
+  # c.default_cassette_options = { record: :new_episodes }
 end
 
 #
@@ -20,3 +20,4 @@ def enumerable_of?(a_class, obj)
 end
 
 SNHD_CASSETTE = 'snhd'
+SF_CASSETTE = 'sf'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eaternet
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Robb Shecter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-05 00:00:00.000000000 Z
+date: 2015-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -242,12 +242,14 @@ files:
 - lib/eaternet/agencies/multco.rb
 - lib/eaternet/agencies/multco_lib/misc.rb
 - lib/eaternet/agencies/nyc.rb
+- lib/eaternet/agencies/sf.rb
 - lib/eaternet/agencies/snhd.rb
 - lib/eaternet/agencies/snhd_config.rb
 - lib/eaternet/agencies/snhd_prototype.rb
 - lib/eaternet/lives_1_0.rb
 - lib/eaternet/lives_1_0/adapter.rb
 - lib/eaternet/lives_1_0/business.rb
+- lib/eaternet/lives_1_0/csv_parser.rb
 - lib/eaternet/lives_1_0/feed_info.rb
 - lib/eaternet/lives_1_0/inspection.rb
 - lib/eaternet/lives_1_0/legend.rb
@@ -261,6 +263,7 @@ files:
 - lib/ext/enumerator.rb
 - test/eaternet/agencies/multco_test.rb
 - test/eaternet/agencies/nyc_test.rb
+- test/eaternet/agencies/sf_test.rb
 - test/eaternet/agencies/snhd_prototype_test.rb
 - test/eaternet/agencies/snhd_test.rb
 - test/eaternet/eaternet_test.rb
@@ -294,13 +297,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.7
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Regional adapters for restaurant health scores
 test_files:
 - test/eaternet/agencies/multco_test.rb
 - test/eaternet/agencies/nyc_test.rb
+- test/eaternet/agencies/sf_test.rb
 - test/eaternet/agencies/snhd_prototype_test.rb
 - test/eaternet/agencies/snhd_test.rb
 - test/eaternet/eaternet_test.rb
@@ -314,3 +318,4 @@ test_files:
 - test/fixtures/morris-park-bake-shop.csv
 - test/script.rb
 - test/test_helper.rb
+has_rdoc: