eaternet 0.2.2 → 0.3.0

data/lib/eaternet/loggable.rb

@@ -0,0 +1,16 @@
+module Eaternet
+  module Loggable
+
+    def logger
+      @logger ||= create_logger
+    end
+
+    def create_logger
+      logger = Logger.new(ENV['EATERNET_LOG_FILE'] || $stderr)
+      logger.datetime_format = '%Y-%m-%d %H:%M:%S'
+      logger.progname = 'Eaternet'
+      logger
+    end
+
+  end
+end

data/lib/eaternet/prototype.rb

@@ -0,0 +1,112 @@
+module Eaternet
+  # A first pass at a health scores mini-framework which
+  # is denormalized and provides some more information than
+  # LIVES.
+  #:nodoc:
+  module Prototype
+
+    module AbstractAdapter
+      # @return [Enumerable<BusinessData>]
+      def businesses
+        fail 'Override this to return an Enumerable of BusinessData'
+      end
+
+      # @return [Enumerable<InspectionData>]
+      def inspections
+        fail 'Override this to return an Enumerable of InspectionData'
+      end
+
+      # @return [Enumerable<ViolationData>]
+      def violations
+        fail 'Override this to return an Enumerable of ViolationData'
+      end
+
+      # @return [Enumerable<ViolationData>]
+      def violation_kinds
+        fail 'Override this to return an Enumerable of ViolationKindData'
+      end
+    end
+
+    class BusinessData
+      # @return [String]
+      attr_reader :name, :address, :city, :zipcode, :orig_key
+
+      #:nodoc:
+      def initialize(name:, address:, city:, zipcode:, orig_key:)
+        @name = name
+        @address = address
+        @city = city
+        @zipcode = zipcode
+        @orig_key = orig_key
+      end
+
+      def ==(other)
+        @orig_key == other.orig_key
+      end
+
+      def eql?(other)
+        self == other
+      end
+
+      def hash
+        @orig_key.hash
+      end
+
+      # @return [String]
+      def to_s
+        "Business #{@orig_key}"
+      end
+    end
+
+    #:nodoc:
+    class InspectionData
+      # @return [String]
+      attr_reader :orig_key, :business_orig_key, :score, :date
+
+      def initialize(orig_key:, business_orig_key:, score:, date:)
+        @orig_key = orig_key
+        @business_orig_key = business_orig_key
+        @score = score
+        @date = date
+      end
+
+      def to_s
+        "Inspection #{@orig_key}"
+      end
+    end
+
+    #:nodoc:
+    class ViolationData
+      # @return [String]
+      attr_reader :orig_key, :inspection_id, :violation_kind_id
+
+      def initialize(orig_key:, inspection_id:, violation_kind_id:)
+        @orig_key = orig_key
+        @inspection_id = inspection_id
+        @violation_kind_id = violation_kind_id
+      end
+
+      def to_s
+        "Violation #{@orig_key}"
+      end
+    end
+
+    #:nodoc:
+    class ViolationKindData
+      # @return [String]
+      attr_reader :orig_key, :code, :demerits, :description
+
+      def initialize(orig_key:, code:, demerits:, description:)
+        @orig_key = orig_key
+        @code = code
+        @demerits = demerits
+        @description = description
+      end
+
+      def to_s
+        "ViolationKind #{@orig_key}"
+      end
+    end
+
+  end
+end

data/lib/eaternet/version.rb

@@ -1,3 +1,3 @@
 module Eaternet
-  VERSION = '0.2.2'
+  VERSION = '0.3.0'
 end

data/test/lives_1_0/business_test.rb

@@ -1,10 +1,8 @@
 require 'test_helper'
 
-require 'eaternet/framework/lives_1_0'
+require 'eaternet/lives_1_0'
 
 class BusinessTest < Minitest::Test
-  include Eaternet::Framework
-
   #
   # Business#latitude and Business#longitude
   #
@@ -12,7 +10,7 @@ class BusinessTest < Minitest::Test
   PORTLAND_OR_US = { lat: 45.5236111, lon: -122.675 }
 
   def test_business_without_lat_and_lon
-    business = Lives_1_0::Business.new do |i|
+    business = Eaternet::Lives_1_0::Business.new do |i|
       i.business_id = '789123hjd'
       i.name = 'Starbucks'
       i.address = '123 Happy Lane'
@@ -22,7 +20,7 @@ class BusinessTest < Minitest::Test
 
   def test_business_rejects_lat_and_lon_which_are_not_numbers
     assert_raises(ArgumentError) {
-      business = Lives_1_0::Business.new do |i|
+      Eaternet::Lives_1_0::Business.new do |i|
         i.business_id = '789123hjd'
         i.name = 'Starbucks'
         i.address = '123 Happy Lane'
@@ -33,7 +31,7 @@ class BusinessTest < Minitest::Test
   end
 
   def test_business_with_lat_and_lon
-    business = Lives_1_0::Business.new do |i|
+    business = Eaternet::Lives_1_0::Business.new do |i|
       i.business_id = '789123hjd'
       i.name = 'Starbucks'
       i.address = '123 Happy Lane'
@@ -45,7 +43,7 @@ class BusinessTest < Minitest::Test
 
   def test_business_rejects_invalid_latitude
     assert_raises(ArgumentError) {
-      business = Lives_1_0::Business.new do |i|
+      Eaternet::Lives_1_0::Business.new do |i|
         i.business_id = '789123hjd'
         i.name = 'Starbucks'
         i.address = '123 Happy Lane'
@@ -57,7 +55,7 @@ class BusinessTest < Minitest::Test
 
   def test_business_rejects_invalid_longitude
     assert_raises(ArgumentError) {
-      business = Lives_1_0::Business.new do |i|
+      Eaternet::Lives_1_0::Business.new do |i|
         i.business_id = '789123hjd'
         i.name = 'Starbucks'
         i.address = '123 Happy Lane'
@@ -73,12 +71,11 @@ class BusinessTest < Minitest::Test
 
   def test_business_rejects_blank_name
     assert_raises(ArgumentError) {
-      business = Lives_1_0::Business.new do |i|
+      Eaternet::Lives_1_0::Business.new do |i|
         i.business_id = '789123hjd'
         i.name = ''
         i.address = '123 Happy Lane'
       end
     }
   end
-
 end

data/test/lives_1_0/feed_info_test.rb

@@ -1,10 +1,8 @@
 require 'test_helper'
 
-require 'eaternet/framework/lives_1_0'
+require 'eaternet/lives_1_0'
 
 class FeedInfoTest < Minitest::Test
-  include Eaternet::Framework::Lives_1_0
-
   def set_required_attrs(feed_info)
     feed_info.feed_date = Date.new(2015, 1, 1)
     feed_info.feed_version = '1.0'
@@ -12,7 +10,7 @@ class FeedInfoTest < Minitest::Test
   end
 
   def setup
-    @dallas = FeedInfo.new { |i| set_required_attrs(i) }
+    @dallas = Eaternet::Lives_1_0::FeedInfo.new { |i| set_required_attrs(i) }
   end
 
 
@@ -22,7 +20,7 @@ class FeedInfoTest < Minitest::Test
 
   def test_rejects_when_missing_feed_date
     assert_raises(ArgumentError) {
-      FeedInfo.new do |i|
+      Eaternet::Lives_1_0::FeedInfo.new do |i|
         i.feed_version = '1.0'
         i.municipality_name = 'NYC'
       end
@@ -66,5 +64,4 @@ class FeedInfoTest < Minitest::Test
     @dallas.contact_email = 'myaddress.com'
     refute @dallas.valid?
   end
-
 end

data/test/lives_1_0/inspection_test.rb

@@ -1,16 +1,14 @@
 require 'test_helper'
 
-require 'eaternet/framework/lives_1_0'
+require 'eaternet/lives_1_0'
 
 class InspectionTest < Minitest::Test
-  include Eaternet::Framework
-
   #
   # Inspection#type
   #
 
   def test_with_a_valid_type
-    inspection = Lives_1_0::Inspection.new do |i|
+    inspection = Eaternet::Lives_1_0::Inspection.new do |i|
       i.business_id = 'abcdef1'
       i.score = 98
       i.date = Date.new(2012, 2, 3)
@@ -21,7 +19,7 @@ class InspectionTest < Minitest::Test
 
   def test_rejects_unspecified_types
     assert_raises(ArgumentError) {
-      inspection = Lives_1_0::Inspection.new do |i|
+      inspection = Eaternet::Lives_1_0::Inspection.new do |i|
         i.business_id = 'abcdef1'
         i.score = 98
         i.date = Date.new(2012, 2, 3)
@@ -31,7 +29,7 @@ class InspectionTest < Minitest::Test
   end
 
   def test_without_a_type
-    inspection = Lives_1_0::Inspection.new do |i|
+    inspection = Eaternet::Lives_1_0::Inspection.new do |i|
       i.business_id = 'abcdef1'
       i.score = 98
       i.date = Date.new(2012, 2, 3)
@@ -45,7 +43,7 @@ class InspectionTest < Minitest::Test
   #
 
   def test_accepts_a_blank_score
-    inspection = Lives_1_0::Inspection.new do |i|
+    inspection = Eaternet::Lives_1_0::Inspection.new do |i|
       i.score = ''
       i.business_id = 'abcdef1'
       i.date = Date.new(2012, 2, 3)
@@ -54,7 +52,7 @@ class InspectionTest < Minitest::Test
   end
 
   def test_accepts_a_numeric_score
-    inspection = Lives_1_0::Inspection.new do |i|
+    inspection = Eaternet::Lives_1_0::Inspection.new do |i|
       i.score = 96
       i.business_id = 'abcdef1'
       i.date = Date.new(2012, 2, 3)
@@ -64,7 +62,7 @@ class InspectionTest < Minitest::Test
 
   def test_rejects_a_score_out_of_bounds
     assert_raises(ArgumentError) {
-      inspection = Lives_1_0::Inspection.new do |i|
+      Eaternet::Lives_1_0::Inspection.new do |i|
         i.score = 101
         i.business_id = 'abcdef1'
         i.date = Date.new(2012, 2, 3)
@@ -74,14 +72,14 @@ class InspectionTest < Minitest::Test
 
   def test_rejects_a_non_numeric_score
     assert_raises(ArgumentError) {
-      inspection = Lives_1_0::Inspection.new do |i|
+      Eaternet::Lives_1_0::Inspection.new do |i|
         i.score = '100'
         i.business_id = 'abcdef1'
         i.date = Date.new(2012, 2, 3)
       end
     }
     assert_raises(ArgumentError) {
-      inspection = Lives_1_0::Inspection.new do |i|
+      Eaternet::Lives_1_0::Inspection.new do |i|
         i.score = 'A'
         i.business_id = 'abcdef1'
         i.date = Date.new(2012, 2, 3)
@@ -90,11 +88,10 @@ class InspectionTest < Minitest::Test
   end
 
   def test_with_no_score_sets_it_to_blank
-    inspection = Lives_1_0::Inspection.new do |i|
+    inspection = Eaternet::Lives_1_0::Inspection.new do |i|
       i.business_id = 'abcdef1'
       i.date = Date.new(2012, 2, 3)
     end
     assert_equal('', inspection.score)
   end
-
 end

data/test/lives_1_0/legend_test.rb

@@ -1,18 +1,16 @@
 require 'test_helper'
 
-require 'eaternet/framework/lives_1_0'
+require 'eaternet/lives_1_0'
 
 class LegendTest < Minitest::Test
-  include Eaternet::Framework::Lives_1_0
-
-  def set_required_attrs(legend_record)
+  def setup_required_attrs(legend_record)
     legend_record.minimum_score = 98
     legend_record.maximum_score = 100
     legend_record.description =   'A+'
   end
 
   def setup
-    @a_plus = Legend.new { |l| set_required_attrs(l) }
+    @a_plus = Eaternet::Lives_1_0::Legend.new { |l| setup_required_attrs(l) }
   end
 
 
@@ -32,7 +30,7 @@ class LegendTest < Minitest::Test
 
   def test_rejects_when_missing_maximum_score
     assert_raises(ArgumentError) {
-      Legend.new do |legend_record|
+      Eaternet::Lives_1_0::Legend.new do |legend_record|
         legend_record.minimum_score = 100
         legend_record.description =   'A+'
       end
@@ -41,7 +39,7 @@ class LegendTest < Minitest::Test
 
   def test_rejects_when_missing_minimum_score
     assert_raises(ArgumentError) {
-      Legend.new do |legend_record|
+      Eaternet::Lives_1_0::Legend.new do |legend_record|
         legend_record.maximum_score = 100
         legend_record.description =   'A+'
       end
@@ -50,7 +48,7 @@ class LegendTest < Minitest::Test
 
   def test_rejects_when_missing_description
     assert_raises(ArgumentError) {
-      Legend.new do |legend_record|
+      Eaternet::Lives_1_0::Legend.new do |legend_record|
         legend_record.minimum_score = 95
         legend_record.maximum_score = 100
       end
@@ -58,7 +56,7 @@ class LegendTest < Minitest::Test
   end
 
   def test_rejects_when_description_not_a_string
-    @a_plus.description = ['the', 'highest', 'score']
+    @a_plus.description = %w(the highest score)
     refute @a_plus.valid?
   end
 
@@ -67,41 +65,41 @@ class LegendTest < Minitest::Test
   #
 
   def test_group_accepts_comprehensive_records
-    group = LegendGroup.new do |lg|
+    group = Eaternet::Lives_1_0::LegendGroup.new do |lg|
       lg.legends = [
-        Legend.new do |l|
+        Eaternet::Lives_1_0::Legend.new do |l|
           l.minimum_score = 95
           l.maximum_score = 100
           l.description =   'A+'
         end,
-        Legend.new do |l|
+        Eaternet::Lives_1_0::Legend.new do |l|
           l.minimum_score = 0
           l.maximum_score = 94
           l.description =   'F'
-        end,
+        end
       ]
     end
     refute_nil group
   end
 
   def test_group_accepts_records_overlapping_by_1
-    group = LegendGroup.new do |lg|
+    group = Eaternet::Lives_1_0::LegendGroup.new do |lg|
       lg.legends = [
-        Legend.new do |l|
+        Eaternet::Lives_1_0::Legend.new do |l|
           l.minimum_score = 95
           l.maximum_score = 100
           l.description =   'A+'
         end,
-        Legend.new do |l|
+        Eaternet::Lives_1_0::Legend.new do |l|
           l.minimum_score = 70
           l.maximum_score = 95
           l.description =   'B'
         end,
-        Legend.new do |l|
+        Eaternet::Lives_1_0::Legend.new do |l|
           l.minimum_score = 0
           l.maximum_score = 69
           l.description =   'F'
-        end,
+        end
       ]
     end
     refute_nil group
@@ -109,22 +107,22 @@ class LegendTest < Minitest::Test
 
   def test_legend_group_rejects_non_comprehensive_records
     assert_raises(ArgumentError) {
-      group = LegendGroup.new do |lg|
-        lg.legends = [ @a_plus ]
+      Eaternet::Lives_1_0::LegendGroup.new do |lg|
+        lg.legends = [@a_plus]
       end
     }
   end
 
   def test_legend_group_rejects_overlapping_records
     assert_raises(ArgumentError) {
-      group = LegendGroup.new do |lg|
+      Eaternet::Lives_1_0::LegendGroup.new do |lg|
         lg.legends = [
-          Legend.new do |l|
+          Eaternet::Lives_1_0::Legend.new do |l|
             l.minimum_score = 90
             l.maximum_score = 100
             l.description =   'A'
           end,
-          Legend.new do |l|
+          Eaternet::Lives_1_0::Legend.new do |l|
             l.minimum_score = 0
             l.maximum_score = 91
             l.description =   'B'
@@ -136,9 +134,9 @@ class LegendTest < Minitest::Test
 
   def test_legend_group_rejects_non_legend_objects
     assert_raises(ArgumentError) {
-      group = LegendGroup.new do |lg|
+      Eaternet::Lives_1_0::LegendGroup.new do |lg|
         lg.legends = [
-          Legend.new do |l|
+          Eaternet::Lives_1_0::Legend.new do |l|
             l.minimum_score = 90
             l.maximum_score = 100
             l.description =   'A'
@@ -148,5 +146,4 @@ class LegendTest < Minitest::Test
       end
     }
   end
-
 end