easybill 0.2.20 → 0.2.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 341539d5c1dea32f277d36ddf5174abc6d061c03
-  data.tar.gz: ec3bbe27d4f6dd368d0636cc0bfeb0b46a039cc2
+  metadata.gz: c118ec30890f5d76a08a4120796255ba0d7fa245
+  data.tar.gz: d4f5e13867771aadfbd1d7aba87a881963ad0176
 SHA512:
-  metadata.gz: 1d3b086f73d64012919bec3adaeff7696a43c76d1224411c64a85ff1bdaa4254f1953ffc231928cf012e7d5bb330b9eeb9f34b5aa6fbf62d4968d7d9224f7851
-  data.tar.gz: 5a100746f1ea807824b346552a3c9a3a5208d89ccd3bcc45c5fbcd7c6f92a3bd4c428ad6a032fe668c333396666cbe1b42eb3d515e8867934ab0b1ba9602548a
+  metadata.gz: 8b0fe6177d840fd5b9f4e4635519a9ff624dae9f54086aefb6a4f2abaf978ab0c6cb781ccdf333186143caea74a9ddca43c5faeb26cfedf47c955f0cfedddb18
+  data.tar.gz: 3ee4d7075182c1725d426ab53cb6772f01b85e0f123b938b8c0472364773858dd9acb7568539687299b1604c85b531876205af7f8e95330b8f7627529e590754

data/.rubocop_todo.yml

@@ -0,0 +1,29 @@
+# This configuration was generated by `rubocop --auto-gen-config`
+# on 2015-04-27 16:05:46 +0200 using RuboCop version 0.30.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 3
+Metrics/AbcSize:
+  Max: 22
+
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 103
+
+# Offense count: 2
+Metrics/CyclomaticComplexity:
+  Max: 7
+
+# Offense count: 21
+# Configuration parameters: AllowURI, URISchemes.
+Metrics/LineLength:
+  Max: 197
+
+# Offense count: 2
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 23

data/.ruby-version

@@ -1 +1 @@
-2.2.0
+2.2.1

data/Gemfile

@@ -1,3 +1,7 @@
 source 'https://rubygems.org'
 
 gemspec
+
+group :development, :test do
+  gem 'rubocop-ci', github: 'ad2games/rubocop-ci'
+end

data/README.md

@@ -1,5 +1,9 @@
 # Easybill
 
+[![Circle CI](https://circleci.com/gh/ad2games/easybill.svg?style=svg)](https://circleci.com/gh/ad2games/easybill)
+[![Code Climate](https://codeclimate.com/github/ad2games/easybill/badges/gpa.svg)](https://codeclimate.com/github/ad2games/easybill)
+[![Test Coverage](https://codeclimate.com/github/ad2games/easybill/badges/coverage.svg)](https://codeclimate.com/github/ad2games/easybill/coverage)
+
 A wrapper for the [Easybill](http://easybill.de) online invoice service.
 Create invoices, manage customer information and their payments using
 the SOAP API.

data/Rakefile

@@ -1 +1,2 @@
 require 'bundler/gem_tasks'
+require 'rubocop-ci'

data/circle.yml

@@ -0,0 +1,3 @@
+test:
+  pre:
+    - bundle exec rake rubocop

data/easybill.gemspec

@@ -4,17 +4,17 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'easybill/version'
 
 Gem::Specification.new do |gem|
-  gem.name          = 'easybill'
-  gem.version       = Easybill::VERSION
-  gem.authors       = ['ad2games GmbH']
-  gem.email         = ['developers@ad2games.com']
-  gem.description   = 'Create invoices with Easybill'
-  gem.summary       = 'A client library to the SOAP API of Easybill.de'
-  gem.homepage      = ''
+  gem.name = 'easybill'
+  gem.version = Easybill::VERSION
+  gem.authors = ['ad2games GmbH']
+  gem.email = ['developers@ad2games.com']
+  gem.description = 'Create invoices with Easybill'
+  gem.summary = 'A client library to the SOAP API of Easybill.de'
+  gem.homepage = ''
 
-  gem.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
-  gem.executables   = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
-  gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
+  gem.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
+  gem.executables = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
+  gem.test_files = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ['lib']
 
   gem.add_runtime_dependency 'sekken'

data/lib/easybill/client.rb

@@ -17,7 +17,7 @@ module Easybill
       find_documents_by_document_number: { op_name: 'findDocumentsByDocumentNumber', result_type: 'document' },
       get_document_pdf: { op_name: 'getDocumentPDF', result_type: 'document' },
       create_dunning: { op_name: 'createDunning', result_type: 'document' },
-      get_document_sent: { op_name: 'getDocumentSent', result_type: 'document' },
+      get_document_sent: { op_name: 'getDocumentSent', result_type: 'document' }
     }
 
     def initialize(options = {})
@@ -73,9 +73,9 @@ module Easybill
           # Work around issue on Easybill's side.
           faultstring = response.body[:fault][:faultstring].to_s
           if faultstring.start_with?('Call to undefined method StandardDocumentStorno::')
-            return OpenStruct.new(body: {
-              get_document_payments_response: { payed: false, to_pay: '0' }
-            })
+            return OpenStruct.new(
+              body: { get_document_payments_response: { payed: false, to_pay: '0' } }
+            )
           end
 
           fail Easybill::Error, response.body[:fault][:faultstring]
@@ -121,8 +121,6 @@ module Easybill
           Easybill::Document.new(result)
         when 'payment'
           Easybill::Payment.new(result)
-        else
-          nil
         end
       end
     end

data/lib/easybill/configuration.rb

@@ -1,6 +1,6 @@
 module Easybill
   class Configuration
-    OPTIONS = [:api_key, :logger].freeze
+    OPTIONS = %i(api_key logger).freeze
 
     # The API key for your user taken from the easybill website.
     attr_accessor :api_key

data/lib/easybill/version.rb

@@ -1,3 +1,3 @@
 module Easybill
-  VERSION = '0.2.20'
+  VERSION = '0.2.21'
 end

data/spec/easybill/client_spec.rb

@@ -9,7 +9,7 @@ describe Easybill::Client do
     end
   end
 
-  subject(:client) { Easybill::Client.new }
+  subject(:client) { described_class.new }
 
   describe '.new' do
     it 'uses Easybill.configuration as default' do
@@ -18,7 +18,7 @@ describe Easybill::Client do
     end
 
     it 'accepts an api key on initialization' do
-      client = Easybill::Client.new(api_key: 'abc1234')
+      client = described_class.new(api_key: 'abc1234')
       expect(client.instance_variable_get(:@options)[:api_key]).to eq('abc1234')
     end
   end
@@ -62,13 +62,13 @@ describe Easybill::Client do
 
     let(:good_params) do
       {
-        salutation:   3, # company
+        salutation: 3, # company
         companyName: 'test company',
-        street:      'Rosenstrasse 17',
+        street: 'Rosenstrasse 17',
         postboxZipCode: '10178',
-        city:         'Berlin',
-        country:      'DE',
-        taxOptions:  1, # with VAT
+        city: 'Berlin',
+        country: 'DE',
+        taxOptions: 1, # with VAT
       }
     end
 

data/spec/easybill/configuration_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe Easybill::Configuration do
-  subject(:config) { Easybill::Configuration.new }
+  subject(:config) { described_class.new }
 
   describe '#new' do
     context 'when the EASYBILL_API_KEY environment variable is set' do

data/spec/easybill_spec.rb

@@ -2,13 +2,13 @@ require 'spec_helper'
 
 describe Easybill do
   describe '.configure' do
-    specify { expect { |b| Easybill.configure(&b) }.to yield_with_args(Easybill.configuration) }
+    specify { expect { |b| described_class.configure(&b) }.to yield_with_args(described_class.configuration) }
   end
 
   describe '.configuration' do
     it 'gives a new configuration by default' do
-      Easybill.configuration = nil
-      expect(Easybill.configuration).to be_a Easybill::Configuration
+      described_class.configuration = nil
+      expect(described_class.configuration).to be_a Easybill::Configuration
     end
   end
 end

data/spec/spec_helper.rb

@@ -54,7 +54,7 @@ VCR.configure do |c|
   c.cassette_library_dir = 'spec/fixtures/vcr_cassettes'
   c.hook_into :webmock
   c.filter_sensitive_data('easybill-api-key') { Easybill.configuration.api_key }
-  c.default_cassette_options = { match_requests_on: [:method, :uri, :body] }
+  c.default_cassette_options = { match_requests_on: %i(method uri body) }
 
   c.ignore_hosts 'codeclimate.com'
 end

data/spec/support/fixture.rb

@@ -2,9 +2,8 @@ require 'yaml'
 
 module Easybill
   module Fixture
-    [:customer, :position, :document].each do |name|
-      define_method name do |*args|
-        key, _ = args
+    %i(customer position document).each do |name|
+      define_method name do |key, *_args|
         key.nil? ? data[name] : data[name][key.to_sym]
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: easybill
 version: !ruby/object:Gem::Version
-  version: 0.2.20
+  version: 0.2.21
 platform: ruby
 authors:
 - ad2games GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-25 00:00:00.000000000 Z
+date: 2015-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sekken
@@ -159,11 +159,13 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop_todo.yml"
 - ".ruby-version"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- circle.yml
 - easybill.gemspec
 - lib/easybill.rb
 - lib/easybill/client.rb