easybill 0.2.17 → 0.2.18

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: db9c7e5fbf2f0dce0f22b7d1f39e084c8f9de86b
-  data.tar.gz: 4da8f71c973ed2478394a282f1565854783df254
+  metadata.gz: 18aed9fd911fb721123bef8409e5c6b4b82f4abf
+  data.tar.gz: 785f4ef18fb4c089a99b7864c4dd92fc6c427494
 SHA512:
-  metadata.gz: 08e76ed6811ec5901323ec690aeafc8ea1bf6522c467dc15ab334c7e388be54950f83f3000d6ecba22ee00364e75af81bdadab804e94274a6db51740f9f6e3f5
-  data.tar.gz: d792eee33d7edd5bf772d6ee96f323602d9dbaf0524863200a51c5ddd600dedac4195729f1f701c0c6bc2717edc725c9bb4783c88e0e1590a5f724205630cc8c
+  metadata.gz: 51e4f72f81a81eca6f105e254412d26c1710e5318ba09b4effa61fed9810d601eed0cb701e2a0dcd81fa625741e583982b8e4fd7472cec496a1817325da4c02a
+  data.tar.gz: 3ea58b28ab0616912cd69c486da2452d68325720c9048fecc5c6fbccac53d9f709d062f832d52703c003a186467abbfa437744f3bb9f74d95525cfcb27857ad4

data/Rakefile

@@ -0,0 +1 @@
+require 'bundler/gem_tasks'

data/lib/easybill/client.rb

@@ -63,7 +63,15 @@ module Easybill
       response = yield
 
       begin
-        if response.body.empty? || (response.body.is_a?(Hash) && response.body.key?(:fault))
+        if response.body.is_a?(Hash) && response.body.key?(:fault)
+          # Work around issue on Easybill's side.
+          if response.body[:fault][:faultstring] ==
+              'Call to undefined method StandardDocumentStorno::isPayed()'
+            return OpenStruct.new(body: {
+              get_document_payments_response: { payed: false, to_pay: '0' }
+            })
+          end
+
           fail Easybill::Error, response.body[:fault][:faultstring]
         end
       rescue NoMethodError

data/lib/easybill/version.rb

@@ -1,3 +1,3 @@
 module Easybill
-  VERSION = '0.2.17'
+  VERSION = '0.2.18'
 end

data/spec/easybill/client_spec.rb

@@ -186,4 +186,11 @@ describe Easybill::Client do
       )
     end
   end
+
+  context 'workarounds' do
+    it 'returns an empty list for payments on a cancelled (storno) document', :vcr do
+      expect(subject.get_document_payments(24356039))
+        .to eq([Easybill::Payment.new(payed: false, to_pay: '0')])
+    end
+  end
 end

data/spec/fixtures/vcr_cassettes/Easybill_Client/workarounds/returns_an_empty_list_for_payments_on_a_cancelled_storno_document.yml

@@ -0,0 +1,50 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://soap2.easybill.de/webservices/webservice4/soap.easybill.php
+    body:
+      encoding: UTF-8
+      string: |
+        <env:Envelope xmlns:lol0="http://www.easybill.de/webservice/" xmlns:lol1="http://www.easybill.de/webservice/document/" xmlns:env="http://schemas.xmlsoap.org/soap/envelope/">
+          <env:Header>
+            <lol0:UserAuthKey>easybill-api-key</lol0:UserAuthKey>
+          </env:Header>
+          <env:Body>
+            <lol1:GetDocumentPaymentsRequest>24356039</lol1:GetDocumentPaymentsRequest>
+          </env:Body>
+        </env:Envelope>
+    headers:
+      User-Agent:
+      - HTTPClient/1.0 (2.6.0.1, ruby 2.2.0 (2014-12-25))
+      Accept:
+      - "*/*"
+      Date:
+      - Fri, 16 Jan 2015 16:36:01 GMT
+      Soapaction:
+      - '"http://www.easybill.de/webservice/payments/getDocumentPayments"'
+      Content-Type:
+      - text/xml;charset=UTF-8
+  response:
+    status:
+      code: 500
+      message: Internal Service Error
+    headers:
+      Server:
+      - nginx/1.6.2
+      Date:
+      - Fri, 16 Jan 2015 16:36:07 GMT
+      Content-Type:
+      - text/xml; charset=utf-8
+      Content-Length:
+      - '325'
+      Connection:
+      - keep-alive
+    body:
+      encoding: UTF-8
+      string: |
+        <?xml version="1.0" encoding="UTF-8"?>
+        <SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/"><SOAP-ENV:Body><SOAP-ENV:Fault><faultcode>SOAP-ENV:Server</faultcode><faultstring>Call to undefined method StandardDocumentStorno::isPayed()</faultstring></SOAP-ENV:Fault></SOAP-ENV:Body></SOAP-ENV:Envelope>
+    http_version: 
+  recorded_at: Fri, 16 Jan 2015 16:36:07 GMT
+recorded_with: VCR 2.9.3

data/spec/spec_helper.rb

@@ -47,6 +47,7 @@ end
 ENV['EASYBILL_API_KEY'] = 'easybill-api-key' if ENV['EASYBILL_API_KEY'].nil?
 
 VCR.configure do |c|
+  c.configure_rspec_metadata!
   c.cassette_library_dir = 'spec/fixtures/vcr_cassettes'
   c.hook_into :webmock
   c.filter_sensitive_data('easybill-api-key') { Easybill.configuration.api_key }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: easybill
 version: !ruby/object:Gem::Version
-  version: 0.2.17
+  version: 0.2.18
 platform: ruby
 authors:
 - ad2games GmbH
@@ -121,6 +121,7 @@ files:
 - Gemfile
 - LICENSE.txt
 - README.md
+- Rakefile
 - easybill.gemspec
 - lib/easybill.rb
 - lib/easybill/client.rb
@@ -138,6 +139,7 @@ files:
 - spec/easybill/document_spec.rb
 - spec/easybill_spec.rb
 - spec/fixtures/fixtures.yml
+- spec/fixtures/vcr_cassettes/Easybill_Client/workarounds/returns_an_empty_list_for_payments_on_a_cancelled_storno_document.yml
 - spec/fixtures/vcr_cassettes/add_document_payment_-_adds_a_payment_.yml
 - spec/fixtures/vcr_cassettes/create_document_-_raises_Easybill_Error_if_unsuccessful_.yml
 - spec/fixtures/vcr_cassettes/create_document_-_returns_an_Easybill_Document_on_success_.yml
@@ -194,6 +196,7 @@ test_files:
 - spec/easybill/document_spec.rb
 - spec/easybill_spec.rb
 - spec/fixtures/fixtures.yml
+- spec/fixtures/vcr_cassettes/Easybill_Client/workarounds/returns_an_empty_list_for_payments_on_a_cancelled_storno_document.yml
 - spec/fixtures/vcr_cassettes/add_document_payment_-_adds_a_payment_.yml
 - spec/fixtures/vcr_cassettes/create_document_-_raises_Easybill_Error_if_unsuccessful_.yml
 - spec/fixtures/vcr_cassettes/create_document_-_returns_an_Easybill_Document_on_success_.yml