easy_talk 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa39fe0359df9334a186807b3e67679b752806db59eb9b03829ec875c6382818
-  data.tar.gz: 150814754a0604fc0149bf042c73d798fe042935ffde11b52c2254ac765c05e8
+  metadata.gz: 4956da04f8ac9e83e12f4ad476e4e340f44b7b9d6c2fb021bbe1afc0b93ef0f2
+  data.tar.gz: 2c64f966e265f5815db6e00bd38412dbef4262344feb270b75e269e71b81df55
 SHA512:
-  metadata.gz: ea9d64a999260983afac690850ae5095b4e2d00583feb1a6dd4baa0a0cb377a82566dae1245e1b767e5ff79549f28e60209b43fa3d765a8b51c46ee6969425bd
-  data.tar.gz: 20e3bea29ad389126937924f431f8729be43b172f8f868ae5fc0189d729e1d19642a9fa0e74a34322e1acafd2b74c6b2fad20bb8f081c7ea504364a2daaf3d99
+  metadata.gz: 4c1b91b2c67cd7d3b458f83bf1da9e483ba5ec67ff346242239e39b9fc88d7ce6eab78eef5ba942db85a8df78431ba1886111e1927c5edf2fdb35f70b22ecd8f
+  data.tar.gz: 915aa38e52e371d38eaa2a9175d4a0e92a34e999963dae8f9654a6117fb66ed514926063a49fcd6564ecba192a01e7310f6707d670be5245a49993264e3be5a9

data/CHANGELOG.md

@@ -1,3 +1,5 @@
+## [1.0.1] - 2024-09-01
+- Fixed that property with custom type does not ignore the constraints hash https://github.com/sergiobayona/easy_talk/issues/17
 ## [1.0.0] - 2024-06-01
 - Use `Hash` instead of `:object` for inline object schema definition.
 example:

data/lib/easy_talk/property.rb

@@ -76,15 +76,15 @@ module EasyTalk
     #
     # @return [Object] The built property.
     def build
-      # return type.respond_to?(:schema) ? type.schema : 'object' unless builder
-
-      # args = builder.collection_type? ? [name, type, constraints] : [name, constraints]
-      # builder.new(*args).build
       if builder
         args = builder.collection_type? ? [name, type, constraints] : [name, constraints]
         builder.new(*args).build
+      elsif type.respond_to?(:schema)
+        # merge the top-level constraints from *this* property
+        # e.g. :title, :description, :default, etc
+        type.schema.merge!(constraints)
       else
-        type.respond_to?(:schema) ? type.schema : 'object'
+        'object'
       end
     end
 

data/lib/easy_talk/schema_definition.rb

@@ -4,13 +4,13 @@ require_relative 'keywords'
 
 module EasyTalk
   class InvalidPropertyNameError < StandardError; end
+
   #
   #= EasyTalk \SchemaDefinition
   # SchemaDefinition provides the methods for defining a schema within the define_schema block.
   # The @schema is a hash that contains the unvalidated schema definition for the model.
   # A SchemaDefinition instanace is the passed to the Builder.build_schema method to validate and compile the schema.
   class SchemaDefinition
-
     extend T::Sig
     extend T::AnyOf
     extend T::OneOf
@@ -56,9 +56,10 @@ module EasyTalk
     end
 
     def validate_property_name(name)
-      unless name.to_s.match?(/^[A-Za-z_][A-Za-z0-9_]*$/)
-        raise InvalidPropertyNameError, "Invalid property name '#{name}'. Must start with letter/underscore and contain only letters, numbers, underscores"
-      end
+      return if name.to_s.match?(/^[A-Za-z_][A-Za-z0-9_]*$/)
+
+      raise InvalidPropertyNameError,
+            "Invalid property name '#{name}'. Must start with letter/underscore and contain only letters, numbers, underscores"
     end
 
     def optional?

data/lib/easy_talk/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EasyTalk
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: easy_talk
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Sergio Bayona