easy_rails_money 0.0.3 → 0.0.4

data/spec/active_record/money_dsl_spec.rb

@@ -1,11 +1,213 @@
 require 'spec_helper'
 require 'active_record_spec_helper'
 
-if defined? ActiveRecord
-  describe EasyRailsMoney::ActiveRecord::MoneyDsl do
-    describe "money" do
-      # validations
-      # accessors
+describe "Money DSL" do
+  subject {
+    require 'loan_model_spec_helper'
+    Loan.new
+  }
+
+  before(:all) do
+    currencies = [:inr, # Indian rupee
+                  :usd, # USA dollars
+                  :aud, # Australian dollar
+                  :eur, # Euro
+                  :gbp  # British pound
+                 ]
+
+    # TODO: how to couple this choice with rspec seed
+    # take a random currency so that we do not depend on any one
+    # default_currency while testing
+    EasyRailsMoney.configure do |c|
+      c.default_currency = Money::Currency.new(currencies.shuffle[0])
     end
   end
+
+  describe "#money" do
+    # validations
+
+    context "individual currency columns" do
+      before(:each) do
+        migrate CreateTableDefinition::CreateLoanWithoutCurrency
+      end
+
+      describe "#getter" do
+        it "defines a getter" do
+          expect(subject).to respond_to(:principal)
+        end
+
+        it "getter returns nil if nothing is set" do
+          expect(subject.principal).to eq nil
+          expect(subject.principal).to_not eq Money.new(0)
+        end
+
+        it "gets the same value as set" do
+          money = Money.new(100, "INR")
+          expect { subject.principal = money }.to change { subject.principal }.
+            from(nil).
+            to(money)
+        end
+      end # describe "#getter"
+
+      describe "#setter=" do
+        it "defines a setter" do
+          expect(subject).to respond_to(:principal=).with(1).argument
+        end
+
+        it "throws an error if we try to set anything other than a Money object or nil" do
+          expect { subject.principal = nil }.to_not raise_error
+          expect { subject.principal = Money.new(100) }.to_not raise_error
+          expect { subject.principal = Money.new(100, :usd) }.to_not raise_error
+          
+          expect { subject.principal = "100" }.to raise_error(ArgumentError)
+          expect { subject.principal = 100.10 }.to raise_error(ArgumentError)
+          expect { subject.principal = 100 }.to raise_error(ArgumentError)
+        end
+
+        it "returns the same value which is set" do
+          money = Money.new(100, "inr")
+          expect(subject.principal = money).to eq money
+        end
+
+        it "returns a value with the default currency when not given" do
+          expect(subject.principal = Money.new(100)).to eq Money.new(100, EasyRailsMoney.default_currency)
+        end
+
+        it "can set a value with a different currency" do
+          money = Money.new(100, "JPY")
+          expect { subject.principal = money }.to change { subject.principal }.
+            from(nil).
+            to(money)
+        end
+
+        context "actually sets the lower-level database columns" do
+          it "sets the money column" do
+            expect { subject.principal = Money.new(100, :inr) }.to change { subject.principal_money }.
+              from(nil).
+              to(100)
+          end
+
+          it "sets the money column when nil" do
+            subject.principal = nil
+            expect(subject.principal_money).to eq nil
+          end
+
+          it "sets the currency column" do
+            expect { subject.principal = Money.new(100, :inr) }.to change { subject.principal_currency }.
+              from(nil).
+              to("inr")
+          end
+
+          it "sets the currency column when nil" do
+            subject.principal = nil
+            expect(subject.principal_currency).to eq nil
+          end
+        end
+
+        context "when nil is set" do
+          it "can set to nil" do
+            subject.principal = nil
+            expect(subject.principal).to eq nil
+          end
+        end
+
+        it "cannot set an integer value" do
+          expect { subject.principal = 100 }.to raise_error
+        end
+      end # describe "#setter="
+    end # context "individual currency columns"
+
+    context "single currency", :single_currency do
+      subject {
+        require 'loan_with_currency_model_spec_helper'
+        LoanWithCurrency.new
+      }
+
+      before(:each) do
+        migrate CreateTableDefinition::CreateLoanWithCurrency
+      end
+
+      it "sets currency column" do
+        expect(subject.currency).to eq ::Money::Currency.new(:inr)
+      end
+
+      it "can change single currency on an instance" do
+        loan = LoanWithCurrency.new(currency: :usd)
+        expect(loan.currency).to eq ::Money::Currency.new(:usd)
+        expect(loan.class.single_currency).to eq ::Money::Currency.new(:inr)
+      end
+
+      describe "#getter" do
+        it "defines a getter" do
+          expect(subject).to respond_to(:principal)
+        end
+
+        it "getter returns nil if nothing is set" do
+          expect(subject.principal).to eq nil
+          expect(subject.principal).to_not eq Money.new(0)
+        end
+
+        it "gets the same value as set" do
+          money = Money.new(100, "INR")
+          expect { subject.principal = 100 }.to change { subject.principal }.
+            from(nil).
+            to(money)
+        end
+      end # describe "#getter"
+
+      describe "#setter=" do
+        it "defines a setter" do
+          expect(subject).to respond_to(:principal=).with(1).argument
+        end
+        
+        it "throws an error if we try to set anything other than a Integer object or nil" do
+          expect { subject.principal = nil }.to_not raise_error
+          expect { subject.principal = 100 }.to_not raise_error
+          
+          expect { subject.principal = Money.new(100, "INR") }.to raise_error
+          expect { subject.principal = "100" }.to raise_error(ArgumentError)
+          expect { subject.principal = 100.10 }.to raise_error(ArgumentError)
+        end
+
+        it "returns the same value which is set" do
+          expect(subject.principal = 100).to eq 100
+        end
+
+        context "actually sets the lower-level database columns" do
+          it "sets the money column" do
+            expect { subject.principal = 100 }.to change { subject.principal_money }.
+              from(nil).
+              to(100)
+          end
+
+          it "sets the money column when nil" do
+            subject.principal = nil
+            expect(subject.principal_money).to eq nil
+          end
+
+          it "does not set the currency column as it is a common column" do
+            expect { subject.principal = 100 }.not_to change { subject.currency }
+          end
+
+          it "does not set the currency column when nil as it is a common column" do
+            expect { subject.principal = nil }.not_to change { subject.currency }
+          end
+        end
+
+        context "when nil is set" do
+          it "can set to nil" do
+            subject.principal = nil
+            expect(subject.principal).to eq nil
+          end
+        end
+      end # describe "#setter="
+      
+    end # context "single currency"
+
+    pending "validations"
+    pending "support defining multiple fields at once"
+    pending "test the return value of #money. pretty useless though"
+    pending "patch create and attributes like #new"
+    
+  end # describe "#money"
 end

data/spec/active_record_spec_helper.rb

@@ -1,3 +1,32 @@
+module CreateTableDefinition
+  class CreateLoanWithCurrency < ActiveRecord::Migration
+    def change
+      suppress_messages do
+        create_table :loans, force: true do |t|
+          t.string :name
+          t.money  :principal
+          t.money  :repaid
+          t.money  :npa
+          t.currency
+        end
+      end
+    end
+  end
+
+  class CreateLoanWithoutCurrency < ActiveRecord::Migration
+    def change
+      suppress_messages do
+        create_table :loans, force: true do |t|
+          t.string :name
+          t.money  :principal
+          t.money  :repaid
+          t.money  :npa
+        end
+      end
+    end
+  end
+end
+
 class String
   def strip_spaces
     strip.gsub(/\s+/, ' ')

data/spec/configuration_spec.rb

@@ -6,22 +6,39 @@ describe "Configuration" do
     let(:existing_currency) { Money::Currency.new(:usd) }
     let(:new_currency) { Money::Currency.new(:inr) }
 
-    before(:each) do       
-      Money.default_currency = existing_currency
+    it "has a default currency" do
+      expect(EasyRailsMoney.default_currency).not_to be_nil
     end
-    
-    it "sets default currency" do
-      expect { EasyRailsMoney.default_currency = new_currency }.
-        to change { Money.default_currency }.
-        from(existing_currency).
-        to(new_currency)
+
+    it "default currency is equal to money's default_currency" do
+      expect(EasyRailsMoney.default_currency).to eq Money.default_currency
     end
+    
+    context "can set and read back the config" do
+      before(:each) do
+        Money.default_currency = existing_currency
+      end
+      
+      it "sets default currency" do
+        expect { EasyRailsMoney.default_currency = new_currency }.
+          to change { Money.default_currency }.
+          from(existing_currency).
+          to(new_currency)
+      end
+
+      it "reads default currency" do
+        expect { EasyRailsMoney.default_currency = new_currency }.
+          to change { EasyRailsMoney.default_currency }.
+          from(existing_currency).
+          to(new_currency)
+      end
 
-    it "reads default currency" do
-      expect { EasyRailsMoney.default_currency = new_currency }.
-        to change { EasyRailsMoney.default_currency }.
-        from(existing_currency).
-        to(new_currency)
+      it "reads back a currency object even when a symbol is set" do
+        expect { EasyRailsMoney.default_currency = new_currency.id }.
+          to change { EasyRailsMoney.default_currency }.
+          from(existing_currency).
+          to(new_currency)
+      end
     end
   end
   

data/spec/loan_model_spec_helper.rb

@@ -0,0 +1,6 @@
+class Loan < ActiveRecord::Base
+  attr_accessible :name
+  money :principal
+  money :repaid
+  money :npa
+end

data/spec/loan_with_currency_model_spec_helper.rb

@@ -0,0 +1,10 @@
+class LoanWithCurrency < ActiveRecord::Base
+  self.table_name = "loans"
+  attr_accessible :name
+
+  with_currency(:inr) do
+    money :principal
+    money :repaid
+    money :npa
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: easy_rails_money
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-03 00:00:00.000000000 Z
+date: 2013-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: money
@@ -194,11 +194,14 @@ files:
 - lib/easy_rails_money/active_record/migration/table_definition.rb
 - lib/easy_rails_money/active_record/money_dsl.rb
 - lib/easy_rails_money/configuration.rb
+- lib/easy_rails_money/money_dsl_helper.rb
 - lib/easy_rails_money/version.rb
 - spec/active_record/migration_spec.rb
 - spec/active_record/money_dsl_spec.rb
 - spec/active_record_spec_helper.rb
 - spec/configuration_spec.rb
+- spec/loan_model_spec_helper.rb
+- spec/loan_with_currency_model_spec_helper.rb
 - spec/simplecov_helper.rb
 - spec/spec_helper.rb
 - vendor/cache/activemodel-3.2.12.gem
@@ -239,7 +242,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2447258643828918702
+      hash: -2090962941235077945
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -248,7 +251,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2447258643828918702
+      hash: -2090962941235077945
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24
@@ -260,6 +263,8 @@ test_files:
 - spec/active_record/money_dsl_spec.rb
 - spec/active_record_spec_helper.rb
 - spec/configuration_spec.rb
+- spec/loan_model_spec_helper.rb
+- spec/loan_with_currency_model_spec_helper.rb
 - spec/simplecov_helper.rb
 - spec/spec_helper.rb
 has_rdoc: