easy_menu 0.4.16 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5865091b943899a2c6656442bc6287895a06b330e1e36c7535145662d92971e3
-  data.tar.gz: a109da0848084d2b4c064abfe5a5219f6351598d313534fbf9cda844d9e8154b
+  metadata.gz: 3b1e9ced377fa41ccde18eb63585c26db224c90265189c18630cf3912bb4df9f
+  data.tar.gz: dd2dfb7d78dc212fa78c3b4f129d5ce5537fe6ef32e13677fe9506fc01b5b4e1
 SHA512:
-  metadata.gz: ac51bc463ae8bf829d71eca14efc0642f86df2be21b8653a0d70a1cb0f875be6703ef89d30ce2f61b6709e4a6b69c2208684e2de968ed6b46742d60a8bb9f416
-  data.tar.gz: 3cf5fce8beb564f08aa4008eadb8d62e1f3be3fdb00109f5ee6397a1bf730f4a84b17eed496d499613f5103f633fe3ac3a5d3b38c3af92ca8c0c6211145ad490
+  metadata.gz: f1f95ffcbff00e46f1ba6eaef34244b86da72c97d73daf97a530b712c025457d8d9f2b6ce1aef57fa5d41fcf8f329176ec5c61530244f8fde5fd25c127edbf15
+  data.tar.gz: 6a5f6e530e9c2da66101db87c0bab4002322aa75b8f3f9ea21c3eaeae42de23b4c2da3f74a2d854aeffdc5bc0f782fb87d93bff4b67dcbaf48a074ed56081718

data/app/assets/javascripts/easy_menu_jquery.js

@@ -4,7 +4,10 @@ $(document).ready(function() {
     // Because some browsers don't support submit buttons outside of forms triggering form submits,
     // do it in javascript just to make sure it happens
     $(document).on('click', 'input[type=submit][form]', function(){
-        if (form = document.getElementById(this.getAttribute('form'))) {
+        var formId = $(this).attr('form');
+        var form = document.getElementById(formId);
+        
+        if (form) {
             // If the form is already submitting, we want don't want to submit it again.
             if ($(form).hasClass('submitting')) {
                 return false;
@@ -13,56 +16,62 @@ $(document).ready(function() {
             var tempCommit = $("<input type='submit' name='commit' style='display:none'>");
             tempCommit.attr('value', $(this).attr('value'));
             form.appendChild(tempCommit[0]);
-            tempCommit.click();
+            tempCommit.trigger('click');
             return false;
         }
     });
     // Used by the above click handler to determine if the browser already submitted the form.
-    $('form').submit(function() {
+    $(document).on('submit', 'form', function() {
         $(this).addClass('submitting');
     });
 
     // Allow users to open and close menus by clicking
     $(menuBarRootSelector + '.menu_bar_content.with_menu').removeClass('no_js');
-    $(menuBarRootSelector + '.menu_bar_content.with_menu .menu_bar_item').click(function(){
+    $(document).on('click', menuBarRootSelector + '.menu_bar_content.with_menu .menu_bar_item', function(){
         var mbc = $(this).closest('.menu_bar_content');
         $(menuBarRootSelector + '.menu_bar_content.with_menu').not(mbc).removeClass('open');
         mbc.toggleClass('open')
-          .find('.menu').trigger('opened')
+          .find('.menu').trigger('opened');
     });
 
     // Close the menu when the user clicks or there is a form submission
     $(document).on('click submit', function(event) {
         // Don't close the menu if the click was on a menu_bar_item. This case is handled by the previous event handler
-        if ($(event.target).closest('.menu_bar_content.with_menu .menu_bar_item').length > 0) { return }
+        if ($(event.target).closest('.menu_bar_content.with_menu .menu_bar_item').length > 0) { return; }
 
         // Don't close if we clicked inside a menu but not on a menu_item
-        if ($(event.target).closest('.menu').length > 0 && $(event.target).closest('.menu_item').length === 0) { return }
+        if ($(event.target).closest('.menu').length > 0 && $(event.target).closest('.menu_item').length === 0) { return; }
 
         $(menuBarRootSelector + '.menu_bar_content.with_menu.open')
           .removeClass('open')
-          .find('.menu').trigger('closed')
+          .find('.menu').trigger('closed');
     });
 
     // Disable Elements with a disable condition when that condition is met
     $(menuBarRootSelector + '.menu_bar_item[data-disable-event-element]').each(function(){
         var mbi = $(this);
-        var observableElement = eval(mbi.getAttribute('data-disable-event-element'));
-        var event = mbi.getAttribute('data-disable-event');
-        var condition = mbi.getAttribute('data-disable-condition') || true;
+        var observableElementCode = mbi.attr('data-disable-event-element');
+        var event = mbi.attr('data-disable-event');
+        var conditionCode = mbi.attr('data-disable-condition') || 'true';
 
         var setState = function(){
-            if (eval(condition)){
+            var observableElement = eval(observableElementCode);
+            var condition = eval(conditionCode);
+            
+            if (condition){
                 mbi.addClass('disabled');
             } else {
                 mbi.removeClass('disabled');
             }
-        }
+        };
 
         // Init the current state and bind the observer
-        if (observableElement && event){
+        if (observableElementCode && event){
             setState();
-            observableElement.bind(event, setState);
+            var observableElement = eval(observableElementCode);
+            if (observableElement) {
+                $(observableElement).on(event, setState);
+            }
         }
     });
 });

data/app/assets/stylesheets/easy_menu.css.scss

@@ -137,10 +137,9 @@
 
     }
     &.with_menu {
-      .menu_bar_item .arrow{
+      .menu_bar_item .arrow {
         @include easy_menu_icon(5, center);
-        margin: -12px -9px -12px -4px;
-        padding: 24px 14px 0 0;
+        padding: 24px 0 0 0;
         vertical-align: middle;
         width: 10px;
         display: inline-block;

data/lib/menu_bar.rb

@@ -84,7 +84,7 @@ class MenuBar
     arrow = @template.content_tag(:span, '', :class => config[:menu_bar_item_arrow_class])
 
     m = Menu.new(config, options)
-    mbt = MenuBarTrigger.new(config, button_text.html_safe + arrow, m, options[:menu_bar_item])
+    mbt = MenuBarTrigger.new(config, button_text.html_safe + ' ' + arrow, m, options[:menu_bar_item])
 
     yield m if block_given?
 
@@ -170,7 +170,7 @@ class MenuBar
     end
 
     def to_s
-      empty? ? '' : wrap_content(@content.join.html_safe) # Don't render anything if empty
+      empty? ? ''.html_safe : wrap_content(@content.join.html_safe) # Don't render anything if empty
     end
 
     def right_aligned?

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: easy_menu
 version: !ruby/object:Gem::Version
-  version: 0.4.16
+  version: 0.5.0
 platform: ruby
 authors:
 - Nicholas Jakobsen
 - Ryan Wallace
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-03-11 00:00:00.000000000 Z
+date: 2026-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -25,8 +25,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.1'
-description: 
-email: 
+description:
+email:
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -44,10 +44,10 @@ files:
 - lib/easy_menu_configuration.rb
 - lib/easy_menu_helpers.rb
 - lib/menu_bar.rb
-homepage: 
+homepage:
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -62,8 +62,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.23
-signing_key: 
+rubygems_version: 3.4.1
+signing_key:
 specification_version: 4
 summary: Simple menu bar DSL for Rails views
 test_files: []