easy_meli 0.5.0 → 0.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d5a3424202e135a649e069fb9381c26e7e6760d9e387821c3e7f2f0358ec4f58
-  data.tar.gz: f947be600fd5c1654b7c920c630f1e916edf58a0c8244c5d5a83def1a2fec288
+  metadata.gz: bea2b5ce32b7601401b386bbde1fd0e1bdc8bcfe7c2fab55fe9d44d065695b2b
+  data.tar.gz: fb22b1e7d147f20d1d4638a66b4ab0eb57a2490e7d5b59725593dab506837438
 SHA512:
-  metadata.gz: 0fb2a5a757c53a87aa5fa77a24a203ae65ab58ca7c979bba04a358df8dd78459e01395f36314c399b33beb15fc03d37b4945ff937c5b19b4281190e098d7910e
-  data.tar.gz: 76a41f9314e945a4ce0846f922d7fb3e9f2d0937a0f74094fc03b52927b105dfa48fb4cc7898f9baff6d850988f8a1d156ef105ebfd54607b498dbc688fd8372
+  metadata.gz: 0dae6c7df5a569e55828291fbca8986af2538309b7df51d7be10da6007857dc71d6442797375dd0a68ddf861920a828ddfa77f57c38095249c60ce34ca789622
+  data.tar.gz: 1fa152bcb974cc631d2b5e0d990ed37cb610b4ef253966a10f948a86cdca66ceb421b87e569c9f3af860d4ebe2fead62d7e9034a2f978671a40e16e829aaf56a

data/.github/workflows/ci.yml

@@ -0,0 +1,32 @@
+name: CI
+on:
+  pull_request:
+    branches: [ master ]
+  push:
+    branches: [ master ]
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby_version: [ '2.6' ]
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+      - name: Setup ruby ${{ matrix.ruby_version }}
+        uses: actions/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby_version }}
+      - name: Setup cache key and directory for gems cache
+        uses: actions/cache@v1
+        with:
+          path: vendor/bundle
+          key: ${{ runner.os }}-gem-use-ruby-${{ matrix.ruby_version }}-${{ hashFiles('**/Gemfile.lock') }}
+      - name: Bundle install
+        run: |
+          gem install bundler:1.17.0
+          bundle config path vendor/bundle
+          bundle install --jobs 4 --retry 3
+      - name: Run tests
+        run: |
+          bundle exec rake test

data/CHANGELOG.md

@@ -1,5 +1,22 @@
 # Changelog
 
+## V 0.6.4
+- Add Unknown error support
+
+## V 0.6.3
+- Fix error when the api response doesn't include error or message keys.
+- Add right error message for forbidden error.
+
+## V 0.6.2
+- Update Error classification mechanism to use error message as first option
+
+## V 0.6.1
+- Fix a bug in the error raising in the authorization client introduced in V 0.6.0
+
+## V 0.6.0
+- Classify an `invalid_token` response as an `InvalidTokenError`.
+- `Malformed access_token` error changed from `AuthenticationError` to `InvalidTokenError`.
+
 ## V 0.5.0
 - `self.api_client` Prevent access_token override when initialize together with a refresh_token.
 - Raises a EasyMeli::TooManyRequestsError if a 429 response status is returned.

data/README.md

@@ -42,16 +42,16 @@ response = EasyMeli.create_token('the_code_in_the_redirect', 'the_same_redirect_
 ```
 This will return a response object with a json body that you can easily access via `response.to_h`.
 
-If you want to refresh the token call 
+If you want to refresh the token call
 
 ```ruby
-access_token = EasyMeli.refresh_token('a_refresh_token')
+access_token = EasyMeli.access_token('a_refresh_token')
 ```
 
 Once you can have an access token you can create a client and call the supported http verb methods.
 
 ```ruby
-client = EasyMeli.api_client(refresh_token: refresh_token)
+client = EasyMeli.api_client(access_token: access_token)
 
 client.get(path, query: { a: 1 })
 client.post(path, query: { a: 1 }, body: { b: 1 })

data/lib/easy_meli/api_client.rb

@@ -5,17 +5,16 @@ class EasyMeli::ApiClient
 
   API_ROOT_URL = 'https://api.mercadolibre.com'
 
-  TOKEN_ERRORS = {
-    'invalid_grant' => 'Invalid Grant',
-    'forbidden' => 'Forbidden',
-    'Malformed access_token' => 'Malformed access token'
+  ERROR_LIST = {
+    'Error validating grant' => EasyMeli::InvalidGrantError,
+    'The User ID must match the consultant\'s' => EasyMeli::ForbiddenError,
+    'invalid_token' => EasyMeli::InvalidTokenError,
+    'Malformed access_token' => EasyMeli::MalformedTokenError,
+    'too_many_requests' => EasyMeli::TooManyRequestsError,
+    'unknown_error' => EasyMeli::UnknownError
   }
 
-  STATUS_ERRORS = {
-    429 => EasyMeli::TooManyRequestsError
-  }
-
-  base_uri API_ROOT_URL 
+  base_uri API_ROOT_URL
   headers EasyMeli::DEFAULT_HEADERS
   format :json
 
@@ -50,29 +49,25 @@ class EasyMeli::ApiClient
 
     self.class.send(verb, path, params.merge(query)).tap do |response|
       logger&.log response
-      check_authentication(response)
-      check_status(response)
+      check_for_errors(response)
     end
   end
 
-  def check_authentication(response)
-    response_message = error_message_from_body(response.to_h) if response.parsed_response.is_a? Hash
-    return if response_message.to_s.empty?
+  def check_for_errors(response)
+    return unless response.parsed_response.is_a?(Hash) && !response.body.nil?
+
+    exception = error_class(response)
 
-    TOKEN_ERRORS.keys.each do |key|
-      if response_message.include?(key)
-        raise EasyMeli::AuthenticationError.new(TOKEN_ERRORS[key], response)
-      end
+    if exception
+      raise exception.new(response)
     end
   end
 
-  def error_message_from_body(body)
-    return if body.nil?
-    body['error'].to_s.empty? ? body['message'] : body['error']
+  def error_class(body)
+    ERROR_LIST.find { |key, _| error_message_from_body(body)&.include?(key) }&.last
   end
 
-  def check_status(response)
-    status_error = STATUS_ERRORS[response.code]
-    raise status_error.new(response) if status_error
+  def error_message_from_body(response)
+    response['message'].to_s.empty? ? response['error'] : response['message']
   end
 end

data/lib/easy_meli/authorization_client.rb

@@ -45,7 +45,7 @@ class EasyMeli::AuthorizationClient
     if response.success?
       response.to_h
     else
-      raise EasyMeli::AuthenticationError.new('Error Creating Token', response)
+      raise EasyMeli::CreateTokenError.new(response)
     end
   end
 
@@ -54,7 +54,7 @@ class EasyMeli::AuthorizationClient
     if response.success?
       response.to_h[EasyMeli::AuthorizationClient::ACCESS_TOKEN_KEY]
     else
-      raise EasyMeli::AuthenticationError.new('Error Refreshing Token', response)
+      raise EasyMeli::InvalidTokenError.new(response)
     end
   end
 

data/lib/easy_meli/errors.rb

@@ -2,17 +2,75 @@ module EasyMeli
   class Error < StandardError
     attr_reader :response
 
-    def initialize(message, response)
+    def initialize(response)
       @response = response
-      super(message)
+      super(local_message)
+    end
+
+    private
+
+    def local_message
+      raise NotImplementedError
     end
   end
 
   class AuthenticationError < Error; end
-  
+
+  class CreateTokenError < AuthenticationError
+    private
+
+    def local_message
+      'Error Creating Token'
+    end
+  end
+
+  class InvalidGrantError < AuthenticationError
+    private
+
+    def local_message
+      'Invalid Grant'
+    end
+  end
+
+  class ForbiddenError < AuthenticationError
+    private
+
+    def local_message
+      'Forbidden'
+    end
+  end
+
+  class AccessTokenError < Error; end
+
+  class InvalidTokenError < AccessTokenError
+    private
+
+    def local_message
+      'Invalid Token'
+    end
+  end
+
+  class MalformedTokenError < AccessTokenError
+    private
+
+    def local_message
+      'Malformed access token'
+    end
+  end
+
   class TooManyRequestsError < Error
-    def initialize(response)
-      super('Too many requests', response)
+    private
+
+    def local_message
+      'Too many requests'
+    end
+  end
+
+  class UnknownError < Error
+    private
+
+    def local_message
+      'Unknown Error'
     end
   end
-end
+end

data/lib/easy_meli/version.rb

@@ -1,3 +1,3 @@
 module EasyMeli
-  VERSION = "0.5.0"
+  VERSION = "0.6.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: easy_meli
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.4
 platform: ruby
 authors:
 - Eric Northam
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-01-18 00:00:00.000000000 Z
+date: 2021-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -108,13 +108,14 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description:
 email:
 - eric@northam.us
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - CHANGELOG.md
 - Gemfile
@@ -136,7 +137,7 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/easybroker/easy_meli
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -151,8 +152,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: A simple gem to work with MercadoLibre's API
 test_files: []