earth 0.3.11 → 0.3.13

data/features/computation_platform.feature

@@ -0,0 +1,14 @@
+Feature: Data import for ComputationPlatform
+  As a data user
+  I want to import ComputationPlatform data
+  So that I can perform computation platform-based calculations
+
+  Scenario: Successfully verifying that data center company name is never missing
+    Given a "ComputationPlatform" data import fetches results listed in "computation_platform_good"
+    When a data import verifies "Data center company name should never be missing"
+    Then the verification should be successful
+
+  Scenario: Failing to verify that data center company name is never missing
+    Given a "ComputationPlatform" data import fetches results listed in "computation_platform_bad"
+    When a data import verifies "Data center company name should never be missing"
+    Then the verification should not be successful

data/features/data_center_company.feature

@@ -0,0 +1,14 @@
+Feature: Data import for DataCenterCompany
+  As a data user
+  I want to import DataCenterCompany data
+  So that I can perform data center company-based calculations
+
+  Scenario: Successfully verifying that power usage effectiveness >= 1.0
+    Given a "DataCenterCompany" data import fetches results listed in "data_center_company_good"
+    When a data import verifies "Power usage effectiveness should be one or more"
+    Then the verification should be successful
+
+  Scenario: Failing to verify that power usage effectiveness >= 1.0
+    Given a "DataCenterCompany" data import fetches results listed in "data_center_company_bad"
+    When a data import verifies "Power usage effectiveness should be one or more"
+    Then the verification should not be successful

data/features/egrid_region.feature

@@ -8,6 +8,12 @@ Feature: Data import for EgridRegion
     When a data import verifies "Loss factor should be greater than zero and less than one"
     Then the verification should be successful
 
+  # FIXME TODO get this to work
+  # Scenario: Successfully verifying that fallback loss factor is greater than zero and less than one
+  #   Given a "EgridRegion" data import fetches results listed in "egrid_region_good"
+  #   When a data import verifies "Fallback loss factor should be greater than zero and less than one"
+  #   Then the verification should be successful
+
   Scenario: Failing to verify that loss factor is greater than zero and less than one
     Given a "EgridRegion" data import fetches results listed in "egrid_region_bad"
     When a data import verifies "Loss factor should be greater than zero and less than one"

data/features/egrid_subregion.feature

@@ -14,9 +14,9 @@ Feature: Data import for EgridSubregion
     When a data import verifies "Electricity emission factor should be greater than zero"
     Then the verification should be successful
 
-  Scenario: Successfully verifying that electricity emission factor units are kilograms per kilowatt hour
+  Scenario: Successfully verifying that electricity emission factor units are kilograms co2e per kilowatt hour
     Given a "EgridSubregion" data import fetches results listed in "egrid_subregion_good"
-    When a data import verifies "Electricity emission factor units should be kilograms per kilowatt hour"
+    When a data import verifies "Electricity emission factor units should be kilograms co2e per kilowatt hour"
     Then the verification should be successful
 
   # FIXME TODO
@@ -30,7 +30,7 @@ Feature: Data import for EgridSubregion
     When a data import verifies "Electricity emission factor should be greater than zero"
     Then the verification should not be successful
 
-  Scenario: Failing to verify that electricity emission factor units are kilograms per kilowatt hour
+  Scenario: Failing to verify that electricity emission factor units are kilograms co2e per kilowatt hour
     Given a "EgridSubregion" data import fetches results listed in "egrid_subregion_bad"
-    When a data import verifies "Electricity emission factor units should be kilograms per kilowatt hour"
+    When a data import verifies "Electricity emission factor units should be kilograms co2e per kilowatt hour"
     Then the verification should not be successful

data/features/flight_segment.feature

@@ -0,0 +1,14 @@
+Feature: Data import for FlightSegment
+  As a data user
+  I want to import FlightSegment data
+  So that I can look up T-100 flight segment data
+  
+  Scenario: Successfully verifying that FlightSegments have related Aircraft
+    Given a "FlightSegment" data import fetches results listed in "flight_segment_good"
+    When a data import verifies "All segments have an associated aircraft"
+    Then the verification should be successful
+
+  Scenario: Failing to verify that FlightSegments have related Aircraft
+    Given a "FlightSegment" data import fetches results listed in "flight_segment_bad"
+    When a data import verifies "All segments have an associated aircraft"
+    Then the verification should not be successful

data/features/fuel_year.feature

@@ -0,0 +1,44 @@
+Feature: Data import for FuelYear
+  As a data user
+  I want to import FuelYear data
+  So that I can perform fuel year control-based calculations
+
+  Scenario: Successfully verifying that fuel name and fuel common name are never missing
+    Given a "FuelYear" data import fetches results listed in "fuel_year_good"
+    When a data import verifies "Fuel name and fuel common name should never be missing"
+    Then the verification should be successful
+
+  Scenario: Successfully verifying that year is from 1990 to 2008
+    Given a "FuelYear" data import fetches results listed in "fuel_year_good"
+    When a data import verifies "Year should be from 1990 to 2008"
+    Then the verification should be successful
+
+  Scenario: Successfully verifying that carbon content, energy content, and CO2 emission factor are greater than zero
+    Given a "FuelYear" data import fetches results listed in "fuel_year_good"
+    When a data import verifies "Carbon content, energy content, and CO2 emission factor should be greater than zero"
+    Then the verification should be successful
+
+  Scenario: Successfully verifying that units are correct
+    Given a "FuelYear" data import fetches results listed in "fuel_year_good"
+    When a data import verifies "Units should be correct"
+    Then the verification should be successful
+
+  Scenario: Failing to verify that fuel name and fuel common name are never missing
+    Given a "FuelYear" data import fetches results listed in "fuel_year_bad"
+    When a data import verifies "Fuel name and fuel common name should never be missing"
+    Then the verification should not be successful
+
+  Scenario: Failing to verify that year is from 1990 to 2008
+    Given a "FuelYear" data import fetches results listed in "fuel_year_bad"
+    When a data import verifies "Year should be from 1990 to 2008"
+    Then the verification should not be successful
+
+  Scenario: Failing to verify that carbon content, energy content, and CO2 emission factor are greater than zero
+    Given a "FuelYear" data import fetches results listed in "fuel_year_bad"
+    When a data import verifies "Carbon content, energy content, and CO2 emission factor should be greater than zero"
+    Then the verification should not be successful
+
+  Scenario: Failing to verify that units are correct
+    Given a "FuelYear" data import fetches results listed in "fuel_year_bad"
+    When a data import verifies "Units should be correct"
+    Then the verification should not be successful

data/features/greenhouse_gas.feature

@@ -0,0 +1,44 @@
+Feature: Data import for GreenhouseGas
+  As a data user
+  I want to import GreenhouseGas data
+  So that I can perform global warming potential-based calculations
+
+  Scenario: Successfully verifying that abbreviation and IPCC report are never missing
+    Given a "GreenhouseGas" data import fetches results listed in "greenhouse_gas_good"
+    When a data import verifies "Abbreviation and IPCC report should never be missing"
+    Then the verification should be successful
+
+  Scenario: Successfully verifying that time horizon is 100
+    Given a "GreenhouseGas" data import fetches results listed in "greenhouse_gas_good"
+    When a data import verifies "Time horizon should be 100"
+    Then the verification should be successful
+
+  Scenario: Successfully verifying that time horizon units are years
+    Given a "GreenhouseGas" data import fetches results listed in "greenhouse_gas_good"
+    When a data import verifies "Time horizon units should be years"
+    Then the verification should be successful
+
+  Scenario: Successfully verifying that global warming potential is one or more
+    Given a "GreenhouseGas" data import fetches results listed in "greenhouse_gas_good"
+    When a data import verifies "Global warming potential should be one or more"
+    Then the verification should be successful
+
+  Scenario: Failing to verify that abbreviation and IPCC report are never missing
+    Given a "GreenhouseGas" data import fetches results listed in "greenhouse_gas_bad"
+    When a data import verifies "Abbreviation and IPCC report should never be missing"
+    Then the verification should not be successful
+
+  Scenario: Failing to verify that time horizon is 100
+    Given a "GreenhouseGas" data import fetches results listed in "greenhouse_gas_bad"
+    When a data import verifies "Time horizon should be 100"
+    Then the verification should not be successful
+
+  Scenario: Failing to verify that time horizon units are years
+    Given a "GreenhouseGas" data import fetches results listed in "greenhouse_gas_bad"
+    When a data import verifies "Time horizon units should be years"
+    Then the verification should not be successful
+
+  Scenario: Failing to verify that global warming potential is one or more
+    Given a "GreenhouseGas" data import fetches results listed in "greenhouse_gas_bad"
+    When a data import verifies "Global warming potential should be one or more"
+    Then the verification should not be successful

data/features/server_type.feature

@@ -0,0 +1,34 @@
+Feature: Data import for ServerType
+  As a data user
+  I want to import ServerType data
+  So that I can perform server type-based calculations
+
+  Scenario: Successfully verifying that data center company name is never missing
+    Given a "ServerType" data import fetches results listed in "server_type_good"
+    When a data import verifies "Data center company name should never be missing"
+    Then the verification should be successful
+
+  Scenario: Successfully verifying that electricity draw is more than zero
+    Given a "ServerType" data import fetches results listed in "server_type_good"
+    When a data import verifies "Electricity draw should be more than zero"
+    Then the verification should be successful
+
+  Scenario: Successfully verifying that electricity draw units are kilowatts
+    Given a "ServerType" data import fetches results listed in "server_type_good"
+    When a data import verifies "Electricity draw units should be kilowatts"
+    Then the verification should be successful
+
+  Scenario: Failing to verify that data center company name is never missing
+    Given a "ServerType" data import fetches results listed in "server_type_bad"
+    When a data import verifies "Data center company name should never be missing"
+    Then the verification should not be successful
+
+  Scenario: Failing to verify that electricity draw is more than zero
+    Given a "ServerType" data import fetches results listed in "server_type_bad"
+    When a data import verifies "Electricity draw should be more than zero"
+    Then the verification should not be successful
+
+  Scenario: Failing to verify that electricity draw units are kilowatts
+    Given a "ServerType" data import fetches results listed in "server_type_bad"
+    When a data import verifies "Electricity draw units should be kilowatts"
+    Then the verification should not be successful

data/features/server_type_alias.feature

@@ -0,0 +1,14 @@
+Feature: Data import for ServerTypeAlias
+  As a data user
+  I want to import ServerTypeAlias data
+  So that I can perform server type alias-based calculations
+
+  Scenario: Successfully verifying that server type name and platform name are never missing
+    Given a "ServerTypeAlias" data import fetches results listed in "server_type_alias_good"
+    When a data import verifies "Server type name and platform name should never be missing"
+    Then the verification should be successful
+
+  Scenario: Failing to verify that server type name and platform name are never missing
+    Given a "ServerTypeAlias" data import fetches results listed in "server_type_alias_bad"
+    When a data import verifies "Server type name and platform name should never be missing"
+    Then the verification should not be successful

data/features/support/imports/automobile_make_fleet_year_bad.csv

@@ -1,3 +1,2 @@
 name,year,fuel_efficiency,volume,fuel_efficiency_units
-Toyota 2000 IP,2000,10,1000,kilometres_per_litre
-Honda 2008 DP,2008,0,0
+Honda 2010 DP,2010,0,0

data/features/support/imports/automobile_make_fleet_year_good.csv

@@ -1,3 +1,2 @@
 name,year,fuel_efficiency,volume,fuel_efficiency_units
-Toyota 2000 IP,2000,10,1000,kilometres_per_litre
-Honda 2007 DP,2007,15,2000,kilometres_per_litre
+Honda 2009 DP,2009,15,2000,kilometres_per_litre

data/features/support/imports/automobile_size_class_year_bad.csv

@@ -0,0 +1,2 @@
+name,year,fuel_efficiency_city,fuel_efficiency_highway,fuel_efficiency_city_units,fuel_efficiency_highway_units
+Small car 2010,2011,0,-1,miles_per_gallon,miles_per_gallon

data/features/support/imports/automobile_size_class_year_good.csv

@@ -0,0 +1,2 @@
+name,year,fuel_efficiency_city,fuel_efficiency_highway,fuel_efficiency_city_units,fuel_efficiency_highway_units
+Small car 2010,2010,20,25,kilometres_per_litre,kilometres_per_litre

data/features/support/imports/automobile_type_fuel_age_bad.csv

@@ -0,0 +1,3 @@
+name,age,age_percent,total_travel_percent,annual_distance,annual_distance_units,vehicles,type_name,fuel_common_name
+Passenger cars gasoline age 0,0,0.25,0.25,10000.0,kilometres,1000,Passenger cars,gasoline
+Light-duty trucks diesel age 2,-1,0,1,0,miles

data/features/support/imports/automobile_type_fuel_age_good.csv

@@ -0,0 +1,3 @@
+name,age,age_percent,total_travel_percent,annual_distance,annual_distance_units,vehicles,type_name,fuel_common_name
+Passenger cars gasoline age 0,0,0.25,0.25,10000.0,kilometres,1000,Passenger cars,gasoline
+Light-duty trucks diesel age 2,2,0.15,0.15,20000.0,kilometres,2000,Light-duty trucks,diesel

data/features/support/imports/automobile_type_fuel_control_bad.csv

@@ -0,0 +1,3 @@
+name,ch4_emission_factor,ch4_emission_factor_units,n2o_emission_factor,n2o_emission_factor_units,type_name,fuel_common_name,control_name
+Passenger cars gasoline epa tier 2,0.2,kilograms_per_kilometre,0.1,kilograms_per_kilometre,Passenger cars,gasoline,epa tier 2
+Light-duty trucks diesel advanced,1,kilograms_per_litre,-1,grams

data/features/support/imports/automobile_type_fuel_control_good.csv

@@ -0,0 +1,3 @@
+name,ch4_emission_factor,ch4_emission_factor_units,n2o_emission_factor,n2o_emission_factor_units,type_name,fuel_common_name,control_name
+Passenger cars gasoline epa tier 2,0.2,kilograms_per_kilometre,0.1,kilograms_per_kilometre,Passenger cars,gasoline,epa tier 2
+Light-duty trucks diesel advanced,0.4,kilograms_per_kilometre,0.2,kilograms_per_kilometre,Light-duty trucks,diesel,advanced

data/features/support/imports/automobile_type_fuel_year_bad.csv

@@ -0,0 +1,2 @@
+name,year,total_travel,fuel_consumption,ch4_emission_factor,n2o_emission_factor,hfc_emission_factor,total_travel_units,fuel_consumption_units,ch4_emission_factor_units,n2o_emission_factor_units,hfc_emission_factor_units,type_name,fuel_common_name
+Light-duty trucks diesel 2010,2010,0,-1,0,-1,-1,miles,gallons,grams_per_mile,grams_per_mile,co2e

data/features/support/imports/automobile_type_fuel_year_control_bad.csv

@@ -0,0 +1,3 @@
+name,year,total_travel_percent,type_name,fuel_common_name,control_name
+Passenger cars gasoline 2008 epa tier 2,2008,0.9,Passenger cars,gasoline,epa tier 2
+Light-duty trucks diesel 2008 epa advanced,2009,0.1

data/features/support/imports/automobile_type_fuel_year_control_good.csv

@@ -0,0 +1,3 @@
+name,year,total_travel_percent,type_name,fuel_common_name,control_name
+Passenger cars gasoline 2008 epa tier 2,2008,0.9,Passenger cars,gasoline,epa tier 2
+Light-duty trucks diesel 2008 epa advanced,2008,-1,Light-duty trucks,diesel,advanced

data/features/support/imports/automobile_type_fuel_year_good.csv

@@ -0,0 +1,2 @@
+name,year,total_travel,fuel_consumption,ch4_emission_factor,n2o_emission_factor,hfc_emission_factor,total_travel_units,fuel_consumption_units,ch4_emission_factor_units,n2o_emission_factor_units,hfc_emission_factor_units,type_name,fuel_common_name
+Passenger cars gasoline 2000,2000,1000,500,0.01,0.001,0,kilometres,litres,kilograms_per_litre,kilograms_per_litre,kilograms_co2e_per_litre,Passenger cars,gasoline

data/features/support/imports/automobile_type_year_bad.csv

@@ -0,0 +1,2 @@
+name,year,hfc_emissions,hfc_emissions_units,type_name
+Passenger cars 2008,2009,-1,pounds

data/features/support/imports/automobile_type_year_good.csv

@@ -0,0 +1,2 @@
+name,year,hfc_emissions,hfc_emissions_units,type_name
+Passenger cars 2008,2008,1000,kilograms_co2e,Passenger cars

data/features/support/imports/computation_platform_bad.csv

@@ -0,0 +1,3 @@
+name,data_center_company_name
+Heroku,Amazon
+Engine Yard

data/features/support/imports/computation_platform_good.csv

@@ -0,0 +1,3 @@
+name,data_center_company_name
+Heroku,Amazon
+Engine Yard,Amazon

data/features/support/imports/data_center_company_bad.csv

@@ -0,0 +1,3 @@
+name,power_usage_effectiveness
+Swift Servers,1.5
+Disorganized Servers

data/features/support/imports/data_center_company_good.csv

@@ -0,0 +1,3 @@
+name,power_usage_effectiveness
+Swift Servers,1.5
+Super Efficient Servers,1.0

data/features/support/imports/egrid_subregion_good.csv

@@ -1,3 +1,3 @@
 name,egrid_region_name,electricity_emission_factor,electricity_emission_factor_units
-US,US,1.2,kilograms_per_kilowatt_hour
-AKGD,AK,0.9,kilograms_per_kilowatt_hour
+US,US,1.2,kilograms_co2e_per_kilowatt_hour
+AKGD,AK,0.9,kilograms_co2e_per_kilowatt_hour

data/features/support/imports/flight_segment_bad.csv

@@ -0,0 +1,8 @@
+origin_airport_iata_code,destination_airport_iata_code,airline_iata_code,aircraft_bts_code,distance,distance_units,departures_performed,passengers,total_seats,seats,freight,freight_units,payload,payload_units,load_factor,freight_share
+ADA,AIA,DA,1,185.2,kilometres,1,100,125,125,100,kilograms,10100,kilograms,0.8,0.00990
+ADA,AIA,DA,2,185.2,kilometres,1,100,120,120,200,kilograms,10200,kilograms,0.833333333,0.01961
+AIA,WEA,IA,2,1852,kilometres,1,100,120,120,500,kilograms,10500,kilograms,0.833333333,0.04762
+AIA,WEA,IA,,1852,kilometres,1,100,120,120,500,kilograms,10500,kilograms,0.833333333,0.04762
+AIA,WEA,EA,3,1852,kilometres,1,100,130,130,1000,kilograms,11000,kilograms,0.769230769,0.09091
+AZP,BZP,ZA,,185.2,kilometres,1,0,110,110,100,kilograms,10100,kilograms,0.8,0.009990
+AZP,BZP,ZA,6,185.2,kilometres,1,0,110,110,100,kilograms,10100,kilograms,0.8,0.009990

data/features/support/imports/flight_segment_good.csv

@@ -0,0 +1,8 @@
+origin_airport_iata_code,destination_airport_iata_code,airline_iata_code,aircraft_bts_code,distance,distance_units,departures_performed,passengers,total_seats,seats,freight,freight_units,payload,payload_units,load_factor,freight_share
+ADA,AIA,DA,1,185.2,kilometres,1,100,125,125,100,kilograms,10100,kilograms,0.8,0.00990
+ADA,AIA,DA,2,185.2,kilometres,1,100,120,120,200,kilograms,10200,kilograms,0.833333333,0.01961
+AIA,WEA,IA,2,1852,kilometres,1,100,120,120,500,kilograms,10500,kilograms,0.833333333,0.04762
+AIA,WEA,IA,2,1852,kilometres,1,100,120,120,500,kilograms,10500,kilograms,0.833333333,0.04762
+AIA,WEA,EA,3,1852,kilometres,1,100,130,130,1000,kilograms,11000,kilograms,0.769230769,0.09091
+AZP,BZP,ZA,6,185.2,kilometres,1,0,110,110,100,kilograms,10100,kilograms,0.8,0.009990
+AZP,BZP,ZA,6,185.2,kilometres,1,0,110,110,100,kilograms,10100,kilograms,0.8,0.009990

data/features/support/imports/fuel_year_bad.csv

@@ -0,0 +1,2 @@
+name,year,carbon_content,energy_content,co2_emission_factor,carbon_content_units,energy_content_units,co2_emission_factor_units,fuel_name,fuel_common_name
+Motor Gasoline 2008,2009,0,-1,0,foo,bar,pounds_per_gallon

data/features/support/imports/fuel_year_good.csv

@@ -0,0 +1,2 @@
+name,year,carbon_content,energy_content,co2_emission_factor,carbon_content_units,energy_content_units,co2_emission_factor_units,fuel_name,fuel_common_name
+Motor Gasoline 2008,2008,19.5,5.2,2.3,teragrams_per_quadrillion_btu,million_btu_per_barrel,kilograms_per_litre,Motor Gasoline,gasoline

data/features/support/imports/greenhouse_gas_bad.csv

@@ -0,0 +1,2 @@
+name,time_horizon,time_horizon_units,global_warming_potential,abbreviation,ipcc_report
+Carbon dioxide,20,months,0

data/features/support/imports/greenhouse_gas_good.csv

@@ -0,0 +1,2 @@
+name,time_horizon,time_horizon_units,global_warming_potential,abbreviation,ipcc_report
+Carbon dioxide,100,years,1,co2,AR4

data/features/support/imports/server_type_alias_bad.csv

@@ -0,0 +1,3 @@
+name,server_type_name,platform_name
+Fugu,Normal,Heroku
+Large

data/features/support/imports/server_type_alias_good.csv

@@ -0,0 +1,3 @@
+name,server_type_name,platform_name
+Fugu,Normal,Heroku
+Large,Large,Engine Yard

data/features/support/imports/server_type_bad.csv

@@ -0,0 +1,3 @@
+name,memory,memory_units,cpu,cpu_units,electricity_draw,electricity_draw_units,data_center_company_name
+Normal,1.7,gigabytes,1,ec2_compute_units,2.3,kilowatts,Amazon
+Large,7.5,gigabytes,4,ec2_compute_units,0,gigawatts

data/features/support/imports/server_type_good.csv

@@ -0,0 +1,3 @@
+name,data_center_company_name,memory,memory_units,cpu,cpu_units,electricity_draw,electricity_draw_units
+Normal,Amazon,1.7,gigabytes,1,ec2_compute_units,2.3,kilowatts
+Large,Amazon,1.7,gigabytes,1,ec2_compute_units,4.0,kilowatts

data/lib/earth/air/aircraft.rb

@@ -1,15 +1,14 @@
 class Aircraft < ActiveRecord::Base
   set_primary_key :bp_code
   
+  belongs_to :manufacturer,   :foreign_key => 'manufacturer_name', :primary_key => 'name',     :class_name => 'AircraftManufacturer'
   belongs_to :aircraft_class, :foreign_key => 'class_code',        :primary_key => 'code'
   has_many   :segments,       :foreign_key => 'aircraft_bts_code', :primary_key => 'bts_code', :class_name => 'FlightSegment'
-  # belongs_to :manufacturer,   :foreign_key => 'icao_manufacturer_name', :primary_key => 'name',     :class_name => 'AircraftManufacturer'
   
   falls_back_on :m3            => lambda { weighted_average(:m3,            :weighted_by => [:segments, :passengers]) }, # 9.73423082858437e-08   r7110: 8.6540464368905e-8      r6972: 8.37e-8
                 :m2            => lambda { weighted_average(:m2,            :weighted_by => [:segments, :passengers]) }, # -0.000134350543484608  r7110: -0.00015337661447817    r6972: -4.09e-5
                 :m1            => lambda { weighted_average(:m1,            :weighted_by => [:segments, :passengers]) }, # 6.7728101555467        r7110: 4.7781966869412         r6972: 7.85
-                :endpoint_fuel => lambda { weighted_average(:endpoint_fuel, :weighted_by => [:segments, :passengers]) }, # 1527.81790006167       r7110: 1065.3476555284         r6972: 1.72e3
-                :seats         => lambda { weighted_average(:seats,         :weighted_by => [:segments, :passengers]) }  # 62.1741
+                :endpoint_fuel => lambda { weighted_average(:endpoint_fuel, :weighted_by => [:segments, :passengers]) }  # 1527.81790006167       r7110: 1065.3476555284         r6972: 1.72e3
   
   data_miner do
     tap "Brighter Planet's sanitized aircraft data", Earth.taps_server

data/lib/earth/air/aircraft/data_miner.rb

@@ -200,8 +200,6 @@ Aircraft.class_eval do
       # update_all "weighting = (#{segments.project(segments[:passengers].sum).where(aircraft[:aircraft_type_code].eq(segments[:aircraft_type_code])).to_sql})"
     end
     
-    process "Synthesize AircraftManufacturer" do
-       AircraftManufacturer.run_data_miner!
-     end
-   end
+    # FIXME TODO verify this
+  end
 end

data/lib/earth/air/aircraft_class/data_miner.rb

@@ -10,7 +10,7 @@ AircraftClass.class_eval do
       float   'seats'
     end
     
-    import "Brighter Planet's aircraft classes",
+    import "a list of Brighter Planet-defined aircraft classes",
            :url => 'https://spreadsheets.google.com/pub?key=0AoQJbWqPrREqdGNBbHFibmxJUFprQkUwZHp6VU51Smc&hl=en&single=true&gid=0&output=csv' do
       key 'code', :field_name => 'aircraft_class_code'
       store 'name'
@@ -27,5 +27,7 @@ AircraftClass.class_eval do
         update_all "#{column} = (#{relation.to_sql})"
       end
     end
+    
+    # FIXME TODO verify this
   end
 end

data/lib/earth/air/airport/data_miner.rb

@@ -48,7 +48,7 @@ Airport.class_eval do
     #     end
     #   end
     # end
-
+    
     process "Determine whether each airport serves international flights" do
       FlightSegment.run_data_miner!
       update_all 'international_origin = 1','(SELECT COUNT(*) FROM flight_segments WHERE flight_segments.origin_airport_iata_code = airports.iata_code AND flight_segments.origin_country_iso_3166_code != flight_segments.destination_country_iso_3166_code AND flight_segments.origin_country_iso_3166_code IS NOT NULL AND flight_segments.destination_country_iso_3166_code IS NOT NULL LIMIT 1) > 0'
@@ -60,7 +60,7 @@ Airport.class_eval do
       FlightSegment.run_data_miner!
       segments = FlightSegment.arel_table
       airports = Airport.arel_table
-
+      
       find_in_batches do |batch|
         batch.each do |airport|
           targeting_relation = airports[:iata_code].eq airport.iata_code
@@ -75,6 +75,7 @@ Airport.class_eval do
         end
       end
     end
+    
+    # FIXME TODO verify this
   end
 end
-