eapi 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ce4210341572090ddcab6a924eef6512c26790a8
-  data.tar.gz: 1773ccd9aa977cd193f4efd802cc1a11abe6d2b4
+  metadata.gz: f8a6da6f094409d07aa648318c1134b587bee426
+  data.tar.gz: c9d3e9715481dc3d1be43324fef7f81e860f3f06
 SHA512:
-  metadata.gz: 2c9beaa7358443dee5acdc658dd422a679376c2a29af2db1d6efdc780c47020ea8fc69c2aa2bdeb2e8d5c9b098544fd1a6bf1cb785eb18cc38ce85c9b588f682
-  data.tar.gz: f4d071de2e5e10e4300509088e3f60fcd6d173a1492766f95eab6600bb991ae28e77eda3b2d0484ed003a51432c5f2480700bec076b17804c85934d7c1856f78
+  metadata.gz: 46a2d8ccee0b0ccd1ca44756b6e7b5a7ed89801c0fd0192fa58367b4a55136df17689dcf13b59f4311bbe76b168e1f3ae84c80092d976467ae249cbb9ca7a5fe
+  data.tar.gz: 6e53f3f52a55fb714fbf48763f075afbb2bee60c77a40f72ed72b73cae1bab78025879b997362bf8b5036d1f15d5a4d5f7613955e32bf6b32a1f2a9657157a0b

data/README.md

@@ -294,6 +294,21 @@ eapi.init_something
 eapi.something # => {}
 ```
 
+A symbol or a string can also be specified as class name in `type` option, and it will be loaded on type check. This can be helpful to avoid loading problems. Using the same example as before:
+
+```ruby
+class TestKlass
+  include Eapi::Common
+
+  property :something, type: "Hash"
+end
+
+eapi = TestKlass.new
+eapi.something # => nil
+eapi.init_something
+eapi.something # => {}
+```
+
 To trigger the error, the value must not be an instance of the given Type, and also must not respond `true` to `value.is?(type)`
 
 #### Custom validation with `validate_with` option

data/lib/eapi/type_checker.rb

@@ -1,5 +1,5 @@
 module Eapi
-  class TypeChecker < Struct.new(:type)
+  class TypeChecker < Struct.new(:given_type)
     def is_valid_type?(value)
       value.nil? || is_same_type?(value) || poses_as_type?(value)
     end
@@ -12,5 +12,13 @@ module Eapi
     def poses_as_type?(value)
       value.respond_to?(:is?) && value.is?(type)
     end
+
+    def type
+      if given_type.kind_of? Module
+        given_type
+      else
+        given_type.to_s.constantize
+      end
+    end
   end
 end

data/lib/eapi/version.rb

@@ -1,3 +1,3 @@
 module Eapi
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/spec/type_spec.rb

@@ -1,15 +1,13 @@
 require 'spec_helper'
 
 RSpec.describe Eapi do
+  class SomeType
+  end
 
   context 'type check' do
-    class OtherType
-    end
-
     class MyTestTypeKlass
       include Eapi::Common
-
-      is :one_thing, :other_thing, OtherType
+      is :one_thing, :other_thing, SomeType
     end
 
     describe '#is? and .is?' do
@@ -30,8 +28,8 @@ RSpec.describe Eapi do
         expect(MyTestTypeKlass).not_to be_is :not_you
         expect(MyTestTypeKlass).to be_is :one_thing
         expect(MyTestTypeKlass).to be_is :other_thing
-        expect(MyTestTypeKlass).to be_is OtherType
-        expect(MyTestTypeKlass).to be_is :OtherType
+        expect(MyTestTypeKlass).to be_is SomeType
+        expect(MyTestTypeKlass).to be_is :SomeType
       end
     end
 
@@ -51,8 +49,8 @@ RSpec.describe Eapi do
         expect(obj).not_to be_is :not_you
         expect(obj).to be_is :one_thing
         expect(obj).to be_is :other_thing
-        expect(obj).to be_is OtherType
-        expect(obj).to be_is :OtherType
+        expect(obj).to be_is SomeType
+        expect(obj).to be_is :SomeType
       end
     end
 
@@ -83,4 +81,20 @@ RSpec.describe Eapi do
       end
     end
   end
+
+  context 'using symbol as type' do
+    class MyTestTypeKlassSymbol
+      include Eapi::Common
+      is :SomeType
+    end
+
+    it 'works the same' do
+      expect(MyTestTypeKlassSymbol).to be_is SomeType
+      expect(MyTestTypeKlassSymbol).to be_is :SomeType
+
+      obj = MyTestTypeKlassSymbol.new
+      expect(obj).to be_is SomeType
+      expect(obj).to be_is :SomeType
+    end
+  end
 end

data/spec/validations_spec.rb

@@ -90,27 +90,81 @@ RSpec.describe Eapi do
         end
       end
 
-      class MyTestClassValType
-        include Eapi::Common
+      describe 'using a class as type' do
+        class MyTestClassValType
+          include Eapi::Common
 
-        property :something, type: Hash
-      end
+          property :something, type: Hash
+        end
 
-      it 'invalid if value is not of that type' do
-        eapi = MyTestClassValType.new something: 1
-        expect(eapi).not_to be_valid
-        expect(eapi.errors.full_messages).to eq ["Something must be a Hash"]
-        expect(eapi.errors.messages).to eq({something: ["must be a Hash"]})
+        it 'invalid if value is not of that type' do
+          eapi = MyTestClassValType.new something: 1
+          expect(eapi).not_to be_valid
+          expect(eapi.errors.full_messages).to eq ["Something must be a Hash"]
+          expect(eapi.errors.messages).to eq({something: ["must be a Hash"]})
+        end
+
+        it 'valid if value is of the given type' do
+          eapi = MyTestClassValType.new something: {}
+          expect(eapi).to be_valid
+        end
+
+        it 'valid if value is not an instance of the given type but responds true to `.is?(type)`' do
+          eapi = MyTestClassValType.new something: SimilarToHash.new
+          expect(eapi).to be_valid
+        end
       end
 
-      it 'valid if value is of the given type' do
-        eapi = MyTestClassValType.new something: {}
-        expect(eapi).to be_valid
+
+      describe 'using a symbol as type' do
+        class MyTestClassValTypeSymbol
+          include Eapi::Common
+
+          property :something, type: :Hash
+        end
+
+        it 'invalid if value is not of that type' do
+          eapi = MyTestClassValTypeSymbol.new something: 1
+          expect(eapi).not_to be_valid
+          expect(eapi.errors.full_messages).to eq ["Something must be a Hash"]
+          expect(eapi.errors.messages).to eq({something: ["must be a Hash"]})
+        end
+
+        it 'valid if value is of the given type' do
+          eapi = MyTestClassValTypeSymbol.new something: {}
+          expect(eapi).to be_valid
+        end
+
+        it 'valid if value is not an instance of the given type but responds true to `.is?(type)`' do
+          eapi = MyTestClassValTypeSymbol.new something: SimilarToHash.new
+          expect(eapi).to be_valid
+        end
       end
 
-      it 'valid if value is not an instance of the given type but responds true to `.is?(type)`' do
-        eapi = MyTestClassValType.new something: SimilarToHash.new
-        expect(eapi).to be_valid
+
+      describe 'using a string as type' do
+        class MyTestClassValTypeString
+          include Eapi::Common
+
+          property :something, type: 'Hash'
+        end
+
+        it 'invalid if value is not of that type' do
+          eapi = MyTestClassValTypeString.new something: 1
+          expect(eapi).not_to be_valid
+          expect(eapi.errors.full_messages).to eq ["Something must be a Hash"]
+          expect(eapi.errors.messages).to eq({something: ["must be a Hash"]})
+        end
+
+        it 'valid if value is of the given type' do
+          eapi = MyTestClassValTypeString.new something: {}
+          expect(eapi).to be_valid
+        end
+
+        it 'valid if value is not an instance of the given type but responds true to `.is?(type)`' do
+          eapi = MyTestClassValTypeString.new something: SimilarToHash.new
+          expect(eapi).to be_valid
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: eapi
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Eduardo Turiño