eapi 0.0.1 → 0.1.0

data/spec/{eapi_validations_spec.rb → validations_spec.rb}

@@ -5,18 +5,18 @@ RSpec.describe Eapi do
   context 'validations' do
     describe '#valid?' do
       it 'true if no validations' do
-        class Eapi::MyTestClassVal
+        class MyTestClassVal
           include Eapi::Common
 
           property :something
         end
 
-        eapi = Eapi::MyTestClassVal.new something: :hey
+        eapi = MyTestClassVal.new something: :hey
         expect(eapi).to be_valid
       end
 
       it 'false if validations not met' do
-        class Eapi::MyTestClassVal2
+        class MyTestClassVal2
           include Eapi::Common
 
           property :something
@@ -24,7 +24,7 @@ RSpec.describe Eapi do
           validates_presence_of :something
         end
 
-        eapi = Eapi::MyTestClassVal2.new
+        eapi = MyTestClassVal2.new
         expect(eapi).not_to be_valid
         expect(eapi.errors.full_messages).to eq ["Something can't be blank"]
         expect(eapi.errors.messages).to eq({something: ["can't be blank"]})
@@ -32,33 +32,20 @@ RSpec.describe Eapi do
     end
 
     it 'if required, same as validate presence' do
-      class Eapi::MyTestClassVal3
+      class MyTestClassVal3
         include Eapi::Common
 
         property :something, required: true
       end
 
-      eapi = Eapi::MyTestClassVal3.new
+      eapi = MyTestClassVal3.new
       expect(eapi).not_to be_valid
       expect(eapi.errors.full_messages).to eq ["Something can't be blank"]
       expect(eapi.errors.messages).to eq({something: ["can't be blank"]})
     end
 
-    it 'if type specified with a class, validates it' do
-      class Eapi::MyTestClassVal3
-        include Eapi::Common
-
-        property :something, type: Hash
-      end
-
-      eapi = Eapi::MyTestClassVal3.new something: 1
-      expect(eapi).not_to be_valid
-      expect(eapi.errors.full_messages).to eq ["Something must be a Hash"]
-      expect(eapi.errors.messages).to eq({something: ["must be a Hash"]})
-    end
-
     it 'if validate_with: specified with a class, uses it to validate the property' do
-      class Eapi::MyTestClassVal4
+      class MyTestClassVal4
         include Eapi::Common
 
         property :something, validate_with: ->(record, attr, value) do
@@ -66,7 +53,7 @@ RSpec.describe Eapi do
         end
       end
 
-      eapi = Eapi::MyTestClassVal4.new something: 1
+      eapi = MyTestClassVal4.new something: 1
 
       expect(eapi).not_to be_valid
       expect(eapi.errors.full_messages).to eq ["Something must pass my custom validation"]
@@ -75,6 +62,57 @@ RSpec.describe Eapi do
       eapi.something :valid_val
       expect(eapi).to be_valid
     end
+
+    it 'normal ActiveModel::Validations can be used' do
+      class MyTestClassVal5
+        include Eapi::Common
+
+        property :something
+
+        validates :something, numericality: true
+
+      end
+
+      eapi = MyTestClassVal5.new something: 'something'
+
+      expect(eapi).not_to be_valid
+      expect(eapi.errors.full_messages).to eq ["Something is not a number"]
+      expect(eapi.errors.messages).to eq({something: ["is not a number"]})
+
+      eapi.something 1
+      expect(eapi).to be_valid
+    end
+
+    context 'type is specified with a class' do
+      class SimilarToHash
+        def is?(type)
+          [:SimilarToHash, :Hash].include? type.to_s.to_sym
+        end
+      end
+
+      class MyTestClassValType
+        include Eapi::Common
+
+        property :something, type: Hash
+      end
+
+      it 'invalid if value is not of that type' do
+        eapi = MyTestClassValType.new something: 1
+        expect(eapi).not_to be_valid
+        expect(eapi.errors.full_messages).to eq ["Something must be a Hash"]
+        expect(eapi.errors.messages).to eq({something: ["must be a Hash"]})
+      end
+
+      it 'valid if value is of the given type' do
+        eapi = MyTestClassValType.new something: {}
+        expect(eapi).to be_valid
+      end
+
+      it 'valid if value is not an instance of the given type but responds true to `.is?(type)`' do
+        eapi = MyTestClassValType.new something: SimilarToHash.new
+        expect(eapi).to be_valid
+      end
+    end
   end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eapi
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Eduardo Turiño
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-28 00:00:00.000000000 Z
+date: 2014-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -136,20 +136,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: coveralls
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -185,7 +171,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".coveralls.yml"
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
@@ -195,7 +180,9 @@ files:
 - Rakefile
 - eapi.gemspec
 - lib/eapi.rb
+- lib/eapi/children.rb
 - lib/eapi/common.rb
+- lib/eapi/definition_runner.rb
 - lib/eapi/errors.rb
 - lib/eapi/methods.rb
 - lib/eapi/methods/accessor.rb
@@ -203,12 +190,17 @@ files:
 - lib/eapi/methods/properties.rb
 - lib/eapi/methods/types.rb
 - lib/eapi/multiple.rb
+- lib/eapi/type_checker.rb
+- lib/eapi/value_converter.rb
 - lib/eapi/version.rb
-- spec/eapi_basic_spec.rb
-- spec/eapi_list_spec.rb
-- spec/eapi_to_h_spec.rb
-- spec/eapi_validations_spec.rb
+- spec/basic_spec.rb
+- spec/definition_spec.rb
+- spec/function_spec.rb
+- spec/list_spec.rb
 - spec/spec_helper.rb
+- spec/to_h_spec.rb
+- spec/type_spec.rb
+- spec/validations_spec.rb
 homepage: ''
 licenses:
 - MIT
@@ -235,9 +227,12 @@ specification_version: 4
 summary: ruby gem for building complex structures that will end up in hashes (initially
   devised for ElasticSearch search requests)
 test_files:
-- spec/eapi_basic_spec.rb
-- spec/eapi_list_spec.rb
-- spec/eapi_to_h_spec.rb
-- spec/eapi_validations_spec.rb
+- spec/basic_spec.rb
+- spec/definition_spec.rb
+- spec/function_spec.rb
+- spec/list_spec.rb
 - spec/spec_helper.rb
+- spec/to_h_spec.rb
+- spec/type_spec.rb
+- spec/validations_spec.rb
 has_rdoc: 

data/.coveralls.yml

@@ -1 +0,0 @@
-service_name: travis-ci

data/spec/eapi_basic_spec.rb

@@ -1,39 +0,0 @@
-require 'spec_helper'
-
-RSpec.describe Eapi do
-
-  context 'basic behaviour' do
-    class Eapi::MyTestKlass
-      include Eapi::Common
-
-      property :something
-    end
-
-    describe '#something (fluent setter/getter)' do
-      describe '#something as getter' do
-        it 'return the value' do
-          eapi = Eapi::MyTestKlass.new something: :hey
-          expect(eapi.something).to eq :hey
-        end
-      end
-
-      describe '#something("val")' do
-        it 'set the value and return self' do
-          eapi = Eapi::MyTestKlass.new something: :hey
-          res  = eapi.something :other
-          expect(eapi).to be res
-          expect(eapi.something).to eq :other
-        end
-      end
-    end
-
-    describe 'Eapi.MyTestKlass(...)' do
-      it 'calls EapiTestClass.new' do
-        eapi = Eapi.MyTestKlass(something: :hey)
-        expect(eapi).to be_a Eapi::MyTestKlass
-        expect(eapi.something).to eq :hey
-      end
-    end
-  end
-
-end

data/spec/eapi_list_spec.rb

@@ -1,92 +0,0 @@
-require 'spec_helper'
-
-RSpec.describe Eapi do
-
-  context 'list' do
-    class Eapi::MyTestClassValMult
-      include Eapi::Common
-
-      property :something, multiple: true
-    end
-
-    it '#add_something' do
-      eapi = Eapi::MyTestClassValMult.new something: [1, 2]
-      res  = eapi.add_something 3
-      expect(res).to be eapi
-      expect(eapi.something).to eq [1, 2, 3]
-    end
-
-    it '#init_something called on first add if element is nil' do
-      eapi = Eapi::MyTestClassValMult.new
-      res  = eapi.add_something :a
-      expect(res).to be eapi
-      expect(eapi.something.to_a).to eq [:a]
-    end
-
-    class Eapi::MyTestClassValMultImpl
-      include Eapi::Common
-
-      property :something, type: Set
-    end
-
-    class MyMultiple
-      def self.is_multiple?
-        true
-      end
-
-      def <<(x)
-        @elements ||= []
-        @elements << x
-      end
-
-      def to_a
-        @elements.to_a
-      end
-    end
-
-    class Eapi::MyTestClassValMultImpl2
-      include Eapi::Common
-
-      property :something, type: MyMultiple
-    end
-
-    class MyMultipleEapi
-      include Eapi::Multiple
-
-      def <<(x)
-        @elements ||= []
-        @elements << x
-      end
-
-      def to_a
-        @elements.to_a
-      end
-    end
-
-    class Eapi::MyTestClassValMultImpl3
-      include Eapi::Common
-
-      property :something, type: MyMultipleEapi
-    end
-
-    it 'if type is Array or Set, or responds true to is_multiple?, it is multiple implicitly + uses that class to initialize the property when adding' do
-      [
-        [Eapi::MyTestClassValMult, Array],
-        [Eapi::MyTestClassValMultImpl, Set],
-        [Eapi::MyTestClassValMultImpl2, MyMultiple],
-        [Eapi::MyTestClassValMultImpl3, MyMultipleEapi],
-      ].each do |(eapi_class, type_class)|
-        eapi = eapi_class.new
-        res  = eapi.add_something :a
-        expect(res).to be eapi
-        expect(eapi.something.to_a).to eq [:a]
-        expect(eapi.something).to be_a_kind_of type_class
-      end
-    end
-
-    it 'validate elements' do
-      skip 'test TBD'
-    end
-  end
-
-end

data/spec/eapi_to_h_spec.rb

@@ -1,42 +0,0 @@
-require 'spec_helper'
-
-RSpec.describe Eapi do
-
-  context '#to_h' do
-    class Eapi::MyTestClassToH
-      include Eapi::Common
-
-      property :something, required: true
-      property :other
-    end
-
-    it 'raise error if invalid' do
-      eapi = Eapi::MyTestClassToH.new
-      expect { eapi.to_h }.to raise_error do |error|
-        expect(error).to be_a_kind_of Eapi::Errors::InvalidElementError
-        expect(error.message).to be_start_with "errors: [\"Something can't be blank\"], self: #<Eapi::MyTestClassToH"
-      end
-
-    end
-
-    it 'create a hash with elements (calling to_h to each element), avoiding nils' do
-      eapi = Eapi::MyTestClassToH.new
-      eapi.something 'hi'
-      expected = {something: 'hi'}
-      expect(eapi.to_h).to eq expected
-
-      class MyTestObject
-        def to_h
-          'hello'
-        end
-      end
-
-      element = MyTestObject.new
-      eapi    = Eapi::MyTestClassToH.new
-      eapi.something(element).other(true)
-      expected = {something: 'hello', other: true}
-
-      expect(eapi.to_h).to eq expected
-    end
-  end
-end