eager_group 0.7.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7ee556b1563f43bb0b0b19d07b47cadf828a0a06586687bb23cea618c85f4d4f
-  data.tar.gz: 67f6b99dae67ae911a02261c98d662fa465407579b4962132d7b7d024bed9816
+  metadata.gz: 559e8eeb3768f38a63b7ec19a0201dfc583073e37cc145ffabd19886bfe4ba59
+  data.tar.gz: 72fa7fd007ac0f9de02490cde602b25ad6bbb3ef48b8d61b1b13976721d89fcf
 SHA512:
-  metadata.gz: 912675975d5fab05a06045bc387ac1c128f2c313c692fc60f5df925d04bb7d846d9d1a458cc64c6a2c6139fc77e7d7c0721bf4173c3d115922ad2ffecff047e0
-  data.tar.gz: ce554fd38a31348d7fee55472aaefcf559a88db0f33f24a516273a83d7380079594377a33ff5d625802329496fc50d8f611006dc4b2bf3fabf00eaef8d26e835
+  metadata.gz: 39e828e5c8e1315d2a3083907c172373c7f6026d3397a7f0eecbf6722408e87af71c3c22226e271d7a7369806227184513a68df24cf865d2dcf6ea8e23f63652
+  data.tar.gz: 559307e3dac7da634ed9a3e28d93a7dbf0f2b16eb422887f308bfd01f1241806485ce34b62a3d6c66fe9a601f63128fe14a2ce47f729c92508516bd60e637e3d

data/CHANGELOG.md

@@ -1,8 +1,12 @@
 # Next Release
 
-## 0.7.0 (03/05/2018)
+## 0.7.1 (08/23/2019)
 
-* Add first_object and last_object aggregation
+* Set `eager_group_definitions` by `mattr_accessor`
+
+## 0.7.0 (08/22/2019)
+
+* Add `first_object` and `last_object` aggregation
 
 ## 0.6.1 (03/05/2018)
 

data/README.md

@@ -88,8 +88,8 @@ result.
 * `association`, association name you want to aggregate.
 * `aggregate_function`, aggregate sql function, can be one of `average`,
 `count`, `maximum`, `minimum`, `sum`, I define 2 additional aggregate
-function `first_object` and `last_object` to fetch first and last object
-from associations.
+function `first_object` and `last_object` to eager load first and last
+association objects.
 * `column_name`, aggregate column name, it can be `:*` for `count`
 * `scope`, scope is optional, it's used to filter data for aggregation.
 
@@ -119,7 +119,7 @@ post.approved_comments_count
 
 ## Advanced
 
-eager_group through association
+`eager_group` through association
 
 ```ruby
 User.limit(10).includes(:posts).eager_group(posts: [:comments_average_rating, :approved_comments_count])
@@ -138,8 +138,8 @@ posts = Post.all.eager_group([:comments_average_rating_by_author, author, true])
 posts.each { |post| post.comments_average_rating_by_author }
 ```
 
-first_object and last_object aggregation to fetch first and last
-association object.
+`first_object` and `last_object` aggregation to eager load first and
+last association objects.
 
 ```ruby
 class Post < ActiveRecord::Base

data/eager_group.gemspec

@@ -23,6 +23,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'activerecord'
   spec.add_development_dependency 'activerecord-import'
+  spec.add_development_dependency 'activesupport'
   spec.add_development_dependency 'benchmark-ips'
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake', '~> 10.0'

data/lib/eager_group.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require 'active_support/core_ext/module/attribute_accessors'
 require 'eager_group/version'
 
 module EagerGroup
@@ -11,7 +12,7 @@ module EagerGroup
   end
 
   module ClassMethods
-    attr_reader :eager_group_definitions
+    mattr_accessor :eager_group_definitions, default: {}
 
     # class Post
     #   define_eager_group :comments_avergage_rating, :comments, :average, :rating
@@ -19,8 +20,7 @@ module EagerGroup
     # end
     def define_eager_group(attr, association, aggregate_function, column_name, scope = nil)
       send :attr_accessor, attr
-      @eager_group_definitions ||= {}
-      @eager_group_definitions[attr] = Definition.new association, aggregate_function, column_name, scope
+      self.eager_group_definitions[attr] = Definition.new(association, aggregate_function, column_name, scope)
 
       define_method attr, lambda { |*args|
         query_result_cache = instance_variable_get("@#{attr}")

data/lib/eager_group/definition.rb

@@ -14,6 +14,7 @@ module EagerGroup
     def aggregation_function
       return :maximum if @aggregate_function.to_sym == :last_object
       return :minimum if @aggregate_function.to_sym == :first_object
+
       @aggregate_function
     end
 

data/lib/eager_group/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EagerGroup
-  VERSION = '0.7.0'
+  VERSION = '0.7.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eager_group
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-08-21 00:00:00.000000000 Z
+date: 2019-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -38,6 +38,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: benchmark-ips
   requirement: !ruby/object:Gem::Requirement