eager_eye 1.2.8 → 1.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 79319b66a87234e31df5def9ba5c0a487e298de8620bd4022f9d7db63e455152
-  data.tar.gz: f400ab8eb6ca1762a9773f90d8d1311546ed58035b3a062c6d408f7a97fd17e2
+  metadata.gz: 4cedfbe1ec9b556f757e9b161f896d96986bfc2dac8bf865c6e1bc289f6777b8
+  data.tar.gz: 8c0dc65a55e21c5d4e122f51293ac480f01435af2b719a262efe6ccdfa04603c
 SHA512:
-  metadata.gz: d70aff4b63cc9da79ca7956487a94d0e950aa85416b64636c1a2d8f94f898c1aea04712d3e964aaf5aafd8eea4fca9a817f09021806462123cc1b4bd45bec9ff
-  data.tar.gz: f77947b4812e87380618ac4544e717b5b17f08386540d6142a0e9f9fbbf9ed8fbdd6460beb8671e0a6e4fb8e8d2f21c1417eb9281082f5da67576bfd51990ab0
+  metadata.gz: 64d29ba207011df8fee0e11e6557de652ad5e3ed87c140e68cbedebb44988a477da0e2d5842fe28460811ebcc53db974f5403f4d73dd9de2653980a329e9a10c
+  data.tar.gz: f1dc481bc8b85c6e03443edee9508216ffd111d49c09c0aabf021ef9250e42bc8a84ca95ab7fa6afb808ab9c041736fb75af40bbb8acdd2efd4f5ac060f879b7

data/CHANGELOG.md

@@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.2.9] - 2026-03-13
+
+### Changed
+
+- **Dynamic Association Detection** - Association names are now automatically parsed from model files
+  - `has_many`, `has_one`, `belongs_to`, `has_and_belongs_to_many` declarations are collected
+  - Custom associations like `:enrollments`, `:subscriptions`, `:invoices` are now detected
+  - Dynamic names supplement (not replace) the hardcoded fallback lists
+  - Benefits `LoopAssociation`, `SerializerNesting`, `DecoratorNPlusOne`, and `MissingCounterCache`
+
 ## [1.2.8] - 2026-03-10
 
 ### Added

data/README.md

@@ -10,7 +10,7 @@
 
 <p align="center">
   <a href="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml"><img src="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg" alt="CI"></a>
-  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.2.8-red.svg" alt="Gem Version"></a>
+  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.2.9-red.svg" alt="Gem Version"></a>
   <a href="https://github.com/hamzagedikkaya/eager_eye"><img src="https://img.shields.io/badge/coverage-95%25-brightgreen.svg" alt="Coverage"></a>
   <a href="https://www.ruby-lang.org/"><img src="https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg" alt="Ruby"></a>
   <a href="https://opensource.org/licenses/MIT"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="License: MIT"></a>

data/lib/eager_eye/analyzer.rb

@@ -18,12 +18,24 @@ module EagerEye
       validation_n_plus_one: Detectors::ValidationNPlusOne
     }.freeze
 
-    attr_reader :paths, :issues, :association_preloads, :delegation_maps, :scope_maps, :uniqueness_models
+    DETECTOR_EXTRA_ARGS = {
+      Detectors::LoopAssociation => %i[association_preloads association_names],
+      Detectors::SerializerNesting => %i[association_names],
+      Detectors::MissingCounterCache => %i[association_names],
+      Detectors::DecoratorNPlusOne => %i[association_names],
+      Detectors::DelegationNPlusOne => %i[delegation_maps],
+      Detectors::ScopeChainNPlusOne => %i[scope_maps],
+      Detectors::ValidationNPlusOne => %i[uniqueness_models]
+    }.freeze
+
+    attr_reader :paths, :issues, :association_preloads, :association_names, :delegation_maps, :scope_maps,
+                :uniqueness_models
 
     def initialize(paths: nil)
       @paths = Array(paths || EagerEye.configuration.app_path)
       @issues = []
       @association_preloads = {}
+      @association_names = Set.new
       @delegation_maps = {}
       @scope_maps = {}
       @uniqueness_models = Set.new
@@ -48,6 +60,7 @@ module EagerEye
         assoc_parser = AssociationParser.new
         assoc_parser.parse_model(ast, model_name)
         @association_preloads.merge!(assoc_parser.preloaded_associations)
+        @association_names.merge(assoc_parser.association_names)
 
         deleg_parser = DelegationParser.new
         deleg_parser.parse_model(ast, model_name)
@@ -117,12 +130,8 @@ module EagerEye
     end
 
     def detector_args(detector, ast, file_path)
-      args = [ast, file_path]
-      args << @association_preloads if detector.is_a?(Detectors::LoopAssociation)
-      args << @delegation_maps if detector.is_a?(Detectors::DelegationNPlusOne)
-      args << @scope_maps if detector.is_a?(Detectors::ScopeChainNPlusOne)
-      args << @uniqueness_models if detector.is_a?(Detectors::ValidationNPlusOne)
-      args
+      extra = DETECTOR_EXTRA_ARGS.find { |klass, _| detector.is_a?(klass) }&.last || []
+      [ast, file_path, *extra.map { |name| instance_variable_get(:"@#{name}") }]
     end
 
     def enabled_detectors

data/lib/eager_eye/association_parser.rb

@@ -4,10 +4,11 @@ module EagerEye
   class AssociationParser
     ASSOCIATION_METHODS = %i[has_many has_one belongs_to has_and_belongs_to_many].freeze
 
-    attr_reader :preloaded_associations
+    attr_reader :preloaded_associations, :association_names
 
     def initialize
       @preloaded_associations = {}
+      @association_names = Set.new
     end
 
     def parse_model(ast, model_name)
@@ -35,6 +36,8 @@ module EagerEye
       association_name = extract_association_name(node)
       return unless association_name
 
+      @association_names << association_name
+
       preloaded = extract_preloaded_associations(node)
       return if preloaded.empty?
 

data/lib/eager_eye/detectors/concerns/class_inspector.rb

@@ -35,7 +35,7 @@ module EagerEye
         end
 
         def likely_association?(method_name)
-          HAS_MANY_ASSOCIATIONS.include?(method_name.to_s)
+          HAS_MANY_ASSOCIATIONS.include?(method_name.to_s) || @dynamic_associations&.include?(method_name)
         end
 
         def collect_active_storage_lines(body)

data/lib/eager_eye/detectors/decorator_n_plus_one.rb

@@ -14,9 +14,10 @@ module EagerEye
         :decorator_n_plus_one
       end
 
-      def detect(ast, file_path)
+      def detect(ast, file_path, association_names = Set.new)
         return [] unless ast
 
+        @dynamic_associations = association_names
         issues = []
         traverse_ast(ast) do |node|
           next unless node.type == :class && decorator_class?(node)

data/lib/eager_eye/detectors/loop_association.rb

@@ -30,11 +30,12 @@ module EagerEye
         :loop_association
       end
 
-      def detect(ast, file_path, association_preloads = {})
+      def detect(ast, file_path, association_preloads = {}, association_names = Set.new)
         return [] unless ast
 
         issues = []
         @association_preloads = association_preloads
+        @dynamic_associations = association_names
         build_variable_maps(ast)
 
         traverse_ast(ast) do |node|
@@ -181,9 +182,13 @@ module EagerEye
 
       def excluded_method?(method, included)
         EXCLUDED_METHODS.include?(method) ||
-          !ASSOCIATION_NAMES.include?(method.to_s) ||
+          !known_association?(method) ||
           included.include?(method)
       end
+
+      def known_association?(method)
+        ASSOCIATION_NAMES.include?(method.to_s) || @dynamic_associations.include?(method)
+      end
     end
   end
 end

data/lib/eager_eye/detectors/missing_counter_cache.rb

@@ -17,9 +17,10 @@ module EagerEye
         :missing_counter_cache
       end
 
-      def detect(ast, file_path)
+      def detect(ast, file_path, association_names = Set.new)
         return [] unless ast
 
+        @dynamic_associations = association_names
         issues = []
 
         traverse_ast(ast) do |node|
@@ -51,7 +52,10 @@ module EagerEye
       end
 
       def likely_association_receiver?(node)
-        node.type == :send && PLURAL_ASSOCIATIONS.include?(node.children[1].to_s)
+        return false unless node.type == :send
+
+        method = node.children[1]
+        PLURAL_ASSOCIATIONS.include?(method.to_s) || @dynamic_associations&.include?(method)
       end
 
       def extract_association_name(node)

data/lib/eager_eye/detectors/serializer_nesting.rb

@@ -15,9 +15,10 @@ module EagerEye
         :serializer_nesting
       end
 
-      def detect(ast, file_path)
+      def detect(ast, file_path, association_names = Set.new)
         return [] unless ast
 
+        @dynamic_associations = association_names
         issues = []
         traverse_ast(ast) do |node|
           next unless node.type == :class && serializer_class?(node)

data/lib/eager_eye/detectors/validation_n_plus_one.rb

@@ -0,0 +1,118 @@
+# frozen_string_literal: true
+
+module EagerEye
+  module Detectors
+    class ValidationNPlusOne < Base
+      ITERATION_METHODS = %i[each map select find_all reject collect detect find_index flat_map
+                             find_each find_in_batches in_batches].freeze
+      CREATE_METHODS = %i[create create!].freeze
+      SAVE_METHODS = %i[save save!].freeze
+
+      def self.detector_name
+        :validation_n_plus_one
+      end
+
+      def detect(ast, file_path, uniqueness_models = Set.new)
+        return [] unless ast
+
+        @issues = []
+        @file_path = file_path
+        @uniqueness_models = uniqueness_models
+        return [] if @uniqueness_models.empty?
+
+        find_iteration_blocks(ast)
+        @issues
+      end
+
+      private
+
+      def find_iteration_blocks(node)
+        return unless node.is_a?(Parser::AST::Node)
+
+        if iteration_block?(node)
+          block_body = node.children[2]
+          check_block(block_body) if block_body
+        end
+
+        node.children.each { |child| find_iteration_blocks(child) }
+      end
+
+      def iteration_block?(node)
+        node.type == :block && node.children[0]&.type == :send &&
+          ITERATION_METHODS.include?(node.children[0].children[1])
+      end
+
+      def check_block(block_body)
+        new_model_vars = {}
+        collect_model_new_assignments(block_body, new_model_vars)
+        scan_for_issues(block_body, new_model_vars)
+      end
+
+      def collect_model_new_assignments(node, vars)
+        return unless node.is_a?(Parser::AST::Node)
+
+        if node.type == :lvasgn && model_new_call?(node.children[1])
+          model_name = const_name(node.children[1].children[0])
+          vars[node.children[0]] = model_name
+        end
+
+        node.children.each { |child| collect_model_new_assignments(child, vars) }
+      end
+
+      def scan_for_issues(node, new_model_vars)
+        return unless node.is_a?(Parser::AST::Node)
+
+        if node.type == :send
+          check_create_call(node)
+          check_save_call(node, new_model_vars)
+        end
+
+        node.children.each { |child| scan_for_issues(child, new_model_vars) }
+      end
+
+      def check_create_call(node)
+        return unless CREATE_METHODS.include?(node.children[1])
+
+        receiver = node.children[0]
+        return unless receiver&.type == :const
+
+        model_name = const_name(receiver)
+        add_issue(node, model_name, node.children[1]) if @uniqueness_models.include?(model_name)
+      end
+
+      def check_save_call(node, new_model_vars)
+        return unless SAVE_METHODS.include?(node.children[1])
+
+        receiver = node.children[0]
+        return unless receiver&.type == :lvar
+
+        model_name = new_model_vars[receiver.children[0]]
+        add_issue(node, model_name, node.children[1]) if model_name
+      end
+
+      def model_new_call?(node)
+        return false unless node.is_a?(Parser::AST::Node) && node.type == :send
+
+        node.children[1] == :new && node.children[0]&.type == :const &&
+          @uniqueness_models.include?(const_name(node.children[0]))
+      end
+
+      def const_name(node)
+        return "" unless node.is_a?(Parser::AST::Node) && node.type == :const
+
+        parent = node.children[0]
+        name = node.children[1].to_s
+        parent ? "#{const_name(parent)}::#{name}" : name
+      end
+
+      def add_issue(node, model_name, method_name)
+        @issues << create_issue(
+          file_path: @file_path,
+          line_number: node.loc.line,
+          message: "`#{model_name}.#{method_name}` inside iteration — uniqueness validation causes SELECT per record",
+          suggestion: "Use `insert_all` with unique index constraints, or batch-validate before saving."
+        )
+      end
+    end
+  end
+end

data/lib/eager_eye/validation_parser.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+module EagerEye
+  class ValidationParser
+    attr_reader :uniqueness_models
+
+    def initialize
+      @uniqueness_models = Set.new
+    end
+
+    def parse_model(ast, model_name)
+      return unless ast
+
+      traverse(ast, model_name)
+    end
+
+    private
+
+    def traverse(node, model_name)
+      return unless node.is_a?(Parser::AST::Node)
+
+      check_uniqueness(node, model_name)
+      node.children.each { |child| traverse(child, model_name) }
+    end
+
+    def check_uniqueness(node, model_name)
+      return unless node.type == :send && node.children[0].nil?
+
+      case node.children[1]
+      when :validates
+        @uniqueness_models << model_name if uniqueness_option?(node)
+      when :validates_uniqueness_of
+        @uniqueness_models << model_name
+      end
+    end
+
+    def uniqueness_option?(node)
+      node.children[2..].any? do |arg|
+        next false unless arg.is_a?(Parser::AST::Node) && arg.type == :hash
+
+        arg.children.any? { |pair| uniqueness_pair?(pair) }
+      end
+    end
+
+    def uniqueness_pair?(pair)
+      return false unless pair.type == :pair
+
+      key = pair.children[0]
+      key&.type == :sym && key.children[0] == :uniqueness
+    end
+  end
+end

data/lib/eager_eye/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EagerEye
-  VERSION = "1.2.8"
+  VERSION = "1.2.9"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eager_eye
 version: !ruby/object:Gem::Version
-  version: 1.2.8
+  version: 1.2.9
 platform: ruby
 authors:
 - hamzagedikkaya
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-03-10 00:00:00.000000000 Z
+date: 2026-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast
@@ -78,6 +78,7 @@ files:
 - lib/eager_eye/detectors/pluck_to_array.rb
 - lib/eager_eye/detectors/scope_chain_n_plus_one.rb
 - lib/eager_eye/detectors/serializer_nesting.rb
+- lib/eager_eye/detectors/validation_n_plus_one.rb
 - lib/eager_eye/fixer_registry.rb
 - lib/eager_eye/fixers/base.rb
 - lib/eager_eye/fixers/pluck_to_select.rb
@@ -90,6 +91,7 @@ files:
 - lib/eager_eye/rspec.rb
 - lib/eager_eye/rspec/matchers.rb
 - lib/eager_eye/scope_parser.rb
+- lib/eager_eye/validation_parser.rb
 - lib/eager_eye/version.rb
 - sig/eager_eye.rbs
 homepage: https://github.com/hamzagedikkaya/eager_eye