eager_eye 1.2.7 → 1.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dd5177a12d64b54cc6cd426440f79018da9ccc7dd931db70c491c9154bb385a1
-  data.tar.gz: dec16deb3b55ab821225d5d0e06a6fa308c41fd472dad405bf125c7e5839f2e0
+  metadata.gz: 79319b66a87234e31df5def9ba5c0a487e298de8620bd4022f9d7db63e455152
+  data.tar.gz: f400ab8eb6ca1762a9773f90d8d1311546ed58035b3a062c6d408f7a97fd17e2
 SHA512:
-  metadata.gz: 4336421ff71269732f594163dc3dbe29ca70d1b10c19dd333d972ea63bff9da36a4e83a041263fa6f61d758c8b0551912e075e00ce8f05978ab59c7db698af41
-  data.tar.gz: 51de528f0dca6b3279c0cb1fe6f21e5c35592dda81220419c209d8d43faf35b41375cbfffd33a463546f5e81e4807f8c48268f618d8383c82a570f81da823efa
+  metadata.gz: d70aff4b63cc9da79ca7956487a94d0e950aa85416b64636c1a2d8f94f898c1aea04712d3e964aaf5aafd8eea4fca9a817f09021806462123cc1b4bd45bec9ff
+  data.tar.gz: f77947b4812e87380618ac4544e717b5b17f08386540d6142a0e9f9fbbf9ed8fbdd6460beb8671e0a6e4fb8e8d2f21c1417eb9281082f5da67576bfd51990ab0

data/CHANGELOG.md

@@ -7,6 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.2.8] - 2026-03-10
+
+### Added
+
+- **New Detector: `ValidationNPlusOne`** - Detects batch create/save inside iterations for models with uniqueness validations
+  - Catches `User.create!(attrs)` and `User.new(attrs) + save!` patterns inside loops
+  - Parses model files for `validates :attr, uniqueness: true` and `validates_uniqueness_of` declarations
+  - Each uniqueness validation triggers a SELECT query per record — 2N queries total
+  - Suggests using `insert_all` with unique index constraints or batch-validating before saving
+- **New Parser: `ValidationParser`** - Collects models with uniqueness validations for cross-file detection
+
 ## [1.2.7] - 2026-03-10
 
 ### Added

data/README.md

@@ -10,7 +10,7 @@
 
 <p align="center">
   <a href="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml"><img src="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg" alt="CI"></a>
-  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.2.7-red.svg" alt="Gem Version"></a>
+  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.2.8-red.svg" alt="Gem Version"></a>
   <a href="https://github.com/hamzagedikkaya/eager_eye"><img src="https://img.shields.io/badge/coverage-95%25-brightgreen.svg" alt="Coverage"></a>
   <a href="https://www.ruby-lang.org/"><img src="https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg" alt="Ruby"></a>
   <a href="https://opensource.org/licenses/MIT"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="License: MIT"></a>
@@ -42,7 +42,7 @@
 
 ## Features
 
-✨ **Detects 10 types of N+1 problems:**
+✨ **Detects 11 types of N+1 problems:**
 - Loop associations (queries in iterations)
 - Serializer nesting issues
 - Missing counter caches
@@ -53,6 +53,7 @@
 - Delegation N+1s (hidden via `delegate :method, to: :association`)
 - Decorator N+1s (Draper, SimpleDelegator, Presenter, ViewObject)
 - Scope chain N+1s (named scopes on associations in loops)
+- Validation N+1s (uniqueness validation in batch create/save)
 
 🔧 **Developer-friendly:**
 - Inline suppression (like RuboCop)
@@ -426,6 +427,35 @@ EagerEye detects these by:
 1. Scanning model files for `scope :name, -> { ... }` declarations
 2. Flagging known scope names called on association chains inside iteration blocks
 
+### 11. Validation N+1
+
+Detects batch create/save operations inside iterations for models with `validates uniqueness`. Each uniqueness validation triggers a SELECT query per record, resulting in 2N queries (SELECT + INSERT per record).
+
+```ruby
+# Model
+class User < ApplicationRecord
+  validates :email, uniqueness: true
+end
+
+# Bad - 2N queries (SELECT + INSERT per record)
+params[:users].each do |user_params|
+  User.create!(user_params)          # SELECT + INSERT for each!
+end
+
+# Bad - same problem with new + save
+params[:users].each do |user_params|
+  user = User.new(user_params)
+  user.save!                         # SELECT + INSERT for each!
+end
+
+# Good - use insert_all with unique index
+User.insert_all(params[:users])      # Single bulk INSERT, DB enforces uniqueness
+```
+
+EagerEye detects these by:
+1. Scanning model files for `validates :attr, uniqueness: true` or `validates_uniqueness_of` declarations
+2. Flagging `Model.create/create!` or `Model.new` + `.save/.save!` patterns inside iteration blocks
+
 ## Inline Suppression
 
 Suppress false positives using inline comments (RuboCop-style):
@@ -471,6 +501,7 @@ Both CamelCase and snake_case formats are accepted:
 | Delegation N+1 | `DelegationNPlusOne` | `delegation_n_plus_one` |
 | Decorator N+1 | `DecoratorNPlusOne` | `decorator_n_plus_one` |
 | Scope Chain N+1 | `ScopeChainNPlusOne` | `scope_chain_n_plus_one` |
+| Validation N+1 | `ValidationNPlusOne` | `validation_n_plus_one` |
 | All Detectors | `all` | `all` |
 
 ## Auto-fix (Experimental)
@@ -576,19 +607,21 @@ enabled_detectors:
   - delegation_n_plus_one
   - decorator_n_plus_one
   - scope_chain_n_plus_one
+  - validation_n_plus_one
 
 # Severity levels per detector (error, warning, info)
 severity_levels:
-  loop_association: error          # Definite N+1
+  loop_association: error           # Definite N+1
   serializer_nesting: warning
   custom_method_query: warning
   count_in_iteration: warning
   callback_query: warning
-  pluck_to_array: warning          # Optimization
-  delegation_n_plus_one: warning   # Hidden delegation N+1
-  decorator_n_plus_one: warning    # Decorator/Presenter N+1
-  scope_chain_n_plus_one: warning  # Scope chain on association
-  missing_counter_cache: info      # Suggestion
+  pluck_to_array: warning           # Optimization
+  delegation_n_plus_one: warning    # Hidden delegation N+1
+  decorator_n_plus_one: warning     # Decorator/Presenter N+1
+  scope_chain_n_plus_one: warning   # Scope chain on association
+  validation_n_plus_one: warning    # Uniqueness validation in batch
+  missing_counter_cache: info       # Suggestion
 
 # Minimum severity to report (default: info)
 min_severity: warning

data/lib/eager_eye/analyzer.rb

@@ -14,10 +14,11 @@ module EagerEye
       pluck_to_array: Detectors::PluckToArray,
       delegation_n_plus_one: Detectors::DelegationNPlusOne,
       decorator_n_plus_one: Detectors::DecoratorNPlusOne,
-      scope_chain_n_plus_one: Detectors::ScopeChainNPlusOne
+      scope_chain_n_plus_one: Detectors::ScopeChainNPlusOne,
+      validation_n_plus_one: Detectors::ValidationNPlusOne
     }.freeze
 
-    attr_reader :paths, :issues, :association_preloads, :delegation_maps, :scope_maps
+    attr_reader :paths, :issues, :association_preloads, :delegation_maps, :scope_maps, :uniqueness_models
 
     def initialize(paths: nil)
       @paths = Array(paths || EagerEye.configuration.app_path)
@@ -25,6 +26,7 @@ module EagerEye
       @association_preloads = {}
       @delegation_maps = {}
       @scope_maps = {}
+      @uniqueness_models = Set.new
     end
 
     def run
@@ -54,6 +56,10 @@ module EagerEye
         scope_parser = ScopeParser.new
         scope_parser.parse_model(ast, model_name)
         @scope_maps.merge!(scope_parser.scope_maps)
+
+        validation_parser = ValidationParser.new
+        validation_parser.parse_model(ast, model_name)
+        @uniqueness_models.merge(validation_parser.uniqueness_models)
       rescue Errno::ENOENT, Errno::EACCES
         next
       end
@@ -115,6 +121,7 @@ module EagerEye
       args << @association_preloads if detector.is_a?(Detectors::LoopAssociation)
       args << @delegation_maps if detector.is_a?(Detectors::DelegationNPlusOne)
       args << @scope_maps if detector.is_a?(Detectors::ScopeChainNPlusOne)
+      args << @uniqueness_models if detector.is_a?(Detectors::ValidationNPlusOne)
       args
     end
 

data/lib/eager_eye/configuration.rb

@@ -9,7 +9,7 @@ module EagerEye
       loop_association serializer_nesting missing_counter_cache
       custom_method_query count_in_iteration callback_query
       pluck_to_array delegation_n_plus_one decorator_n_plus_one
-      scope_chain_n_plus_one
+      scope_chain_n_plus_one validation_n_plus_one
     ].freeze
 
     DEFAULT_SEVERITY_LEVELS = {
@@ -22,7 +22,8 @@ module EagerEye
       pluck_to_array: :warning,
       delegation_n_plus_one: :warning,
       decorator_n_plus_one: :warning,
-      scope_chain_n_plus_one: :warning
+      scope_chain_n_plus_one: :warning,
+      validation_n_plus_one: :warning
     }.freeze
 
     VALID_SEVERITIES = %i[info warning error].freeze

data/lib/eager_eye/detectors/scope_chain_n_plus_one.rb

@@ -0,0 +1,78 @@
+# frozen_string_literal: true
+
+module EagerEye
+  module Detectors
+    class ScopeChainNPlusOne < Base
+      ITERATION_METHODS = %i[each map select find_all reject collect detect find_index flat_map
+                             find_each find_in_batches in_batches].freeze
+
+      def self.detector_name
+        :scope_chain_n_plus_one
+      end
+
+      def detect(ast, file_path, scope_maps = {})
+        return [] unless ast
+
+        @issues = []
+        @file_path = file_path
+        @all_scopes = scope_maps.each_value.reduce(Set.new, :merge)
+        return [] if @all_scopes.empty?
+
+        find_iteration_blocks(ast)
+        @issues
+      end
+
+      private
+
+      def find_iteration_blocks(node)
+        return unless node.is_a?(Parser::AST::Node)
+
+        if iteration_block?(node)
+          block_var = extract_block_variable(node)
+          check_block(node.children[2], block_var) if block_var
+        end
+
+        node.children.each { |child| find_iteration_blocks(child) }
+      end
+
+      def iteration_block?(node)
+        node.type == :block && node.children[0]&.type == :send &&
+          ITERATION_METHODS.include?(node.children[0].children[1])
+      end
+
+      def check_block(node, block_var)
+        return unless node.is_a?(Parser::AST::Node)
+
+        add_issue(node) if scope_chain_on_association?(node, block_var)
+        node.children.each { |child| check_block(child, block_var) }
+      end
+
+      def scope_chain_on_association?(node, block_var)
+        return false unless node.type == :send
+
+        method_name = node.children[1]
+        return false unless @all_scopes.include?(method_name)
+
+        receiver = node.children[0]
+        receiver_chain_starts_with?(receiver, block_var) && chain_depth(receiver, block_var) >= 1
+      end
+
+      def chain_depth(node, block_var)
+        return 0 unless node.is_a?(Parser::AST::Node)
+        return 0 if node.type == :lvar && node.children[0] == block_var
+
+        node.type == :send ? 1 + chain_depth(node.children[0], block_var) : 0
+      end
+
+      def add_issue(node)
+        chain = reconstruct_chain(node.children[0])
+        @issues << create_issue(
+          file_path: @file_path,
+          line_number: node.loc.line,
+          message: "Scope `.#{node.children[1]}` called on `#{chain}` inside iteration",
+          suggestion: "Each scope call executes a new query. Consider preloading or using a joined query."
+        )
+      end
+    end
+  end
+end

data/lib/eager_eye/scope_parser.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+module EagerEye
+  class ScopeParser
+    attr_reader :scope_maps
+
+    def initialize
+      @scope_maps = {}
+    end
+
+    def parse_model(ast, model_name)
+      return unless ast
+
+      traverse(ast, model_name)
+    end
+
+    private
+
+    def traverse(node, model_name)
+      return unless node.is_a?(Parser::AST::Node)
+
+      check_scope(node, model_name)
+      node.children.each { |child| traverse(child, model_name) }
+    end
+
+    def check_scope(node, model_name)
+      return unless scope_call?(node)
+
+      scope_name = extract_scope_name(node)
+      return unless scope_name
+
+      @scope_maps[model_name] ||= Set.new
+      @scope_maps[model_name] << scope_name
+    end
+
+    def scope_call?(node)
+      node.type == :send && node.children[0].nil? && node.children[1] == :scope
+    end
+
+    def extract_scope_name(node)
+      first_arg = node.children[2]
+      first_arg&.type == :sym ? first_arg.children[0] : nil
+    end
+  end
+end

data/lib/eager_eye/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EagerEye
-  VERSION = "1.2.7"
+  VERSION = "1.2.8"
 end

data/lib/eager_eye.rb

@@ -7,6 +7,7 @@ require_relative "eager_eye/issue"
 require_relative "eager_eye/association_parser"
 require_relative "eager_eye/delegation_parser"
 require_relative "eager_eye/scope_parser"
+require_relative "eager_eye/validation_parser"
 require_relative "eager_eye/detectors/base"
 require_relative "eager_eye/detectors/loop_association"
 require_relative "eager_eye/detectors/serializer_nesting"
@@ -18,6 +19,7 @@ require_relative "eager_eye/detectors/pluck_to_array"
 require_relative "eager_eye/detectors/delegation_n_plus_one"
 require_relative "eager_eye/detectors/decorator_n_plus_one"
 require_relative "eager_eye/detectors/scope_chain_n_plus_one"
+require_relative "eager_eye/detectors/validation_n_plus_one"
 require_relative "eager_eye/comment_parser"
 require_relative "eager_eye/analyzer"
 require_relative "eager_eye/fixers/base"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: eager_eye
 version: !ruby/object:Gem::Version
-  version: 1.2.7
+  version: 1.2.8
 platform: ruby
 authors:
 - hamzagedikkaya
@@ -76,6 +76,7 @@ files:
 - lib/eager_eye/detectors/loop_association.rb
 - lib/eager_eye/detectors/missing_counter_cache.rb
 - lib/eager_eye/detectors/pluck_to_array.rb
+- lib/eager_eye/detectors/scope_chain_n_plus_one.rb
 - lib/eager_eye/detectors/serializer_nesting.rb
 - lib/eager_eye/fixer_registry.rb
 - lib/eager_eye/fixers/base.rb
@@ -88,6 +89,7 @@ files:
 - lib/eager_eye/reporters/json.rb
 - lib/eager_eye/rspec.rb
 - lib/eager_eye/rspec/matchers.rb
+- lib/eager_eye/scope_parser.rb
 - lib/eager_eye/version.rb
 - sig/eager_eye.rbs
 homepage: https://github.com/hamzagedikkaya/eager_eye