eager_eye 1.2.11 → 1.2.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6f108cfabf63f2311f76b96145ea91535ef022703c3d10f73f04cbf6132110ba
-  data.tar.gz: ee909d0893f862770c3e481adf5e9041da306c86e821458dd5c069404738ff1a
+  metadata.gz: c9b4195fa833057ee04ef87d148e78de8463fdbca97e234ba9d5b08ecaab9afc
+  data.tar.gz: f5c45a109aba0f563866669c4b6a32ce0823990fe5de467d65f6baea8d405197
 SHA512:
-  metadata.gz: 387702e5516001bd86637e039c999dbb52cf30e1d20ec293afd23c70a4b591be34f0aa245bc96eb6d5bec4e1e34a3a9bc9e09295525db53550b2df6833a3a06c
-  data.tar.gz: 605eec5df28fdaf038d77c95c564e8ee3eb4768be9e900be58c96b99a0b715ad4d28b286c65a2c7844f61906146db39168761744386f73ce5f61e1e77fe7c4cb
+  metadata.gz: 8312903e2476381ad7d9fe8a5a22feb74eb97937c5d488efc96448df9b0f5973f9d612c35cccd5235900e2eb25011694c862bb1a45a5bdeb70b2a8e17be155e2
+  data.tar.gz: cc7b4336007a72b0d4131b311a2897d4dae9cf0b4ba18ceb4826f25931875f418067bd5a16e6d1fec472cbb29abd7d1f2d2f0b58cc943b871fdea4e9991fa623

data/CHANGELOG.md

@@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.2.12] - 2026-03-20
+
+### Added
+
+- **`.jbuilder` File Support** - Analyzer now scans `.jbuilder` files for N+1 queries
+  - `json.array!` blocks are recognized as iteration patterns across all detectors
+  - Existing detectors (LoopAssociation, CountInIteration, etc.) work seamlessly on jbuilder views
+- **`CountToSize` Auto-fix** - Automatically replaces `.count` with `.size` inside iteration blocks
+- **`AddIncludes` Auto-fix** - Suggests and applies `.includes(:association)` before iteration calls
+
 ## [1.2.11] - 2026-03-17
 
 ### Added

data/README.md

@@ -10,7 +10,7 @@
 
 <p align="center">
   <a href="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml"><img src="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg" alt="CI"></a>
-  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.2.11-red.svg" alt="Gem Version"></a>
+  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.2.12-red.svg" alt="Gem Version"></a>
   <a href="https://github.com/hamzagedikkaya/eager_eye"><img src="https://img.shields.io/badge/coverage-95%25-brightgreen.svg" alt="Coverage"></a>
   <a href="https://www.ruby-lang.org/"><img src="https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg" alt="Ruby"></a>
   <a href="https://opensource.org/licenses/MIT"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="License: MIT"></a>
@@ -57,7 +57,8 @@
 
 🔧 **Developer-friendly:**
 - Inline suppression (like RuboCop)
-- Auto-fix support (experimental)
+- Auto-fix support (3 fixers: PluckToSelect, CountToSize, AddIncludes)
+- `.jbuilder` file support (`json.array!` iteration detection)
 - JSON/Console output formats
 - RSpec integration
 
@@ -524,6 +525,8 @@ eager_eye --fix --force
 | Issue | Fix |
 |-------|-----|
 | `.pluck(:id)` inline | → `.select(:id)` |
+| `.count` in iteration | → `.size` |
+| Missing `includes` before loop | → `.includes(:assoc)` inserted |
 
 ### Example
 
@@ -535,6 +538,15 @@ app/services/user_service.rb:
     - Post.where(user_id: User.active.pluck(:id))
     + Post.where(user_id: User.active.select(:id))
 
+app/controllers/posts_controller.rb:
+  Line 8:
+    - user.posts.count
+    + user.posts.size
+
+  Line 5:
+    - @posts.each do |post|
+    + @posts.includes(:author).each do |post|
+
 $ eager_eye --fix
 app/services/user_service.rb:12
   - Post.where(user_id: User.active.pluck(:id))
@@ -739,7 +751,7 @@ EagerEye uses static analysis, which means:
 - **No runtime context** - Cannot know if associations are already eager loaded elsewhere
 - **Heuristic-based** - Uses naming conventions to identify associations (may have false positives)
 - **Ruby code only** - Does not analyze SQL queries or ActiveRecord internals
-- **Cross-file scope** - Cross-file analysis is limited to model-defined methods; controller-to-view or service-to-service patterns are not yet tracked
+- **Cross-file scope** - Cross-file analysis covers model-defined query methods; controller-to-view or service-to-service patterns are not yet tracked
 
 For best results, use EagerEye alongside runtime tools like Bullet for comprehensive N+1 detection.
 

data/lib/eager_eye/analyzer.rb

@@ -99,7 +99,7 @@ module EagerEye
 
     def resolve_path(path)
       return [path] if File.file?(path)
-      return Dir.glob(File.join(path, "**", "*.rb")) if File.directory?(path)
+      return Dir.glob(File.join(path, "**", "*.{rb,jbuilder}")) if File.directory?(path)
 
       Dir.glob(path)
     end

data/lib/eager_eye/detectors/callback_query.rb

@@ -27,7 +27,7 @@ module EagerEye
       ].freeze
 
       ITERATION_METHODS = %i[each map select find_all reject collect
-                             find_each find_in_batches in_batches].freeze
+                             find_each find_in_batches in_batches array!].freeze
       AR_BATCH_METHODS = %i[find_each find_in_batches in_batches].freeze
       NON_AR_NAMESPACES = %w[Sidekiq Redis ActionCable ActionMailer Kafka].freeze
       TRANSACTIONAL_CALLBACKS = %i[before_validation before_save before_create before_update before_destroy

data/lib/eager_eye/detectors/count_in_iteration.rb

@@ -5,7 +5,7 @@ module EagerEye
     class CountInIteration < Base
       COUNT_METHODS = %i[count].freeze
       ITERATION_METHODS = %i[each map select find_all reject collect each_with_index each_with_object flat_map
-                             find_each find_in_batches in_batches].freeze
+                             find_each find_in_batches in_batches array!].freeze
       ARRAY_METHOD_SUFFIXES = %w[_ids _tags _types _codes _names _values].freeze
 
       def self.detector_name

data/lib/eager_eye/detectors/custom_method_query.rb

@@ -10,7 +10,7 @@ module EagerEye
       ARRAY_COLUMN_SUFFIXES = %w[_ids _tags _types _codes _names _values _arr].freeze
       ITERATION_METHODS = %i[each map select find_all reject collect detect find_index flat_map
                              each_with_index each_with_object reduce inject
-                             find_each find_in_batches in_batches].freeze
+                             find_each find_in_batches in_batches array!].freeze
 
       def self.detector_name
         :custom_method_query

data/lib/eager_eye/detectors/delegation_n_plus_one.rb

@@ -5,7 +5,7 @@ module EagerEye
     class DelegationNPlusOne < Base
       ITERATION_METHODS = %i[
         each map collect select find_all reject filter filter_map flat_map
-        find_each find_in_batches in_batches
+        find_each find_in_batches in_batches array!
       ].freeze
       PRELOAD_METHODS = %i[includes preload eager_load].freeze
 

data/lib/eager_eye/detectors/loop_association.rb

@@ -5,7 +5,7 @@ module EagerEye
     class LoopAssociation < Base
       ITERATION_METHODS = %i[each map collect select find find_all reject filter filter_map flat_map
                              each_with_index each_with_object reduce inject
-                             find_each find_in_batches in_batches].freeze
+                             find_each find_in_batches in_batches array!].freeze
       PRELOAD_METHODS = %i[includes preload eager_load].freeze
       SINGLE_RECORD_METHODS = %i[find find_by find_by! first first! last last! take take! second third fourth fifth
                                  forty_two sole find_sole_by].freeze

data/lib/eager_eye/detectors/missing_counter_cache.rb

@@ -11,7 +11,7 @@ module EagerEye
       ].freeze
       ITERATION_METHODS = %i[each map collect select reject find_all filter filter_map flat_map
                              each_with_index each_with_object reduce inject sum
-                             find_each find_in_batches in_batches].freeze
+                             find_each find_in_batches in_batches array!].freeze
 
       def self.detector_name
         :missing_counter_cache

data/lib/eager_eye/detectors/scope_chain_n_plus_one.rb

@@ -4,7 +4,7 @@ module EagerEye
   module Detectors
     class ScopeChainNPlusOne < Base
       ITERATION_METHODS = %i[each map select find_all reject collect detect find_index flat_map
-                             find_each find_in_batches in_batches].freeze
+                             find_each find_in_batches in_batches array!].freeze
 
       def self.detector_name
         :scope_chain_n_plus_one

data/lib/eager_eye/detectors/validation_n_plus_one.rb

@@ -4,7 +4,7 @@ module EagerEye
   module Detectors
     class ValidationNPlusOne < Base
       ITERATION_METHODS = %i[each map select find_all reject collect detect find_index flat_map
-                             find_each find_in_batches in_batches].freeze
+                             find_each find_in_batches in_batches array!].freeze
       CREATE_METHODS = %i[create create!].freeze
       SAVE_METHODS = %i[save save!].freeze
 

data/lib/eager_eye/fixer_registry.rb

@@ -3,7 +3,9 @@
 module EagerEye
   class FixerRegistry
     FIXERS = {
-      pluck_to_array: Fixers::PluckToSelect
+      pluck_to_array: Fixers::PluckToSelect,
+      count_in_iteration: Fixers::CountToSize,
+      loop_association: Fixers::AddIncludes
     }.freeze
 
     def self.fixer_for(issue, source_code)

data/lib/eager_eye/fixers/add_includes.rb

@@ -0,0 +1,62 @@
+# frozen_string_literal: true
+
+module EagerEye
+  module Fixers
+    class AddIncludes < Base
+      ITERATION_METHODS_RE = %w[
+        each map collect select find_all reject filter filter_map
+        flat_map find_each find_in_batches in_batches
+      ].join("|")
+      ITERATION_PATTERN = /\.(#{ITERATION_METHODS_RE})\b/
+
+      def fixable?
+        issue.detector == :loop_association &&
+          !association_name.nil? &&
+          !iteration_line_index.nil?
+      end
+
+      def diff
+        return nil unless fixable?
+
+        idx = iteration_line_index
+        original_line = @source_lines[idx]
+        fixed_line = insert_includes(original_line)
+        return nil if original_line == fixed_line
+
+        {
+          file: issue.file_path,
+          line: idx + 1,
+          original: original_line.chomp,
+          fixed: fixed_line.chomp
+        }
+      end
+
+      protected
+
+      def fixed_content
+        raise NotImplementedError
+      end
+
+      private
+
+      def association_name
+        return nil unless issue.suggestion
+
+        match = issue.suggestion.match(/includes\(:(\w+)\)/)
+        match && match[1]
+      end
+
+      def iteration_line_index
+        start = issue.line_number - 2
+        start.downto([start - 10, 0].max) do |i|
+          return i if @source_lines[i]&.match?(ITERATION_PATTERN)
+        end
+        nil
+      end
+
+      def insert_includes(line)
+        line.sub(ITERATION_PATTERN, ".includes(:#{association_name})\\0")
+      end
+    end
+  end
+end

data/lib/eager_eye/fixers/count_to_size.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module EagerEye
+  module Fixers
+    class CountToSize < Base
+      def fixable?
+        issue.detector == :count_in_iteration &&
+          single_line_count?
+      end
+
+      protected
+
+      def fixed_content
+        line_content.sub(/\.count\b/, ".size")
+      end
+
+      private
+
+      def single_line_count?
+        line_content&.match?(/\.count\b/)
+      end
+    end
+  end
+end

data/lib/eager_eye/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EagerEye
-  VERSION = "1.2.11"
+  VERSION = "1.2.13"
 end

data/lib/eager_eye.rb

@@ -25,6 +25,8 @@ require_relative "eager_eye/comment_parser"
 require_relative "eager_eye/analyzer"
 require_relative "eager_eye/fixers/base"
 require_relative "eager_eye/fixers/pluck_to_select"
+require_relative "eager_eye/fixers/count_to_size"
+require_relative "eager_eye/fixers/add_includes"
 require_relative "eager_eye/fixer_registry"
 require_relative "eager_eye/auto_fixer"
 require_relative "eager_eye/reporters/base"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eager_eye
 version: !ruby/object:Gem::Version
-  version: 1.2.11
+  version: 1.2.13
 platform: ruby
 authors:
 - hamzagedikkaya
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-03-17 00:00:00.000000000 Z
+date: 2026-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast
@@ -80,7 +80,9 @@ files:
 - lib/eager_eye/detectors/serializer_nesting.rb
 - lib/eager_eye/detectors/validation_n_plus_one.rb
 - lib/eager_eye/fixer_registry.rb
+- lib/eager_eye/fixers/add_includes.rb
 - lib/eager_eye/fixers/base.rb
+- lib/eager_eye/fixers/count_to_size.rb
 - lib/eager_eye/fixers/pluck_to_select.rb
 - lib/eager_eye/generators/install_generator.rb
 - lib/eager_eye/issue.rb