eager_eye 1.2.10 → 1.2.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 428a53d534da23f40ea61c600afe71dab1b3463eab4a0640a78502eb35dd2ebc
-  data.tar.gz: 004edfb6e51aa7e4708ff1731d1205fa336722995f440ac438e49535be7934b8
+  metadata.gz: d6d4e056fa0d51ee629c031675f0e1b2ae2de62a1ebde0161f9d8d3d6f860f90
+  data.tar.gz: e8c8239cc5017c68b1d4b91279a212086b1741493327eea0bc0059622de83116
 SHA512:
-  metadata.gz: 3e1e172cc60a07b7f031be8236b626c4b1fc5d081ef201d952d6e366ffddeddbcc102332cd281714529a0f51b3a35df5195a567b32d596ccf9af97aff93eb28a
-  data.tar.gz: c52ac7fe9047f9cdb3cf8ba040cea3faf0f910f50e6f36561d20fc2728da1a41c0e442efbc7af4511e68744071c005fd1dd328cf5cac68bb4807e5220bfcbc51
+  metadata.gz: deb89e2a0cedaa0d0fc41874a124725c1403634a105f157e66c52b6f80c63d02bf120bd4aa43765b452951b648972ad442deea3ca970d5355c4f79c34a3b5def
+  data.tar.gz: dcdbff4d567c605f0525c56d1e205e33e9383098eb30428bd336913917367afa00ff3b3bae893ba3b961d7bcb069528b28d44dd4a9613904aff29344bdfd8865

data/CHANGELOG.md

@@ -7,6 +7,25 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.2.12] - 2026-03-20
+
+### Added
+
+- **`.jbuilder` File Support** - Analyzer now scans `.jbuilder` files for N+1 queries
+  - `json.array!` blocks are recognized as iteration patterns across all detectors
+  - Existing detectors (LoopAssociation, CountInIteration, etc.) work seamlessly on jbuilder views
+- **`CountToSize` Auto-fix** - Automatically replaces `.count` with `.size` inside iteration blocks
+- **`AddIncludes` Auto-fix** - Suggests and applies `.includes(:association)` before iteration calls
+
+## [1.2.11] - 2026-03-17
+
+### Added
+
+- **`each_with_object` / `reduce` / `inject` Support** - `LoopAssociation` and `CustomMethodQuery` detectors now recognize these iteration methods
+  - `each_with_object` and `each_with_index` blocks are detected (item is first param)
+  - `reduce` and `inject` blocks are detected with correct variable extraction (item is second param: `|memo, item|`)
+  - `extract_iteration_variable` helper added to `Base` for reuse across detectors
+
 ## [1.2.10] - 2026-03-16
 
 ### Added

data/README.md

@@ -10,7 +10,7 @@
 
 <p align="center">
   <a href="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml"><img src="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg" alt="CI"></a>
-  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.2.10-red.svg" alt="Gem Version"></a>
+  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.2.12-red.svg" alt="Gem Version"></a>
   <a href="https://github.com/hamzagedikkaya/eager_eye"><img src="https://img.shields.io/badge/coverage-95%25-brightgreen.svg" alt="Coverage"></a>
   <a href="https://www.ruby-lang.org/"><img src="https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg" alt="Ruby"></a>
   <a href="https://opensource.org/licenses/MIT"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="License: MIT"></a>

data/lib/eager_eye/analyzer.rb

@@ -99,7 +99,7 @@ module EagerEye
 
     def resolve_path(path)
       return [path] if File.file?(path)
-      return Dir.glob(File.join(path, "**", "*.rb")) if File.directory?(path)
+      return Dir.glob(File.join(path, "**", "*.{rb,jbuilder}")) if File.directory?(path)
 
       Dir.glob(path)
     end

data/lib/eager_eye/detectors/base.rb

@@ -73,12 +73,24 @@ module EagerEye
         end
       end
 
+      ACCUMULATOR_FIRST_METHODS = %i[reduce inject].freeze
+
       def extract_block_variable(block_node)
         args = block_node&.children&.[](1)
         first_arg = args&.children&.first
         first_arg&.type == :arg ? first_arg.children[0] : nil
       end
 
+      def extract_iteration_variable(block_node)
+        idx = accumulator_first?(block_node) ? 1 : 0
+        arg = block_node.children[1]&.children&.[](idx)
+        arg&.type == :arg ? arg.children[0] : nil
+      end
+
+      def accumulator_first?(block_node)
+        ACCUMULATOR_FIRST_METHODS.include?(block_node.children[0]&.children&.[](1))
+      end
+
       def receiver_chain_starts_with?(node, target_var)
         return false unless node.is_a?(Parser::AST::Node)
 

data/lib/eager_eye/detectors/callback_query.rb

@@ -27,7 +27,7 @@ module EagerEye
       ].freeze
 
       ITERATION_METHODS = %i[each map select find_all reject collect
-                             find_each find_in_batches in_batches].freeze
+                             find_each find_in_batches in_batches array!].freeze
       AR_BATCH_METHODS = %i[find_each find_in_batches in_batches].freeze
       NON_AR_NAMESPACES = %w[Sidekiq Redis ActionCable ActionMailer Kafka].freeze
       TRANSACTIONAL_CALLBACKS = %i[before_validation before_save before_create before_update before_destroy

data/lib/eager_eye/detectors/count_in_iteration.rb

@@ -5,7 +5,7 @@ module EagerEye
     class CountInIteration < Base
       COUNT_METHODS = %i[count].freeze
       ITERATION_METHODS = %i[each map select find_all reject collect each_with_index each_with_object flat_map
-                             find_each find_in_batches in_batches].freeze
+                             find_each find_in_batches in_batches array!].freeze
       ARRAY_METHOD_SUFFIXES = %w[_ids _tags _types _codes _names _values].freeze
 
       def self.detector_name

data/lib/eager_eye/detectors/custom_method_query.rb

@@ -9,7 +9,8 @@ module EagerEye
       SAFE_TRANSFORM_METHODS = %i[keys values split [] params sort pluck ids to_s to_a to_i chars bytes].freeze
       ARRAY_COLUMN_SUFFIXES = %w[_ids _tags _types _codes _names _values _arr].freeze
       ITERATION_METHODS = %i[each map select find_all reject collect detect find_index flat_map
-                             find_each find_in_batches in_batches].freeze
+                             each_with_index each_with_object reduce inject
+                             find_each find_in_batches in_batches array!].freeze
 
       def self.detector_name
         :custom_method_query
@@ -38,7 +39,7 @@ module EagerEye
         definitions[node.children[0]] = node.children[1] if node.type == :lvasgn
 
         if iteration_block?(node)
-          block_var = extract_block_variable(node)
+          block_var = extract_iteration_variable(node)
           block_body = node.children[2]
           yield(block_body, block_var, node.children[0], definitions) if block_var && block_body
         end

data/lib/eager_eye/detectors/delegation_n_plus_one.rb

@@ -5,7 +5,7 @@ module EagerEye
     class DelegationNPlusOne < Base
       ITERATION_METHODS = %i[
         each map collect select find_all reject filter filter_map flat_map
-        find_each find_in_batches in_batches
+        find_each find_in_batches in_batches array!
       ].freeze
       PRELOAD_METHODS = %i[includes preload eager_load].freeze
 

data/lib/eager_eye/detectors/loop_association.rb

@@ -4,7 +4,8 @@ module EagerEye
   module Detectors
     class LoopAssociation < Base
       ITERATION_METHODS = %i[each map collect select find find_all reject filter filter_map flat_map
-                             find_each find_in_batches in_batches].freeze
+                             each_with_index each_with_object reduce inject
+                             find_each find_in_batches in_batches array!].freeze
       PRELOAD_METHODS = %i[includes preload eager_load].freeze
       SINGLE_RECORD_METHODS = %i[find find_by find_by! first first! last last! take take! second third fourth fifth
                                  forty_two sole find_sole_by].freeze
@@ -42,7 +43,7 @@ module EagerEye
         traverse_ast(ast) do |node|
           next unless iteration_block?(node)
 
-          block_var = extract_block_variable(node)
+          block_var = extract_iteration_variable(node)
           next unless block_var
 
           block_body = node.children[2]

data/lib/eager_eye/detectors/missing_counter_cache.rb

@@ -11,7 +11,7 @@ module EagerEye
       ].freeze
       ITERATION_METHODS = %i[each map collect select reject find_all filter filter_map flat_map
                              each_with_index each_with_object reduce inject sum
-                             find_each find_in_batches in_batches].freeze
+                             find_each find_in_batches in_batches array!].freeze
 
       def self.detector_name
         :missing_counter_cache

data/lib/eager_eye/detectors/scope_chain_n_plus_one.rb

@@ -4,7 +4,7 @@ module EagerEye
   module Detectors
     class ScopeChainNPlusOne < Base
       ITERATION_METHODS = %i[each map select find_all reject collect detect find_index flat_map
-                             find_each find_in_batches in_batches].freeze
+                             find_each find_in_batches in_batches array!].freeze
 
       def self.detector_name
         :scope_chain_n_plus_one

data/lib/eager_eye/detectors/validation_n_plus_one.rb

@@ -4,7 +4,7 @@ module EagerEye
   module Detectors
     class ValidationNPlusOne < Base
       ITERATION_METHODS = %i[each map select find_all reject collect detect find_index flat_map
-                             find_each find_in_batches in_batches].freeze
+                             find_each find_in_batches in_batches array!].freeze
       CREATE_METHODS = %i[create create!].freeze
       SAVE_METHODS = %i[save save!].freeze
 

data/lib/eager_eye/fixer_registry.rb

@@ -3,7 +3,9 @@
 module EagerEye
   class FixerRegistry
     FIXERS = {
-      pluck_to_array: Fixers::PluckToSelect
+      pluck_to_array: Fixers::PluckToSelect,
+      count_in_iteration: Fixers::CountToSize,
+      loop_association: Fixers::AddIncludes
     }.freeze
 
     def self.fixer_for(issue, source_code)

data/lib/eager_eye/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EagerEye
-  VERSION = "1.2.10"
+  VERSION = "1.2.12"
 end

data/lib/eager_eye.rb

@@ -25,6 +25,8 @@ require_relative "eager_eye/comment_parser"
 require_relative "eager_eye/analyzer"
 require_relative "eager_eye/fixers/base"
 require_relative "eager_eye/fixers/pluck_to_select"
+require_relative "eager_eye/fixers/count_to_size"
+require_relative "eager_eye/fixers/add_includes"
 require_relative "eager_eye/fixer_registry"
 require_relative "eager_eye/auto_fixer"
 require_relative "eager_eye/reporters/base"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eager_eye
 version: !ruby/object:Gem::Version
-  version: 1.2.10
+  version: 1.2.12
 platform: ruby
 authors:
 - hamzagedikkaya
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-03-16 00:00:00.000000000 Z
+date: 2026-03-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast