eager_eye 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2e098f00c3f4cffd7e4450d5fd8e2adaa01d9e1fca4d7180d996e6b9c646a448
-  data.tar.gz: 4a2abc06d7986eaa0629e076ffc7950dfe0a7af81f051bee9faee608ee5f0779
+  metadata.gz: a432b16aece37497880140ff64a88cd3dabe6ae603846a513d21f71a8b11b5a1
+  data.tar.gz: 330aac1ef792a5ca24597dcd4128329e20f05959ea45437e244788b94f12026d
 SHA512:
-  metadata.gz: b7683c5e0209f89058a99a0e4fd438f2253c231df17646baf7cfe59a18c2b617ebe9664ef10cc7e0243ae0cd863056940ba792ba82c671c908b757f5774ac04f
-  data.tar.gz: 489810690ff2bef7ccb7c36c55367ffacbedbe9191393d0b27eeb7133457d896096f54d593133944b6f265f97d4aadec96464811975bcaea7ab0f3108d2ce3b5
+  metadata.gz: 192aa6bb71494f09091ac64a44de11526db09ec389cf41db80229457d59d52f5e81c9b9ae05cc6892ec11c646078a12520c657940a986c47f6519af6b956526f
+  data.tar.gz: 3e18421c967675ea0c10ab19ff7f0426d2a2d8e2fcf969a20b6bc0571f0f32a40c8f515b16c464df57c67b447fe0e9c3b3087b22cee37bbda3bee89b1dd3d418

data/CHANGELOG.md

@@ -7,6 +7,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.2.2] - 2026-01-31
+
+### Fixed
+
+- **CustomMethodQuery False Positive** - Skip PostgreSQL array column methods
+  - Methods ending with `_ids`, `_tags`, `_types`, `_codes`, `_names`, `_values` now recognized as array attributes
+  - `sector_subcategory_ids.first` no longer flagged (Ruby Array#first, not AR query)
+
+- **LoopAssociation False Positive** - Skip common non-association attribute methods
+  - Added `origin`, `priority`, `level`, `kind`, `label`, `code`, `reason`, `amount`, `price`, `quantity`, `url`, `path`, `email`, `phone`, `address`, `notes`, `memo`, `data`, `metadata`, `position`, `rank`, `score`, `rating`, `enabled`, `disabled`, `active`, `published`, `draft`, `archived`, `locked`, `visible`, `hidden` to excluded methods
+  - Note: `category` and `tag` remain detectable as they're common association names - use inline suppression if they're string attributes in your codebase
+
+- **PluckToArray False Positive** - Skip params-originated values
+  - `params[:ids].split(',').map(&:to_i)` no longer flagged
+  - `params` method now recognized as non-ActiveRecord source
+
 ## [1.2.1] - 2026-01-31
 
 ### Fixed

data/README.md

@@ -10,7 +10,7 @@
 
 <p align="center">
   <a href="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml"><img src="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg" alt="CI"></a>
-  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.2.1-red.svg" alt="Gem Version"></a>
+  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.2.2-red.svg" alt="Gem Version"></a>
   <a href="https://github.com/hamzagedikkaya/eager_eye"><img src="https://img.shields.io/badge/coverage-95%25-brightgreen.svg" alt="Coverage"></a>
   <a href="https://www.ruby-lang.org/"><img src="https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg" alt="Ruby"></a>
   <a href="https://opensource.org/licenses/MIT"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="License: MIT"></a>

data/lib/eager_eye/detectors/concerns/non_ar_source_detector.rb

@@ -6,7 +6,7 @@ module EagerEye
       module NonArSourceDetector
         NON_AR_RECEIVERS = %w[Sidekiq Redis Resque DelayedJob Queue Job Hash Array Set].freeze
         NON_DB_SOURCE_METHODS = %i[smembers sinter sunion sdiff zrange zrangebyscore lrange hkeys hvals hgetall
-                                   keys values entries args].freeze
+                                   keys values entries args params].freeze
 
         private
 

data/lib/eager_eye/detectors/custom_method_query.rb

@@ -7,6 +7,7 @@ module EagerEye
                          maximum].freeze
       SAFE_QUERY_METHODS = %i[first last take count sum find size length ids].freeze
       SAFE_TRANSFORM_METHODS = %i[keys values split [] params sort pluck ids to_s to_a to_i chars bytes].freeze
+      ARRAY_COLUMN_SUFFIXES = %w[_ids _tags _types _codes _names _values].freeze
       ITERATION_METHODS = %i[each map select find_all reject collect detect find_index flat_map].freeze
 
       def self.detector_name
@@ -124,7 +125,13 @@ module EagerEye
       def receiver_ends_with_safe_transform_method?(node)
         return false unless node.is_a?(Parser::AST::Node) && node.type == :send
 
-        SAFE_TRANSFORM_METHODS.include?(node.children[1])
+        method_name = node.children[1]
+        SAFE_TRANSFORM_METHODS.include?(method_name) || array_column_method?(method_name)
+      end
+
+      def array_column_method?(method_name)
+        method_str = method_name.to_s
+        ARRAY_COLUMN_SUFFIXES.any? { |suffix| method_str.end_with?(suffix) }
       end
 
       def add_issue(node)

data/lib/eager_eye/detectors/loop_association.rb

@@ -19,7 +19,10 @@ module EagerEye
         id to_s to_h to_a to_json to_xml inspect class object_id nil? blank? present? empty?
         any? none? size count length save save! update update! destroy destroy! delete delete!
         valid? invalid? errors new? persisted? changed? frozen? name title body content text
-        description value key type status state created_at updated_at deleted_at
+        description value key type status state created_at updated_at deleted_at origin
+        priority level kind label code reason amount price quantity url path email phone
+        address notes memo data metadata position rank score rating enabled disabled active
+        published draft archived locked visible hidden
       ].freeze
 
       def self.detector_name

data/lib/eager_eye/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EagerEye
-  VERSION = "1.2.1"
+  VERSION = "1.2.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eager_eye
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - hamzagedikkaya
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-01-30 00:00:00.000000000 Z
+date: 2026-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast