eager_eye 1.1.9 → 1.1.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e5affda3dbf4ab9e59ce8c0a5fcbadd3b6b11bf60eba882031226050589a2a04
-  data.tar.gz: bfa17f748016257d75c7135908656c9bf920b3dc0ea6d8fbbd41352b8a3c96f4
+  metadata.gz: 200f52cfc9b2d47ee338155372eded81c115c5c05578e6ff89e689f148fabac5
+  data.tar.gz: 3b236fff4d78662c30140b3e429d222defed03100b2c8d6928711886bd7c525a
 SHA512:
-  metadata.gz: e2d0edc257c6384c294a6f3a40037e2841c9c4a7d0f07cce69cf144ee01cf46353ec58d8db13da9549604206460d43efa4da91fb0966961a827e59cb3fe2518b
-  data.tar.gz: 665ba27b30fda25e287ecc7ac34d573d8f523ed1eaab9f52fb9f628ce74b0a562e57a3a92bd6ef70226b9ccadb825577ae7d21e7f674fe080dac01f1df463dbe
+  metadata.gz: 8a09fbc10c6f944c9c42f31723dc0bf248eff29691a35fbc31f6a4e21836224225863eb625ac33e818a30b2e12b119831e02ec2f0d0689476e014a9ab0d5331e
+  data.tar.gz: 36dff575a0277abc141848a1866a057f31fcefe6fdecd861a32fcad7120167a56120f0ed8a507c9ff9fdcb4ac54be72be64a475ca0b5105574ace91e26618f8b

data/CHANGELOG.md

@@ -7,6 +7,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.1.11] - 2026-01-13
+
+### Fixed
+
+- **CustomMethodQuery False Positive** - Skip `count`, `sum`, `find` on safe collections
+  - `id.to_s.count` no longer flagged (scalar count)
+  - `array.count` no longer flagged inside iteration
+  - Expanded safe transform methods (`to_s`, `to_i`, `to_a`, `chars`, `bytes`)
+
+## [1.1.10] - 2026-01-12
+
+### Fixed
+
+- **CustomMethodQuery False Positive** - Skip `pluck` and `ids` results
+  - `Model.pluck(:id).each { |id| ... }` no longer flagged
+  - Supports tracking local variable assignments for pluck results
+
 ## [1.1.9] - 2026-01-11
 
 ### Fixed

data/README.md

@@ -10,7 +10,7 @@
 
 <p align="center">
   <a href="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml"><img src="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg" alt="CI"></a>
-  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.9-red.svg" alt="Gem Version"></a>
+  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.11-red.svg" alt="Gem Version"></a>
   <a href="https://github.com/hamzagedikkaya/eager_eye"><img src="https://img.shields.io/badge/coverage-95%25-brightgreen.svg" alt="Coverage"></a>
   <a href="https://www.ruby-lang.org/"><img src="https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg" alt="Ruby"></a>
   <a href="https://opensource.org/licenses/MIT"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="License: MIT"></a>

data/lib/eager_eye/detectors/custom_method_query.rb

@@ -5,10 +5,8 @@ module EagerEye
     class CustomMethodQuery < Base
       QUERY_METHODS = %i[where find_by find_by! exists? find first last take pluck ids count sum average minimum
                          maximum].freeze
-      ARRAY_METHODS = %i[first last take].freeze
-      HASH_ARRAY_METHODS = %i[keys values].freeze
-      STRING_ARRAY_METHODS = %i[split].freeze
-      BRACKET_ARRAY_METHODS = %i[[]].freeze
+      SAFE_QUERY_METHODS = %i[first last take count sum find size length].freeze
+      SAFE_TRANSFORM_METHODS = %i[keys values split [] params sort pluck ids to_s to_a to_i chars bytes].freeze
       ITERATION_METHODS = %i[each map select find_all reject collect detect find_index flat_map].freeze
 
       def self.detector_name
@@ -21,8 +19,8 @@ module EagerEye
         @issues = []
         @file_path = file_path
 
-        find_iteration_blocks(ast) do |block_body, block_var, collection|
-          is_array_collection = collection_is_array?(collection)
+        find_iteration_blocks(ast) do |block_body, block_var, collection, definitions|
+          is_array_collection = collection_is_array?(collection, definitions)
           check_block_for_query_methods(block_body, block_var, is_array_collection)
         end
 
@@ -31,15 +29,17 @@ module EagerEye
 
       private
 
-      def find_iteration_blocks(node, &block)
+      def find_iteration_blocks(node, definitions = {}, &block)
         return unless node.is_a?(Parser::AST::Node)
 
+        definitions[node.children[0]] = node.children[1] if node.type == :lvasgn
+
         if iteration_block?(node)
           block_var = extract_block_variable(node)
           block_body = node.children[2]
-          yield(block_body, block_var, node.children[0]) if block_var && block_body
+          yield(block_body, block_var, node.children[0], definitions) if block_var && block_body
         end
-        node.children.each { |child| find_iteration_blocks(child, &block) }
+        node.children.each { |child| find_iteration_blocks(child, definitions, &block) }
       end
 
       def iteration_block?(node)
@@ -65,9 +65,9 @@ module EagerEye
       end
 
       def skip_array_method?(node, block_var, is_array_collection)
-        return true if receiver_ends_with_hash_array_method?(node.children[0])
+        return true if receiver_ends_with_safe_transform_method?(node.children[0])
 
-        ARRAY_METHODS.include?(node.children[1]) &&
+        SAFE_QUERY_METHODS.include?(node.children[1]) &&
           is_array_collection && receiver_is_only_block_var?(node.children[0], block_var)
       end
 
@@ -93,28 +93,34 @@ module EagerEye
         first_arg&.type == :arg ? first_arg.children[0] : nil
       end
 
-      def collection_is_array?(node)
+      def collection_is_array?(node, definitions = {})
         return false unless node.is_a?(Parser::AST::Node)
-
         return true if %i[array hash].include?(node.type)
+        return check_lvar_collection?(node, definitions) if node.type == :lvar
+        return check_send_collection?(node, definitions) if node.type == :send
 
-        if node.type == :send
-          method_name = node.children[1]
-          return true if %i[map select collect flat_map to_a uniq compact keys values split []
-                            params sort].include?(method_name)
+        false
+      end
 
-          return collection_is_array?(node.children[0])
-        end
+      def check_lvar_collection?(node, definitions)
+        return false unless definitions
 
-        false
+        definition = definitions[node.children[0]]
+        definition ? collection_is_array?(definition, definitions) : false
+      end
+
+      def check_send_collection?(node, definitions)
+        method_name = node.children[1]
+        return true if %i[map select collect flat_map uniq compact].include?(method_name)
+        return true if SAFE_TRANSFORM_METHODS.include?(method_name)
+
+        collection_is_array?(node.children[0], definitions)
       end
 
-      def receiver_ends_with_hash_array_method?(node)
+      def receiver_ends_with_safe_transform_method?(node)
         return false unless node.is_a?(Parser::AST::Node) && node.type == :send
 
-        HASH_ARRAY_METHODS.include?(node.children[1]) ||
-          STRING_ARRAY_METHODS.include?(node.children[1]) ||
-          BRACKET_ARRAY_METHODS.include?(node.children[1])
+        SAFE_TRANSFORM_METHODS.include?(node.children[1])
       end
 
       def add_issue(node)

data/lib/eager_eye/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EagerEye
-  VERSION = "1.1.9"
+  VERSION = "1.1.11"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eager_eye
 version: !ruby/object:Gem::Version
-  version: 1.1.9
+  version: 1.1.11
 platform: ruby
 authors:
 - hamzagedikkaya
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-01-11 00:00:00.000000000 Z
+date: 2026-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast