eager_eye 1.1.8 → 1.1.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b43ce92b9c6437cbf79890d4bac363d23a81c1297429e70bd7d47ffda5c179ef
-  data.tar.gz: 913b85723206ed1c0b9d193bbad46394ff8bbf4cce6cbacf9b9e33ef6e7f7be3
+  metadata.gz: 28c53330ec88bd4b8125e357ad3d11bc3155e6425d7feef88ccf4fd8bec93123
+  data.tar.gz: c671ff6c33dd1fef2a0be359452a195ecc5a72b27d534ca09d92c17f1928c89f
 SHA512:
-  metadata.gz: d065cbff74e8d0499fc9cd2218b1e0c1ed2629200cb8447b0c9fd53bfc4814c914b942514872cd8b76181f41c773fb50737f108dc954fc58d1ad64cec6469991
-  data.tar.gz: 21b23f430fecc8a4137e18e55a0c9d0bcfb40ebb7c0c36adaff7c92f86eedec895ec37dd1073b0124199fe43833aed8d04fdc55107e3a1532a726f5c060f6b28
+  metadata.gz: 75dd57d12d3b869f4ae9246130de9ae497ec6240f0f81adeaae1d7c2aaf48eed0f5d2626a62ba2f72a0b0adf8d207129322977c60639986881c1cd9fec91ecec
+  data.tar.gz: 265a28c9086ae7a215f31f7295b9d48be4882b926718a70029678b7c46d80ef171c308060507670477385cb52fd8aba66d7fac0bc05c1da13cd246e3eab56ed9

data/CHANGELOG.md

@@ -7,6 +7,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.1.10] - 2026-01-12
+
+### Fixed
+
+- **CustomMethodQuery False Positive** - Skip `pluck` and `ids` results
+  - `Model.pluck(:id).each { |id| ... }` no longer flagged
+  - Supports tracking local variable assignments for pluck results
+
+## [1.1.9] - 2026-01-11
+
+### Fixed
+
+- **CustomMethodQuery False Positive** - Skip `ActionController::Parameters` and Hash tuple access
+  - `params.each { |p| p.last }` no longer flagged (tuple access)
+  - `hash.each { |k, v| [k, v].last }` no longer flagged
+
 ## [1.1.8] - 2026-01-10
 
 ### Fixed

data/README.md

@@ -10,7 +10,7 @@
 
 <p align="center">
   <a href="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml"><img src="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg" alt="CI"></a>
-  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.8-red.svg" alt="Gem Version"></a>
+  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.10-red.svg" alt="Gem Version"></a>
   <a href="https://github.com/hamzagedikkaya/eager_eye"><img src="https://img.shields.io/badge/coverage-95%25-brightgreen.svg" alt="Coverage"></a>
   <a href="https://www.ruby-lang.org/"><img src="https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg" alt="Ruby"></a>
   <a href="https://opensource.org/licenses/MIT"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="License: MIT"></a>

data/lib/eager_eye/detectors/custom_method_query.rb

@@ -21,8 +21,8 @@ module EagerEye
         @issues = []
         @file_path = file_path
 
-        find_iteration_blocks(ast) do |block_body, block_var, collection|
-          is_array_collection = collection_is_array?(collection)
+        find_iteration_blocks(ast) do |block_body, block_var, collection, definitions|
+          is_array_collection = collection_is_array?(collection, definitions)
           check_block_for_query_methods(block_body, block_var, is_array_collection)
         end
 
@@ -31,15 +31,17 @@ module EagerEye
 
       private
 
-      def find_iteration_blocks(node, &block)
+      def find_iteration_blocks(node, definitions = {}, &block)
         return unless node.is_a?(Parser::AST::Node)
 
+        definitions[node.children[0]] = node.children[1] if node.type == :lvasgn
+
         if iteration_block?(node)
           block_var = extract_block_variable(node)
           block_body = node.children[2]
-          yield(block_body, block_var, node.children[0]) if block_var && block_body
+          yield(block_body, block_var, node.children[0], definitions) if block_var && block_body
         end
-        node.children.each { |child| find_iteration_blocks(child, &block) }
+        node.children.each { |child| find_iteration_blocks(child, definitions, &block) }
       end
 
       def iteration_block?(node)
@@ -93,15 +95,28 @@ module EagerEye
         first_arg&.type == :arg ? first_arg.children[0] : nil
       end
 
-      def collection_is_array?(node)
+      def collection_is_array?(node, definitions = {})
         return false unless node.is_a?(Parser::AST::Node)
+        return true if %i[array hash].include?(node.type)
+        return check_lvar_collection?(node, definitions) if node.type == :lvar
+        return check_send_collection?(node, definitions) if node.type == :send
 
-        case node.type
-        when :array then true
-        when :send then %i[map select collect flat_map to_a uniq compact keys values split
-                           []].include?(node.children[1])
-        else false
-        end
+        false
+      end
+
+      def check_lvar_collection?(node, definitions)
+        return false unless definitions
+
+        definition = definitions[node.children[0]]
+        definition ? collection_is_array?(definition, definitions) : false
+      end
+
+      def check_send_collection?(node, definitions)
+        method_name = node.children[1]
+        return true if %i[map select collect flat_map to_a uniq compact keys values split []
+                          params sort pluck ids].include?(method_name)
+
+        collection_is_array?(node.children[0], definitions)
       end
 
       def receiver_ends_with_hash_array_method?(node)

data/lib/eager_eye/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EagerEye
-  VERSION = "1.1.8"
+  VERSION = "1.1.10"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eager_eye
 version: !ruby/object:Gem::Version
-  version: 1.1.8
+  version: 1.1.10
 platform: ruby
 authors:
 - hamzagedikkaya
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-01-10 00:00:00.000000000 Z
+date: 2026-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast