eager_eye 1.1.7 → 1.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 60b775a876ad65129457036e90c076a5e14b789f9049ede284c86bacbebba9b8
-  data.tar.gz: fa8080dd194f991025218fa0188d4aef6eb37e3c2210f6f7c1a5710894070aa6
+  metadata.gz: e5affda3dbf4ab9e59ce8c0a5fcbadd3b6b11bf60eba882031226050589a2a04
+  data.tar.gz: bfa17f748016257d75c7135908656c9bf920b3dc0ea6d8fbbd41352b8a3c96f4
 SHA512:
-  metadata.gz: 78d62d608b7326a8fae187fd1cc6ff66bd9d5a2d3896a2ae3457017ab315002a56965fc6a6fe57dec48036e7c9c37eb38795263f6a6ff34dd0f119d0bbe9d175
-  data.tar.gz: d1a22234a0fc7265f42b27e91301730dbba9b1845609f5150a93fbc2c35a2ba22071babb35e46e67db5669693641791dd2e0d055881a8323a4e54fdd4bd0b667
+  metadata.gz: e2d0edc257c6384c294a6f3a40037e2841c9c4a7d0f07cce69cf144ee01cf46353ec58d8db13da9549604206460d43efa4da91fb0966961a827e59cb3fe2518b
+  data.tar.gz: 665ba27b30fda25e287ecc7ac34d573d8f523ed1eaab9f52fb9f628ce74b0a562e57a3a92bd6ef70226b9ccadb825577ae7d21e7f674fe080dac01f1df463dbe

data/CHANGELOG.md

@@ -7,6 +7,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.1.9] - 2026-01-11
+
+### Fixed
+
+- **CustomMethodQuery False Positive** - Skip `ActionController::Parameters` and Hash tuple access
+  - `params.each { |p| p.last }` no longer flagged (tuple access)
+  - `hash.each { |k, v| [k, v].last }` no longer flagged
+
+## [1.1.8] - 2026-01-10
+
+### Fixed
+
+- **CustomMethodQuery False Positive** - Skip `[]` (bracket access) chains
+  - `data["items"].first` no longer flagged as ActiveRecord query
+  - Recognizes bracket access returns Array/Hash for subsequent enumerable calls
+
 ## [1.1.7] - 2026-01-09
 
 ### Fixed

data/README.md

@@ -10,7 +10,7 @@
 
 <p align="center">
   <a href="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml"><img src="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg" alt="CI"></a>
-  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.7-red.svg" alt="Gem Version"></a>
+  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.9-red.svg" alt="Gem Version"></a>
   <a href="https://github.com/hamzagedikkaya/eager_eye"><img src="https://img.shields.io/badge/coverage-95%25-brightgreen.svg" alt="Coverage"></a>
   <a href="https://www.ruby-lang.org/"><img src="https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg" alt="Ruby"></a>
   <a href="https://opensource.org/licenses/MIT"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="License: MIT"></a>

data/lib/eager_eye/detectors/custom_method_query.rb

@@ -8,6 +8,7 @@ module EagerEye
       ARRAY_METHODS = %i[first last take].freeze
       HASH_ARRAY_METHODS = %i[keys values].freeze
       STRING_ARRAY_METHODS = %i[split].freeze
+      BRACKET_ARRAY_METHODS = %i[[]].freeze
       ITERATION_METHODS = %i[each map select find_all reject collect detect find_index flat_map].freeze
 
       def self.detector_name
@@ -64,10 +65,10 @@ module EagerEye
       end
 
       def skip_array_method?(node, block_var, is_array_collection)
-        return false unless ARRAY_METHODS.include?(node.children[1])
+        return true if receiver_ends_with_hash_array_method?(node.children[0])
 
-        receiver_ends_with_hash_array_method?(node.children[0]) ||
-          (is_array_collection && receiver_is_only_block_var?(node.children[0], block_var))
+        ARRAY_METHODS.include?(node.children[1]) &&
+          is_array_collection && receiver_is_only_block_var?(node.children[0], block_var)
       end
 
       def receiver_is_only_block_var?(node, block_var)
@@ -95,17 +96,25 @@ module EagerEye
       def collection_is_array?(node)
         return false unless node.is_a?(Parser::AST::Node)
 
-        case node.type
-        when :array then true
-        when :send then %i[map select collect flat_map to_a uniq compact keys values split].include?(node.children[1])
-        else false
+        return true if %i[array hash].include?(node.type)
+
+        if node.type == :send
+          method_name = node.children[1]
+          return true if %i[map select collect flat_map to_a uniq compact keys values split []
+                            params sort].include?(method_name)
+
+          return collection_is_array?(node.children[0])
         end
+
+        false
       end
 
       def receiver_ends_with_hash_array_method?(node)
         return false unless node.is_a?(Parser::AST::Node) && node.type == :send
 
-        HASH_ARRAY_METHODS.include?(node.children[1]) || STRING_ARRAY_METHODS.include?(node.children[1])
+        HASH_ARRAY_METHODS.include?(node.children[1]) ||
+          STRING_ARRAY_METHODS.include?(node.children[1]) ||
+          BRACKET_ARRAY_METHODS.include?(node.children[1])
       end
 
       def add_issue(node)

data/lib/eager_eye/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EagerEye
-  VERSION = "1.1.7"
+  VERSION = "1.1.9"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eager_eye
 version: !ruby/object:Gem::Version
-  version: 1.1.7
+  version: 1.1.9
 platform: ruby
 authors:
 - hamzagedikkaya
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-01-09 00:00:00.000000000 Z
+date: 2026-01-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast