eager_eye 1.1.5 → 1.1.7
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/CHANGELOG.md +15 -0
- data/README.md +1 -1
- data/lib/eager_eye/detectors/custom_method_query.rb +17 -3
- data/lib/eager_eye/version.rb +1 -1
- metadata +2 -2
checksums.yaml
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
SHA256:
|
|
3
|
-
metadata.gz:
|
|
4
|
-
data.tar.gz:
|
|
3
|
+
metadata.gz: 60b775a876ad65129457036e90c076a5e14b789f9049ede284c86bacbebba9b8
|
|
4
|
+
data.tar.gz: fa8080dd194f991025218fa0188d4aef6eb37e3c2210f6f7c1a5710894070aa6
|
|
5
5
|
SHA512:
|
|
6
|
-
metadata.gz:
|
|
7
|
-
data.tar.gz:
|
|
6
|
+
metadata.gz: 78d62d608b7326a8fae187fd1cc6ff66bd9d5a2d3896a2ae3457017ab315002a56965fc6a6fe57dec48036e7c9c37eb38795263f6a6ff34dd0f119d0bbe9d175
|
|
7
|
+
data.tar.gz: d1a22234a0fc7265f42b27e91301730dbba9b1845609f5150a93fbc2c35a2ba22071babb35e46e67db5669693641791dd2e0d055881a8323a4e54fdd4bd0b667
|
data/CHANGELOG.md
CHANGED
|
@@ -7,6 +7,21 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
|
|
7
7
|
|
|
8
8
|
## [Unreleased]
|
|
9
9
|
|
|
10
|
+
## [1.1.7] - 2026-01-09
|
|
11
|
+
|
|
12
|
+
### Fixed
|
|
13
|
+
|
|
14
|
+
- **CustomMethodQuery False Positive** - Skip `String#split` chains
|
|
15
|
+
- `url.split("?").first` no longer flagged as ActiveRecord query
|
|
16
|
+
|
|
17
|
+
## [1.1.6] - 2026-01-09
|
|
18
|
+
|
|
19
|
+
### Fixed
|
|
20
|
+
|
|
21
|
+
- **CustomMethodQuery False Positive** - Skip `Hash#keys` and `Hash#values` chains
|
|
22
|
+
- `hash.keys.first`, `hash.values.last` no longer flagged as ActiveRecord queries
|
|
23
|
+
- Recognizes `keys` and `values` as Array-returning methods
|
|
24
|
+
|
|
10
25
|
## [1.1.5] - 2026-01-06
|
|
11
26
|
|
|
12
27
|
### Changed
|
data/README.md
CHANGED
|
@@ -10,7 +10,7 @@
|
|
|
10
10
|
|
|
11
11
|
<p align="center">
|
|
12
12
|
<a href="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml"><img src="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg" alt="CI"></a>
|
|
13
|
-
<a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.
|
|
13
|
+
<a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.7-red.svg" alt="Gem Version"></a>
|
|
14
14
|
<a href="https://github.com/hamzagedikkaya/eager_eye"><img src="https://img.shields.io/badge/coverage-95%25-brightgreen.svg" alt="Coverage"></a>
|
|
15
15
|
<a href="https://www.ruby-lang.org/"><img src="https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg" alt="Ruby"></a>
|
|
16
16
|
<a href="https://opensource.org/licenses/MIT"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="License: MIT"></a>
|
|
@@ -6,6 +6,8 @@ module EagerEye
|
|
|
6
6
|
QUERY_METHODS = %i[where find_by find_by! exists? find first last take pluck ids count sum average minimum
|
|
7
7
|
maximum].freeze
|
|
8
8
|
ARRAY_METHODS = %i[first last take].freeze
|
|
9
|
+
HASH_ARRAY_METHODS = %i[keys values].freeze
|
|
10
|
+
STRING_ARRAY_METHODS = %i[split].freeze
|
|
9
11
|
ITERATION_METHODS = %i[each map select find_all reject collect detect find_index flat_map].freeze
|
|
10
12
|
|
|
11
13
|
def self.detector_name
|
|
@@ -56,12 +58,18 @@ module EagerEye
|
|
|
56
58
|
|
|
57
59
|
method_name = node.children[1]
|
|
58
60
|
return false unless QUERY_METHODS.include?(method_name)
|
|
59
|
-
return false if
|
|
60
|
-
receiver_is_only_block_var?(node.children[0], block_var)
|
|
61
|
+
return false if skip_array_method?(node, block_var, is_array_collection)
|
|
61
62
|
|
|
62
63
|
receiver_chain_starts_with?(node.children[0], block_var)
|
|
63
64
|
end
|
|
64
65
|
|
|
66
|
+
def skip_array_method?(node, block_var, is_array_collection)
|
|
67
|
+
return false unless ARRAY_METHODS.include?(node.children[1])
|
|
68
|
+
|
|
69
|
+
receiver_ends_with_hash_array_method?(node.children[0]) ||
|
|
70
|
+
(is_array_collection && receiver_is_only_block_var?(node.children[0], block_var))
|
|
71
|
+
end
|
|
72
|
+
|
|
65
73
|
def receiver_is_only_block_var?(node, block_var)
|
|
66
74
|
node.is_a?(Parser::AST::Node) && node.type == :lvar && node.children[0] == block_var
|
|
67
75
|
end
|
|
@@ -89,11 +97,17 @@ module EagerEye
|
|
|
89
97
|
|
|
90
98
|
case node.type
|
|
91
99
|
when :array then true
|
|
92
|
-
when :send then %i[map select collect flat_map to_a uniq compact].include?(node.children[1])
|
|
100
|
+
when :send then %i[map select collect flat_map to_a uniq compact keys values split].include?(node.children[1])
|
|
93
101
|
else false
|
|
94
102
|
end
|
|
95
103
|
end
|
|
96
104
|
|
|
105
|
+
def receiver_ends_with_hash_array_method?(node)
|
|
106
|
+
return false unless node.is_a?(Parser::AST::Node) && node.type == :send
|
|
107
|
+
|
|
108
|
+
HASH_ARRAY_METHODS.include?(node.children[1]) || STRING_ARRAY_METHODS.include?(node.children[1])
|
|
109
|
+
end
|
|
110
|
+
|
|
97
111
|
def add_issue(node)
|
|
98
112
|
method_name = node.children[1]
|
|
99
113
|
association_chain = reconstruct_chain(node.children[0])
|
data/lib/eager_eye/version.rb
CHANGED
metadata
CHANGED
|
@@ -1,14 +1,14 @@
|
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
|
2
2
|
name: eager_eye
|
|
3
3
|
version: !ruby/object:Gem::Version
|
|
4
|
-
version: 1.1.
|
|
4
|
+
version: 1.1.7
|
|
5
5
|
platform: ruby
|
|
6
6
|
authors:
|
|
7
7
|
- hamzagedikkaya
|
|
8
8
|
autorequire:
|
|
9
9
|
bindir: exe
|
|
10
10
|
cert_chain: []
|
|
11
|
-
date: 2026-01-
|
|
11
|
+
date: 2026-01-09 00:00:00.000000000 Z
|
|
12
12
|
dependencies:
|
|
13
13
|
- !ruby/object:Gem::Dependency
|
|
14
14
|
name: ast
|