eager_eye 1.1.4 → 1.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6ae532397830e96202bc3a3d10dc231570f4912d5df67085783123fbb2ebba5e
-  data.tar.gz: ddc5a6971c2c65c73260c59ff8b6acfd52711a2e1ce1d43ea8c44895be729016
+  metadata.gz: 8770de7a3e968ddce30789d077c4ffd949b04438a494d4053a35af891343cb2b
+  data.tar.gz: 1e3b4e5b797527635983a43c888691eca6ebab70d1985af4bcca0f3f0f1f52f2
 SHA512:
-  metadata.gz: fa15940b451ebd100e908b4f9931c8f40708f9566451a0f1edb8a65c70fee15f832bd30d91d49f54c9b2f0ebe63cbdf2f5dbabfb5f7894db23d1a2f35c1e95c5
-  data.tar.gz: 80ea91965317596061db8a38cce960ac4f573a4c887de7a2fe88b7a4ad7e43f35f2b18b6716a6487e256e1ed292e8f79c437249e9dbef6cccded54397a7ecf8c
+  metadata.gz: bbd7f4209da48c0a7312fde0c2bb433999c45febcc9f87a4eca72ba0ce4b0ace89e6a4e530f4cd569746d0f18bd98094c9b262072c71069ad2313a5d83c176d6
+  data.tar.gz: 7f8701b944dbaff58f7d9aa9151da69a81dbf1ad206c8dfd7c5c9877d1c0143a19bb7e2601e010c1fae6c95b7db0f81fbf5385c6aaa368db588f516a4c0184de

data/CHANGELOG.md

@@ -7,6 +7,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.1.6] - 2026-01-09
+
+### Fixed
+
+- **CustomMethodQuery False Positive** - Skip `Hash#keys` and `Hash#values` chains
+  - `hash.keys.first`, `hash.values.last` no longer flagged as ActiveRecord queries
+  - Recognizes `keys` and `values` as Array-returning methods
+
+## [1.1.5] - 2026-01-06
+
+### Changed
+
+- **PluckToArray Severity** - Lower severity to `info` for small collections
+  - `tags`, `settings`, `roles`, `permissions`, `options` etc. now `info` level
+  - Large collections remain `warning`, `.all.pluck` remains `error`
+
 ## [1.1.4] - 2026-01-06
 
 ### Fixed

data/README.md

@@ -10,7 +10,7 @@
 
 <p align="center">
   <a href="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml"><img src="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg" alt="CI"></a>
-  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.4-red.svg" alt="Gem Version"></a>
+  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.6-red.svg" alt="Gem Version"></a>
   <a href="https://github.com/hamzagedikkaya/eager_eye"><img src="https://img.shields.io/badge/coverage-95%25-brightgreen.svg" alt="Coverage"></a>
   <a href="https://www.ruby-lang.org/"><img src="https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg" alt="Ruby"></a>
   <a href="https://opensource.org/licenses/MIT"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="License: MIT"></a>

data/lib/eager_eye/detectors/custom_method_query.rb

@@ -6,6 +6,7 @@ module EagerEye
       QUERY_METHODS = %i[where find_by find_by! exists? find first last take pluck ids count sum average minimum
                          maximum].freeze
       ARRAY_METHODS = %i[first last take].freeze
+      HASH_ARRAY_METHODS = %i[keys values].freeze
       ITERATION_METHODS = %i[each map select find_all reject collect detect find_index flat_map].freeze
 
       def self.detector_name
@@ -56,12 +57,18 @@ module EagerEye
 
         method_name = node.children[1]
         return false unless QUERY_METHODS.include?(method_name)
-        return false if is_array_collection && ARRAY_METHODS.include?(method_name) &&
-                        receiver_is_only_block_var?(node.children[0], block_var)
+        return false if skip_array_method?(node, block_var, is_array_collection)
 
         receiver_chain_starts_with?(node.children[0], block_var)
       end
 
+      def skip_array_method?(node, block_var, is_array_collection)
+        return false unless ARRAY_METHODS.include?(node.children[1])
+
+        receiver_ends_with_hash_array_method?(node.children[0]) ||
+          (is_array_collection && receiver_is_only_block_var?(node.children[0], block_var))
+      end
+
       def receiver_is_only_block_var?(node, block_var)
         node.is_a?(Parser::AST::Node) && node.type == :lvar && node.children[0] == block_var
       end
@@ -89,11 +96,15 @@ module EagerEye
 
         case node.type
         when :array then true
-        when :send then %i[map select collect flat_map to_a uniq compact].include?(node.children[1])
+        when :send then %i[map select collect flat_map to_a uniq compact keys values].include?(node.children[1])
         else false
         end
       end
 
+      def receiver_ends_with_hash_array_method?(node)
+        node.is_a?(Parser::AST::Node) && node.type == :send && HASH_ARRAY_METHODS.include?(node.children[1])
+      end
+
       def add_issue(node)
         method_name = node.children[1]
         association_chain = reconstruct_chain(node.children[0])

data/lib/eager_eye/detectors/pluck_to_array.rb

@@ -3,6 +3,8 @@
 module EagerEye
   module Detectors
     class PluckToArray < Base
+      SMALL_COLLECTIONS = %w[tags settings options categories roles permissions statuses types priorities].freeze
+
       def self.detector_name
         :pluck_to_array
       end
@@ -13,6 +15,7 @@ module EagerEye
         @pluck_variables = {}
         @map_id_variables = {}
         @critical_pluck_variables = {}
+        @small_collection_variables = {}
 
         return @issues unless ast
 
@@ -38,6 +41,7 @@ module EagerEye
         value = node.children[1]
 
         @critical_pluck_variables[var_name] = node.loc.line if all_pluck_call?(value)
+        @small_collection_variables[var_name] = node.loc.line if small_collection_pluck?(value)
         @pluck_variables[var_name] = node.loc.line if pluck_call?(value)
         @map_id_variables[var_name] = node.loc.line if map_id_call?(value)
       end
@@ -45,8 +49,13 @@ module EagerEye
       def check_where_calls(node)
         return unless where_call?(node)
 
-        add_critical_issue(node) if critical_pluck?(node)
-        add_issue(node) if regular_pluck?(node)
+        if critical_pluck?(node)
+          add_critical_issue(node)
+        elsif small_collection?(node)
+          add_info_issue(node)
+        elsif regular_pluck?(node)
+          add_issue(node)
+        end
       end
 
       def local_variable_assignment?(node) = node.type == :lvasgn
@@ -64,6 +73,16 @@ module EagerEye
         receiver.is_a?(Parser::AST::Node) && receiver.type == :send && receiver.children[1] == :all
       end
 
+      def small_collection_pluck?(node)
+        return false unless pluck_call?(node)
+
+        receiver = node.children[0]
+        return false unless receiver.is_a?(Parser::AST::Node) && receiver.type == :send
+
+        method_name = receiver.children[1].to_s
+        SMALL_COLLECTIONS.any? { |c| method_name.include?(c) }
+      end
+
       def map_id_call?(node)
         node.is_a?(Parser::AST::Node) && (block_map?(node) || send_map?(node))
       end
@@ -92,6 +111,10 @@ module EagerEye
         node.children[2..].any? { |arg| critical_pluck_in_hash?(arg) }
       end
 
+      def small_collection?(node)
+        node.children[2..].any? { |arg| small_collection_in_hash?(arg) }
+      end
+
       def pluck_var_in_hash?(node)
         return false unless node.is_a?(Parser::AST::Node) && node.type == :hash
 
@@ -104,6 +127,12 @@ module EagerEye
         node.children.any? { |pair| pair.type == :pair && critical_value?(pair.children[1]) }
       end
 
+      def small_collection_in_hash?(node)
+        return false unless node.is_a?(Parser::AST::Node) && node.type == :hash
+
+        node.children.any? { |pair| pair.type == :pair && small_collection_value?(pair.children[1]) }
+      end
+
       def pluck_value?(value)
         value.type == :lvar && (@pluck_variables.key?(value.children[0]) || @map_id_variables.key?(value.children[0]))
       end
@@ -112,6 +141,10 @@ module EagerEye
         value.type == :lvar ? @critical_pluck_variables.key?(value.children[0]) : all_pluck_call?(value)
       end
 
+      def small_collection_value?(value)
+        value.type == :lvar && @small_collection_variables.key?(value.children[0])
+      end
+
       def add_issue(node)
         @issues << create_issue(
           file_path: @file_path,
@@ -131,6 +164,16 @@ module EagerEye
           severity: :error
         )
       end
+
+      def add_info_issue(node)
+        @issues << create_issue(
+          file_path: @file_path,
+          line_number: node.loc.line,
+          message: "Small collection pluck may be acceptable for few records",
+          suggestion: "Consider `.select(:id)` for consistency, but pluck is fine for small collections",
+          severity: :info
+        )
+      end
     end
   end
 end

data/lib/eager_eye/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EagerEye
-  VERSION = "1.1.4"
+  VERSION = "1.1.6"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eager_eye
 version: !ruby/object:Gem::Version
-  version: 1.1.4
+  version: 1.1.6
 platform: ruby
 authors:
 - hamzagedikkaya
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-01-06 00:00:00.000000000 Z
+date: 2026-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast