eager_eye 1.1.2 → 1.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 22770991f73a5bc9ca8694ae4e45212fc6c0517036dad5a8734a11af90aa4496
-  data.tar.gz: bcdbdf3076b011a7a4eb83d62d34b4173d7f6c5cb1dff3c0ac767bbd0f47c316
+  metadata.gz: 6ae532397830e96202bc3a3d10dc231570f4912d5df67085783123fbb2ebba5e
+  data.tar.gz: ddc5a6971c2c65c73260c59ff8b6acfd52711a2e1ce1d43ea8c44895be729016
 SHA512:
-  metadata.gz: fcf06b3db031246fcd6549bff94a13f5e30b29da2d72a6e3c2d233fcb9740cf4a60f807e190e3f082620eda08755e90a01e96915ac873f4205f3938c44de1e8a
-  data.tar.gz: 93a926cb2d961f1b5c8341df4c7ac0dbcb3d482e9bbc00b61b7d84ed3c457432611792f999d9c02b7dcb164cf3d238c561d89392b5cb67bb287e57dcbb008a12
+  metadata.gz: fa15940b451ebd100e908b4f9931c8f40708f9566451a0f1edb8a65c70fee15f832bd30d91d49f54c9b2f0ebe63cbdf2f5dbabfb5f7894db23d1a2f35c1e95c5
+  data.tar.gz: 80ea91965317596061db8a38cce960ac4f573a4c887de7a2fe88b7a4ad7e43f35f2b18b6716a6487e256e1ed292e8f79c437249e9dbef6cccded54397a7ecf8c

data/CHANGELOG.md

@@ -7,6 +7,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.1.4] - 2026-01-06
+
+### Fixed
+
+- **SerializerNesting False Positive** - Skip ActiveStorage attachments
+  - `user.avatar.attached?`, `user.avatar.variant(...)` no longer flagged
+  - Recognizes `attached?`, `attach`, `blob`, `variant`, `purge` methods
+
+## [1.1.3] - 2026-01-04
+
+### Fixed
+
+- **CallbackQuery False Positive** - Skip iterations over constants, arrays, and ranges
+  - `CONDITIONS.each { |c| ... }` no longer triggers warning
+  - `[:a, :b].each { |x| ... }` and `(1..5).each { |i| ... }` are now ignored
+
 ## [1.1.2] - 2026-01-04
 
 ### Fixed

data/README.md

@@ -10,7 +10,7 @@
 
 <p align="center">
   <a href="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml"><img src="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg" alt="CI"></a>
-  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.2-red.svg" alt="Gem Version"></a>
+  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.4-red.svg" alt="Gem Version"></a>
   <a href="https://github.com/hamzagedikkaya/eager_eye"><img src="https://img.shields.io/badge/coverage-95%25-brightgreen.svg" alt="Coverage"></a>
   <a href="https://www.ruby-lang.org/"><img src="https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg" alt="Ruby"></a>
   <a href="https://opensource.org/licenses/MIT"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="License: MIT"></a>

data/lib/eager_eye/detectors/callback_query.rb

@@ -109,8 +109,16 @@ module EagerEye
       end
 
       def iteration_block?(node)
-        node.type == :block && node.children[0]&.type == :send &&
-          ITERATION_METHODS.include?(node.children[0].children[1])
+        return false unless node.type == :block && node.children[0]&.type == :send
+        return false unless ITERATION_METHODS.include?(node.children[0].children[1])
+
+        !static_collection?(node.children[0].children[0])
+      end
+
+      def static_collection?(node)
+        return true unless node.is_a?(Parser::AST::Node)
+
+        %i[array const irange erange].include?(node.type)
       end
 
       def add_query_issue(node, method_name, callback_type)

data/lib/eager_eye/detectors/serializer_nesting.rb

@@ -6,6 +6,8 @@ module EagerEye
       SERIALIZER_PATTERNS = %w[ActiveModel::Serializer ActiveModelSerializers::Model Blueprinter::Base Alba::Resource].freeze
       ATTRIBUTE_METHODS = %i[attribute field attributes].freeze
       OBJECT_REFS = %i[object record resource].freeze
+      ACTIVE_STORAGE_METHODS = %i[attached? attach attachment attachments blob blobs purge purge_later variant
+                                  preview].freeze
       HAS_MANY_ASSOCIATIONS = %w[
         authors users owners creators admins members customers clients
         posts articles comments categories tags children companies organizations
@@ -100,8 +102,11 @@ module EagerEye
       end
 
       def find_association_in_block(block_body, file_path, issues)
+        storage_lines = collect_active_storage_lines(block_body)
+
         traverse_ast(block_body) do |node|
           next unless node.type == :send
+          next if storage_lines.include?(node.loc.line)
 
           receiver = node.children[0]
           method_name = node.children[1]
@@ -116,6 +121,16 @@ module EagerEye
         end
       end
 
+      def collect_active_storage_lines(block_body)
+        lines = Set.new
+        traverse_ast(block_body) do |node|
+          next unless node.type == :send && ACTIVE_STORAGE_METHODS.include?(node.children[1])
+
+          lines << node.loc.line
+        end
+        lines
+      end
+
       def object_reference?(node)
         return false unless node
 

data/lib/eager_eye/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EagerEye
-  VERSION = "1.1.2"
+  VERSION = "1.1.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eager_eye
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.1.4
 platform: ruby
 authors:
 - hamzagedikkaya
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-01-04 00:00:00.000000000 Z
+date: 2026-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast