eager_eye 1.1.12 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8b9c34f34d7b2a4433772c5478a94eb28ada60b751b560900c257a9d013b9b9f
-  data.tar.gz: 41ba835f40199d7a0946b5e2f42db2a73c1beb43ef3684d32f147bf1250dc5f3
+  metadata.gz: 717dbf77ddadff7da379108a74205cabaed1cdb2796ff8af8dce681fca07b1c9
+  data.tar.gz: 424b8b40da2e4bb69f54d58a5d2923346b016db3d1e69220c06e8bbde0dfa7c6
 SHA512:
-  metadata.gz: 6cc33125266267c58f0dff32d1e791cd7209660be223b54f57a001af08aae178528ee081f95613638109942ce169638b37e0239077df9794e8162cb2cf69f367
-  data.tar.gz: 40a0fd9a91164e0a261c8dd3119db5ce7f3795b1f50b07b99276d226c3a72cd2f3acbb98fc0ec6a9063ed846eb93f5a1968e227e5c6cdfde8c0d0691fe016b90
+  metadata.gz: efd5e760d3ea54457eb837011b538424553c532ca38a29660a3865c952a32a42ff82bbaeca5925fd423c56510800fc6bc961483a6c167e5a7b132eb06b2f93d3
+  data.tar.gz: 5d80c29a7a1648541377e10e990869293e9f1ba3c99490fec4aa4efab16b99ad56f7ac00b8ab5df9763c70dc41d3dbe2ee9984212f43e2d261f599c15aca8919

data/CHANGELOG.md

@@ -7,6 +7,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.2.0] - 2026-01-18
+
+### Features
+
+- **Safer PluckToSelect Auto-fix** - Improved safety for `.pluck` to `.select` auto-fixer
+  - Skips `info` severity issues (small collections like `statuses`, `types`) to preserve caching
+  - Uses strict regex to ensure `.pluck` is inside `.where` arguments to prevent code breakage
+  - Prevents unsafe replacements like `User.where(active: 1).pluck(:id)` → `select` (which changes return type)
+
+## [1.1.13] - 2026-01-16
+
+### Fixed
+
+- **CustomMethodQuery False Positive** - Skip `.ids` on SQL alias attributes
+  - `s_eod.ids` no longer flagged when `ids` is a SQL alias (e.g., `select('array_agg(...) AS ids')`)
+  - Deep chains like `item.comments.ids` still correctly detected
+
 ## [1.1.12] - 2026-01-15
 
 ### Fixed

data/README.md

@@ -10,7 +10,7 @@
 
 <p align="center">
   <a href="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml"><img src="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg" alt="CI"></a>
-  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.12-red.svg" alt="Gem Version"></a>
+  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.2.0-red.svg" alt="Gem Version"></a>
   <a href="https://github.com/hamzagedikkaya/eager_eye"><img src="https://img.shields.io/badge/coverage-95%25-brightgreen.svg" alt="Coverage"></a>
   <a href="https://www.ruby-lang.org/"><img src="https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg" alt="Ruby"></a>
   <a href="https://opensource.org/licenses/MIT"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="License: MIT"></a>

data/lib/eager_eye/detectors/custom_method_query.rb

@@ -5,7 +5,7 @@ module EagerEye
     class CustomMethodQuery < Base
       QUERY_METHODS = %i[where find_by find_by! exists? find first last take pluck ids count sum average minimum
                          maximum].freeze
-      SAFE_QUERY_METHODS = %i[first last take count sum find size length].freeze
+      SAFE_QUERY_METHODS = %i[first last take count sum find size length ids].freeze
       SAFE_TRANSFORM_METHODS = %i[keys values split [] params sort pluck ids to_s to_a to_i chars bytes].freeze
       ITERATION_METHODS = %i[each map select find_all reject collect detect find_index flat_map].freeze
 

data/lib/eager_eye/fixers/pluck_to_select.rb

@@ -4,19 +4,23 @@ module EagerEye
   module Fixers
     class PluckToSelect < Base
       def fixable?
-        issue.detector == :pluck_to_array && single_line_pattern?
+        issue.detector == :pluck_to_array &&
+          issue.severity != :info &&
+          single_line_pattern?
       end
 
       protected
 
       def fixed_content
-        line_content.gsub(/\.pluck\((:\w+)\)/, '.select(\1)')
+        line_content.sub(/(\.where\s*\([^)]*)(\.pluck)(\((?::\w+)\))/) do
+          "#{::Regexp.last_match(1)}.select#{::Regexp.last_match(3)}"
+        end
       end
 
       private
 
       def single_line_pattern?
-        line_content&.include?(".pluck(") && line_content.include?(".where(")
+        line_content&.match?(/\.where\s*\([^)]*\.pluck\(/)
       end
     end
   end

data/lib/eager_eye/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EagerEye
-  VERSION = "1.1.12"
+  VERSION = "1.2.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eager_eye
 version: !ruby/object:Gem::Version
-  version: 1.1.12
+  version: 1.2.0
 platform: ruby
 authors:
 - hamzagedikkaya
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-01-15 00:00:00.000000000 Z
+date: 2026-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast