eager_eye 1.1.11 → 1.1.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 200f52cfc9b2d47ee338155372eded81c115c5c05578e6ff89e689f148fabac5
-  data.tar.gz: 3b236fff4d78662c30140b3e429d222defed03100b2c8d6928711886bd7c525a
+  metadata.gz: 2016440524db060dc267545c436a7f3ed33958efc344bba2a6c14b94a69dd0a3
+  data.tar.gz: 61961e507f36c1929f0d1d68a8b05ec8169667aac2e8f941e155d94af01d011f
 SHA512:
-  metadata.gz: 8a09fbc10c6f944c9c42f31723dc0bf248eff29691a35fbc31f6a4e21836224225863eb625ac33e818a30b2e12b119831e02ec2f0d0689476e014a9ab0d5331e
-  data.tar.gz: 36dff575a0277abc141848a1866a057f31fcefe6fdecd861a32fcad7120167a56120f0ed8a507c9ff9fdcb4ac54be72be64a475ca0b5105574ace91e26618f8b
+  metadata.gz: 9ff57ccdd2efe4fa5cf526a6833caa534e429cf45b84ac5e8e578b1bc280d088ec0aa65553879da5d654561a963b80d7381928fcb8e2275060d78271600b8468
+  data.tar.gz: ccc2892f3bfb35d89fd2a2b2b7976e80ecae008d9341f93231a1e23fc4d444a614402253e28d1c2f6b3e8a4bab8c5c5d42ae8e6c4ad22d888f9aef0315f1f895

data/CHANGELOG.md

@@ -7,6 +7,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.1.13] - 2026-01-16
+
+### Fixed
+
+- **CustomMethodQuery False Positive** - Skip `.ids` on SQL alias attributes
+  - `s_eod.ids` no longer flagged when `ids` is a SQL alias (e.g., `select('array_agg(...) AS ids')`)
+  - Deep chains like `item.comments.ids` still correctly detected
+
+## [1.1.12] - 2026-01-15
+
+### Fixed
+
+- **CustomMethodQuery Stack Overflow** - Fix infinite recursion in `collection_is_array?`
+  - Added `visited` Set to track already-visited nodes and prevent cyclic traversal
+  - Fixes `stack level too deep` error on complex method chains
+
 ## [1.1.11] - 2026-01-13
 
 ### Fixed

data/README.md

@@ -10,7 +10,7 @@
 
 <p align="center">
   <a href="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml"><img src="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg" alt="CI"></a>
-  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.11-red.svg" alt="Gem Version"></a>
+  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.13-red.svg" alt="Gem Version"></a>
   <a href="https://github.com/hamzagedikkaya/eager_eye"><img src="https://img.shields.io/badge/coverage-95%25-brightgreen.svg" alt="Coverage"></a>
   <a href="https://www.ruby-lang.org/"><img src="https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg" alt="Ruby"></a>
   <a href="https://opensource.org/licenses/MIT"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="License: MIT"></a>

data/lib/eager_eye/detectors/custom_method_query.rb

@@ -5,7 +5,7 @@ module EagerEye
     class CustomMethodQuery < Base
       QUERY_METHODS = %i[where find_by find_by! exists? find first last take pluck ids count sum average minimum
                          maximum].freeze
-      SAFE_QUERY_METHODS = %i[first last take count sum find size length].freeze
+      SAFE_QUERY_METHODS = %i[first last take count sum find size length ids].freeze
       SAFE_TRANSFORM_METHODS = %i[keys values split [] params sort pluck ids to_s to_a to_i chars bytes].freeze
       ITERATION_METHODS = %i[each map select find_all reject collect detect find_index flat_map].freeze
 
@@ -93,28 +93,32 @@ module EagerEye
         first_arg&.type == :arg ? first_arg.children[0] : nil
       end
 
-      def collection_is_array?(node, definitions = {})
+      def collection_is_array?(node, definitions = {}, visited = Set.new)
         return false unless node.is_a?(Parser::AST::Node)
+        return false if visited.include?(node.object_id)
+
+        visited.add(node.object_id)
+
         return true if %i[array hash].include?(node.type)
-        return check_lvar_collection?(node, definitions) if node.type == :lvar
-        return check_send_collection?(node, definitions) if node.type == :send
+        return check_lvar_collection?(node, definitions, visited) if node.type == :lvar
+        return check_send_collection?(node, definitions, visited) if node.type == :send
 
         false
       end
 
-      def check_lvar_collection?(node, definitions)
+      def check_lvar_collection?(node, definitions, visited)
         return false unless definitions
 
         definition = definitions[node.children[0]]
-        definition ? collection_is_array?(definition, definitions) : false
+        definition ? collection_is_array?(definition, definitions, visited) : false
       end
 
-      def check_send_collection?(node, definitions)
+      def check_send_collection?(node, definitions, visited)
         method_name = node.children[1]
         return true if %i[map select collect flat_map uniq compact].include?(method_name)
         return true if SAFE_TRANSFORM_METHODS.include?(method_name)
 
-        collection_is_array?(node.children[0], definitions)
+        collection_is_array?(node.children[0], definitions, visited)
       end
 
       def receiver_ends_with_safe_transform_method?(node)

data/lib/eager_eye/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EagerEye
-  VERSION = "1.1.11"
+  VERSION = "1.1.13"
 end

data/lib/eager_eye.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require "set"
 require_relative "eager_eye/version"
 require_relative "eager_eye/configuration"
 require_relative "eager_eye/issue"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eager_eye
 version: !ruby/object:Gem::Version
-  version: 1.1.11
+  version: 1.1.13
 platform: ruby
 authors:
 - hamzagedikkaya
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-01-13 00:00:00.000000000 Z
+date: 2026-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast