eager_eye 1.1.10 → 1.1.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 28c53330ec88bd4b8125e357ad3d11bc3155e6425d7feef88ccf4fd8bec93123
-  data.tar.gz: c671ff6c33dd1fef2a0be359452a195ecc5a72b27d534ca09d92c17f1928c89f
+  metadata.gz: 8b9c34f34d7b2a4433772c5478a94eb28ada60b751b560900c257a9d013b9b9f
+  data.tar.gz: 41ba835f40199d7a0946b5e2f42db2a73c1beb43ef3684d32f147bf1250dc5f3
 SHA512:
-  metadata.gz: 75dd57d12d3b869f4ae9246130de9ae497ec6240f0f81adeaae1d7c2aaf48eed0f5d2626a62ba2f72a0b0adf8d207129322977c60639986881c1cd9fec91ecec
-  data.tar.gz: 265a28c9086ae7a215f31f7295b9d48be4882b926718a70029678b7c46d80ef171c308060507670477385cb52fd8aba66d7fac0bc05c1da13cd246e3eab56ed9
+  metadata.gz: 6cc33125266267c58f0dff32d1e791cd7209660be223b54f57a001af08aae178528ee081f95613638109942ce169638b37e0239077df9794e8162cb2cf69f367
+  data.tar.gz: 40a0fd9a91164e0a261c8dd3119db5ce7f3795b1f50b07b99276d226c3a72cd2f3acbb98fc0ec6a9063ed846eb93f5a1968e227e5c6cdfde8c0d0691fe016b90

data/CHANGELOG.md

@@ -7,6 +7,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.1.12] - 2026-01-15
+
+### Fixed
+
+- **CustomMethodQuery Stack Overflow** - Fix infinite recursion in `collection_is_array?`
+  - Added `visited` Set to track already-visited nodes and prevent cyclic traversal
+  - Fixes `stack level too deep` error on complex method chains
+
+## [1.1.11] - 2026-01-13
+
+### Fixed
+
+- **CustomMethodQuery False Positive** - Skip `count`, `sum`, `find` on safe collections
+  - `id.to_s.count` no longer flagged (scalar count)
+  - `array.count` no longer flagged inside iteration
+  - Expanded safe transform methods (`to_s`, `to_i`, `to_a`, `chars`, `bytes`)
+
 ## [1.1.10] - 2026-01-12
 
 ### Fixed

data/README.md

@@ -10,7 +10,7 @@
 
 <p align="center">
   <a href="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml"><img src="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg" alt="CI"></a>
-  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.10-red.svg" alt="Gem Version"></a>
+  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.12-red.svg" alt="Gem Version"></a>
   <a href="https://github.com/hamzagedikkaya/eager_eye"><img src="https://img.shields.io/badge/coverage-95%25-brightgreen.svg" alt="Coverage"></a>
   <a href="https://www.ruby-lang.org/"><img src="https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg" alt="Ruby"></a>
   <a href="https://opensource.org/licenses/MIT"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="License: MIT"></a>

data/lib/eager_eye/detectors/custom_method_query.rb

@@ -5,10 +5,8 @@ module EagerEye
     class CustomMethodQuery < Base
       QUERY_METHODS = %i[where find_by find_by! exists? find first last take pluck ids count sum average minimum
                          maximum].freeze
-      ARRAY_METHODS = %i[first last take].freeze
-      HASH_ARRAY_METHODS = %i[keys values].freeze
-      STRING_ARRAY_METHODS = %i[split].freeze
-      BRACKET_ARRAY_METHODS = %i[[]].freeze
+      SAFE_QUERY_METHODS = %i[first last take count sum find size length].freeze
+      SAFE_TRANSFORM_METHODS = %i[keys values split [] params sort pluck ids to_s to_a to_i chars bytes].freeze
       ITERATION_METHODS = %i[each map select find_all reject collect detect find_index flat_map].freeze
 
       def self.detector_name
@@ -67,9 +65,9 @@ module EagerEye
       end
 
       def skip_array_method?(node, block_var, is_array_collection)
-        return true if receiver_ends_with_hash_array_method?(node.children[0])
+        return true if receiver_ends_with_safe_transform_method?(node.children[0])
 
-        ARRAY_METHODS.include?(node.children[1]) &&
+        SAFE_QUERY_METHODS.include?(node.children[1]) &&
           is_array_collection && receiver_is_only_block_var?(node.children[0], block_var)
       end
 
@@ -95,36 +93,38 @@ module EagerEye
         first_arg&.type == :arg ? first_arg.children[0] : nil
       end
 
-      def collection_is_array?(node, definitions = {})
+      def collection_is_array?(node, definitions = {}, visited = Set.new)
         return false unless node.is_a?(Parser::AST::Node)
+        return false if visited.include?(node.object_id)
+
+        visited.add(node.object_id)
+
         return true if %i[array hash].include?(node.type)
-        return check_lvar_collection?(node, definitions) if node.type == :lvar
-        return check_send_collection?(node, definitions) if node.type == :send
+        return check_lvar_collection?(node, definitions, visited) if node.type == :lvar
+        return check_send_collection?(node, definitions, visited) if node.type == :send
 
         false
       end
 
-      def check_lvar_collection?(node, definitions)
+      def check_lvar_collection?(node, definitions, visited)
         return false unless definitions
 
         definition = definitions[node.children[0]]
-        definition ? collection_is_array?(definition, definitions) : false
+        definition ? collection_is_array?(definition, definitions, visited) : false
       end
 
-      def check_send_collection?(node, definitions)
+      def check_send_collection?(node, definitions, visited)
         method_name = node.children[1]
-        return true if %i[map select collect flat_map to_a uniq compact keys values split []
-                          params sort pluck ids].include?(method_name)
+        return true if %i[map select collect flat_map uniq compact].include?(method_name)
+        return true if SAFE_TRANSFORM_METHODS.include?(method_name)
 
-        collection_is_array?(node.children[0], definitions)
+        collection_is_array?(node.children[0], definitions, visited)
       end
 
-      def receiver_ends_with_hash_array_method?(node)
+      def receiver_ends_with_safe_transform_method?(node)
         return false unless node.is_a?(Parser::AST::Node) && node.type == :send
 
-        HASH_ARRAY_METHODS.include?(node.children[1]) ||
-          STRING_ARRAY_METHODS.include?(node.children[1]) ||
-          BRACKET_ARRAY_METHODS.include?(node.children[1])
+        SAFE_TRANSFORM_METHODS.include?(node.children[1])
       end
 
       def add_issue(node)

data/lib/eager_eye/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EagerEye
-  VERSION = "1.1.10"
+  VERSION = "1.1.12"
 end

data/lib/eager_eye.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require "set"
 require_relative "eager_eye/version"
 require_relative "eager_eye/configuration"
 require_relative "eager_eye/issue"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eager_eye
 version: !ruby/object:Gem::Version
-  version: 1.1.10
+  version: 1.1.12
 platform: ruby
 authors:
 - hamzagedikkaya
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-01-12 00:00:00.000000000 Z
+date: 2026-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast