eager_eye 1.1.1 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8b6c076a6dd51cb872bfb213cbb83369a7d9f159bb20054b41901710b738b4df
-  data.tar.gz: 15850c235c48858cbbb2585c83ffaeacf1331a029b959f973aede31ef584ae24
+  metadata.gz: 928603853f971cca5717d7db1ca527da41562b4aef18c27b37be3b2824a4993e
+  data.tar.gz: b3e7af83cfb0085a6e34ad65e3e633da6d3eaa517d548b530504dbb6f0a7c5c4
 SHA512:
-  metadata.gz: 0454d92551dcc8d96ae35513ae89c3198a707ee6aac43538c7233d679cb9328c9190c8def794736c53cf61b06419051baa937a9358288a046590de14d15c22b1
-  data.tar.gz: bfd0dc368252cf5d0118a5dcf912b981ea02bf6f158a80a59a1fc475f0f5810c302c223c4126dfc639f8a5ad5e8be3fbcfd3ed87d5c21d3e148405a5f5033b1a
+  metadata.gz: 1879d46b6a428002adfc1d241b763fb8b59c5f6a0c82656459dbd389fe04d37ffcdf39394185141ce78837cec72386b689147171291a494f7484dbcae0bfe438
+  data.tar.gz: b6cdafbe35419653bd4d374504b1d32475c9cab7fc7ec41d8612c77924589aa1d950c819bd901f0196cdf1de33b2f114bbbbb5fcb11defb7d4624f5043356ee2

data/CHANGELOG.md

@@ -7,6 +7,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.1.3] - 2026-01-04
+
+### Fixed
+
+- **CallbackQuery False Positive** - Skip iterations over constants, arrays, and ranges
+  - `CONDITIONS.each { |c| ... }` no longer triggers warning
+  - `[:a, :b].each { |x| ... }` and `(1..5).each { |i| ... }` are now ignored
+
+## [1.1.2] - 2026-01-04
+
+### Fixed
+
+- **CallbackQuery False Positive** - Only flag iterations that contain actual AR query methods
+  - Non-AR iterations (Redis, Sidekiq, mailers) are no longer flagged
+  - `Sidekiq::ScheduledSet.new.select { |job| ... }.each(&:delete)` no longer triggers warning
+
 ## [1.1.1] - 2026-01-03
 
 ### Fixed

data/README.md

@@ -10,7 +10,7 @@
 
 <p align="center">
   <a href="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml"><img src="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg" alt="CI"></a>
-  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.1-red.svg" alt="Gem Version"></a>
+  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.1.3-red.svg" alt="Gem Version"></a>
   <a href="https://github.com/hamzagedikkaya/eager_eye"><img src="https://img.shields.io/badge/coverage-95%25-brightgreen.svg" alt="Coverage"></a>
   <a href="https://www.ruby-lang.org/"><img src="https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg" alt="Ruby"></a>
   <a href="https://opensource.org/licenses/MIT"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="License: MIT"></a>

data/lib/eager_eye/detectors/callback_query.rb

@@ -85,8 +85,10 @@ module EagerEye
 
         if iteration_block?(node)
           block_var = extract_block_variable(node)
-          add_iteration_issue(node, method_name, callback_type)
-          find_query_calls_in_block(node, method_name, callback_type, block_var) if block_var
+          if block_var && contains_ar_query_on_variable?(node, block_var)
+            add_iteration_issue(node, method_name, callback_type)
+            find_query_calls_in_block(node, method_name, callback_type, block_var)
+          end
         end
 
         node.children.each { |child| find_iterations_with_queries(child, method_name, callback_type) }
@@ -107,8 +109,16 @@ module EagerEye
       end
 
       def iteration_block?(node)
-        node.type == :block && node.children[0]&.type == :send &&
-          ITERATION_METHODS.include?(node.children[0].children[1])
+        return false unless node.type == :block && node.children[0]&.type == :send
+        return false unless ITERATION_METHODS.include?(node.children[0].children[1])
+
+        !static_collection?(node.children[0].children[0])
+      end
+
+      def static_collection?(node)
+        return true unless node.is_a?(Parser::AST::Node)
+
+        %i[array const irange erange].include?(node.type)
       end
 
       def add_query_issue(node, method_name, callback_type)
@@ -155,6 +165,13 @@ module EagerEye
           false
         end
       end
+
+      def contains_ar_query_on_variable?(node, block_var)
+        return false unless node.is_a?(Parser::AST::Node)
+        return true if query_call?(node) && receiver_chain_starts_with?(node.children[0], block_var)
+
+        node.children.any? { |child| contains_ar_query_on_variable?(child, block_var) }
+      end
     end
   end
 end

data/lib/eager_eye/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EagerEye
-  VERSION = "1.1.1"
+  VERSION = "1.1.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eager_eye
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.3
 platform: ruby
 authors:
 - hamzagedikkaya
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-01-03 00:00:00.000000000 Z
+date: 2026-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast