eager_eye 1.0.5 → 1.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1e198460506f7e19906eeed320e9f9f11987ca1f4894b4b205a56d58799f3781
-  data.tar.gz: e61be4439b88d9731678fae64cb530390c7d2ab06dede3bbef570f8923c5542c
+  metadata.gz: f19a4d72ee31d2ea100782d4fd9da6594db5f9ec78e9290723461441f58e264d
+  data.tar.gz: d8b347ecb77010db7ebff3db74610de1516c653991d7264321f302d2b3eaf0ea
 SHA512:
-  metadata.gz: b32e0853b58fd412511418aedf8ce2d452d0f5a20b20e54eb3c2bb260c7233af7f7bbbe465f7efd7b511114152ffb72b381f54b88bd12c67463a63b547f6ff91
-  data.tar.gz: bf371dcf0600ec9f57614eae0d2d52fee4a904f3be37bd5d2f8a0e8d7066135d78b86d6a914e90f61fbc26afcee09003f886c8415ce2d84ce3d35799825975ee
+  metadata.gz: 6e676774f31b89d5a6948dda61c18e6c08a522f83c224d796a16dc954f3ae2fd6ef63e91bb1d4e9afe652ab4447538af5e521875bc2544833cabf429549582ff
+  data.tar.gz: a6bde55b11a3cb95f2550ddd5592b855e2ed6accd36abf3e1fb33f00ba34343291e0eab1a17253de95990c876a9119d15ef1b9e2548cc706e7dea0c6c446a510

data/CHANGELOG.md

@@ -7,6 +7,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.0.7] - 2025-12-24
+
+### Fixed
+
+- Fixed `invalid byte sequence in US-ASCII` error when parsing files containing non-ASCII characters (Turkish, Chinese, etc.)
+  - Now properly encodes source code to UTF-8 with replacement for invalid/undefined characters
+  - Fixes crash when analyzing files with special characters in comments or strings
+
+## [1.0.6] - 2025-12-22
+
+### Fixed
+
+- Fixed false positive in `MissingCounterCache` detector for single `.count`/`.size`/`.length` calls
+  - Now only detects count calls **inside iterations** where N+1 queries actually occur
+  - Single calls like `post.comments.count` are no longer flagged (not N+1)
+  - Iteration patterns like `posts.each { |p| p.comments.count }` are correctly detected
+
 ## [1.0.5] - 2025-12-21
 
 ### Fixed

data/README.md

@@ -1,15 +1,27 @@
-# EagerEye
+<p align="center">
+  <img src="images/icon.png" alt="EagerEye Logo" width="140">
+</p>
 
-[![CI](https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg)](https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml)
-[![Gem Version](https://img.shields.io/badge/gem-v1.0.5-red.svg)](https://rubygems.org/gems/eager_eye)
-[![Coverage](https://img.shields.io/badge/coverage-95%25-brightgreen.svg)](https://github.com/hamzagedikkaya/eager_eye)
-[![Ruby](https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg)](https://www.ruby-lang.org/)
-[![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
-[![VS Code Extension](https://img.shields.io/badge/VS%20Code-Extension-blue.svg)](https://marketplace.visualstudio.com/items?itemName=hamzagedikkaya.eager-eye)
+<h1 align="center">EagerEye</h1>
 
-**Static analysis tool for detecting N+1 queries in Rails applications.**
+<p align="center">
+  <strong>Static analysis tool for detecting N+1 queries in Rails applications.</strong>
+</p>
 
-EagerEye analyzes your Ruby code without running it, using AST (Abstract Syntax Tree) parsing to find potential N+1 query issues before they hit production.
+<p align="center">
+  <a href="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml"><img src="https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg" alt="CI"></a>
+  <a href="https://rubygems.org/gems/eager_eye"><img src="https://img.shields.io/badge/gem-v1.0.7-red.svg" alt="Gem Version"></a>
+  <a href="https://github.com/hamzagedikkaya/eager_eye"><img src="https://img.shields.io/badge/coverage-95%25-brightgreen.svg" alt="Coverage"></a>
+  <a href="https://www.ruby-lang.org/"><img src="https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg" alt="Ruby"></a>
+  <a href="https://opensource.org/licenses/MIT"><img src="https://img.shields.io/badge/License-MIT-yellow.svg" alt="License: MIT"></a>
+  <a href="https://marketplace.visualstudio.com/items?itemName=hamzagedikkaya.eager-eye"><img src="https://img.shields.io/badge/VS%20Code-Extension-blue.svg" alt="VS Code Extension"></a>
+</p>
+
+<p align="center">
+  <em>Analyze your Ruby code without running it — find N+1 query issues before they hit production using AST parsing.</em>
+</p>
+
+---
 
 ## Why EagerEye?
 
@@ -150,19 +162,26 @@ Supports multiple serializer libraries:
 
 ### 3. Missing Counter Cache
 
-Detects `.count` or `.size` calls on associations that could benefit from counter caches.
+Detects `.count`, `.size`, or `.length` calls on associations **inside iterations** that could benefit from counter caches. Single calls outside loops are not flagged since they don't cause N+1 issues.
 
 ```ruby
-# Bad - COUNT query every time
-post.comments.count
-post.comments.size
+# Bad - COUNT query for each post in iteration
+posts.each do |post|
+  post.comments.count   # Detected: N+1 query!
+  post.likes.size       # Detected: N+1 query!
+end
 
-# Good - Add counter cache
+# OK - Single count call (not in iteration, no N+1)
+post.comments.count     # Not flagged - single query is fine
+
+# Good - Add counter cache for iteration use cases
 # In Comment model:
 belongs_to :post, counter_cache: true
 
 # Then this is a simple column read:
-post.comments_count
+posts.each do |post|
+  post.comments_count   # No query - just reads the column
+end
 ```
 
 ### 4. Custom Method Query (N+1 in query methods)

data/lib/eager_eye/comment_parser.rb

@@ -10,8 +10,8 @@ module EagerEye
     BLOCK_DISABLE_PATTERN = /eager_eye:disable\s+(.+?)(?:\s+--|$)/i
 
     def initialize(source_code)
-      @source_code = source_code
-      @lines = source_code.lines
+      @source_code = source_code.encode("UTF-8", invalid: :replace, undef: :replace)
+      @lines = @source_code.lines
       @disabled_ranges = Hash.new { |h, k| h[k] = [] }
       @file_disabled = Set.new
       @current_disabled = Set.new

data/lib/eager_eye/detectors/missing_counter_cache.rb

@@ -15,6 +15,11 @@ module EagerEye
         children replies responses answers questions
       ].freeze
 
+      # Iteration methods that indicate a loop context
+      ITERATION_METHODS = %i[each map collect select reject find_all
+                             filter filter_map flat_map each_with_index
+                             each_with_object reduce inject sum].freeze
+
       def self.detector_name
         :missing_counter_cache
       end
@@ -26,6 +31,7 @@ module EagerEye
 
         traverse_ast(ast) do |node|
           next unless count_on_association?(node)
+          next unless inside_iteration?(node)
 
           association_name = extract_association_name(node)
           next unless association_name
@@ -33,7 +39,7 @@ module EagerEye
           issues << create_issue(
             file_path: file_path,
             line_number: node.loc.line,
-            message: "`.#{node.children[1]}` called on `#{association_name}` may cause N+1 queries",
+            message: "`.#{node.children[1]}` called on `#{association_name}` inside iteration may cause N+1 queries",
             suggestion: "Consider adding `counter_cache: true` to the belongs_to association"
           )
         end
@@ -68,6 +74,46 @@ module EagerEye
 
         receiver.children[1].to_s
       end
+
+      # Check if the node is inside an iteration block
+      def inside_iteration?(node)
+        parent = node
+        while (parent = find_parent(parent))
+          return true if iteration_block?(parent)
+        end
+        false
+      end
+
+      def find_parent(node)
+        @parent_map ||= {}
+        @parent_map[node]
+      end
+
+      # Override traverse_ast to build parent map
+      def traverse_ast(node, &block)
+        return unless node.is_a?(Parser::AST::Node)
+
+        @parent_map ||= {}
+
+        yield node
+
+        node.children.each do |child|
+          if child.is_a?(Parser::AST::Node)
+            @parent_map[child] = node
+            traverse_ast(child, &block)
+          end
+        end
+      end
+
+      def iteration_block?(node)
+        return false unless node.type == :block
+
+        send_node = node.children[0]
+        return false unless send_node&.type == :send
+
+        method_name = send_node.children[1]
+        ITERATION_METHODS.include?(method_name)
+      end
     end
   end
 end

data/lib/eager_eye/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EagerEye
-  VERSION = "1.0.5"
+  VERSION = "1.0.7"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eager_eye
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.7
 platform: ruby
 authors:
 - hamzagedikkaya
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-12-21 00:00:00.000000000 Z
+date: 2025-12-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast
@@ -58,6 +58,7 @@ files:
 - SECURITY.md
 - examples/github_action.yml
 - exe/eager_eye
+- images/icon.png
 - lib/eager_eye.rb
 - lib/eager_eye/analyzer.rb
 - lib/eager_eye/auto_fixer.rb