eager_eye 1.0.1 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6600c4275476bffa0b4db2a3d245bc889a39a113827ae5e9ee023fd4cdc108b2
-  data.tar.gz: d295dbec99f78fe9c0c0eead0b7d863408eefa7e9e461f8681736963d243b6b7
+  metadata.gz: ecc47488d2632329805448f55dfafc1f6670efd02b04a3dd0464c22ef9a3a4ba
+  data.tar.gz: b37b1be91854abeea6a11d33f28df1ada2a3fb0a427b28a892cb1249c22a7e67
 SHA512:
-  metadata.gz: c35374cd1c854cb377095ca7c973fdc9cc93ed3686275be51c0b6a87ff7fa696bbe4e582e8bc45d9df1b98da0b8781d9141ff9744af448efcdd0727af324d3a0
-  data.tar.gz: 45d8b73b921239751f733147738e47018a967f88df1dfbb7b66a72a5cffa1deceb9ec480b9680a34e3d22532a38b142ddf9b2964a2ee43953f640b1cbf332e32
+  metadata.gz: 19adae5e3c000cfa658f5d2615da31c9a702ff031766240b86968d69165445bbbc7b630b5a1596822eaa9683c23db84379127d0c83ed4a59366475b3585972b7
+  data.tar.gz: a87d19f36dcaf9bd7a360b31051ed32da241e7c0b867815e8e17962f4b29bdd43d6983d84981e54a350ba4d415a076a84a8b1abc6852311277f25398c51d6a1a

data/CHANGELOG.md

@@ -7,6 +7,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.0.3] - 2025-12-20
+
+### Fixed
+
+- Only flag queries in callbacks where the iteration variable is the receiver (reduces false positives)
+- Updated README callback query documentation to accurately reflect current behavior
+
+## [1.0.2] - 2025-12-19
+
+### Fixed
+
+- Only detect queries inside iterations in callback detector
+
 ## [1.0.1] - 2025-12-16
 
 ### Changed

data/README.md

@@ -1,7 +1,7 @@
 # EagerEye
 
 [![CI](https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml/badge.svg)](https://github.com/hamzagedikkaya/eager_eye/actions/workflows/main.yml)
-[![Gem Version](https://img.shields.io/badge/gem-v1.0.1-red.svg)](https://rubygems.org/gems/eager_eye)
+[![Gem Version](https://img.shields.io/badge/gem-v1.0.3-red.svg)](https://rubygems.org/gems/eager_eye)
 [![Coverage](https://img.shields.io/badge/coverage-95%25-brightgreen.svg)](https://github.com/hamzagedikkaya/eager_eye)
 [![Ruby](https://img.shields.io/badge/ruby-%3E%3D%203.1-ruby.svg)](https://www.ruby-lang.org/)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
@@ -209,42 +209,45 @@ user.posts_count  # Just reads the column
 
 ### 6. Callback Query Detection
 
-Detects database queries and iterations inside ActiveRecord callbacks. These become performance disasters during bulk operations.
+Detects N+1 patterns inside ActiveRecord callbacks - specifically iterations that execute queries on each loop.
 
 ```ruby
-# Bad - Queries in callbacks
-class Article < ApplicationRecord
-  after_save :recalculate_stats
+# Bad - N+1 in callback (DETECTED)
+class Order < ApplicationRecord
+  after_create :notify_subscribers
 
-  def recalculate_stats
-    author.articles.published.count  # Runs on EVERY save
-    category.update_article_count!   # Another query on EVERY save
+  def notify_subscribers
+    customer.followers.each do |follower|  # Error: Iteration in callback
+      follower.notifications.create!(...)  # Warning: Query on iteration variable
+    end
   end
 end
 
-# Disaster scenario
-Article.import(1000.times.map { |i| { title: "Post #{i}" } })
-# = 2000+ queries from callbacks!
+# OK - Single query in callback (NOT flagged - not N+1)
+class Article < ApplicationRecord
+  after_save :update_stats
 
-# Bad - N+1 in callback
-class Order < ApplicationRecord
-  after_create :notify_subscribers
+  def update_stats
+    author.articles.count  # Single query, acceptable
+  end
+end
 
-  def notify_subscribers
-    customer.followers.each do |follower|  # N+1!
-      NotificationMailer.new_order(follower).deliver_later
+# OK - Query not on iteration variable (NOT flagged)
+class Post < ApplicationRecord
+  after_save :process_items
+
+  def process_items
+    items.each do |item|
+      OtherModel.where(name: item.name).first  # OtherModel is receiver, not item
     end
   end
 end
 
-# Good - Use conditional callbacks
-after_save :recalculate_stats, if: :should_recalculate?
-
-# Good - Move to background job
-after_commit :schedule_stats_update, on: :create
+# Good - Move iterations to background job
+after_commit :schedule_notifications, on: :create
 
-def schedule_stats_update
-  RecalculateStatsJob.perform_later(id)
+def schedule_notifications
+  NotifySubscribersJob.perform_later(id)
 end
 ```
 

data/lib/eager_eye/detectors/callback_query.rb

@@ -99,27 +99,32 @@ module EagerEye
         method_body = method_node.children[2]
         return unless method_body
 
-        find_query_calls(method_body, method_name, callback_type)
-        find_iteration_with_queries(method_body, method_name, callback_type)
+        find_iterations_with_queries(method_body, method_name, callback_type)
       end
 
-      def find_query_calls(node, method_name, callback_type)
+      def find_iterations_with_queries(node, method_name, callback_type)
         return unless node.is_a?(Parser::AST::Node)
 
-        add_query_issue(node, method_name, callback_type) if query_call?(node)
+        if iteration_block?(node)
+          block_var = extract_block_variable(node)
+          add_iteration_issue(node, method_name, callback_type)
+          find_query_calls_in_block(node, method_name, callback_type, block_var) if block_var
+        end
 
         node.children.each do |child|
-          find_query_calls(child, method_name, callback_type)
+          find_iterations_with_queries(child, method_name, callback_type)
         end
       end
 
-      def find_iteration_with_queries(node, method_name, callback_type)
+      def find_query_calls_in_block(node, method_name, callback_type, block_var)
         return unless node.is_a?(Parser::AST::Node)
 
-        add_iteration_issue(node, method_name, callback_type) if iteration_block?(node)
+        if query_call?(node) && receiver_chain_starts_with?(node.children[0], block_var)
+          add_query_issue(node, method_name, callback_type)
+        end
 
         node.children.each do |child|
-          find_iteration_with_queries(child, method_name, callback_type)
+          find_query_calls_in_block(child, method_name, callback_type, block_var)
         end
       end
 
@@ -161,6 +166,29 @@ module EagerEye
           suggestion: "Avoid iterations in callbacks. Use background jobs for bulk operations"
         )
       end
+
+      def extract_block_variable(block_node)
+        args_node = block_node.children[1]
+        return nil unless args_node&.type == :args
+
+        first_arg = args_node.children[0]
+        return nil unless first_arg&.type == :arg
+
+        first_arg.children[0]
+      end
+
+      def receiver_chain_starts_with?(node, block_var)
+        return false unless node.is_a?(Parser::AST::Node)
+
+        case node.type
+        when :lvar
+          node.children[0] == block_var
+        when :send
+          receiver_chain_starts_with?(node.children[0], block_var)
+        else
+          false
+        end
+      end
     end
   end
 end

data/lib/eager_eye/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EagerEye
-  VERSION = "1.0.1"
+  VERSION = "1.0.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eager_eye
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.3
 platform: ruby
 authors:
 - hamzagedikkaya
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-12-16 00:00:00.000000000 Z
+date: 2025-12-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast