eac_rails_utils 0.8.0 → 0.9.0

data/lib/eac/menus_helper/data_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Eac
   module MenusHelper
     class DataBuilder
@@ -12,7 +14,8 @@ module Eac
       private
 
       def build_entries(entries, level)
-        fail 'Argument "entries" is not a hash' unless entries.is_a?(Hash)
+        raise 'Argument "entries" is not a hash' unless entries.is_a?(Hash)
+
         r = entries.map { |k, v| build_entry(k, v, level) }.select { |e| e }
         r.empty? ? nil : r
       end
@@ -28,12 +31,14 @@ module Eac
       def build_group(label, menu_entries, level)
         e = build_entries(menu_entries, level + 1)
         return nil unless e
+
         { type: :group, label: label, children: e, level: level }
       end
 
       def build_item(label, value, level)
         path, options = menu_item_options(value)
         return nil unless can_access_path?(path, options[:link_method])
+
         { type: :item, label: label, path: path, options: options, level: level }
       end
 

data/lib/eac/menus_helper/gui_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Eac
   module MenusHelper
     class GuiBuilder
@@ -6,7 +8,8 @@ module Eac
       end
 
       def build(entries, options = {})
-        fail "Argument \"entries\" is not a array" unless entries.is_a?(Array)
+        raise 'Argument "entries" is not a array' unless entries.is_a?(Array)
+
         @view.content_tag(:ul, options) do
           b = ActiveSupport::SafeBuffer.new
           entries.map { |v| menu_entry(v) }.each { |e| b << e }
@@ -22,7 +25,7 @@ module Eac
         elsif entry[:type] == :item
           menu_item(entry[:label], entry[:path], entry[:options])
         else
-          fail "Unknown menu entry type: \"#{entry[:type]}\""
+          raise "Unknown menu entry type: \"#{entry[:type]}\""
         end
       end
 

data/lib/eac/model.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Eac
   module Model
     # Adiciona as mensagens de erro de record. As mensagens de uma coluna X em record
@@ -22,7 +24,8 @@ module Eac
     end
 
     def fetch_column_errors(record, record_column, self_column, options = {})
-      return if options[:skip] && options[:skip].include?(record_column)
+      return if options[:skip]&.include?(record_column)
+
       record.errors[record_column].each do |message|
         fetch_error_column_message(self_column, message, options[:default_column],
                                    "#{record.class.human_attribute_name(record_column)}: ")
@@ -35,9 +38,8 @@ module Eac
     end
 
     def save_or_raise
-      unless save
-        fail "Falha ao tentar salvar #{self.class.name}: #{errors_to_string}"
-      end
+      raise "Falha ao tentar salvar #{self.class.name}: #{errors_to_string}" unless save
+
       self
     end
 
@@ -57,13 +59,14 @@ module Eac
     # ainda não a possui
     def add_error_message(column, message)
       return if errors[column].include?(message)
+
       errors.add(column, message)
     end
 
     # Produz uma lista de campos-mensagens, em ordem de preferência,
     # que podem receber uma mensagem de falha.
     def build_self_columns_messages(column, message, default_column,
-        default_column_message_prefix)
+                                    default_column_message_prefix)
       r = { column => message }
       m = /^(.+)_id$/.match(column)
       if m

data/lib/eac/no_presence_validator.rb

@@ -1,11 +1,11 @@
-
-
 # frozen_string_literal: true
+
 module Eac
   # https://stackoverflow.com/questions/10070786/rails-3-validation-presence-false
   class NoPresenceValidator < ActiveModel::EachValidator
     def validate_each(record, attribute, _value)
       return if record.send(attribute).blank?
+
       record.errors[attribute] << (options[:message] || 'must be blank')
     end
   end

data/lib/eac/test_utils.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Eac
   module TestUtils
     # Add more helper methods to be used by all tests here...
@@ -27,8 +28,8 @@ module Eac
     def assert_column_changes(ppp, expected_valid_result, changes)
       changes.each do |k, v|
         ppp.send("#{k}=", v)
-        assert_equal expected_valid_result, ppp.valid?, "\"#{k}\" change should be " +
-                                                        (expected_valid_result ? 'valid' : 'invalid')
+        assert_equal expected_valid_result, ppp.valid?,
+                     "\"#{k}\" change should be " + (expected_valid_result ? 'valid' : 'invalid')
         assert_not ppp.errors[k].empty? unless expected_valid_result
         ppp.restore_attributes
       end
@@ -39,18 +40,22 @@ module Eac
     def all_combinations(attrs)
       combs = [{}]
       attrs.each do |attr_name, value|
-        new_comb = []
-        assert_not value.nil?, "#{attr_name}=#{value}"
-        [nil, value].each do |vv|
-          combs.each do |c|
-            cc = c.dup
-            cc[attr_name] = vv
-            new_comb << cc
-          end
-        end
-        combs = new_comb
+        combs = all_combinations_new_combination(attr_name, value, combs)
       end
       combs
     end
+
+    def all_combinations_new_combination(attr_name, value, combs)
+      new_comb = []
+      assert_not value.nil?, "#{attr_name}=#{value}"
+      [nil, value].each do |vv|
+        combs.each do |c|
+          cc = c.dup
+          cc[attr_name] = vv
+          new_comb << cc
+        end
+      end
+      new_comb
+    end
   end
 end

data/lib/eac_rails_utils.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'active_support/dependencies'
 
 module EacRailsUtils
@@ -35,11 +36,9 @@ module EacRailsUtils
   require 'eac/menus_helper/gui_builder'
   require 'eac/model'
   require 'eac/no_presence_validator'
-  require 'eac/parsers/files_test'
-  require 'eac/source_target_fixtures'
   require 'eac/test_utils'
 
-  ActionView::Base.send :include, Eac::CommonFormHelper
-  ActionView::Base.send :include, Eac::DataTableHelper
-  ActionView::Base.send :include, Eac::MenusHelper
+  ActionView::Base.include Eac::CommonFormHelper
+  ActionView::Base.include Eac::DataTableHelper
+  ActionView::Base.include Eac::MenusHelper
 end

data/lib/eac_rails_utils/engine.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module EacRailsUtils
   class Engine < ::Rails::Engine; end
 end

data/lib/eac_rails_utils/patches/action_controller_base.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module EacRailsUtils
   module Patches
     module ActionControllerBasePatch

data/lib/eac_rails_utils/patches/model_attribute_required.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_record'
 
 module EacRailsUtils
@@ -27,5 +29,6 @@ end
 
 [::ActiveRecord::Base, ::ActiveModel::Model].each do |c|
   next if c.included_modules.include? ::EacRailsUtils::Patches::ModelAttributeRequired
+
   c.include ::EacRailsUtils::Patches::ModelAttributeRequired
 end

data/lib/eac_rails_utils/patches/ofx_parser.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'ofx-parser'
 
 module EacRailsUtils
@@ -14,9 +15,9 @@ module EacRailsUtils
         end
 
         module ClassMethods
-          def build_transaction(t)
+          def build_transaction(transaction)
             r = super
-            r.currate = (t / 'CURRENCY/CURRATE').inner_text
+            r.currate = (transaction / 'CURRENCY/CURRATE').inner_text
             r
           end
         end
@@ -32,11 +33,11 @@ end
 unless ::OfxParser::OfxParser.included_modules.include?(
   ::EacRailsUtils::Patches::OfxParser::OfxParser
 )
-  ::OfxParser::OfxParser.send(:include, ::EacRailsUtils::Patches::OfxParser::OfxParser)
+  ::OfxParser::OfxParser.include ::EacRailsUtils::Patches::OfxParser::OfxParser
 end
 
 unless ::OfxParser::Transaction.included_modules.include?(
   ::EacRailsUtils::Patches::OfxParser::Transaction
 )
-  ::OfxParser::Transaction.send(:include, ::EacRailsUtils::Patches::OfxParser::Transaction)
+  ::OfxParser::Transaction.include ::EacRailsUtils::Patches::OfxParser::Transaction
 end

data/lib/eac_rails_utils/tableless_model.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module EacRailsUtils
   class TablelessModel
     include ActiveModel::Model
@@ -34,7 +35,7 @@ module EacRailsUtils
     end
 
     class AttributesBuilder
-      DATE_TIME_FIELDS = %i(year month day hour min sec).freeze
+      DATE_TIME_FIELDS = %i[year month day hour min sec].freeze
 
       def initialize(model_class, values)
         @model_class = model_class
@@ -59,9 +60,9 @@ module EacRailsUtils
 
       def parse_array_attr_key(key)
         m = /\A(.+)\(([0-9]+)(.)\)\z/.match(key)
-        if m
-          ::OpenStruct.new(key: m[1], index: m[2].to_i - 1, converter: array_value_converter(m[3]))
-        end
+        return unless m
+
+        ::OpenStruct.new(key: m[1], index: m[2].to_i - 1, converter: array_value_converter(m[3]))
       end
 
       def array_value_set(array_attr, value)
@@ -83,6 +84,7 @@ module EacRailsUtils
       def date_time_attribute?(key)
         attr = @model_class.attributes[key]
         return false unless attr
+
         raise attr.to_s
       end
     end

data/lib/eac_rails_utils/version.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module EacRailsUtils
-  VERSION = '0.8.0'
+  VERSION = '0.9.0'
 end

data/test/app/helpers/eac_rails_utils/formatter_helper_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module EacRailsUtils

data/test/dummy/Rakefile

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 
-require File.expand_path('../config/application', __FILE__)
+require File.expand_path('config/application', __dir__)
 
 Rails.application.load_tasks

data/test/dummy/app/models/job.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Job < ActiveRecord::Base
   has_many :users
   accepts_nested_attributes_for :users, reject_if: :all_blank, allow_destroy: true

data/test/dummy/app/models/user.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class User < ActiveRecord::Base
   belongs_to :job
 

data/test/dummy/config.ru

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This file is used by Rack-based servers to start the application.
 
 require ::File.expand_path('../config/environment', __FILE__)

data/test/dummy/config/application.rb

@@ -1,4 +1,6 @@
-require File.expand_path('../boot', __FILE__)
+# frozen_string_literal: true
+
+require File.expand_path('boot', __dir__)
 
 require 'rails/all'
 

data/test/dummy/config/boot.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
+
 # Set up gems listed in the Gemfile.
-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../../Gemfile', __FILE__)
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../Gemfile', __dir__)
 
 require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE'])

data/test/dummy/config/environment.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 # Load the Rails application.
-require File.expand_path('../application', __FILE__)
+require File.expand_path('application', __dir__)
 
 # Initialize the Rails application.
 Rails.application.initialize!

data/test/dummy/config/environments/test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 

data/test/dummy/config/routes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.routes.draw do
   resources :jobs do
     collection do

data/test/dummy/db/migrate/20160415125333_create_users.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CreateUsers < ActiveRecord::Migration
   def change
     create_table :users do |t|

data/test/dummy/db/migrate/20160415143123_create_jobs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CreateJobs < ActiveRecord::Migration
   def change
     create_table :jobs do |t|

data/test/dummy/db/migrate/20160415143229_add_job_to_users.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AddJobToUsers < ActiveRecord::Migration
   def change
     add_belongs_to :users, :job

data/test/lib/eac/common_form_helper_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 module Eac

data/test/lib/eac/cpf_validator_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 module Eac

data/test/lib/eac/{data_table_test_helper.rb → data_table_test_helper_test.rb}

@@ -1,8 +1,9 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module Eac
-  class DataTableTestHelper < ActionView::TestCase
+  class DataTableTestHelperTest < ActionView::TestCase
     include ::Eac::DataTableHelper
 
     class Person

data/test/lib/eac/model_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 module Eac

data/test/lib/eac_rails_utils/patches/model_attribute_required_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 module EacRailsUtils

data/test/lib/eac_rails_utils/tableless_model_test.rb

@@ -1,5 +1,5 @@
-# encoding: UTF-8
 # frozen_string_literal: true
+
 require 'test_helper'
 
 module EacRailsUtils

data/test/test_helper.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 ENV['RAILS_ENV'] = 'test'
-require File.expand_path('../../test/dummy/config/environment.rb', __FILE__)
+require File.expand_path('../test/dummy/config/environment.rb', __dir__)
 require 'rails/test_help'
 
 module ActiveSupport

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eac_rails_utils
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - E.A.C.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-11 00:00:00.000000000 Z
+date: 2020-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel-associations
@@ -25,25 +25,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.1.2
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: bootstrap-sass
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.2'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.1
+        version: 3.3.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.2'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.1
+        version: 3.3.6
 - !ruby/object:Gem::Dependency
   name: htmlbeautifier
   requirement: !ruby/object:Gem::Requirement
@@ -59,33 +53,39 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 1.1.1
 - !ruby/object:Gem::Dependency
-  name: bootstrap-sass
+  name: ofx-parser
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.3.6
+        version: 1.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.3.6
+        version: 1.1.0
 - !ruby/object:Gem::Dependency
-  name: ofx-parser
+  name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.2'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.0
+        version: 4.2.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.2'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.0
+        version: 4.2.1
 - !ruby/object:Gem::Dependency
   name: virtus
   requirement: !ruby/object:Gem::Requirement
@@ -114,6 +114,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.80.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.80.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.4.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.4.2
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -175,8 +203,6 @@ files:
 - lib/eac/menus_helper/gui_builder.rb
 - lib/eac/model.rb
 - lib/eac/no_presence_validator.rb
-- lib/eac/parsers/files_test.rb
-- lib/eac/source_target_fixtures.rb
 - lib/eac/test_utils.rb
 - lib/eac_rails_utils.rb
 - lib/eac_rails_utils/engine.rb
@@ -204,14 +230,8 @@ files:
 - test/dummy/db/schema.rb
 - test/lib/eac/common_form_helper_test.rb
 - test/lib/eac/cpf_validator_test.rb
-- test/lib/eac/data_table_test_helper.rb
+- test/lib/eac/data_table_test_helper_test.rb
 - test/lib/eac/model_test.rb
-- test/lib/eac/parsers/files_test_test.rb
-- test/lib/eac/parsers/ok_test_files/a.source.yaml
-- test/lib/eac/parsers/ok_test_files/a.target.yaml
-- test/lib/eac/parsers/ok_test_files/b.source.yaml
-- test/lib/eac/parsers/ok_test_files/b.target.yaml
-- test/lib/eac/source_target_fixtures_test.rb
 - test/lib/eac/source_target_fixtures_test_files/a.source.html
 - test/lib/eac/source_target_fixtures_test_files/a.target.yaml
 - test/lib/eac/source_target_fixtures_test_files/b.source.html
@@ -243,37 +263,31 @@ signing_key:
 specification_version: 4
 summary: Código reutilizável para as aplicações Rails da E.A.C..
 test_files:
-- test/lib/eac_rails_utils/tableless_model_test.rb
-- test/lib/eac_rails_utils/patches/model_attribute_required_test.rb
-- test/lib/eac/source_target_fixtures_test.rb
-- test/lib/eac/data_table_test_helper.rb
-- test/lib/eac/cpf_validator_test.rb
-- test/lib/eac/model_test.rb
-- test/lib/eac/common_form_helper_test.rb
-- test/lib/eac/source_target_fixtures_test_files/a.target.yaml
-- test/lib/eac/source_target_fixtures_test_files/b.source.html
-- test/lib/eac/source_target_fixtures_test_files/c.target.yaml
-- test/lib/eac/source_target_fixtures_test_files/a.source.html
-- test/lib/eac/parsers/files_test_test.rb
-- test/lib/eac/parsers/ok_test_files/a.target.yaml
-- test/lib/eac/parsers/ok_test_files/b.source.yaml
-- test/lib/eac/parsers/ok_test_files/b.target.yaml
-- test/lib/eac/parsers/ok_test_files/a.source.yaml
-- test/dummy/config/routes.rb
+- test/dummy/Rakefile
+- test/dummy/config.ru
+- test/dummy/config/boot.rb
 - test/dummy/config/database.yml
 - test/dummy/config/secrets.yml
 - test/dummy/config/locales/pt-BR.yml
-- test/dummy/config/environment.rb
-- test/dummy/config/boot.rb
 - test/dummy/config/application.rb
 - test/dummy/config/environments/test.rb
-- test/dummy/Rakefile
-- test/dummy/config.ru
-- test/dummy/app/models/user.rb
-- test/dummy/app/models/job.rb
+- test/dummy/config/environment.rb
+- test/dummy/config/routes.rb
 - test/dummy/db/schema.rb
-- test/dummy/db/migrate/20160415125333_create_users.rb
 - test/dummy/db/migrate/20160415143123_create_jobs.rb
 - test/dummy/db/migrate/20160415143229_add_job_to_users.rb
-- test/app/helpers/eac_rails_utils/formatter_helper_test.rb
+- test/dummy/db/migrate/20160415125333_create_users.rb
+- test/dummy/app/models/job.rb
+- test/dummy/app/models/user.rb
 - test/test_helper.rb
+- test/app/helpers/eac_rails_utils/formatter_helper_test.rb
+- test/lib/eac_rails_utils/patches/model_attribute_required_test.rb
+- test/lib/eac_rails_utils/tableless_model_test.rb
+- test/lib/eac/common_form_helper_test.rb
+- test/lib/eac/data_table_test_helper_test.rb
+- test/lib/eac/cpf_validator_test.rb
+- test/lib/eac/source_target_fixtures_test_files/c.target.yaml
+- test/lib/eac/source_target_fixtures_test_files/b.source.html
+- test/lib/eac/source_target_fixtures_test_files/a.target.yaml
+- test/lib/eac/source_target_fixtures_test_files/a.source.html
+- test/lib/eac/model_test.rb