ea 0.6.4 → 0.6.6

data/lib/ea/svg/parity/corpus_report.rb

@@ -0,0 +1,83 @@
+# frozen_string_literal: true
+
+require "json"
+
+module Ea
+  module Svg
+    module Parity
+      # Renders every diagram of a Document and diffs it against the
+      # EA-authored reference export for that diagram (EAID_-named
+      # files), aggregating itemized deltas into a corpus report.
+      #
+      # References stay wherever EA published them (e.g. an EA "Save
+      # as image" directory); nothing is copied into the gem.
+      class CorpusReport
+        DELTA_KEYS = %i[extra_text missing_text moved_text wrong_font
+                        wrong_size wrong_weight].freeze
+
+        attr_reader :document, :ref_dir
+
+        def initialize(document:, ref_dir:)
+          @document = document
+          @ref_dir = ref_dir
+        end
+
+        # Returns { diagrams: [...], totals: {...} } and writes JSON
+        # when output_path is given.
+        def run(output_path: nil)
+          index = document.index_by_id
+          rows = diagrams_with_references.map do |diagram|
+            measure_one(diagram, index)
+          end.compact
+
+          result = { totals: totals(rows), diagrams: rows }
+          File.write(output_path, JSON.pretty_generate(result)) if output_path
+          result
+        end
+
+        private
+
+        def diagrams_with_references
+          document.diagrams.select { |d| reference_path_for(d) }
+        end
+
+        # EA publishes images as EAID_<guid-with-underscores>.svg;
+        # fall back to the raw diagram id for non-QEA sources.
+        def reference_path_for(diagram)
+          [
+            File.join(ref_dir, "EAID_#{diagram.id.tr('-', '_')}.svg"),
+            File.join(ref_dir, "#{Ea::Sources::Qea::IdNormalizer.to_eaid(diagram.id)}.svg"),
+            File.join(ref_dir, "#{diagram.id}.svg")
+          ].find { |p| File.exist?(p) }
+        end
+
+        def measure_one(diagram, index)
+          ref_path = reference_path_for(diagram)
+          return nil unless ref_path
+
+          ours = Ea::Svg::EaEmitter::Document.new(
+            diagram, model_index: index, document: document
+          ).render
+          differ = Differ.new(ours: ours, reference: File.read(ref_path))
+          deltas = differ.text_deltas
+
+          {
+            id: diagram.id, name: diagram.name,
+            deltas: DELTA_KEYS.to_h { |k| [k, deltas[k].size] },
+            shapes: differ.shape_summary.slice(:matched, :missing, :extra)
+          }
+        end
+
+        def totals(rows)
+          sum = DELTA_KEYS.to_h { |k| [k, 0] }
+          shapes = { matched: 0, missing: 0, extra: 0 }
+          rows.each do |row|
+            DELTA_KEYS.each { |k| sum[k] += row[:deltas][k] }
+            shapes.each_key { |k| shapes[k] += row[:shapes][k] }
+          end
+          sum.merge(shapes: shapes, diagrams: rows.size)
+        end
+      end
+    end
+  end
+end

data/lib/ea/svg/parity/differ.rb

@@ -0,0 +1,231 @@
+# frozen_string_literal: true
+
+require "nokogiri"
+
+module Ea
+  module Svg
+    module Parity
+      # Normalizes an EA-style SVG (ours or EA's own export — both use
+      # the same writer conventions) into a flat list of primitives,
+      # then reports itemized differences: missing/extra/moved texts,
+      # wrong fonts, shape geometry deltas.
+      #
+      # Primitives inherit fill/stroke from their wrapping <g style>
+      # since both writers emit one primitive per group.
+      class Differ
+        EPSILON = 0.51 # sub-pixel jitter is noise; EA writes 2 decimals
+        MATCH_DISTANCE = 6.0 # max centroid distance for shape pairing
+
+        attr_reader :ours, :reference
+
+        def initialize(ours:, reference:)
+          @ours = parse(ours)
+          @reference = parse(reference)
+          @shift = dominant_shift
+        end
+
+        # EA crops each published image to its own content bounds, so
+        # the two canvases differ by a per-diagram translation. Estimate
+        # it as the modal delta over content-matched texts and subtract
+        # it before comparing positions.
+        def dominant_shift
+          ref_by_content = @reference.select { |p| p[:kind] == :text }
+                                     .group_by { |p| p[:content] }
+          deltas = []
+          @ours.select { |p| p[:kind] == :text }.each do |ours|
+            ref = ref_by_content[ours[:content]]&.min_by { |c| distance(ours, c) }
+            next unless ref
+
+            deltas << [(ref[:x] - ours[:x]).round, (ref[:y] - ours[:y]).round]
+          end
+          return [0.0, 0.0] if deltas.empty?
+
+          deltas.tally.max_by { |_, count| count }.first.map(&:to_f)
+        end
+        private :dominant_shift
+
+        # --- primitive extraction -----------------------------------
+
+        def parse(svg)
+          doc = Nokogiri::XML(svg)
+          primitives = []
+          doc.css("g").each do |g|
+            g_style = g["style"] || ""
+            g.children.each do |node|
+              next unless node.element?
+
+              case node.name
+              when "text" then primitives << text_primitive(node, g_style)
+              when "rect" then primitives << rect_primitive(node, g_style)
+              when "polygon" then primitives << points_primitive(:polygon, node["points"], g_style)
+              when "line"
+                primitives << points_primitive(:line, "#{node['x1']} #{node['y1']} #{node['x2']} #{node['y2']}", g_style)
+              when "path" then primitives << path_primitive(node, g_style)
+              end
+            end
+          end
+          primitives
+        end
+        private :parse
+
+        def text_primitive(node, g_style)
+          style = node["style"] || ""
+          {
+            kind: :text,
+            x: float(node["x"]), y: float(node["y"]),
+            content: node.text.strip,
+            family: style[/font-family:([^;]+)/, 1],
+            size: style[/font-size:([^;]+)/, 1],
+            weight: normalize_weight(style[/font-weight:([^;]+)/, 1]),
+            style: style[/font-style:([^;]+)/, 1],
+            fill: style[/[^-]fill:([^;]+)/, 1] || g_style[/fill:([^;]+)/, 1]
+          }
+        end
+        private :text_primitive
+
+        def rect_primitive(node, g_style)
+          {
+            kind: :rect,
+            x: float(node["x"]), y: float(node["y"]),
+            width: float(node["width"]), height: float(node["height"]),
+            centroid: rect_centroid(node),
+            fill: g_style[/fill:([^;]+)/, 1],
+            stroke: g_style[/stroke:([^;]+)/, 1]
+          }
+        end
+        private :rect_primitive
+
+        def rect_centroid(node)
+          x = float(node["x"]); y = float(node["y"])
+          return [0.0, 0.0] if x.nil? || y.nil?
+
+          [x + float(node["width"]).to_f / 2, y + float(node["height"]).to_f / 2]
+        end
+        private :rect_centroid
+
+        def path_primitive(node, g_style)
+          points = (node["d"] || "").scan(/-?\d+(?:\.\d+)?/).each_slice(2)
+                                    .map { |(x, y)| [x.to_f, y.to_f] }
+          {
+            kind: :path, points: points,
+            centroid: centroid(points), closed: node["d"].to_s.include?("Z"),
+            stroke: g_style[/stroke:([^;]+)/, 1]
+          }
+        end
+        private :path_primitive
+
+        def points_primitive(kind, points_attr, g_style)
+          points = (points_attr || "").scan(/-?\d+(?:\.\d+)?/).each_slice(2)
+                                      .map { |(x, y)| [x.to_f, y.to_f] }
+          {
+            kind: kind, points: points, centroid: centroid(points),
+            stroke: g_style[/stroke:([^;]+)/, 1]
+          }
+        end
+        private :points_primitive
+
+        def centroid(points)
+          return [0.0, 0.0] if points.nil? || points.empty?
+
+          xs = points.map(&:first); ys = points.map(&:last)
+          [xs.sum / points.size, ys.sum / points.size]
+        end
+        private :centroid
+
+        def float(value)
+          value&.to_f
+        end
+        private :float
+
+        def normalize_weight(raw)
+          return "400" if raw.nil? || raw == "0"
+
+          raw
+        end
+        private :normalize_weight
+
+        # --- diffing -------------------------------------------------
+
+        # Texts pair on identical content; positions, family, size and
+        # weight are then compared directly.
+        def text_deltas
+          ref_by_content = @reference.select { |p| p[:kind] == :text }
+                                     .group_by { |p| p[:content] }
+          deltas = Hash.new { |h, k| h[k] = [] }
+
+          @ours.select { |p| p[:kind] == :text }.each do |ours|
+            candidates = ref_by_content[ours[:content]]
+            ref = candidates&.min_by { |c| distance(ours, c) }
+            if ref.nil?
+              deltas[:extra_text] << ours
+              next
+            end
+            candidates.delete(ref)
+
+            deltas[:moved_text] << ours if moved?(ours, ref)
+            deltas[:wrong_font] << [ours, ref] if ours[:family] != ref[:family]
+            deltas[:wrong_size] << [ours, ref] if ours[:size] != ref[:size]
+            deltas[:wrong_weight] << [ours, ref] if normalize_weight(ours[:weight]) != normalize_weight(ref[:weight])
+          end
+
+          unmatched = ref_by_content.values.flatten
+          deltas[:missing_text].concat(unmatched)
+          deltas
+        end
+
+        # Shapes pair greedily by centroid distance within the same
+        # kind; paired shapes count as equal when their bounding boxes
+        # agree within epsilon (routing bend-level diffs need the
+        # point-level comparison and are reported as count mismatches).
+        def shape_summary
+          our_shapes = @ours.reject { |p| p[:kind] == :text }
+                            .map { |p| shift_primitive(p) }
+          ref_shapes = @reference.reject { |p| p[:kind] == :text }
+
+          matched = 0
+          our_shapes.each do |ours|
+            ref = ref_shapes.min_by { |c| shape_distance(ours, c) }
+            next unless ref && shape_distance(ours, ref) <= MATCH_DISTANCE
+
+            ref_shapes.delete(ref)
+            matched += 1
+          end
+
+          {
+            our_shapes: our_shapes.size, ref_shapes: ref_shapes.size + matched,
+            matched: matched, missing: ref_shapes.size, extra: our_shapes.size - matched
+          }
+        end
+
+        def shift_primitive(p)
+          if p[:centroid]
+            p.merge(centroid: [p[:centroid][0] + @shift[0], p[:centroid][1] + @shift[1]])
+          else
+            p
+          end
+        end
+        private :shift_primitive
+
+        def shape_distance(a, b)
+          return Float::INFINITY unless a[:kind] == b[:kind]
+          return Float::INFINITY if a[:centroid].nil? || b[:centroid].nil?
+
+          ax, ay = a[:centroid]; bx, by = b[:centroid]
+          Math.sqrt(((ax - bx).abs**2) + ((ay - by).abs**2))
+        end
+        private :shape_distance
+
+        def moved?(ours, ref)
+          ((ours[:x] + @shift[0]) - ref[:x]).abs > EPSILON ||
+            ((ours[:y] + @shift[1]) - ref[:y]).abs > EPSILON
+        end
+        private :moved?
+
+        def distance(a, b)
+          Math.sqrt(((a[:x] - b[:x]).abs**2) + ((a[:y] - b[:y]).abs**2))
+        end
+        private :distance
+      end
+    end
+  end
+end

data/lib/ea/svg/parity.rb

@@ -7,6 +7,8 @@ module Ea
     # source format (.qea or .xmi) from specs or a rake task.
     module Parity
       autoload :Checker, "ea/svg/parity/checker"
+      autoload :CorpusReport, "ea/svg/parity/corpus_report"
+      autoload :Differ, "ea/svg/parity/differ"
       autoload :Suite, "ea/svg/parity/suite"
       autoload :Source, "ea/svg/parity/source"
     end

data/lib/ea/theme/definition.rb

@@ -44,10 +44,10 @@ module Ea
       DEFAULT_FRAME = FrameSpec.new(inset: 6, tab_height: 20, tab_slant: 13,
                                      tab_label_x: 11, tab_label_y: 19,
                                      tab_padding: 7).freeze
-      DEFAULT_COMPARTMENTS = CompartmentSpec.new(header_top_padding: 9,
+      DEFAULT_COMPARTMENTS = CompartmentSpec.new(header_top_padding: 12,
                                                    header_line_offset: 6,
                                                    divider_offset: 8,
-                                                   attr_line_offset: 4,
+                                                   attr_line_offset: 6,
                                                    attr_first_offset: 7,
                                                    op_line_offset: 4).freeze
       DEFAULT_ATTR = AttrSpec.new(visibility_x_offset: 5,
@@ -74,7 +74,7 @@ module Ea
                      stroke_in_text_color: "#000000",
                      element_border_width: 2, connector_line_width: 2,
                      divider_stroke_width: 2, marker_stroke_width: 2,
-                     text_width_factor: 0.65,
+                     text_width_factor: 0.612,
                      geometry: nil, frame: nil, compartments: nil,
                      attribute_spec: nil, markers: nil, package: nil,
                      note: nil, fills: {})

data/lib/ea/theme/loader.rb

@@ -86,10 +86,10 @@ module Ea
               tab_padding: frame["tab_padding"] || 7
             ),
             compartments: comps.empty? ? nil : Definition::CompartmentSpec.new(
-              header_top_padding: comps["header_top_padding"] || 9,
+              header_top_padding: comps["header_top_padding"] || 12,
               header_line_offset: comps["header_line_offset"] || 6,
               divider_offset: comps["divider_offset"] || 8,
-              attr_line_offset: comps["attr_line_offset"] || 4,
+              attr_line_offset: comps["attr_line_offset"] || 7,
               attr_first_offset: comps["attr_first_offset"] || 7,
               op_line_offset: comps["op_line_offset"] || 4
             ),

data/lib/ea/version.rb

@@ -4,5 +4,5 @@ module Ea
   # Gem release version. Extracted to its own file so the
   # `gem-release` tool's `gem bump` can find and update it via the
   # standard `lib/<gem>/version.rb` convention.
-  VERSION = "0.6.4"
+  VERSION = "0.6.6"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ea
 version: !ruby/object:Gem::Version
-  version: 0.6.4
+  version: 0.6.6
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-09-24 00:00:00.000000000 Z
+date: 2026-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lutaml-model
@@ -945,6 +945,8 @@ files:
 - lib/ea/svg/ea_emitter/visibility_symbol.rb
 - lib/ea/svg/parity.rb
 - lib/ea/svg/parity/checker.rb
+- lib/ea/svg/parity/corpus_report.rb
+- lib/ea/svg/parity/differ.rb
 - lib/ea/svg/parity/source.rb
 - lib/ea/svg/parity/suite.rb
 - lib/ea/svg/stereotype_color_resolver.rb