ea 0.3.1 → 0.5.0

data/TODO.fixup/70-tagged-values-compartment.md

@@ -0,0 +1,39 @@
+# 70 - Tagged Values Compartment Rendering
+
+## Status: COMPLETE (2026-07-26)
+
+## What changed
+
+1. `lib/ea/sources/xmi/tag_builder.rb` (NEW) — Parses
+   `<xmi:Extension>/<elements>/<element>/<tags>/<tag/>` blocks via
+   Nokogiri (the xmi gem doesn't expose Sparx tags directly).
+   Groups tags by their `modelElement` attribute and strips the
+   `#NOTES#...` suffix EA appends to the value attribute.
+
+2. `lib/ea/sources/xmi/adapter.rb` — Calls TagBuilder, attaches the
+   resulting TaggedValue arrays to the owning Classifier and
+   Package objects. Handles the EAPK_↔EAID_ alias for packages.
+
+3. `lib/ea/svg/ea_emitter/element/tagged_value_renderer.rb` (NEW) —
+   Emits an italic "tags" header followed by `key = value` lines
+   for each tagged value, matching EA's encoding.
+
+4. `lib/ea/svg/ea_emitter/elements.rb` —
+   `groups_for` now invokes `TaggedValueRenderer` when the
+   classifier has tagged_values. `CompartmentGeometry` gains
+   `tagged_values_count` + `tagged_value_first_y`.
+   `has_content_below_header?` now treats tagged values as
+   content (so the divider renders).
+
+5. `lib/ea/svg/ea_emitter/element.rb` — autoload for
+   TaggedValueRenderer.
+
+6. `lib/ea/sources/xmi.rb` — autoload for TagBuilder.
+
+## Acceptance
+
+- AcmeUmlClass in simple.xmi renders the "tags" header plus
+  isCollection and noPropertyType lines.
+- Text count on diagrams with tagged classifiers increases
+  proportionally.
+- All 2285 specs pass.

data/TODO.fixup/71-auto-detect-theme-from-xmi.md

@@ -0,0 +1,37 @@
+# 71 - Auto-Detect Theme from QEA StyleEx via XMI
+
+## Status: COMPLETE (2026-07-26)
+
+## What changed
+
+`lib/ea/sources/xmi/diagram_builder.rb` — `build_one` now reads
+`ext_diagram.style2.value` and assigns it to the Diagram's
+`style_ex` attribute. EA stores StyleEx in the XMI's `<style2>`
+element (alongside Style1 in `<style1>`). The value carries
+`Theme=:119`, `SuppressFOC=1`, `AttPkg=1`, etc. — the same shape
+the Diagram model already parses via `style_ex_flags` and
+`display_config`.
+
+This means: diagrams from sample XMI files now auto-resolve Theme
+:119 (Carlito 7pt) without any manual theme setting.
+
+## What was wrong before
+
+The Xmi adapter was dropping `style2` entirely, so `style_ex` was
+always nil. The Theme system worked correctly given a StyleEx
+string — there was just no code path populating StyleEx from XMI.
+
+## Acceptance
+
+- simple.xmi "Package Contents" auto-detects Carlito 7pt without
+  any manual intervention (previously emitted Calibri 13px).
+- New spec asserts that `diagram.style_ex` includes "Theme=:119"
+  and `diagram.theme.font_family` equals "Carlito".
+- All 2286 specs pass.
+
+## Why Option A from the original TODO was wrong
+
+The original TODO assumed XMI omitted StyleEx and proposed
+heuristic detection from element styles. In reality, XMI DOES
+carry StyleEx via the style2 element — the previous Xmi adapter
+was simply dropping it.

data/TODO.fixup/72-sample-exports-as-regression-specs.md

@@ -0,0 +1,37 @@
+# 72 - Use Sample Exports as Regression Specs
+
+## Status: COMPLETE (2026-07-26)
+
+## What changed
+
+`spec/ea/svg/sample_exports_regression_spec.rb` (NEW) — renders
+every diagram from `examples/exports/*/model.xml` (220 diagrams
+across 5 sample projects) and compares total shape counts
+(rect + polygon + path) against the corresponding reference SVG
+in `examples/exports/*/images/`.
+
+Two specs:
+1. "matches reference element counts within tolerance for most
+   diagrams" — asserts at least 60% of diagrams are within 20%
+   (or 5, whichever is larger) of the reference total.
+2. "renders every diagram without raising" — runs the emitter on
+   every diagram and asserts no exceptions.
+
+## Current parity (measured by this spec)
+
+- 178/220 diagrams within tolerance (81%)
+- 42 diagrams over tolerance (mostly plateau diagrams with 6-18
+  element delta)
+
+## Why combined rect+polygon+path
+
+EA swaps rect↔polygon based on shape type (Classifier=rect,
+Package=polygon). Comparing each shape count independently would
+double-penalize shape-type swaps that are actually correct. The
+combined total reflects "did we emit the right number of shapes?"
+
+## Acceptance
+
+- Spec covers all 220 sample diagrams.
+- Passes at >60% threshold (currently 81%).
+- Reports first 5 failures when threshold not met.

data/TODO.fixup/73-delete-dead-transformations.md

@@ -0,0 +1,14 @@
+# 73 - Delete dead Transformations subsystem
+
+## Status: COMPLETE (2026-07-26)
+
+Removed `lib/ea/transformations/parsers/` (BaseParser, QeaParser,
+XmiParser), `format_registry.rb`, `transformation_engine.rb`,
+`configuration.rb`, plus their specs.
+
+Production entry points (`Ea::Transformations.parse` and `.to_uml`)
+already bypassed these wrappers and called `Ea::Qea.load`,
+`Ea::Xmi.load`, and `Ea::Bridge::*` directly. The "engine" layer was
+dead weight that only specs referenced.
+
+Slimmed `lib/ea/transformations.rb` from 130 lines to 47.

data/TODO.fixup/74-delete-dead-diagram-renderers.md

@@ -0,0 +1,18 @@
+# 74 - Delete dead Diagram legacy renderers
+
+## Status: COMPLETE (2026-07-26)
+
+Removed `lib/ea/diagram/{svg_renderer, layout_engine, style_parser,
+path_builder, style_resolver, configuration, util, element_renderers,
+extractor}.rb` plus their specs. These served the legacy
+lutaml-uml-backed rendering pipeline that was already replaced by
+`Ea::Svg::EaEmitter`.
+
+Kept:
+- `lib/ea/diagram/display_config.rb` — used by `Ea::Model::Diagram`
+- (extractor moved to modern pipeline; see below)
+
+Rewrote `lib/ea/cli/command/diagrams.rb` `extract` action to use
+`Ea::Sources::{Qea,Xmi}::Adapter` + `Ea::Svg::EaEmitter::Document`
+directly, removing its dependency on lutaml-uml/Repository. The
+`list` action now uses the same modern adapters.

data/TODO.fixup/75-visibility-legend-icons.md

@@ -0,0 +1,23 @@
+# 75 - Visibility legend icons
+
+## Status: WONTFIX (2026-07-26)
+
+## Original hypothesis
+
+101 plateau diagrams were missing 3-4 small 17×17 rects per
+diagram. Originally believed to be auto-generated visibility toggle
+icons that EA emits as a column of color swatches.
+
+## Investigation finding
+
+The 17×17 rects are actually manually-authored Note element content
+(legend color swatches), not auto-generated UI elements. The Note
+element's body text describes what each color represents (e.g.,
+"GML classes", "CityGML classes"). Implementing this generically
+would require parsing Note element intent, which is diagram-specific.
+
+## Resolution
+
+Closed as wontfix. The Note element rendering (TODO 78) handles the
+container; the legend swatches inside are user-authored content
+that flows from the Note body via future layout work.

data/TODO.fixup/76-plateau-text-undershoot.md

@@ -0,0 +1,27 @@
+# 76 - Plateau text undershoot investigation
+
+## Status: COMPLETE (2026-07-26)
+
+## Root cause
+
+`DisplayConfig` was mis-mapping `SuppressFOC=1` (suppress foreign
+object content — embedded images/OLE) to "suppress feature
+compartments" (attributes/operations). 60 percent of plateau
+diagrams have `SuppressFOC=1` in their StyleEx, so they were
+rendering without attribute compartments — losing 10-100+ text
+elements per diagram.
+
+## Fix
+
+Decoupled `show_attributes?` and `show_operations?` from
+`SuppressFOC`. They now correctly check Style1 `HideAtts=1` and
+`HideOps=1` (the actual EA UI flags for hiding compartments).
+
+Restructured DisplayConfig to take both Style (style1) and StyleEx
+(style2) since the visibility flags are split across both columns in
+t_diagram.
+
+## Impact
+
+Sample parity jumped from 178/220 (81 percent) to 193/220
+(88 percent). The biggest single fix in this round.

data/TODO.fixup/77-canvas-frame-margins.md

@@ -0,0 +1,28 @@
+# 77 - Canvas frame margins and connector Path= semantics
+
+## Status: PARTIAL (2026-07-26)
+
+## What changed
+
+`ConnectorRouter#waypoints` was treating `Path=` values as relative
+deltas from the source point, applying `src_pt + (dx, dy)`. The
+`ExtensionGeometryParser` documentation says (and EA reference SVGs
+confirm) these are ABSOLUTE pixel positions on the canvas.
+
+Fixed by using bend points as-is. Plateau diagrams that had
+connector endpoints at x=2700+ (vs element bounds max=1463) now
+route correctly.
+
+## What remains
+
+The canvas size still doesn't perfectly match the reference — EA
+uses non-uniform frame margins (left=35, right=50, top=60,
+bottom=36) plus a per-diagram "DocSize" override. Our
+BoundsCalculator uses uniform 10px padding plus 20px reserved for
+Package tabs.
+
+Closing the remaining gap requires either:
+1. Parsing t_diagram.cx/cy fields for explicit canvas dimensions
+2. Hard-coding EA's non-uniform frame insets per diagram type
+
+Deferred until more parity work justifies it.

data/TODO.fixup/78-note-element-rendering.md

@@ -0,0 +1,30 @@
+# 78 - Note element rendering
+
+## Status: COMPLETE (2026-07-26)
+
+## What changed
+
+- New `Ea::Model::Note` class (id, name, body, note_type)
+- New `NoteBuilder` extracts Notes from `<xmi:Extension>/<elements>`
+  via `ext_element.type == "uml:Note"`. The note body comes from
+  `<properties documentation="..."/>`.
+- `Document` gains a `notes` collection; `index_by_id` includes
+  them so diagram element `subject=EAID_...` refs resolve.
+- New `Element::NoteShapeRenderer` emits:
+  - Folded-corner polygon (top-right corner cut)
+  - Diagonal fold line marking the dog-ear
+  - Body text with naive char-count-based word wrap
+- `Elements#render_shape` dispatches to `NoteShapeRenderer` when
+  the model element `is_a?(Ea::Model::Note)`.
+
+## Acceptance
+
+- Plateau document parses 27 Notes (was 0 before).
+- 4 diagrams that place Notes on the canvas now render them.
+- All 1596 specs pass.
+
+## Limitations
+
+Text wrapping uses character count, not GDI text metrics. EA uses
+the latter for accurate wrap points; matching it would require
+platform-specific font metric tables.

data/TODO.fixup/79-operation-compartment-rendering.md

@@ -0,0 +1,27 @@
+# 79 - Operation compartment text rendering
+
+## Status: ANALYZED (2026-07-26)
+
+## Current state
+
+`OperationRenderer` exists and emits operation signatures as text
+lines. `Elements#groups_for` invokes it when the classifier has
+operations AND `show_operations?` is true.
+
+The Plateau parity failures showed large text over-rendering
+(+68 on Tunnel diagram). Investigation revealed:
+
+1. We render `«DataType»` stereotype labels for every classifier
+   with a stereotype — ref SVGs only show stereotypes for some.
+2. We render the `tags` compartment + tagged value lines for every
+   classifier with tagged values — ref only shows them on 2/220
+   diagrams.
+
+Both are visibility rule gaps, not Operation-specific bugs. The
+OperationRenderer itself works correctly when invoked.
+
+## Why deferred
+
+The actual rendering is correct; the gap is in WHEN to render.
+Closing it requires understanding EA's stereotype-tagged-value
+visibility rule (TODO 80).

data/TODO.fixup/80-tagged-value-stereotype-visibility.md

@@ -0,0 +1,37 @@
+# 80 - Tagged value and stereotype visibility rules
+
+## Status: TODO
+
+## Context
+
+Only 2 of 220 reference SVGs in `examples/exports/` render a
+"tags" header compartment, even though most plateau elements have
+`Tag=1` in their per-element style and most classifiers have
+tagged values from stereotype applications.
+
+Likewise, the simple.xmi "Package A.1.1" reference shows
+`«DataType»` for AcmeUmlClass, but the plateau Tunnel reference
+does NOT show `«DataType»` for classifiers that also have
+`stereotype="DataType"`.
+
+## What needs to change
+
+1. **Tagged value visibility rule**: Determine when EA actually
+   renders the tags compartment. Likely factors:
+   - Stereotype source (profile-applied vs user-defined tagged values)
+   - Element style `Tag=` flag semantics (currently parsed but unused)
+   - Diagram Style1 `ShowTags=` flag interaction
+
+2. **Stereotype label visibility rule**: Determine when EA renders
+   the `«Stereotype»` label. Hypotheses to verify:
+   - Ref SVGs show stereotypes only when the classifier is NOT
+     a "primitive" type or abstract base
+   - Show stereotypes only when they come from a non-default profile
+   - Show only when `HideElemStereo=0` AND the element is in a
+     specific diagram type
+
+## Acceptance
+
+- Visibility rules documented with concrete EA behavior citations
+- Implementation gates tagged value + stereotype rendering
+- Sample parity improves from 88 percent toward 95 percent+

data/TODO.fixup/81-figure-parity-current-state.md

@@ -0,0 +1,63 @@
+# 81 - Figure parity current state and roadmap
+
+## Status: LIVING DOCUMENT (2026-07-26)
+
+## Where we are
+
+- **193/220 sample diagrams (88%)** render within shape-count
+  tolerance of EA's reference SVGs.
+- **1596 specs, all passing.**
+- **Major code cleanup**: removed 695 legacy spec examples and
+  ~3000 lines of dead production code (Transformations engine,
+  Diagram legacy renderers).
+
+## What's working
+
+- Theme system auto-detects Theme=:119 (Carlito 7pt) from XMI
+  style2 attribute.
+- DisplayConfig correctly reads HideAtts/HideOps (Style1) and
+  SuppressFOC/AttPub (StyleEx) as separate concerns.
+- Packages render as polygon body+tab (matching EA folder shape).
+- Notes render as folded-corner rect with body text.
+- Tagged values render when classifier has them.
+- Connector Path= coordinates treated as absolute (matching EA
+  reference SVG geometry).
+- Per-element Tag flag, EAPK↔EAID alias for package lookups,
+  frame border+tab always rendered.
+
+## What's still off (and where the 12% gap lives)
+
+### 1. Stereotype label visibility (TODO 80)
+We render `«DataType»` for every classifier with a stereotype,
+but reference SVGs only render some. The rule appears to be
+profile-specific (GML stereotypes shown, others hidden) but not
+yet characterized.
+
+### 2. Tagged value visibility (TODO 80)
+Only 2/220 reference diagrams show the "tags" compartment, but
+we render it on every classifier with tagged values. Likely
+tied to the same stereotype visibility rule.
+
+### 3. Canvas size non-parity (TODO 77)
+Our canvas is ~40px narrower and ~26px shorter than reference
+due to non-uniform EA frame margins (left=35, right=50, top=60,
+bottom=36). Functional but visually offset.
+
+### 4. Visibility toggle icons (TODO 75 — wontfix)
+3-4 small 17×17 colored rects appear on a few diagrams as
+manually-authored Note element legend content. Not a generic
+feature; closed as wontfix.
+
+## Next high-value investigations
+
+1. **Compare ref SVGs element-by-element** to characterize the
+   stereotype visibility rule. Likely factors: element style
+   `Tag=`, HideElemStereo, stereotype FQName prefix.
+
+2. **Parse t_diagram.cx/cy** (canvas dimensions stored in QEA,
+   lost in XMI export) for exact canvas sizing. XMI uses DocSize
+   which is paper-size, not pixel-canvas.
+
+3. **Wire QEA loader to skip XMI** — parsing QEA directly gives
+   StyleEx, exact element positions, and tagged value scopes
+   that the XMI export loses.