e_way_client 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 41dcf6cbd4f4efaeb6ed7d5192a3ae5ebe05219a
-  data.tar.gz: 313a0c20df81dc1ca32dc673e9a752a95366b7ed
+  metadata.gz: 3e658e180737871960d98e2b7160808938645c40
+  data.tar.gz: 41fdb507f076b856267692cb1bff2aaf72a697ab
 SHA512:
-  metadata.gz: 76fb5c720604b59135bdbd8b41d031ae71105b505aebbc851913536cfe8b70251d374b3d99e0b2a44150a75032909371ad1f6bf58f16452fed76c5d87a1262c5
-  data.tar.gz: 5e66413f38935b7ae90bc597ca16d524d88275ed2c2367837a4dcbd8cf8998482bde210d114672e577aa8c4a26ce3327d1f47b773857322ff90516511f1dd9f2
+  metadata.gz: 26fcc585b285c9cb787594ccec178478e88a58b13fb32d9f5dc1ecc8d75312869b591619b04ab95d51f5e89e85f40ac235ef4e4136a04a20cad133c826a06e77
+  data.tar.gz: 6bcf7cf6eaf1495acc8c6e03d9eb82e178822c71c74ada1977ea9de1fde823125351568d9423d136efe0092dfecf164a84f9a7c6d9aac514b1be46e5cc362890

data/CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [0.1.1] - 2017-01-09
+### Fixed
+- Do not blow up if `diffgram` in XML response is missing. Return nil instead.
+
 ## [0.1.0] - 2016-12-31
 ### Added
 - Initial release

data/lib/e_way_client/models/province.rb

@@ -24,7 +24,7 @@ module EWayClient
     attribute :districts, Array[String], lazy: true, default: :default_districts
     TYPES_COUNT.times do |n|
       count = n+1
-      attribute(:"districts#{count}", Array[String], {
+      attribute(:"districts#{count}", String, {
         lazy: true,
         default: :"default_districts#{count}",
       })

data/lib/e_way_client/responses/base_response.rb

@@ -3,6 +3,23 @@ module EWayClient
 
     include APIClientBase::Response.module
     attribute :success, Boolean, lazy: true, default: :default_success
+    attribute :data, Object, lazy: true, default: :default_data
+
+    private
+
+    def default_data
+      raw_response.body.deep_fetch(
+        :"#{action_slug}_response",
+        :"#{action_slug}_result",
+        :diffgram,
+        :document_element,
+        action_slug,
+      ) { nil }
+    end
+
+    def action_slug
+      self.class.name.demodulize.gsub("Response", "").underscore.to_sym
+    end
 
   end
 end

data/lib/e_way_client/responses/query_list_banks_response.rb

@@ -1,21 +1,10 @@
 module EWayClient
   class QueryListBanksResponse < BaseResponse
 
-    attribute :data, Object, lazy: true, default: :default_data
     attribute :banks, Array, lazy: true, default: :default_banks
 
     private
 
-    def default_data
-      raw_response.body.deep_fetch(*%i[
-        query_list_banks_response
-        query_list_banks_result
-        diffgram
-        document_element
-        query_list_banks
-      ])
-    end
-
     def default_banks
       data.map { |hash| Bank.new(hash) }
     end

data/lib/e_way_client/responses/query_list_provinces_response.rb

@@ -1,21 +1,10 @@
 module EWayClient
   class QueryListProvincesResponse < BaseResponse
 
-    attribute :data, Object, lazy: true, default: :default_data
     attribute :provinces, Array, lazy: true, default: :default_provinces
 
     private
 
-    def default_data
-      raw_response.body.deep_fetch(*%i[
-        query_list_provinces_response
-        query_list_provinces_result
-        diffgram
-        document_element
-        query_list_provinces
-      ])
-    end
-
     def default_provinces
       data.map { |hash| Province.new(hash) }
     end

data/lib/e_way_client/responses/send_transaction_response.rb

@@ -32,7 +32,6 @@ module EWayClient
       "6006" => "Sender country is blank",
     }
 
-    attribute :data, Object, lazy: true, default: :default_data
     attribute(:response_code, String, {
       lazy: true,
       default: :default_response_code,
@@ -44,16 +43,6 @@ module EWayClient
 
     private
 
-    def default_data
-      raw_response.body.deep_fetch(*%i[
-        send_transaction_response
-        send_transaction_result
-        diffgram
-        document_element
-        send_transaction
-      ])
-    end
-
     def default_success
       response_code == SUCCESS_RESPONSE_CODE
     end

data/lib/e_way_client/version.rb

@@ -1,3 +1,3 @@
 module EWayClient
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: e_way_client
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Ramon Tayag
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-12-31 00:00:00.000000000 Z
+date: 2017-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus