dynflow 1.8.2 → 1.8.4

data/test/redis_locking_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative 'test_helper'
 require 'mocha/minitest'
 require 'minitest/stub_const'

data/test/rescue_test.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
+
 require_relative 'test_helper'
 
 module Dynflow
   module RescueTest
     describe 'on error' do
-
       Example = Support::RescueExample
 
       let(:world) { WorldFactory.create_world }
@@ -21,7 +21,6 @@ module Dynflow
 
       describe 'no auto rescue' do
         describe 'of simple skippable action in run phase' do
-
           let :execution_plan do
             execute(Example::ActionWithSkip, 1, :error_on_run)
           end
@@ -36,7 +35,6 @@ module Dynflow
         end
 
         describe 'of simple skippable action in finalize phase' do
-
           let :execution_plan do
             execute(Example::ActionWithSkip, 1, :error_on_finalize)
           end
@@ -51,7 +49,6 @@ module Dynflow
         end
 
         describe 'of complex action with skips in run phase' do
-
           let :execution_plan do
             execute(Example::ComplexActionWithSkip, :error_on_run)
           end
@@ -66,7 +63,6 @@ module Dynflow
         end
 
         describe 'of complex action with skips in finalize phase' do
-
           let :execution_plan do
             execute(Example::ComplexActionWithSkip, :error_on_finalize)
           end
@@ -81,7 +77,6 @@ module Dynflow
         end
 
         describe 'of complex action without skips' do
-
           let :execution_plan do
             execute(Example::ComplexActionWithoutSkip, :error_on_run)
           end
@@ -96,7 +91,6 @@ module Dynflow
         end
 
         describe 'of complex action with fail' do
-
           let :execution_plan do
             execute(Example::ComplexActionWithFail, :error_on_run)
           end
@@ -112,7 +106,6 @@ module Dynflow
       end
 
       describe 'auto rescue' do
-
         let(:world) do
           WorldFactory.create_world do |config|
             config.auto_rescue = true
@@ -127,8 +120,8 @@ module Dynflow
           it 'skips the action and continues' do
             _(rescued_plan.state).must_equal :stopped
             _(rescued_plan.result).must_equal :warning
-            _(rescued_plan.entry_action.output[:message]).
-              must_equal "skipped because some error as you wish"
+            _(rescued_plan.entry_action.output[:message])
+              .must_equal "skipped because some error as you wish"
           end
         end
 
@@ -215,7 +208,6 @@ module Dynflow
             _(execution_plan.execution_history.map { |h| [h.name, h.world_id] }).must_equal(expected_history)
           end
         end
-
       end
     end
   end

data/test/round_robin_test.rb

@@ -1,5 +1,6 @@
 # -*- coding: utf-8 -*-
 # frozen_string_literal: true
+
 require_relative 'test_helper'
 
 module Dynflow

data/test/semaphores_test.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
+
 require_relative 'test_helper'
 
 module Dynflow
   module SemaphoresTest
     describe ::Dynflow::Semaphores::Stateful do
-
       let(:semaphore_class) { ::Dynflow::Semaphores::Stateful }
       let(:tickets_count) { 5 }
 
@@ -41,7 +41,6 @@ module Dynflow
         waiting = semaphore.get_waiting
         _(waiting).must_equal 3
       end
-
     end
 
     describe ::Dynflow::Semaphores::Dummy do
@@ -71,10 +70,10 @@ module Dynflow
         }
       end
 
-      def assert_semaphore_state(semaphore, state_A, state_B)
-        _(semaphore.children[:child_A].free).must_equal state_A
-        _(semaphore.children[:child_B].free).must_equal state_B
-        _(semaphore.free).must_equal [state_A, state_B].min
+      def assert_semaphore_state(semaphore, state_a, state_b)
+        _(semaphore.children[:child_A].free).must_equal state_a
+        _(semaphore.children[:child_B].free).must_equal state_b
+        _(semaphore.free).must_equal [state_a, state_b].min
       end
 
       it 'can be used as counter' do
@@ -94,6 +93,5 @@ module Dynflow
         assert_semaphore_state semaphore, 0, 0
       end
     end
-
   end
 end

data/test/support/code_workflow_example.rb

@@ -1,11 +1,10 @@
 # frozen_string_literal: true
+
 require 'logger'
 
 module Support
   module CodeWorkflowExample
-
     class IncomingIssues < Dynflow::Action
-
       def plan(issues)
         issues.each do |issue|
           plan_action(IncomingIssue, issue)
@@ -36,7 +35,6 @@ module Support
     end
 
     class IncomingIssue < Dynflow::Action
-
       def plan(issue)
         raise "You want me to fail" if issue == :fail
         plan_self(issue)
@@ -47,18 +45,16 @@ module Support
         param :author, String
         param :text, String
       end
-
     end
 
     class Triage < Dynflow::Action
-
       def plan(issue)
         triage = plan_self(issue)
         plan_action(UpdateIssue,
-                    author:   triage.input[:author],
-                    text:     triage.input[:text],
-                    assignee: triage.output[:classification][:assignee],
-                    severity: triage.output[:classification][:severity])
+          author:   triage.input[:author],
+          text:     triage.input[:text],
+          assignee: triage.output[:classification][:assignee],
+          severity: triage.output[:classification][:severity])
       end
 
       input_format do
@@ -84,11 +80,9 @@ module Support
         error! 'Trolling detected' if input[:text] == "trolling in finalize"
         TestExecutionLog.finalize << self
       end
-
     end
 
     class UpdateIssue < Dynflow::Action
-
       input_format do
         param :author, String
         param :text, String
@@ -101,7 +95,6 @@ module Support
     end
 
     class NotifyAssignee < Dynflow::Action
-
       def self.subscribe
         Triage
       end
@@ -137,15 +130,14 @@ module Support
           end
 
           plan_action(Merge,
-                      commit:         commit,
-                      ci_result:      ci.output[:passed],
-                      review_results: review_actions.map { |ra| ra.output[:passed] })
+            commit:         commit,
+            ci_result:      ci.output[:passed],
+            review_results: review_actions.map { |ra| ra.output[:passed] })
         end
       end
     end
 
     class FastCommit < Dynflow::Action
-
       def plan(commit)
         sequence do
           ci, review = concurrence do
@@ -154,20 +146,18 @@ module Support
           end
 
           plan_action(Merge,
-                      commit:         commit,
-                      ci_result:      ci.output[:passed],
-                      review_results: [review.output[:passed]])
+            commit:         commit,
+            ci_result:      ci.output[:passed],
+            review_results: [review.output[:passed]])
         end
       end
 
       input_format do
         param :sha, String
       end
-
     end
 
     class Ci < Dynflow::Action
-
       input_format do
         param :commit, Commit.input_format
       end
@@ -182,7 +172,6 @@ module Support
     end
 
     class Review < Dynflow::Action
-
       input_format do
         param :reviewer, String
         param :commit, Commit.input_format
@@ -202,7 +191,6 @@ module Support
     end
 
     class Merge < Dynflow::Action
-
       input_format do
         param :commit, Commit.input_format
         param :ci_result, Ci.output_format
@@ -233,25 +221,21 @@ module Support
     end
 
     class DummySubscribe < Dynflow::Action
-
       def self.subscribe
         DummyTrigger
       end
 
       def run
       end
-
     end
 
     class DummyMultiSubscribe < Dynflow::Action
-
       def self.subscribe
         [DummyTrigger, DummyAnotherTrigger]
       end
 
       def run
       end
-
     end
 
     class CancelableSuspended < Dynflow::Action
@@ -301,6 +285,5 @@ module Support
         external_task && external_task[:progress].to_f / 100
       end
     end
-
   end
 end

data/test/support/dummy_example.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'logger'
 
 module Support
@@ -24,6 +25,7 @@ module Support
       def delay(delay_options, *args)
         MySerializer.new(args)
       end
+
       def run; end
     end
 
@@ -43,7 +45,7 @@ module Support
         sleep input[:interval]
         action_logger.debug 'done with sleeping'
         $slow_actions_done ||= 0
-        $slow_actions_done +=1
+        $slow_actions_done += 1
       end
 
       def queue
@@ -87,7 +89,6 @@ module Support
     end
 
     class WeightedPolling < Dynflow::Action
-
       def plan(input)
         sequence do
           plan_self(input)
@@ -148,23 +149,23 @@ module Support
     class ComposedAction < Dynflow::Action
       def run(event = nil)
         match event,
-              (on nil do
-                 sub_plan = world.trigger(Dummy)
-                 output[:sub_plan_id] = sub_plan.id
-                 suspend do |suspended_action|
-                   if input[:timeout]
-                     world.clock.ping suspended_action, input[:timeout], "timeout"
-                   end
-
-                   sub_plan.finished.on_fulfillment! { suspended_action << 'finish' }
-                 end
-               end),
-              (on 'finish' do
-                 output[:event] = 'finish'
-               end),
-              (on 'timeout' do
-                 output[:event] = 'timeout'
-               end)
+          (on nil do
+             sub_plan = world.trigger(Dummy)
+             output[:sub_plan_id] = sub_plan.id
+             suspend do |suspended_action|
+               if input[:timeout]
+                 world.clock.ping suspended_action, input[:timeout], "timeout"
+               end
+
+               sub_plan.finished.on_fulfillment! { suspended_action << 'finish' }
+             end
+           end),
+          (on 'finish' do
+             output[:event] = 'finish'
+           end),
+          (on 'timeout' do
+             output[:event] = 'timeout'
+           end)
       end
     end
   end

data/test/support/middleware_example.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
+
 module Support
   module MiddlewareExample
     class LogMiddleware < Dynflow::Middleware
-
       def self.log
         @log
       end
@@ -17,7 +17,7 @@ module Support
 
       def delay(*args)
         log 'before_delay'
-        pass *args
+        pass(*args)
         log 'after_delay'
       end
 
@@ -51,11 +51,9 @@ module Support
         pass
         log 'after_finalize_phase'
       end
-
     end
 
     class LogRunMiddleware < Dynflow::Middleware
-
       def log(message)
         LogMiddleware.log << "#{self.class.name[/\w+$/]}::#{message}"
       end
@@ -105,7 +103,6 @@ module Support
     end
 
     class LoggingAction < Dynflow::Action
-
       middleware.use LogMiddleware
 
       def log(message)
@@ -132,7 +129,6 @@ module Support
     end
 
     class ObservingMiddleware < Dynflow::Middleware
-
       def log(message)
         LogMiddleware.log << message
       end
@@ -146,7 +142,6 @@ module Support
     end
 
     class AnotherObservingMiddleware < ObservingMiddleware
-
       def delay(*args)
         pass(*args).tap do
           log("delay#set-input:#{action.world.id}")
@@ -158,7 +153,6 @@ module Support
         log("plan#input:#{action.input[:message]}")
         pass(*args)
       end
-
     end
 
     class Action < Dynflow::Action

data/test/support/rescue_example.rb

@@ -1,11 +1,10 @@
 # frozen_string_literal: true
+
 require 'logger'
 
 module Support
   module RescueExample
-
     class ComplexActionWithSkip < Dynflow::Action
-
       def plan(error_state)
         sequence do
           concurrence do
@@ -20,20 +19,16 @@ module Support
       def rescue_strategy_for_self
         Dynflow::Action::Rescue::Skip
       end
-
     end
 
     class ComplexActionWithoutSkip < ComplexActionWithSkip
-
       def rescue_strategy_for_planned_action(action)
         # enforce pause even when error on skipable action
         Dynflow::Action::Rescue::Pause
       end
-
     end
 
     class AbstractAction < Dynflow::Action
-
       def plan(identifier, desired_state)
         plan_self(identifier: identifier, desired_state: desired_state)
       end
@@ -57,11 +52,9 @@ module Support
           raise 'some error as you wish'
         end
       end
-
     end
 
     class ActionWithSkip < AbstractAction
-
       def run(event = nil)
         if event === Dynflow::Action::Skip
           output[:message] = "skipped because #{self.error.message}"
@@ -74,19 +67,15 @@ module Support
       def rescue_strategy_for_self
         Dynflow::Action::Rescue::Skip
       end
-
     end
 
     class ActionWithFail < AbstractAction
-
       def rescue_strategy_for_self
         Dynflow::Action::Rescue::Fail
       end
-
     end
 
     class ComplexActionWithFail < ActionWithFail
-
       def plan(error_state)
         sequence do
           concurrence do
@@ -97,8 +86,6 @@ module Support
           plan_action(ActionWithSkip, 6, :success)
         end
       end
-
     end
-
   end
 end

data/test/support/test_execution_log.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
-class TestExecutionLog
 
+class TestExecutionLog
   include Enumerable
 
   def initialize
@@ -38,5 +38,4 @@ class TestExecutionLog
   def self.finalize
     @finalize || []
   end
-
 end

data/test/test_helper.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'bundler/setup'
 require 'minitest/reporters'
 require 'minitest/autorun'
@@ -13,7 +14,6 @@ $LOAD_PATH << load_path unless $LOAD_PATH.include? load_path
 require 'dynflow'
 require 'dynflow/testing'
 begin require 'pry'; rescue LoadError; nil end
-
 require 'support/code_workflow_example'
 require 'support/middleware_example'
 require 'support/rescue_example'
@@ -24,7 +24,6 @@ Concurrent.disable_at_exit_handlers!
 
 # To be able to stop a process in some step and perform assertions while paused
 class TestPause
-
   def self.setup
     @pause = Concurrent::Promises.resolvable_future
     @ready = Concurrent::Promises.resolvable_future
@@ -78,7 +77,6 @@ class CoordiationAdapterWithLog < Dynflow::CoordinatorAdapters::Sequel
 end
 
 module WorldFactory
-
   def self.created_worlds
     @created_worlds ||= []
   end
@@ -129,7 +127,7 @@ module WorldFactory
   def self.clean_coordinator_records
     persistence_adapter = WorldFactory.persistence_adapter
     persistence_adapter.find_coordinator_records({}).each do |w|
-      warn "Unexpected coordinator record: #{ w }"
+      warn "Unexpected coordinator record: #{w}"
       persistence_adapter.delete_coordinator_record(w[:class], w[:id])
     end
   end
@@ -230,7 +228,7 @@ module TestHelpers
                   'terminate execution',
                   'start execution',
                   'finish execution'],
-                 plan.execution_history.map(&:name)
+      plan.execution_history.map(&:name)
     refute_equal plan.execution_history.first.world_id, plan.execution_history.to_a.last.world_id
   end
 end
@@ -302,7 +300,6 @@ events_test = -> do
       wait_method.bind(self).call(timeout || default_timeout)
     end
   end
-
 end
 
 events_test.call
@@ -331,7 +328,6 @@ class ConcurrentRunTester
 end
 
 module PlanAssertions
-
   def inspect_flow(execution_plan, flow)
     out = "".dup
     inspect_subflow(out, execution_plan, flow, "".dup)

data/test/testing_test.rb

@@ -1,15 +1,14 @@
 # frozen_string_literal: true
+
 require_relative 'test_helper'
 
 module Dynflow
-
   CWE = Support::CodeWorkflowExample
 
   describe Testing do
     include Testing
 
     describe 'testing' do
-
       specify '#plan_action' do
         input  = { 'input' => 'input' }
         action = create_and_plan_action Support::DummyExample::WeightedPolling, input
@@ -63,20 +62,20 @@ module Dynflow
         _(action.run_progress).must_equal 0
 
         3.times { progress_action_time action }
-        _(action.output).must_equal('task' => { 'progress' => 30, 'done' => false } ,
-                                 'poll_attempts' => {'total' => 2, 'failed'=> 0 })
+        _(action.output).must_equal('task' => { 'progress' => 30, 'done' => false },
+                                 'poll_attempts' => { 'total' => 2, 'failed' => 0 })
         _(action.run_progress).must_equal 0.3
 
         run_action action, Dynflow::Action::Polling::Poll
         run_action action, Dynflow::Action::Polling::Poll
         _(action.output).must_equal('task' => { 'progress' => 50, 'done' => false },
-                                 'poll_attempts' => {'total' => 4, 'failed' => 0 })
+                                 'poll_attempts' => { 'total' => 4, 'failed' => 0 })
         _(action.run_progress).must_equal 0.5
 
         5.times { progress_action_time action }
 
         _(action.output).must_equal('task' => { 'progress' => 100, 'done' => true },
-                                 'poll_attempts' => {'total' => 9, 'failed' => 0 })
+                                 'poll_attempts' => { 'total' => 9, 'failed' => 0 })
         _(action.run_progress).must_equal 1
       end
 
@@ -100,7 +99,6 @@ module Dynflow
     end
 
     describe 'testing examples' do
-
       describe CWE::Commit do
         it 'plans' do
           action = create_and_plan_action CWE::Commit, sha = 'commit-sha'
@@ -125,7 +123,7 @@ module Dynflow
 
         it 'plans' do
           _(planned_action.input).must_equal Utils.stringify_keys(input)
-          assert_run_phase planned_action, { commit: "sha", reviewer: "name", result: true}
+          assert_run_phase planned_action, { commit: "sha", reviewer: "name", result: true }
           refute_finalize_phase planned_action
 
           _(planned_action.execution_plan.planned_plan_steps).must_be_empty

data/test/utils_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative 'test_helper'
 
 module Dynflow

data/test/v2_sub_plans_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative 'test_helper'
 require 'mocha/minitest'
 

data/test/web_console_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative 'test_helper'
 
 ENV['RACK_ENV'] = 'test'
@@ -8,14 +9,13 @@ require 'rack/test'
 
 module Dynflow
   describe 'web console' do
-
     include Rack::Test::Methods
     let(:world) { WorldFactory.create_world }
 
     let :execution_plan_id do
-      world.trigger(Support::CodeWorkflowExample::FastCommit, 'sha' => 'abc123').
-          tap { |o| o.finished.wait }.
-          id
+      world.trigger(Support::CodeWorkflowExample::FastCommit, 'sha' => 'abc123')
+           .tap { |o| o.finished.wait }
+           .id
     end
 
     let :app do