dynflow 1.8.1 → 1.8.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (233) hide show
  1. checksums.yaml +4 -4
  2. data/.github/workflows/ruby.yml +1 -1
  3. data/.rubocop.yml +11 -5
  4. data/.rubocop_todo.yml +777 -345
  5. data/Gemfile +4 -3
  6. data/Rakefile +1 -0
  7. data/doc/pages/Gemfile +4 -3
  8. data/doc/pages/Rakefile +1 -0
  9. data/doc/pages/plugins/alert_block.rb +1 -0
  10. data/doc/pages/plugins/div_tag.rb +1 -0
  11. data/doc/pages/plugins/graphviz.rb +6 -6
  12. data/doc/pages/plugins/plantuml.rb +2 -3
  13. data/doc/pages/plugins/play.rb +1 -2
  14. data/doc/pages/plugins/tags.rb +2 -8
  15. data/doc/pages/plugins/toc.rb +1 -1
  16. data/dynflow.gemspec +11 -10
  17. data/examples/clock_benchmark.rb +1 -0
  18. data/examples/example_helper.rb +4 -3
  19. data/examples/future_execution.rb +0 -2
  20. data/examples/memory_limit_watcher.rb +8 -8
  21. data/examples/orchestrate.rb +9 -21
  22. data/examples/orchestrate_evented.rb +18 -33
  23. data/examples/remote_executor.rb +13 -14
  24. data/examples/singletons.rb +1 -0
  25. data/examples/sub_plan_concurrency_control.rb +0 -1
  26. data/examples/sub_plans.rb +1 -0
  27. data/examples/sub_plans_v2.rb +1 -0
  28. data/lib/dynflow/action/cancellable.rb +1 -0
  29. data/lib/dynflow/action/format.rb +1 -4
  30. data/lib/dynflow/action/missing.rb +4 -4
  31. data/lib/dynflow/action/polling.rb +2 -3
  32. data/lib/dynflow/action/progress.rb +1 -4
  33. data/lib/dynflow/action/rescue.rb +1 -2
  34. data/lib/dynflow/action/singleton.rb +1 -0
  35. data/lib/dynflow/action/suspended.rb +1 -0
  36. data/lib/dynflow/action/timeouts.rb +2 -1
  37. data/lib/dynflow/action/with_bulk_sub_plans.rb +1 -0
  38. data/lib/dynflow/action/with_polling_sub_plans.rb +1 -1
  39. data/lib/dynflow/action/with_sub_plans.rb +20 -19
  40. data/lib/dynflow/action.rb +37 -37
  41. data/lib/dynflow/active_job/queue_adapter.rb +2 -1
  42. data/lib/dynflow/actor.rb +2 -2
  43. data/lib/dynflow/actors/execution_plan_cleaner.rb +1 -0
  44. data/lib/dynflow/actors.rb +1 -0
  45. data/lib/dynflow/clock.rb +3 -4
  46. data/lib/dynflow/config.rb +6 -5
  47. data/lib/dynflow/connectors/abstract.rb +11 -10
  48. data/lib/dynflow/connectors/database.rb +2 -2
  49. data/lib/dynflow/connectors/direct.rb +2 -3
  50. data/lib/dynflow/connectors.rb +1 -0
  51. data/lib/dynflow/coordinator.rb +2 -6
  52. data/lib/dynflow/coordinator_adapters/abstract.rb +1 -0
  53. data/lib/dynflow/coordinator_adapters/sequel.rb +1 -0
  54. data/lib/dynflow/coordinator_adapters.rb +1 -2
  55. data/lib/dynflow/dead_letter_silencer.rb +1 -0
  56. data/lib/dynflow/debug/telemetry/persistence.rb +3 -2
  57. data/lib/dynflow/delayed_executors/abstract.rb +1 -2
  58. data/lib/dynflow/delayed_executors/abstract_core.rb +1 -1
  59. data/lib/dynflow/delayed_executors/polling.rb +1 -2
  60. data/lib/dynflow/delayed_executors.rb +1 -2
  61. data/lib/dynflow/delayed_plan.rb +6 -6
  62. data/lib/dynflow/director/execution_plan_manager.rb +1 -1
  63. data/lib/dynflow/director/flow_manager.rb +1 -0
  64. data/lib/dynflow/director/queue_hash.rb +2 -1
  65. data/lib/dynflow/director/running_steps_manager.rb +3 -2
  66. data/lib/dynflow/director/sequence_cursor.rb +1 -2
  67. data/lib/dynflow/director/sequential_manager.rb +1 -0
  68. data/lib/dynflow/director.rb +12 -11
  69. data/lib/dynflow/dispatcher/abstract.rb +1 -0
  70. data/lib/dynflow/dispatcher/client_dispatcher.rb +33 -33
  71. data/lib/dynflow/dispatcher/executor_dispatcher.rb +7 -6
  72. data/lib/dynflow/dispatcher.rb +8 -7
  73. data/lib/dynflow/errors.rb +1 -0
  74. data/lib/dynflow/execution_history.rb +2 -1
  75. data/lib/dynflow/execution_plan/dependency_graph.rb +1 -2
  76. data/lib/dynflow/execution_plan/hooks.rb +1 -1
  77. data/lib/dynflow/execution_plan/output_reference.rb +4 -4
  78. data/lib/dynflow/execution_plan/steps/abstract.rb +21 -20
  79. data/lib/dynflow/execution_plan/steps/abstract_flow_step.rb +1 -1
  80. data/lib/dynflow/execution_plan/steps/error.rb +10 -9
  81. data/lib/dynflow/execution_plan/steps/finalize_step.rb +1 -2
  82. data/lib/dynflow/execution_plan/steps/plan_step.rb +12 -11
  83. data/lib/dynflow/execution_plan/steps/run_step.rb +1 -1
  84. data/lib/dynflow/execution_plan/steps.rb +1 -2
  85. data/lib/dynflow/execution_plan.rb +46 -46
  86. data/lib/dynflow/executors/abstract/core.rb +4 -3
  87. data/lib/dynflow/executors/parallel/core.rb +3 -2
  88. data/lib/dynflow/executors/parallel/pool.rb +1 -4
  89. data/lib/dynflow/executors/parallel/worker.rb +1 -0
  90. data/lib/dynflow/executors/parallel.rb +3 -2
  91. data/lib/dynflow/executors/sidekiq/core.rb +3 -1
  92. data/lib/dynflow/executors/sidekiq/internal_job_base.rb +1 -0
  93. data/lib/dynflow/executors/sidekiq/orchestrator_jobs.rb +1 -0
  94. data/lib/dynflow/executors/sidekiq/redis_locking.rb +1 -0
  95. data/lib/dynflow/executors/sidekiq/serialization.rb +1 -0
  96. data/lib/dynflow/executors/sidekiq/worker_jobs.rb +1 -0
  97. data/lib/dynflow/executors.rb +1 -1
  98. data/lib/dynflow/extensions/msgpack.rb +5 -4
  99. data/lib/dynflow/extensions.rb +1 -0
  100. data/lib/dynflow/flows/abstract.rb +1 -1
  101. data/lib/dynflow/flows/abstract_composed.rb +1 -2
  102. data/lib/dynflow/flows/atom.rb +1 -2
  103. data/lib/dynflow/flows/concurrence.rb +1 -1
  104. data/lib/dynflow/flows/registry.rb +1 -0
  105. data/lib/dynflow/flows/sequence.rb +1 -1
  106. data/lib/dynflow/flows.rb +1 -2
  107. data/lib/dynflow/logger_adapters/abstract.rb +1 -1
  108. data/lib/dynflow/logger_adapters/delegator.rb +1 -1
  109. data/lib/dynflow/logger_adapters/formatters/abstract.rb +1 -0
  110. data/lib/dynflow/logger_adapters/formatters/exception.rb +1 -0
  111. data/lib/dynflow/logger_adapters/formatters.rb +1 -0
  112. data/lib/dynflow/logger_adapters/simple.rb +6 -5
  113. data/lib/dynflow/logger_adapters.rb +1 -0
  114. data/lib/dynflow/middleware/common/singleton.rb +1 -0
  115. data/lib/dynflow/middleware/common/transaction.rb +1 -0
  116. data/lib/dynflow/middleware/register.rb +1 -0
  117. data/lib/dynflow/middleware/resolver.rb +2 -3
  118. data/lib/dynflow/middleware/stack.rb +1 -0
  119. data/lib/dynflow/middleware/world.rb +1 -2
  120. data/lib/dynflow/middleware.rb +1 -0
  121. data/lib/dynflow/persistence.rb +4 -5
  122. data/lib/dynflow/persistence_adapters/abstract.rb +1 -1
  123. data/lib/dynflow/persistence_adapters/sequel.rb +14 -14
  124. data/lib/dynflow/persistence_adapters/sequel_migrations/001_initial.rb +2 -1
  125. data/lib/dynflow/persistence_adapters/sequel_migrations/002_incremental_progress.rb +1 -0
  126. data/lib/dynflow/persistence_adapters/sequel_migrations/003_parent_action.rb +1 -0
  127. data/lib/dynflow/persistence_adapters/sequel_migrations/004_coordinator_records.rb +1 -1
  128. data/lib/dynflow/persistence_adapters/sequel_migrations/005_envelopes.rb +1 -0
  129. data/lib/dynflow/persistence_adapters/sequel_migrations/006_fix_data_length.rb +1 -0
  130. data/lib/dynflow/persistence_adapters/sequel_migrations/007_future_execution.rb +1 -0
  131. data/lib/dynflow/persistence_adapters/sequel_migrations/008_rename_scheduled_plans_to_delayed_plans.rb +1 -0
  132. data/lib/dynflow/persistence_adapters/sequel_migrations/009_fix_mysql_data_length.rb +1 -1
  133. data/lib/dynflow/persistence_adapters/sequel_migrations/010_add_execution_plans_label.rb +1 -0
  134. data/lib/dynflow/persistence_adapters/sequel_migrations/011_placeholder.rb +1 -0
  135. data/lib/dynflow/persistence_adapters/sequel_migrations/012_add_delayed_plans_serialized_args.rb +1 -0
  136. data/lib/dynflow/persistence_adapters/sequel_migrations/013_add_action_columns.rb +1 -0
  137. data/lib/dynflow/persistence_adapters/sequel_migrations/014_add_step_columns.rb +1 -0
  138. data/lib/dynflow/persistence_adapters/sequel_migrations/015_add_execution_plan_columns.rb +1 -0
  139. data/lib/dynflow/persistence_adapters/sequel_migrations/016_add_step_queue.rb +1 -0
  140. data/lib/dynflow/persistence_adapters/sequel_migrations/017_add_delayed_plan_frozen.rb +1 -0
  141. data/lib/dynflow/persistence_adapters/sequel_migrations/018_add_uuid_column.rb +37 -30
  142. data/lib/dynflow/persistence_adapters/sequel_migrations/019_update_mysql_time_precision.rb +1 -0
  143. data/lib/dynflow/persistence_adapters/sequel_migrations/020_drop_duplicate_indices.rb +1 -0
  144. data/lib/dynflow/persistence_adapters/sequel_migrations/021_create_output_chunks.rb +4 -3
  145. data/lib/dynflow/persistence_adapters/sequel_migrations/023_sqlite_workarounds.rb +1 -0
  146. data/lib/dynflow/persistence_adapters.rb +1 -0
  147. data/lib/dynflow/rails/configuration.rb +5 -4
  148. data/lib/dynflow/rails/daemon.rb +1 -1
  149. data/lib/dynflow/rails.rb +3 -2
  150. data/lib/dynflow/round_robin.rb +2 -2
  151. data/lib/dynflow/semaphores/abstract.rb +1 -1
  152. data/lib/dynflow/semaphores/aggregating.rb +1 -2
  153. data/lib/dynflow/semaphores/dummy.rb +1 -1
  154. data/lib/dynflow/semaphores/stateful.rb +1 -1
  155. data/lib/dynflow/semaphores.rb +1 -0
  156. data/lib/dynflow/serializable.rb +1 -0
  157. data/lib/dynflow/serializer.rb +2 -2
  158. data/lib/dynflow/serializers/abstract.rb +1 -2
  159. data/lib/dynflow/serializers/noop.rb +1 -2
  160. data/lib/dynflow/serializers.rb +1 -2
  161. data/lib/dynflow/stateful.rb +1 -0
  162. data/lib/dynflow/telemetry.rb +11 -10
  163. data/lib/dynflow/telemetry_adapters/abstract.rb +1 -0
  164. data/lib/dynflow/telemetry_adapters/dummy.rb +1 -0
  165. data/lib/dynflow/telemetry_adapters/statsd.rb +2 -1
  166. data/lib/dynflow/testing/assertions.rb +7 -7
  167. data/lib/dynflow/testing/dummy_coordinator.rb +1 -0
  168. data/lib/dynflow/testing/dummy_execution_plan.rb +1 -0
  169. data/lib/dynflow/testing/dummy_executor.rb +1 -0
  170. data/lib/dynflow/testing/dummy_planned_action.rb +3 -1
  171. data/lib/dynflow/testing/dummy_step.rb +1 -0
  172. data/lib/dynflow/testing/dummy_world.rb +1 -0
  173. data/lib/dynflow/testing/factories.rb +42 -37
  174. data/lib/dynflow/testing/in_thread_executor.rb +1 -0
  175. data/lib/dynflow/testing/in_thread_world.rb +1 -0
  176. data/lib/dynflow/testing/managed_clock.rb +1 -1
  177. data/lib/dynflow/testing/mimic.rb +4 -4
  178. data/lib/dynflow/testing.rb +1 -0
  179. data/lib/dynflow/throttle_limiter.rb +1 -1
  180. data/lib/dynflow/transaction_adapters/abstract.rb +1 -0
  181. data/lib/dynflow/transaction_adapters/active_record.rb +1 -0
  182. data/lib/dynflow/transaction_adapters/none.rb +1 -0
  183. data/lib/dynflow/transaction_adapters.rb +1 -2
  184. data/lib/dynflow/utils/indifferent_hash.rb +7 -1
  185. data/lib/dynflow/utils/priority_queue.rb +1 -0
  186. data/lib/dynflow/utils.rb +1 -1
  187. data/lib/dynflow/version.rb +2 -1
  188. data/lib/dynflow/watchers/memory_consumption_watcher.rb +1 -1
  189. data/lib/dynflow/web/console.rb +1 -3
  190. data/lib/dynflow/web/console_helpers.rb +5 -4
  191. data/lib/dynflow/web/filtering_helpers.rb +1 -0
  192. data/lib/dynflow/web/world_helpers.rb +1 -0
  193. data/lib/dynflow/web.rb +3 -3
  194. data/lib/dynflow/web_console.rb +1 -0
  195. data/lib/dynflow/world/invalidation.rb +1 -0
  196. data/lib/dynflow/world.rb +19 -19
  197. data/lib/dynflow.rb +3 -6
  198. data/test/abnormal_states_recovery_test.rb +4 -8
  199. data/test/action_test.rb +10 -18
  200. data/test/activejob_adapter_test.rb +2 -2
  201. data/test/batch_sub_tasks_test.rb +1 -1
  202. data/test/clock_test.rb +2 -3
  203. data/test/concurrency_control_test.rb +6 -7
  204. data/test/coordinator_test.rb +1 -0
  205. data/test/daemon_test.rb +3 -2
  206. data/test/dead_letter_silencer_test.rb +2 -1
  207. data/test/dispatcher_test.rb +4 -5
  208. data/test/execution_plan_cleaner_test.rb +1 -0
  209. data/test/execution_plan_hooks_test.rb +1 -0
  210. data/test/execution_plan_test.rb +10 -32
  211. data/test/executor_test.rb +20 -37
  212. data/test/extensions_test.rb +1 -0
  213. data/test/flows_test.rb +2 -2
  214. data/test/future_execution_test.rb +2 -3
  215. data/test/memory_cosumption_watcher_test.rb +1 -0
  216. data/test/middleware_test.rb +4 -6
  217. data/test/persistence_test.rb +26 -26
  218. data/test/redis_locking_test.rb +1 -0
  219. data/test/rescue_test.rb +3 -11
  220. data/test/round_robin_test.rb +1 -0
  221. data/test/semaphores_test.rb +5 -7
  222. data/test/support/code_workflow_example.rb +11 -28
  223. data/test/support/dummy_example.rb +20 -19
  224. data/test/support/middleware_example.rb +2 -8
  225. data/test/support/rescue_example.rb +1 -14
  226. data/test/support/test_execution_log.rb +1 -2
  227. data/test/test_helper.rb +3 -7
  228. data/test/testing_test.rb +6 -8
  229. data/test/utils_test.rb +1 -0
  230. data/test/v2_sub_plans_test.rb +1 -0
  231. data/test/web_console_test.rb +4 -4
  232. data/test/world_test.rb +4 -3
  233. metadata +43 -43
data/.rubocop_todo.yml CHANGED
@@ -1,418 +1,787 @@
1
1
  # This configuration was generated by
2
- # `rubocop --auto-gen-config --exclude-limit 0`
3
- # on 2016-08-24 10:37:35 -0400 using RuboCop version 0.39.0.
2
+ # `rubocop --auto-gen-config`
3
+ # on 2024-01-26 13:59:46 UTC using RuboCop version 0.89.1.
4
4
  # The point is for the user to remove these configuration records
5
5
  # one by one as the offenses are removed from the code base.
6
6
  # Note that changes in the inspected code, or installation of new
7
7
  # versions of RuboCop, may require this file to be generated again.
8
8
 
9
- # Offense count: 7
10
- Lint/AmbiguousOperator:
11
- Enabled: false
9
+ # Offense count: 1
10
+ # Cop supports --auto-correct.
11
+ # Configuration parameters: EnforcedStyleAlignWith.
12
+ # SupportedStylesAlignWith: either, start_of_block, start_of_line
13
+ Layout/BlockAlignment:
14
+ Exclude:
15
+ - 'test/test_helper.rb'
12
16
 
13
- # Offense count: 2
14
- Lint/AmbiguousRegexpLiteral:
17
+ # Offense count: 7
18
+ # Cop supports --auto-correct.
19
+ # Configuration parameters: EnforcedStyle, IndentationWidth.
20
+ # SupportedStyles: special_inside_parentheses, consistent, align_braces
21
+ Layout/FirstHashElementIndentation:
22
+ Exclude:
23
+ - 'lib/dynflow/execution_plan/steps/finalize_step.rb'
24
+ - 'lib/dynflow/execution_plan/steps/run_step.rb'
25
+ - 'lib/dynflow/persistence_adapters/sequel_migrations/022_store_flows_as_msgpack.rb'
26
+ - 'lib/dynflow/persistence_adapters/sequel_migrations/024_store_execution_plan_data_as_msgpack.rb'
27
+ - 'test/persistence_test.rb'
28
+
29
+ # Offense count: 201
30
+ # Cop supports --auto-correct.
31
+ # Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
32
+ # SupportedHashRocketStyles: key, separator, table
33
+ # SupportedColonStyles: key, separator, table
34
+ # SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
35
+ Layout/HashAlignment:
15
36
  Enabled: false
16
37
 
17
- # Offense count: 7
38
+ # Offense count: 8
18
39
  # Configuration parameters: AllowSafeAssignment.
19
40
  Lint/AssignmentInCondition:
20
- Enabled: false
21
-
22
- # Offense count: 3
23
- # Cop supports --auto-correct.
24
- # Configuration parameters: AlignWith, SupportedStyles.
25
- # SupportedStyles: either, start_of_block, start_of_line
26
- Lint/BlockAlignment:
27
- Enabled: false
41
+ Exclude:
42
+ - 'doc/pages/plugins/tags.rb'
43
+ - 'lib/dynflow/action/v2/with_sub_plans.rb'
44
+ - 'lib/dynflow/connectors/direct.rb'
45
+ - 'lib/dynflow/director/running_steps_manager.rb'
46
+ - 'lib/dynflow/testing/dummy_execution_plan.rb'
47
+ - 'lib/dynflow/testing/managed_clock.rb'
48
+ - 'lib/dynflow/web/console_helpers.rb'
49
+ - 'test/test_helper.rb'
28
50
 
29
- # Offense count: 1
51
+ # Offense count: 4
30
52
  Lint/DuplicateMethods:
31
- Enabled: false
32
-
33
- # Offense count: 1
34
- # Cop supports --auto-correct.
35
- # Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
36
- # SupportedStyles: keyword, variable, start_of_line
37
- Lint/EndAlignment:
38
- Enabled: false
53
+ Exclude:
54
+ - 'lib/dynflow/coordinator.rb'
55
+ - 'lib/dynflow/executors/parallel/pool.rb'
56
+ - 'lib/dynflow/rails/configuration.rb'
57
+ - 'lib/dynflow/rails/daemon.rb'
39
58
 
40
59
  # Offense count: 6
41
60
  Lint/IneffectiveAccessModifier:
42
- Enabled: false
61
+ Exclude:
62
+ - 'lib/dynflow/action.rb'
63
+ - 'lib/dynflow/execution_plan/output_reference.rb'
64
+ - 'lib/dynflow/execution_plan/steps/abstract.rb'
65
+ - 'lib/dynflow/flows/atom.rb'
66
+ - 'lib/dynflow/persistence_adapters/sequel.rb'
43
67
 
44
- # Offense count: 5
45
- Lint/ParenthesesAsGroupedExpression:
46
- Enabled: false
68
+ # Offense count: 1
69
+ # Configuration parameters: MaximumRangeSize.
70
+ Lint/MissingCopEnableDirective:
71
+ Exclude:
72
+ - 'test/persistence_test.rb'
47
73
 
48
74
  # Offense count: 1
49
75
  Lint/RandOne:
50
- Enabled: false
76
+ Exclude:
77
+ - 'examples/orchestrate_evented.rb'
51
78
 
52
79
  # Offense count: 3
53
80
  Lint/RescueException:
54
- Enabled: false
81
+ Exclude:
82
+ - 'lib/dynflow/action.rb'
83
+ - 'lib/dynflow/delayed_executors/abstract_core.rb'
84
+ - 'lib/dynflow/persistence_adapters/sequel.rb'
55
85
 
56
- # Offense count: 1
86
+ # Offense count: 3
87
+ # Cop supports --auto-correct.
88
+ Lint/ScriptPermission:
89
+ Exclude:
90
+ - 'examples/chunked_output_benchmark.rb'
91
+ - 'examples/memory_limit_watcher.rb'
92
+ - 'examples/sub_plan_concurrency_control.rb'
93
+
94
+ # Offense count: 3
57
95
  Lint/ShadowingOuterLocalVariable:
58
- Enabled: false
96
+ Exclude:
97
+ - 'lib/dynflow/logger_adapters/abstract.rb'
98
+ - 'lib/dynflow/rails/daemon.rb'
59
99
 
60
100
  # Offense count: 1
101
+ # Configuration parameters: AllowKeywordBlockArguments.
61
102
  Lint/UnderscorePrefixedVariableName:
62
- Enabled: false
103
+ Exclude:
104
+ - 'lib/dynflow/utils/indifferent_hash.rb'
63
105
 
64
- # Offense count: 17
106
+ # Offense count: 30
65
107
  # Cop supports --auto-correct.
66
- # Configuration parameters: IgnoreEmptyBlocks.
108
+ # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
67
109
  Lint/UnusedBlockArgument:
68
110
  Enabled: false
69
111
 
70
- # Offense count: 78
112
+ # Offense count: 43
71
113
  # Cop supports --auto-correct.
72
- # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
114
+ # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
73
115
  Lint/UnusedMethodArgument:
74
116
  Enabled: false
75
117
 
76
- # Offense count: 3
118
+ # Offense count: 6
119
+ # Cop supports --auto-correct.
120
+ # Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
77
121
  Lint/UselessAccessModifier:
78
- Enabled: false
122
+ Exclude:
123
+ - 'lib/dynflow/dead_letter_silencer.rb'
124
+ - 'lib/dynflow/delayed_executors/abstract_core.rb'
125
+ - 'lib/dynflow/execution_plan/output_reference.rb'
126
+ - 'lib/dynflow/execution_plan/steps/abstract.rb'
127
+ - 'lib/dynflow/flows/atom.rb'
128
+ - 'lib/dynflow/rails/daemon.rb'
79
129
 
80
- # Offense count: 5
130
+ # Offense count: 9
81
131
  Lint/UselessAssignment:
82
- Enabled: false
132
+ Exclude:
133
+ - 'doc/pages/plugins/plantuml.rb'
134
+ - 'examples/memory_limit_watcher.rb'
135
+ - 'examples/singletons.rb'
136
+ - 'lib/dynflow/executors/parallel.rb'
137
+ - 'lib/dynflow/persistence_adapters/sequel.rb'
138
+ - 'lib/dynflow/rails/configuration.rb'
139
+ - 'lib/dynflow/world.rb'
140
+ - 'test/concurrency_control_test.rb'
141
+
142
+ # Offense count: 1
143
+ # Configuration parameters: CheckForMethodsWithNoSideEffects.
144
+ Lint/Void:
145
+ Exclude:
146
+ - 'test/executor_test.rb'
83
147
 
84
- # Offense count: 73
148
+ # Offense count: 86
149
+ # Configuration parameters: IgnoredMethods.
85
150
  Metrics/AbcSize:
86
- Max: 207
151
+ Max: 66
87
152
 
88
- # Offense count: 9
89
- # Configuration parameters: CountComments.
90
- Metrics/ClassLength:
91
- Max: 402
153
+ # Offense count: 101
154
+ # Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
155
+ # ExcludedMethods: refine
156
+ Metrics/BlockLength:
157
+ Max: 738
92
158
 
93
159
  # Offense count: 11
94
- Metrics/CyclomaticComplexity:
95
- Max: 11
160
+ # Configuration parameters: CountComments, CountAsOne.
161
+ Metrics/ClassLength:
162
+ Max: 292
96
163
 
97
- # Offense count: 521
98
- # Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
99
- # URISchemes: http, https
100
- Metrics/LineLength:
101
- Max: 166
164
+ # Offense count: 19
165
+ # Configuration parameters: IgnoredMethods.
166
+ Metrics/CyclomaticComplexity:
167
+ Max: 18
102
168
 
103
- # Offense count: 99
104
- # Configuration parameters: CountComments.
169
+ # Offense count: 135
170
+ # Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
105
171
  Metrics/MethodLength:
106
- Max: 104
172
+ Max: 47
107
173
 
108
- # Offense count: 14
109
- # Configuration parameters: CountComments.
174
+ # Offense count: 4
175
+ # Configuration parameters: CountComments, CountAsOne.
110
176
  Metrics/ModuleLength:
111
- Max: 548
177
+ Max: 188
112
178
 
113
- # Offense count: 3
179
+ # Offense count: 8
114
180
  # Configuration parameters: CountKeywordArgs.
115
181
  Metrics/ParameterLists:
116
182
  Max: 13
117
183
 
118
- # Offense count: 9
184
+ # Offense count: 15
185
+ # Configuration parameters: IgnoredMethods.
119
186
  Metrics/PerceivedComplexity:
120
- Max: 11
187
+ Max: 18
188
+
189
+ # Offense count: 10
190
+ Naming/AccessorMethodName:
191
+ Exclude:
192
+ - 'examples/example_helper.rb'
193
+ - 'lib/dynflow/action.rb'
194
+ - 'lib/dynflow/director.rb'
195
+ - 'lib/dynflow/semaphores/abstract.rb'
196
+ - 'lib/dynflow/semaphores/aggregating.rb'
197
+ - 'lib/dynflow/semaphores/dummy.rb'
198
+ - 'lib/dynflow/semaphores/stateful.rb'
199
+ - 'lib/dynflow/telemetry.rb'
200
+ - 'lib/dynflow/testing.rb'
201
+ - 'lib/dynflow/watchers/memory_consumption_watcher.rb'
121
202
 
122
- # Offense count: 16
203
+ # Offense count: 1
204
+ Naming/BinaryOperatorParameterName:
205
+ Exclude:
206
+ - 'lib/dynflow/coordinator.rb'
207
+
208
+ # Offense count: 3
209
+ Naming/ConstantName:
210
+ Exclude:
211
+ - 'examples/sub_plan_concurrency_control.rb'
212
+
213
+ # Offense count: 5
214
+ # Configuration parameters: EnforcedStyleForLeadingUnderscores.
215
+ # SupportedStylesForLeadingUnderscores: disallowed, required, optional
216
+ Naming/MemoizedInstanceVariableName:
217
+ Exclude:
218
+ - 'lib/dynflow/action.rb'
219
+ - 'lib/dynflow/execution_plan/steps/abstract_flow_step.rb'
220
+ - 'lib/dynflow/persistence_adapters/abstract.rb'
221
+ - 'lib/dynflow/testing/in_thread_world.rb'
222
+ - 'test/test_helper.rb'
223
+
224
+ # Offense count: 13
225
+ # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
226
+ # AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to
227
+ Naming/MethodParameterName:
228
+ Exclude:
229
+ - 'lib/dynflow/flows/abstract_composed.rb'
230
+ - 'lib/dynflow/logger_adapters/abstract.rb'
231
+ - 'lib/dynflow/logger_adapters/formatters/abstract.rb'
232
+ - 'lib/dynflow/logger_adapters/simple.rb'
233
+ - 'lib/dynflow/semaphores/abstract.rb'
234
+ - 'lib/dynflow/semaphores/aggregating.rb'
235
+ - 'lib/dynflow/semaphores/dummy.rb'
236
+ - 'lib/dynflow/semaphores/stateful.rb'
237
+ - 'lib/dynflow/testing/mimic.rb'
238
+
239
+ # Offense count: 4
240
+ # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
241
+ # NamePrefix: is_, has_, have_
242
+ # ForbiddenPrefixes: is_, has_, have_
243
+ # AllowedMethods: is_a?
244
+ # MethodDefinitionMacros: define_method, define_singleton_method
245
+ Naming/PredicateName:
246
+ Exclude:
247
+ - 'spec/**/*'
248
+ - 'lib/dynflow/semaphores/abstract.rb'
249
+ - 'lib/dynflow/semaphores/aggregating.rb'
250
+ - 'lib/dynflow/semaphores/dummy.rb'
251
+ - 'lib/dynflow/semaphores/stateful.rb'
252
+
253
+ # Offense count: 7
123
254
  # Cop supports --auto-correct.
124
- Performance/RedundantBlockCall:
125
- Enabled: false
255
+ # Configuration parameters: PreferredName.
256
+ Naming/RescuedExceptionsVariableName:
257
+ Exclude:
258
+ - 'lib/dynflow/action.rb'
259
+ - 'lib/dynflow/action/polling.rb'
260
+ - 'lib/dynflow/action/progress.rb'
261
+ - 'lib/dynflow/execution_plan.rb'
262
+ - 'lib/dynflow/executors/parallel.rb'
263
+ - 'lib/dynflow/serializable.rb'
264
+
265
+ # Offense count: 3
266
+ # Configuration parameters: MinSize.
267
+ Performance/CollectionLiteralInLoop:
268
+ Exclude:
269
+ - 'lib/dynflow/coordinator.rb'
270
+ - 'lib/dynflow/director/sequential_manager.rb'
271
+ - 'lib/dynflow/execution_plan.rb'
126
272
 
127
273
  # Offense count: 4
128
274
  # Cop supports --auto-correct.
275
+ Performance/Count:
276
+ Exclude:
277
+ - 'lib/dynflow/world/invalidation.rb'
278
+ - 'test/concurrency_control_test.rb'
279
+
280
+ # Offense count: 17
281
+ # Cop supports --auto-correct.
282
+ Performance/RedundantBlockCall:
283
+ Exclude:
284
+ - 'lib/dynflow/action.rb'
285
+ - 'lib/dynflow/coordinator.rb'
286
+ - 'lib/dynflow/delayed_executors/abstract_core.rb'
287
+ - 'lib/dynflow/director/sequential_manager.rb'
288
+ - 'lib/dynflow/execution_plan.rb'
289
+ - 'lib/dynflow/execution_plan/steps/abstract.rb'
290
+ - 'lib/dynflow/persistence_adapters/sequel_migrations/018_add_uuid_column.rb'
291
+ - 'lib/dynflow/testing/assertions.rb'
292
+ - 'lib/dynflow/testing/dummy_execution_plan.rb'
293
+ - 'lib/dynflow/testing/factories.rb'
294
+ - 'lib/dynflow/transaction_adapters/none.rb'
295
+ - 'lib/dynflow/world.rb'
296
+ - 'test/test_helper.rb'
297
+
298
+ # Offense count: 3
299
+ # Cop supports --auto-correct.
300
+ Performance/RegexpMatch:
301
+ Exclude:
302
+ - 'test/support/code_workflow_example.rb'
303
+
304
+ # Offense count: 3
305
+ # Cop supports --auto-correct.
306
+ # Configuration parameters: AutoCorrect.
129
307
  Performance/TimesMap:
130
- Enabled: false
308
+ Exclude:
309
+ - 'examples/sub_plan_concurrency_control.rb'
310
+ - 'test/action_test.rb'
311
+ - 'test/concurrency_control_test.rb'
131
312
 
132
- # Offense count: 8
133
- Style/AccessorMethodName:
134
- Enabled: false
313
+ # Offense count: 7
314
+ Performance/UnfreezeString:
315
+ Exclude:
316
+ - 'lib/dynflow/execution_plan/output_reference.rb'
317
+ - 'lib/dynflow/extensions/msgpack.rb'
318
+ - 'test/support/middleware_example.rb'
319
+ - 'test/test_helper.rb'
135
320
 
136
- # Offense count: 13
321
+ # Offense count: 1
137
322
  # Cop supports --auto-correct.
138
- # Configuration parameters: EnforcedStyle, SupportedStyles.
139
- # SupportedStyles: prefer_alias, prefer_alias_method
140
- Style/Alias:
141
- Enabled: false
323
+ # Configuration parameters: Include.
324
+ # Include: **/test/**/*
325
+ Rails/AssertNot:
326
+ Exclude:
327
+ - 'test/executor_test.rb'
142
328
 
143
329
  # Offense count: 1
144
330
  # Cop supports --auto-correct.
145
- # Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle, SupportedLastArgumentHashStyles.
146
- # SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
147
- Style/AlignHash:
148
- Enabled: false
331
+ # Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent.
332
+ Rails/Blank:
333
+ Exclude:
334
+ - 'lib/dynflow/telemetry_adapters/statsd.rb'
149
335
 
150
- # Offense count: 11
336
+ # Offense count: 3
337
+ # Configuration parameters: EnforcedStyle.
338
+ # SupportedStyles: strict, flexible
339
+ Rails/Date:
340
+ Exclude:
341
+ - 'lib/dynflow/extensions/msgpack.rb'
342
+ - 'lib/dynflow/persistence.rb'
343
+
344
+ # Offense count: 12
345
+ # Cop supports --auto-correct.
346
+ # Configuration parameters: EnforceForPrefixed.
347
+ Rails/Delegate:
348
+ Exclude:
349
+ - 'lib/dynflow/action.rb'
350
+ - 'lib/dynflow/execution_plan.rb'
351
+ - 'lib/dynflow/execution_plan/steps/abstract.rb'
352
+ - 'lib/dynflow/persistence.rb'
353
+ - 'lib/dynflow/rails/configuration.rb'
354
+ - 'lib/dynflow/web/world_helpers.rb'
355
+ - 'lib/dynflow/world.rb'
356
+
357
+ # Offense count: 2
358
+ # Configuration parameters: Include.
359
+ # Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb
360
+ Rails/Exit:
361
+ Exclude:
362
+ - 'lib/**/*.rake'
363
+ - 'lib/dynflow/rails/daemon.rb'
364
+ - 'lib/dynflow/world.rb'
365
+
366
+ # Offense count: 1
367
+ # Configuration parameters: Include.
368
+ # Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb
369
+ Rails/Output:
370
+ Exclude:
371
+ - 'lib/dynflow/testing/in_thread_world.rb'
372
+
373
+ # Offense count: 1
374
+ # Cop supports --auto-correct.
375
+ Rails/PluralizationGrammar:
376
+ Exclude:
377
+ - 'test/activejob_adapter_test.rb'
378
+
379
+ # Offense count: 1
151
380
  # Cop supports --auto-correct.
152
- # Configuration parameters: EnforcedStyle, SupportedStyles.
153
- # SupportedStyles: always, conditionals
154
- Style/AndOr:
381
+ # Configuration parameters: Include.
382
+ # Include: **/Rakefile, **/*.rake
383
+ Rails/RakeEnvironment:
384
+ Exclude:
385
+ - 'lib/capistrano/tasks/**/*.rake'
386
+ - 'doc/pages/Rakefile'
387
+
388
+ # Offense count: 24
389
+ # Cop supports --auto-correct.
390
+ # Configuration parameters: EnforcedStyle, Include.
391
+ # SupportedStyles: assert_not, refute
392
+ # Include: **/test/**/*
393
+ Rails/RefuteMethods:
394
+ Exclude:
395
+ - 'test/abnormal_states_recovery_test.rb'
396
+ - 'test/action_test.rb'
397
+ - 'test/dispatcher_test.rb'
398
+ - 'test/execution_plan_hooks_test.rb'
399
+ - 'test/execution_plan_test.rb'
400
+ - 'test/executor_test.rb'
401
+ - 'test/test_helper.rb'
402
+
403
+ # Offense count: 14
404
+ # Configuration parameters: ForbiddenMethods, AllowedMethods.
405
+ # ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all
406
+ Rails/SkipsModelValidations:
407
+ Exclude:
408
+ - 'db/migrate/*.rb'
409
+ - 'lib/dynflow/connectors/abstract.rb'
410
+ - 'lib/dynflow/connectors/database.rb'
411
+ - 'lib/dynflow/connectors/direct.rb'
412
+ - 'lib/dynflow/execution_plan.rb'
413
+ - 'lib/dynflow/executors/parallel/worker.rb'
414
+ - 'lib/dynflow/executors/sidekiq/worker_jobs.rb'
415
+ - 'lib/dynflow/persistence_adapters/sequel.rb'
416
+ - 'test/persistence_test.rb'
417
+
418
+ # Offense count: 37
419
+ # Cop supports --auto-correct.
420
+ # Configuration parameters: EnforcedStyle.
421
+ # SupportedStyles: strict, flexible
422
+ Rails/TimeZone:
155
423
  Enabled: false
156
424
 
425
+ # Offense count: 2
426
+ Security/MarshalLoad:
427
+ Exclude:
428
+ - 'lib/dynflow/dispatcher.rb'
429
+ - 'lib/dynflow/serializer.rb'
430
+
431
+ # Offense count: 4
432
+ # Cop supports --auto-correct.
433
+ # Configuration parameters: EnforcedStyle.
434
+ # SupportedStyles: prefer_alias, prefer_alias_method
435
+ Style/Alias:
436
+ Exclude:
437
+ - 'lib/dynflow/rails/configuration.rb'
438
+ - 'lib/dynflow/testing/assertions.rb'
439
+
157
440
  # Offense count: 2
158
441
  # Cop supports --auto-correct.
159
- # Configuration parameters: EnforcedStyle, SupportedStyles.
442
+ # Configuration parameters: EnforcedStyle.
160
443
  # SupportedStyles: percent_q, bare_percent
161
444
  Style/BarePercentLiterals:
162
- Enabled: false
445
+ Exclude:
446
+ - 'doc/pages/plugins/tags.rb'
163
447
 
164
448
  # Offense count: 3
165
449
  # Cop supports --auto-correct.
166
- # Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
167
- # SupportedStyles: line_count_based, semantic, braces_for_chaining
450
+ # Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
451
+ # SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
168
452
  # ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
169
453
  # FunctionalMethods: let, let!, subject, watch
170
454
  # IgnoredMethods: lambda, proc, it
171
455
  Style/BlockDelimiters:
172
- Enabled: false
456
+ Exclude:
457
+ - 'doc/pages/plugins/tags.rb'
173
458
 
174
- # Offense count: 18
459
+ # Offense count: 10
175
460
  # Cop supports --auto-correct.
176
- # Configuration parameters: EnforcedStyle, SupportedStyles.
177
- # SupportedStyles: braces, no_braces, context_dependent
178
- Style/BracesAroundHashParameters:
179
- Enabled: false
180
-
181
- # Offense count: 13
461
+ # Configuration parameters: AllowOnConstant.
182
462
  Style/CaseEquality:
183
- Enabled: false
184
-
185
- # Offense count: 24
186
- # Configuration parameters: EnforcedStyle, SupportedStyles.
463
+ Exclude:
464
+ - 'lib/dynflow/action/with_bulk_sub_plans.rb'
465
+ - 'lib/dynflow/clock.rb'
466
+ - 'lib/dynflow/connectors/database.rb'
467
+ - 'lib/dynflow/connectors/direct.rb'
468
+ - 'lib/dynflow/director/running_steps_manager.rb'
469
+ - 'lib/dynflow/dispatcher/client_dispatcher.rb'
470
+ - 'lib/dynflow/logger_adapters/formatters/exception.rb'
471
+ - 'lib/dynflow/serializer.rb'
472
+ - 'test/abnormal_states_recovery_test.rb'
473
+ - 'test/support/rescue_example.rb'
474
+
475
+ # Offense count: 29
476
+ # Cop supports --auto-correct.
477
+ # Configuration parameters: AutoCorrect, EnforcedStyle.
187
478
  # SupportedStyles: nested, compact
188
479
  Style/ClassAndModuleChildren:
189
480
  Enabled: false
190
481
 
191
- # Offense count: 3
192
- # Cop supports --auto-correct.
193
- # Configuration parameters: EnforcedStyle, SupportedStyles.
194
- # SupportedStyles: is_a?, kind_of?
195
- Style/ClassCheck:
196
- Enabled: false
197
-
198
- # Offense count: 4
482
+ # Offense count: 5
199
483
  # Cop supports --auto-correct.
200
484
  Style/ColonMethodCall:
201
- Enabled: false
485
+ Exclude:
486
+ - 'doc/pages/plugins/graphviz.rb'
487
+ - 'doc/pages/plugins/plantuml.rb'
488
+ - 'test/executor_test.rb'
202
489
 
203
490
  # Offense count: 5
204
491
  # Cop supports --auto-correct.
205
492
  # Configuration parameters: Keywords.
206
493
  # Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
207
494
  Style/CommentAnnotation:
208
- Enabled: false
209
-
210
- # Offense count: 4
211
- Style/ConstantName:
212
- Enabled: false
213
-
214
- # Offense count: 3
215
- # Cop supports --auto-correct.
216
- Style/DeprecatedHashMethods:
217
- Enabled: false
495
+ Exclude:
496
+ - 'doc/pages/plugins/tags.rb'
497
+ - 'examples/remote_executor.rb'
498
+ - 'lib/dynflow.rb'
499
+ - 'lib/dynflow/world.rb'
500
+ - 'test/support/code_workflow_example.rb'
218
501
 
219
- # Offense count: 172
220
- Style/Documentation:
221
- Enabled: false
502
+ # Offense count: 1
503
+ Style/CommentedKeyword:
504
+ Exclude:
505
+ - 'doc/pages/plugins/plantuml.rb'
222
506
 
223
- # Offense count: 20
507
+ # Offense count: 1
224
508
  # Cop supports --auto-correct.
225
- # Configuration parameters: EnforcedStyle, SupportedStyles.
226
- # SupportedStyles: leading, trailing
227
- Style/DotPosition:
228
- Enabled: false
229
-
230
- # Offense count: 3
231
- Style/DoubleNegation:
232
- Enabled: false
509
+ Style/Dir:
510
+ Exclude:
511
+ - 'test/test_helper.rb'
233
512
 
234
513
  # Offense count: 1
235
- Style/EachWithObject:
236
- Enabled: false
514
+ # Configuration parameters: EnforcedStyle.
515
+ # SupportedStyles: allowed_in_returns, forbidden
516
+ Style/DoubleNegation:
517
+ Exclude:
518
+ - 'lib/dynflow/config.rb'
237
519
 
238
520
  # Offense count: 2
239
521
  # Cop supports --auto-correct.
240
- # Configuration parameters: EnforcedStyle, SupportedStyles.
241
- # SupportedStyles: empty, nil, both
242
- Style/EmptyElse:
243
- Enabled: false
244
-
245
- # Offense count: 5
246
- # Cop supports --auto-correct.
247
- # Configuration parameters: AllowAdjacentOneLineDefs.
248
- Style/EmptyLineBetweenDefs:
249
- Enabled: false
522
+ Style/EachWithObject:
523
+ Exclude:
524
+ - 'lib/dynflow/execution_plan.rb'
250
525
 
251
526
  # Offense count: 1
252
527
  # Cop supports --auto-correct.
253
- Style/EmptyLinesAroundAccessModifier:
254
- Enabled: false
528
+ Style/EmptyCaseCondition:
529
+ Exclude:
530
+ - 'lib/dynflow/serializer.rb'
255
531
 
256
- # Offense count: 91
532
+ # Offense count: 2
257
533
  # Cop supports --auto-correct.
258
- # Configuration parameters: EnforcedStyle, SupportedStyles.
259
- # SupportedStyles: empty_lines, no_empty_lines
260
- Style/EmptyLinesAroundBlockBody:
261
- Enabled: false
534
+ # Configuration parameters: EnforcedStyle.
535
+ # SupportedStyles: empty, nil, both
536
+ Style/EmptyElse:
537
+ Exclude:
538
+ - 'lib/dynflow/action.rb'
539
+ - 'lib/dynflow/execution_plan.rb'
262
540
 
263
- # Offense count: 143
541
+ # Offense count: 9
264
542
  # Cop supports --auto-correct.
265
- # Configuration parameters: EnforcedStyle, SupportedStyles.
266
- # SupportedStyles: empty_lines, no_empty_lines
267
- Style/EmptyLinesAroundClassBody:
268
- Enabled: false
543
+ # Configuration parameters: EnforcedStyle.
544
+ # SupportedStyles: compact, expanded
545
+ Style/EmptyMethod:
546
+ Exclude:
547
+ - 'test/action_test.rb'
548
+ - 'test/execution_plan_cleaner_test.rb'
549
+ - 'test/executor_test.rb'
550
+ - 'test/support/dummy_example.rb'
269
551
 
270
- # Offense count: 2
552
+ # Offense count: 7
271
553
  # Cop supports --auto-correct.
272
- Style/EmptyLinesAroundMethodBody:
273
- Enabled: false
554
+ Style/Encoding:
555
+ Exclude:
556
+ - 'dynflow.gemspec'
557
+ - 'examples/remote_executor.rb'
558
+ - 'lib/dynflow/rails.rb'
559
+ - 'lib/dynflow/world.rb'
560
+ - 'test/abnormal_states_recovery_test.rb'
561
+ - 'test/executor_test.rb'
562
+ - 'test/round_robin_test.rb'
274
563
 
275
- # Offense count: 52
276
- # Cop supports --auto-correct.
277
- # Configuration parameters: EnforcedStyle, SupportedStyles.
278
- # SupportedStyles: empty_lines, no_empty_lines
279
- Style/EmptyLinesAroundModuleBody:
280
- Enabled: false
281
-
282
- # Offense count: 9
564
+ # Offense count: 8
283
565
  # Cop supports --auto-correct.
284
- # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
285
- # SupportedStyles: consistent, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
286
- Style/FirstParameterIndentation:
287
- Enabled: false
566
+ Style/ExpandPathArguments:
567
+ Exclude:
568
+ - 'dynflow.gemspec'
569
+ - 'examples/example_helper.rb'
570
+ - 'examples/remote_executor.rb'
571
+ - 'lib/dynflow/persistence_adapters/sequel.rb'
572
+ - 'lib/dynflow/rails.rb'
573
+ - 'lib/dynflow/web.rb'
574
+ - 'test/daemon_test.rb'
288
575
 
289
576
  # Offense count: 4
290
- # Configuration parameters: EnforcedStyle, SupportedStyles.
577
+ # Cop supports --auto-correct.
578
+ # Configuration parameters: EnforcedStyle.
291
579
  # SupportedStyles: format, sprintf, percent
292
580
  Style/FormatString:
293
- Enabled: false
581
+ Exclude:
582
+ - 'lib/dynflow/coordinator.rb'
583
+ - 'lib/dynflow/web/console_helpers.rb'
584
+
585
+ # Offense count: 31
586
+ # Configuration parameters: EnforcedStyle.
587
+ # SupportedStyles: annotated, template, unannotated
588
+ Style/FormatStringToken:
589
+ Exclude:
590
+ - 'lib/dynflow/action.rb'
591
+ - 'lib/dynflow/actor.rb'
592
+ - 'lib/dynflow/coordinator.rb'
593
+ - 'lib/dynflow/execution_plan.rb'
594
+ - 'lib/dynflow/execution_plan/steps/error.rb'
595
+ - 'lib/dynflow/logger_adapters/simple.rb'
596
+ - 'lib/dynflow/web/console_helpers.rb'
294
597
 
295
598
  # Offense count: 7
296
599
  # Configuration parameters: AllowedVariables.
297
600
  Style/GlobalVars:
298
- Enabled: false
601
+ Exclude:
602
+ - 'test/executor_test.rb'
603
+ - 'test/support/dummy_example.rb'
604
+ - 'test/testing_test.rb'
299
605
 
300
- # Offense count: 13
606
+ # Offense count: 60
301
607
  # Configuration parameters: MinBodyLength.
302
608
  Style/GuardClause:
303
609
  Enabled: false
304
610
 
305
- # Offense count: 106
611
+ # Offense count: 10
306
612
  # Cop supports --auto-correct.
307
- # Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues.
308
- # SupportedStyles: ruby19, ruby19_no_mixed_keys, hash_rockets
613
+ # Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
614
+ # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
309
615
  Style/HashSyntax:
310
- Enabled: false
616
+ Exclude:
617
+ - 'lib/dynflow/persistence_adapters/sequel.rb'
618
+ - 'test/persistence_test.rb'
311
619
 
312
- # Offense count: 4
620
+ # Offense count: 8
621
+ # Configuration parameters: AllowIfModifier.
313
622
  Style/IfInsideElse:
314
- Enabled: false
623
+ Exclude:
624
+ - 'lib/dynflow/action/rescue.rb'
625
+ - 'lib/dynflow/action/with_polling_sub_plans.rb'
626
+ - 'lib/dynflow/clock.rb'
627
+ - 'lib/dynflow/dispatcher/client_dispatcher.rb'
628
+ - 'lib/dynflow/rails/configuration.rb'
629
+ - 'lib/dynflow/utils.rb'
630
+ - 'lib/dynflow/world/invalidation.rb'
315
631
 
316
- # Offense count: 22
632
+ # Offense count: 69
317
633
  # Cop supports --auto-correct.
318
- # Configuration parameters: MaxLineLength.
319
634
  Style/IfUnlessModifier:
320
635
  Enabled: false
321
636
 
322
- # Offense count: 4
323
- # Cop supports --auto-correct.
324
- # Configuration parameters: IndentationWidth.
325
- Style/IndentAssignment:
326
- Enabled: false
327
-
328
- # Offense count: 2
637
+ # Offense count: 1
329
638
  # Cop supports --auto-correct.
330
- # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
331
- # SupportedStyles: special_inside_parentheses, consistent, align_braces
332
- Style/IndentHash:
333
- Enabled: false
639
+ # Configuration parameters: InverseMethods, InverseBlocks.
640
+ Style/InverseMethods:
641
+ Exclude:
642
+ - 'lib/dynflow/middleware/resolver.rb'
334
643
 
335
644
  # Offense count: 8
336
645
  # Cop supports --auto-correct.
646
+ # Configuration parameters: EnforcedStyle.
647
+ # SupportedStyles: line_count_dependent, lambda, literal
337
648
  Style/Lambda:
338
- Enabled: false
339
-
340
- # Offense count: 13
341
- # Cop supports --auto-correct.
342
- # Configuration parameters: EnforcedStyle, SupportedStyles.
343
- # SupportedStyles: call, braces
344
- Style/LambdaCall:
345
- Enabled: false
346
-
347
- # Offense count: 3
348
- # Cop supports --auto-correct.
349
- Style/LineEndConcatenation:
350
- Enabled: false
649
+ Exclude:
650
+ - 'lib/dynflow/action.rb'
651
+ - 'lib/dynflow/extensions/msgpack.rb'
652
+ - 'lib/dynflow/rails/daemon.rb'
653
+ - 'lib/dynflow/testing/mimic.rb'
654
+ - 'test/concurrency_control_test.rb'
655
+ - 'test/test_helper.rb'
351
656
 
352
- # Offense count: 3
657
+ # Offense count: 12
353
658
  # Cop supports --auto-correct.
354
- Style/MethodCallParentheses:
355
- Enabled: false
659
+ # Configuration parameters: IgnoredMethods.
660
+ Style/MethodCallWithoutArgsParentheses:
661
+ Exclude:
662
+ - 'doc/pages/plugins/plantuml.rb'
663
+ - 'lib/dynflow/delayed_executors/abstract_core.rb'
664
+ - 'lib/dynflow/director.rb'
665
+ - 'test/action_test.rb'
666
+ - 'test/dispatcher_test.rb'
667
+ - 'test/v2_sub_plans_test.rb'
356
668
 
357
- # Offense count: 2
669
+ # Offense count: 1
358
670
  # Cop supports --auto-correct.
359
- # Configuration parameters: EnforcedStyle, SupportedStyles.
671
+ # Configuration parameters: EnforcedStyle.
360
672
  # SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline
361
673
  Style/MethodDefParentheses:
362
- Enabled: false
674
+ Exclude:
675
+ - 'doc/pages/plugins/graphviz.rb'
363
676
 
364
- # Offense count: 6
677
+ # Offense count: 1
678
+ Style/MissingRespondToMissing:
679
+ Exclude:
680
+ - 'lib/dynflow/config.rb'
681
+
682
+ # Offense count: 5
365
683
  Style/MultilineBlockChain:
366
- Enabled: false
684
+ Exclude:
685
+ - 'lib/dynflow/dispatcher/executor_dispatcher.rb'
686
+ - 'lib/dynflow/world.rb'
687
+ - 'test/executor_test.rb'
688
+
689
+ # Offense count: 3
690
+ # Cop supports --auto-correct.
691
+ Style/MultilineIfModifier:
692
+ Exclude:
693
+ - 'lib/dynflow/action.rb'
694
+ - 'lib/dynflow/execution_plan.rb'
367
695
 
368
696
  # Offense count: 1
369
697
  # Cop supports --auto-correct.
370
698
  Style/MultilineIfThen:
371
- Enabled: false
699
+ Exclude:
700
+ - 'doc/pages/plugins/graphviz.rb'
372
701
 
373
- # Offense count: 23
702
+ # Offense count: 3
374
703
  # Cop supports --auto-correct.
375
- # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
376
- # SupportedStyles: aligned, indented
377
- Style/MultilineMethodCallIndentation:
378
- Enabled: false
704
+ Style/MultilineWhenThen:
705
+ Exclude:
706
+ - 'doc/pages/plugins/graphviz.rb'
379
707
 
380
- # Offense count: 9
708
+ # Offense count: 1
709
+ Style/MultipleComparison:
710
+ Exclude:
711
+ - 'test/action_test.rb'
712
+
713
+ # Offense count: 4
381
714
  # Cop supports --auto-correct.
715
+ # Configuration parameters: EnforcedStyle.
716
+ # SupportedStyles: literals, strict
382
717
  Style/MutableConstant:
383
- Enabled: false
718
+ Exclude:
719
+ - 'doc/pages/plugins/alert_block.rb'
720
+ - 'lib/dynflow/persistence_adapters/sequel.rb'
384
721
 
385
722
  # Offense count: 5
386
723
  # Cop supports --auto-correct.
724
+ # Configuration parameters: EnforcedStyle.
725
+ # SupportedStyles: both, prefix, postfix
387
726
  Style/NegatedIf:
388
- Enabled: false
727
+ Exclude:
728
+ - 'doc/pages/plugins/graphviz.rb'
729
+ - 'doc/pages/plugins/plantuml.rb'
730
+ - 'doc/pages/plugins/tags.rb'
731
+ - 'lib/dynflow/actor.rb'
389
732
 
390
- # Offense count: 9
733
+ # Offense count: 11
734
+ # Cop supports --auto-correct.
735
+ # Configuration parameters: AllowedMethods.
736
+ # AllowedMethods: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
391
737
  Style/NestedParenthesizedCalls:
392
- Enabled: false
738
+ Exclude:
739
+ - 'lib/dynflow/persistence_adapters/sequel.rb'
740
+ - 'lib/dynflow/web/console.rb'
393
741
 
394
- # Offense count: 2
742
+ # Offense count: 1
395
743
  # Cop supports --auto-correct.
396
- # Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
744
+ # Configuration parameters: EnforcedStyle, MinBodyLength.
397
745
  # SupportedStyles: skip_modifier_ifs, always
398
746
  Style/Next:
399
- Enabled: false
747
+ Exclude:
748
+ - 'doc/pages/plugins/tags.rb'
400
749
 
401
750
  # Offense count: 2
402
751
  # Cop supports --auto-correct.
403
752
  Style/Not:
404
- Enabled: false
405
-
406
- # Offense count: 2
407
- Style/OpMethod:
408
- Enabled: false
753
+ Exclude:
754
+ - 'doc/pages/plugins/graphviz.rb'
755
+ - 'doc/pages/plugins/tags.rb'
756
+
757
+ # Offense count: 15
758
+ # Cop supports --auto-correct.
759
+ # Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
760
+ # SupportedStyles: predicate, comparison
761
+ Style/NumericPredicate:
762
+ Exclude:
763
+ - 'spec/**/*'
764
+ - 'lib/dynflow/action/v2/with_sub_plans.rb'
765
+ - 'lib/dynflow/action/with_bulk_sub_plans.rb'
766
+ - 'lib/dynflow/action/with_sub_plans.rb'
767
+ - 'lib/dynflow/execution_plan.rb'
768
+ - 'lib/dynflow/flows/abstract.rb'
769
+ - 'lib/dynflow/rails.rb'
770
+ - 'lib/dynflow/rails/daemon.rb'
771
+ - 'lib/dynflow/semaphores/aggregating.rb'
772
+ - 'lib/dynflow/semaphores/stateful.rb'
773
+ - 'test/execution_plan_hooks_test.rb'
409
774
 
410
775
  # Offense count: 5
411
776
  # Cop supports --auto-correct.
412
777
  Style/ParallelAssignment:
413
- Enabled: false
778
+ Exclude:
779
+ - 'doc/pages/plugins/tags.rb'
780
+ - 'test/executor_test.rb'
781
+ - 'test/support/test_execution_log.rb'
782
+ - 'test/test_helper.rb'
414
783
 
415
- # Offense count: 24
784
+ # Offense count: 45
416
785
  # Cop supports --auto-correct.
417
786
  # Configuration parameters: PreferredDelimiters.
418
787
  Style/PercentLiteralDelimiters:
@@ -421,44 +790,67 @@ Style/PercentLiteralDelimiters:
421
790
  # Offense count: 1
422
791
  # Cop supports --auto-correct.
423
792
  Style/PerlBackrefs:
424
- Enabled: false
793
+ Exclude:
794
+ - 'test/support/dummy_example.rb'
425
795
 
426
- # Offense count: 4
427
- # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
428
- # NamePrefix: is_, has_, have_
429
- # NamePrefixBlacklist: is_, has_, have_
430
- # NameWhitelist: is_a?
431
- Style/PredicateName:
432
- Enabled: false
796
+ # Offense count: 2
797
+ # Cop supports --auto-correct.
798
+ # Configuration parameters: EnforcedStyle.
799
+ # SupportedStyles: short, verbose
800
+ Style/PreferredHashMethods:
801
+ Exclude:
802
+ - 'lib/dynflow/middleware/resolver.rb'
803
+ - 'lib/dynflow/world.rb'
433
804
 
434
805
  # Offense count: 6
435
806
  # Cop supports --auto-correct.
436
807
  Style/Proc:
437
- Enabled: false
808
+ Exclude:
809
+ - 'examples/remote_executor.rb'
810
+ - 'test/abnormal_states_recovery_test.rb'
811
+ - 'test/dispatcher_test.rb'
438
812
 
439
- # Offense count: 4
440
- # Configuration parameters: EnforcedStyle, SupportedStyles.
813
+ # Offense count: 6
814
+ # Cop supports --auto-correct.
815
+ # Configuration parameters: EnforcedStyle.
441
816
  # SupportedStyles: compact, exploded
442
817
  Style/RaiseArgs:
443
- Enabled: false
818
+ Exclude:
819
+ - 'lib/dynflow/action/v2/with_sub_plans.rb'
820
+ - 'lib/dynflow/action/with_sub_plans.rb'
821
+ - 'lib/dynflow/coordinator.rb'
822
+ - 'lib/dynflow/coordinator_adapters/sequel.rb'
823
+ - 'lib/dynflow/dispatcher/client_dispatcher.rb'
444
824
 
445
- # Offense count: 1
825
+ # Offense count: 7
446
826
  # Cop supports --auto-correct.
447
827
  Style/RedundantBegin:
448
- Enabled: false
828
+ Exclude:
829
+ - 'examples/remote_executor.rb'
830
+ - 'lib/dynflow/execution_plan/hooks.rb'
831
+ - 'lib/dynflow/rails/daemon.rb'
832
+ - 'lib/dynflow/world.rb'
833
+ - 'test/test_helper.rb'
449
834
 
450
- # Offense count: 2
835
+ # Offense count: 1
836
+ # Cop supports --auto-correct.
837
+ Style/RedundantCapitalW:
838
+ Exclude:
839
+ - 'test/future_execution_test.rb'
840
+
841
+ # Offense count: 1
451
842
  # Cop supports --auto-correct.
452
843
  Style/RedundantParentheses:
453
- Enabled: false
844
+ Exclude:
845
+ - 'test/coordinator_test.rb'
454
846
 
455
- # Offense count: 43
847
+ # Offense count: 72
456
848
  # Cop supports --auto-correct.
457
849
  # Configuration parameters: AllowMultipleReturnValues.
458
850
  Style/RedundantReturn:
459
851
  Enabled: false
460
852
 
461
- # Offense count: 87
853
+ # Offense count: 107
462
854
  # Cop supports --auto-correct.
463
855
  Style/RedundantSelf:
464
856
  Enabled: false
@@ -466,145 +858,185 @@ Style/RedundantSelf:
466
858
  # Offense count: 1
467
859
  # Cop supports --auto-correct.
468
860
  Style/RescueModifier:
861
+ Exclude:
862
+ - 'lib/dynflow/serializer.rb'
863
+
864
+ # Offense count: 22
865
+ # Cop supports --auto-correct.
866
+ # Configuration parameters: EnforcedStyle.
867
+ # SupportedStyles: implicit, explicit
868
+ Style/RescueStandardError:
869
+ Exclude:
870
+ - 'lib/dynflow/action.rb'
871
+ - 'lib/dynflow/action/polling.rb'
872
+ - 'lib/dynflow/action/progress.rb'
873
+ - 'lib/dynflow/clock.rb'
874
+ - 'lib/dynflow/connectors/database.rb'
875
+ - 'lib/dynflow/director.rb'
876
+ - 'lib/dynflow/dispatcher/client_dispatcher.rb'
877
+ - 'lib/dynflow/execution_plan.rb'
878
+ - 'lib/dynflow/execution_plan/hooks.rb'
879
+ - 'lib/dynflow/executors/parallel.rb'
880
+ - 'lib/dynflow/rails/daemon.rb'
881
+ - 'lib/dynflow/testing/in_thread_executor.rb'
882
+ - 'lib/dynflow/testing/in_thread_world.rb'
883
+ - 'lib/dynflow/world.rb'
884
+ - 'lib/dynflow/world/invalidation.rb'
885
+
886
+ # Offense count: 21
887
+ # Cop supports --auto-correct.
888
+ # Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods.
889
+ # AllowedMethods: present?, blank?, presence, try, try!
890
+ Style/SafeNavigation:
469
891
  Enabled: false
470
892
 
471
893
  # Offense count: 6
472
894
  # Cop supports --auto-correct.
473
895
  # Configuration parameters: AllowAsExpressionSeparator.
474
896
  Style/Semicolon:
475
- Enabled: false
897
+ Exclude:
898
+ - 'test/abnormal_states_recovery_test.rb'
899
+ - 'test/concurrency_control_test.rb'
900
+ - 'test/dispatcher_test.rb'
901
+ - 'test/executor_test.rb'
476
902
 
477
903
  # Offense count: 3
478
904
  # Cop supports --auto-correct.
479
- # Configuration parameters: EnforcedStyle, SupportedStyles.
905
+ # Configuration parameters: EnforcedStyle.
480
906
  # SupportedStyles: only_raise, only_fail, semantic
481
907
  Style/SignalException:
482
- Enabled: false
483
-
484
- # Offense count: 6
485
- # Configuration parameters: Methods.
486
- # Methods: {"reduce"=>["a", "e"]}, {"inject"=>["a", "e"]}
487
- Style/SingleLineBlockParams:
488
- Enabled: false
908
+ Exclude:
909
+ - 'lib/dynflow/action/singleton.rb'
910
+ - 'lib/dynflow/action/timeouts.rb'
911
+ - 'lib/dynflow/action/with_sub_plans.rb'
489
912
 
490
913
  # Offense count: 6
491
914
  # Cop supports --auto-correct.
492
915
  # Configuration parameters: AllowIfMethodIsEmpty.
493
916
  Style/SingleLineMethods:
494
- Enabled: false
495
-
496
- # Offense count: 42
497
- # Cop supports --auto-correct.
498
- # Configuration parameters: AllowForAlignment.
499
- Style/SpaceAroundOperators:
500
- Enabled: false
501
-
502
- # Offense count: 1
503
- # Cop supports --auto-correct.
504
- Style/SpaceBeforeComma:
505
- Enabled: false
506
-
507
- # Offense count: 3
508
- # Cop supports --auto-correct.
509
- # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
510
- # SupportedStyles: space, no_space
511
- Style/SpaceInsideBlockBraces:
512
- Enabled: false
917
+ Exclude:
918
+ - 'lib/dynflow/utils/indifferent_hash.rb'
919
+ - 'test/support/dummy_example.rb'
513
920
 
514
- # Offense count: 7
515
- # Cop supports --auto-correct.
516
- # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
517
- # SupportedStyles: space, no_space
518
- Style/SpaceInsideHashLiteralBraces:
519
- Enabled: false
520
-
521
- # Offense count: 7
522
- # Cop supports --auto-correct.
523
- Style/SpaceInsideParens:
524
- Enabled: false
525
-
526
- # Offense count: 8
527
- # Cop supports --auto-correct.
528
- # Configuration parameters: EnforcedStyle, SupportedStyles.
529
- # SupportedStyles: space, no_space
530
- Style/SpaceInsideStringInterpolation:
531
- Enabled: false
532
-
533
- # Offense count: 9
921
+ # Offense count: 14
534
922
  # Cop supports --auto-correct.
535
- # Configuration parameters: EnforcedStyle, SupportedStyles.
923
+ # Configuration parameters: EnforcedStyle.
536
924
  # SupportedStyles: use_perl_names, use_english_names
537
925
  Style/SpecialGlobalVars:
538
- Enabled: false
926
+ Exclude:
927
+ - 'dynflow.gemspec'
928
+ - 'examples/chunked_output_benchmark.rb'
929
+ - 'examples/example_helper.rb'
930
+ - 'examples/future_execution.rb'
931
+ - 'examples/memory_limit_watcher.rb'
932
+ - 'examples/orchestrate.rb'
933
+ - 'examples/orchestrate_evented.rb'
934
+ - 'examples/remote_executor.rb'
935
+ - 'examples/singletons.rb'
936
+ - 'examples/sub_plan_concurrency_control.rb'
937
+ - 'examples/sub_plans.rb'
938
+ - 'examples/sub_plans_v2.rb'
939
+ - 'examples/termination.rb'
539
940
 
540
- # Offense count: 5
941
+ # Offense count: 4
541
942
  # Cop supports --auto-correct.
542
- # Configuration parameters: EnforcedStyle, SupportedStyles.
943
+ # Configuration parameters: EnforcedStyle.
543
944
  # SupportedStyles: require_parentheses, require_no_parentheses
544
945
  Style/StabbyLambdaParentheses:
545
- Enabled: false
946
+ Exclude:
947
+ - 'lib/dynflow/action.rb'
948
+ - 'lib/dynflow/clock.rb'
949
+ - 'lib/dynflow/testing/mimic.rb'
546
950
 
547
- # Offense count: 230
951
+ # Offense count: 2
548
952
  # Cop supports --auto-correct.
549
- # Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
550
- # SupportedStyles: single_quotes, double_quotes
551
- Style/StringLiterals:
552
- Enabled: false
953
+ Style/StderrPuts:
954
+ Exclude:
955
+ - 'lib/dynflow/rails/daemon.rb'
553
956
 
554
957
  # Offense count: 2
555
958
  # Cop supports --auto-correct.
556
- # Configuration parameters: EnforcedStyle, SupportedStyles.
959
+ # Configuration parameters: EnforcedStyle.
557
960
  # SupportedStyles: single_quotes, double_quotes
558
961
  Style/StringLiteralsInInterpolation:
559
- Enabled: false
962
+ Exclude:
963
+ - 'lib/dynflow/web/console.rb'
964
+ - 'lib/dynflow/web/console_helpers.rb'
560
965
 
561
- # Offense count: 9
966
+ # Offense count: 10
562
967
  # Cop supports --auto-correct.
563
968
  # Configuration parameters: IgnoredMethods.
564
- # IgnoredMethods: respond_to
969
+ # IgnoredMethods: respond_to, define_method
565
970
  Style/SymbolProc:
566
- Enabled: false
567
-
568
- # Offense count: 6
569
- # Cop supports --auto-correct.
570
- # Configuration parameters: EnforcedStyle, SupportedStyles.
571
- # SupportedStyles: final_newline, final_blank_line
572
- Style/TrailingBlankLines:
573
- Enabled: false
971
+ Exclude:
972
+ - 'doc/pages/plugins/tags.rb'
973
+ - 'lib/dynflow/action.rb'
974
+ - 'lib/dynflow/action/v2/with_sub_plans.rb'
975
+ - 'lib/dynflow/action/with_polling_sub_plans.rb'
976
+ - 'lib/dynflow/action/with_sub_plans.rb'
977
+ - 'lib/dynflow/director.rb'
978
+ - 'lib/dynflow/director/sequence_cursor.rb'
979
+ - 'lib/dynflow/world.rb'
980
+ - 'test/concurrency_control_test.rb'
981
+ - 'test/test_helper.rb'
574
982
 
575
983
  # Offense count: 2
576
984
  # Cop supports --auto-correct.
577
- # Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
578
- # Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
579
- Style/TrivialAccessors:
580
- Enabled: false
985
+ # Configuration parameters: EnforcedStyleForMultiline.
986
+ # SupportedStylesForMultiline: comma, consistent_comma, no_comma
987
+ Style/TrailingCommaInArrayLiteral:
988
+ Exclude:
989
+ - 'lib/dynflow/config.rb'
990
+ - 'lib/dynflow/debug/telemetry/persistence.rb'
581
991
 
582
- # Offense count: 1
992
+ # Offense count: 9
583
993
  # Cop supports --auto-correct.
584
- Style/UnneededCapitalW:
585
- Enabled: false
994
+ # Configuration parameters: EnforcedStyleForMultiline.
995
+ # SupportedStylesForMultiline: comma, consistent_comma, no_comma
996
+ Style/TrailingCommaInHashLiteral:
997
+ Exclude:
998
+ - 'lib/dynflow/execution_plan/steps/finalize_step.rb'
999
+ - 'lib/dynflow/execution_plan/steps/run_step.rb'
1000
+ - 'lib/dynflow/persistence_adapters/sequel_migrations/022_store_flows_as_msgpack.rb'
1001
+ - 'lib/dynflow/persistence_adapters/sequel_migrations/024_store_execution_plan_data_as_msgpack.rb'
1002
+ - 'lib/dynflow/rails/daemon.rb'
1003
+ - 'lib/dynflow/semaphores/stateful.rb'
1004
+ - 'test/persistence_test.rb'
1005
+ - 'test/semaphores_test.rb'
586
1006
 
587
- # Offense count: 2
588
- # Configuration parameters: EnforcedStyle, SupportedStyles.
589
- # SupportedStyles: snake_case, camelCase
590
- Style/VariableName:
591
- Enabled: false
1007
+ # Offense count: 3
1008
+ # Cop supports --auto-correct.
1009
+ # Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, AllowedMethods.
1010
+ # AllowedMethods: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
1011
+ Style/TrivialAccessors:
1012
+ Exclude:
1013
+ - 'lib/dynflow/director.rb'
1014
+ - 'test/support/middleware_example.rb'
1015
+ - 'test/support/test_execution_log.rb'
592
1016
 
593
1017
  # Offense count: 1
594
1018
  # Cop supports --auto-correct.
595
- # Configuration parameters: MaxLineLength.
596
- Style/WhileUntilModifier:
597
- Enabled: false
1019
+ Style/UnpackFirst:
1020
+ Exclude:
1021
+ - 'lib/dynflow/persistence_adapters/sequel.rb'
598
1022
 
599
- # Offense count: 7
1023
+ # Offense count: 1
600
1024
  # Cop supports --auto-correct.
601
- # Configuration parameters: SupportedStyles, WordRegex.
602
- # SupportedStyles: percent, brackets
603
- Style/WordArray:
604
- EnforcedStyle: percent
605
- MinSize: 4
1025
+ # Configuration parameters: EnforcedStyle.
1026
+ # SupportedStyles: forbid_for_all_comparison_operators, forbid_for_equality_operators_only, require_for_all_comparison_operators, require_for_equality_operators_only
1027
+ Style/YodaCondition:
1028
+ Exclude:
1029
+ - 'lib/dynflow/actor.rb'
606
1030
 
607
1031
  # Offense count: 1
608
1032
  # Cop supports --auto-correct.
609
1033
  Style/ZeroLengthPredicate:
610
- Enabled: false
1034
+ Exclude:
1035
+ - 'lib/dynflow/flows/abstract.rb'
1036
+
1037
+ # Offense count: 86
1038
+ # Cop supports --auto-correct.
1039
+ # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
1040
+ # URISchemes: http, https
1041
+ Layout/LineLength:
1042
+ Max: 165