dynamic_router 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 59b9c8ce0c8e7f5607f7f6f66dce1a35f31292f2
-  data.tar.gz: 7b9a38b8bea748f00c1029e6e33f8264855b6fd4
+  metadata.gz: bdd251c30a19c88907ea5056b56eeb712d82db5c
+  data.tar.gz: 3cea3b2431af8ac7e7514bf74559c477e8caae62
 SHA512:
-  metadata.gz: 076391a6883e1a5457bb6572cb24bbda2c5332e36ecd12e8a86672fab621ca72a006cefc98351502fe7ef3df17c424d66bdb4f82e3074d4f2ecc0cf5324dddec
-  data.tar.gz: 3458f3b113f4d67dfe49d1ebc7baffc9da0deb32a0064fe871431d7fb66446453f7fbaacbdf0da1f10d58cff56e2acfc8adbfb1228b77f86fcdfb6c9862ea0cd
+  metadata.gz: f7cdbfdfbd559459367aa9f000c5d12a5e41232b8850f4d797f088bbd61b7645a9d399fd97e8973b4315cb73246cc2e87e69cec2c5cbad7df6ccb21fa7b95c36
+  data.tar.gz: 5ddf82072defc141a98ba7d5b34107ac77bc69aa23f9c81afb568f450f6b9aaaf228635be3002eea36bc5048b8cd329b77dce0e927b5e349a602543eccca23e8

data/README.md

@@ -26,15 +26,11 @@ Suppose you want to create a friendly URL for a resource based on fields of an e
 		# This model has a field called 'url'
 	end
 	
-You can create a route to a resource using this field as URL, just use the notation:
+To create a route to a resource using the field 'url' as URL, add the following line to your routes.rb:
 
-	class Example < ActiveRecord::Base
-		# This model has a field called 'url'
-		
-		has_dynamic_route Proc.new {|example| "/#{example.url}"}, "dummy#dummy_method"
-	end
+	DynamicRouter.has_dynamic_route_for Example, Proc.new {|example| "/#{example.url}"}, "dummy#dummy_method"
 	
-With this notation, when you create models like:
+After this when you create models like:
 
 	Example.create!(:url => "abc")
 	Example.create!(:url => "123")
@@ -43,19 +39,11 @@ The dynamic router will create the routes "/abc" and "/123" mapping to DummyCont
 
 You can pass the desired HTTP method also:
 	
-	class Example < ActiveRecord::Base
-		# This model has a field called 'url'
-		
-		has_dynamic_route Proc.new {|example| "/#{example.url}"}, "dummy#dummy_method", :method => :post
-	end
+	DynamicRouter.has_dynamic_route_for Example, Proc.new {|example| "/#{example.url}"}, "dummy#dummy_method", :method => :post
 	
 And can specify default values to be passed, like:
 
-	class Example < ActiveRecord::Base
-		# This model has two fields called 'url' and 'default_field'
-		
-		has_dynamic_route Proc.new {|example| "/#{example.url}"}, "dummy#dummy_method", :defaults => {:some_value => Proc.new {|example| example.default_field}}
-	end
+	DynamicRouter.has_dynamic_route_for Example, Proc.new {|example| "/#{example.url}"}, "dummy#dummy_method", :defaults => {:some_value => Proc.new {|example| example.default_field}}
 	
 The dynamic router will map ALL records of the model on the startup and will create an after_save hook to create new routes as the models are created. 
 

data/lib/dynamic_router/version.rb

@@ -1,3 +1,3 @@
 module DynamicRouter
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/dynamic_router.rb

@@ -1,8 +1,38 @@
 require "dynamic_router/version"
-require "dynamic_router/class_methods"
 
 module DynamicRouter
-  def self.extended(receiver)
-    receiver.extend ClassMethods
-  end
-end
+  module_function
+    def has_dynamic_route_for(klass, url, target, options = {})
+      route_method = options[:method] || :get
+      
+      if ActiveRecord::Base.connection.table_exists? klass.table_name
+        Rails.application.routes.draw do
+          klass.find_each do |model|
+            unless options[:defaults].blank?
+              defaults = {}
+              
+              options[:defaults].each do |key, value|
+                defaults[key.to_sym] = value.call(model)
+              end  
+            end
+            
+            _url = url.call(model).to_s
+            _target = target.to_s
+            
+            unless _url.blank? || _url.gsub(/\//, "").blank?
+              #puts "Routing #{route_method.to_s.upcase} #{_url}, to #{target}, defaults : #{defaults}"
+              send(route_method, _url, :to => _target, :defaults => defaults)
+            end
+          end   
+        end
+      end
+      
+      klass.class_eval do
+        after_save :create_route
+        
+        def create_route
+          Rails.application.routes_reloader.reload!
+        end
+      end
+    end
+end

data/spec/dummy/config/routes.rb

@@ -1,2 +1,3 @@
 Dummy::Application.routes.draw do
+  DynamicRouter.has_dynamic_route_for(Example, Proc.new {|example| "/#{example.first_path}/#{example.second_path}"}, "dummy#dummy_method")
 end

data/spec/dynamic_router_spec.rb

@@ -2,11 +2,8 @@ require 'spec_helper'
 
 RSpec.describe DynamicRouter do
   before(:each) do
-    class Example < ActiveRecord::Base
-      extend DynamicRouter
-    end
-    
     Example.destroy_all
+    
     Example.create!(:first_path => "path_a", :second_path => "path_a_a", :default_field => "default_value")
     Example.create!(:first_path => "path_a", :second_path => "path_a_c", :default_field => "default_value")
   end
@@ -17,30 +14,40 @@ RSpec.describe DynamicRouter do
     allow(ActiveRecord::Base).to receive(:connection).and_return(connection)
     expect(connection).to receive(:table_exists?).with(Example.table_name)
     
-    Example.send(:has_dynamic_route, Proc.new {|example| "/#{example.first_path}/#{example.second_path}"}, "dummy#dummy_method")
+    Rails.application.routes.draw do
+      DynamicRouter.has_dynamic_route_for(Example, Proc.new {|example| "/#{example.first_path}/#{example.second_path}"}, "dummy#dummy_method")
+    end
   end
   
   it "should create a get route with the supplied url" do
-    Example.send(:has_dynamic_route, Proc.new {|example| "/#{example.first_path}/#{example.second_path}"}, "dummy#dummy_method")
+    Rails.application.routes.draw do
+      DynamicRouter.has_dynamic_route_for(Example, Proc.new {|example| "/#{example.first_path}/#{example.second_path}"}, "dummy#dummy_method")
+    end
     
     expect(Rails.application.routes.recognize_path('/path_a/path_a_a', :method => :get))
     expect(Rails.application.routes.recognize_path('/path_a/path_a_c', :method => :get))
   end
   
   it "should accept the method option" do
-    Example.send(:has_dynamic_route, Proc.new {|example| "/#{example.first_path}/#{example.second_path}"}, "dummy#dummy_method", :method => :post)
+    Rails.application.routes.draw do
+      DynamicRouter.has_dynamic_route_for(Example, Proc.new {|example| "/#{example.first_path}/#{example.second_path}"}, "dummy#dummy_method", :method => :post)
+    end
     
     expect(Rails.application.routes.recognize_path('/path_a/path_a_a', :method => :post))
   end
   
   it "should accept the defaults option" do
-    Example.send(:has_dynamic_route, Proc.new {|example| "/#{example.first_path}/#{example.second_path}"}, "dummy#dummy_method", :defaults => {:default_value => Proc.new {|example| example.default_field}})
+    Rails.application.routes.draw do
+      DynamicRouter.has_dynamic_route_for(Example, Proc.new {|example| "/#{example.first_path}/#{example.second_path}"}, "dummy#dummy_method", :defaults => {:default_value => Proc.new {|example| example.default_field}})
+    end
     
     expect(Rails.application.routes.routes.named_routes["path_a_path_a_a"].defaults).to match a_hash_including(:default_value => "default_value")
   end
   
   it "should create the route after save the model" do
-    Example.send(:has_dynamic_route, Proc.new {|example| "/#{example.first_path}/#{example.second_path}"}, "dummy#dummy_method", :defaults => {:default_value => Proc.new {|example| example.default_field}})
+    Rails.application.routes.draw do
+      DynamicRouter.has_dynamic_route_for(Example, Proc.new {|example| "/#{example.first_path}/#{example.second_path}"}, "dummy#dummy_method", :defaults => {:default_value => Proc.new {|example| example.default_field}})
+    end
     
     Example.create!(:first_path => "path_a", :second_path => "path_a_b")
     
@@ -48,13 +55,17 @@ RSpec.describe DynamicRouter do
   end
   
   it "should not create the route if the url is blank" do
-    Example.send(:has_dynamic_route, Proc.new {|example| ""}, "dummy#dummy_method")
+    Rails.application.routes.draw do
+      DynamicRouter.has_dynamic_route_for(Example, Proc.new {|example| ""}, "dummy#dummy_method")
+    end
     
     expect(Rails.application.routes.routes.named_routes).to be_empty
   end
   
   it "should not create the route if the url eval to blank" do
-    Example.send(:has_dynamic_route, Proc.new {|example| "/#{example.first_path}/#{example.second_path}"}, "dummy#dummy_method")
+    Rails.application.routes.draw do
+      DynamicRouter.has_dynamic_route_for(Example, Proc.new {|example| "/#{example.first_path}/#{example.second_path}"}, "dummy#dummy_method")
+    end
     
     Example.create!(:first_path => "")
     

metadata

@@ -1,111 +1,111 @@
 --- !ruby/object:Gem::Specification
 name: dynamic_router
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Gustavo Berdugo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-15 00:00:00.000000000 Z
+date: 2014-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '4.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.1'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.10'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.7'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
 description: Use this gem to add dynamic routes to your project.
@@ -115,9 +115,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".coveralls.yml"
-- ".gitignore"
-- ".travis.yml"
+- .coveralls.yml
+- .gitignore
+- .travis.yml
 - Gemfile
 - LICENSE
 - LICENSE.txt
@@ -125,7 +125,6 @@ files:
 - Rakefile
 - dynamic_router.gemspec
 - lib/dynamic_router.rb
-- lib/dynamic_router/class_methods.rb
 - lib/dynamic_router/version.rb
 - spec/db/create_database.rb
 - spec/dummy/Rakefile
@@ -168,12 +167,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
@@ -214,4 +213,3 @@ test_files:
 - spec/dummy/script/rails
 - spec/dynamic_router_spec.rb
 - spec/spec_helper.rb
-has_rdoc: 

data/lib/dynamic_router/class_methods.rb

@@ -1,68 +0,0 @@
-module DynamicRouter
-  module ClassMethods
-    def has_dynamic_route(url, target, options = {})
-      method = options[:method] || :get
-      klass = self
-      
-      if ActiveRecord::Base.connection.table_exists? klass.table_name
-        Rails.application.routes.draw do
-          klass.find_each do |model|
-            defaults = DynamicRouter::ClassMethods.parse_defaults(options[:defaults], model)
-            
-            DynamicRouter::ClassMethods.draw_route(self, method, url.call(model).to_s, target.to_s, defaults)
-          end
-        end
-      end
-      
-      add_after_save_callback(klass, method, url, target, options[:defaults])
-    end
-    
-    def add_after_save_callback(klass, method, url, target, defaults)
-      klass.cattr_accessor :_method
-      klass.cattr_accessor :_url
-      klass.cattr_accessor :_target
-      klass.cattr_accessor :_defaults
-      
-      klass._method = method
-      klass._url = url
-      klass._target = target
-      klass._defaults = defaults
-      
-      klass.class_eval do
-        after_save :create_route
-        
-        def create_route
-          klass = self
-          
-          _routes = Rails.application.routes
-          _routes.disable_clear_and_finalize = true
-          
-          _routes.draw do
-            defaults = DynamicRouter::ClassMethods.parse_defaults(klass._defaults, klass)
-            
-            DynamicRouter::ClassMethods.draw_route(self, klass._method, klass._url.call(klass).to_s, klass._target.to_s, defaults)
-          end
-          
-          _routes.disable_clear_and_finalize = false
-        end
-      end
-    end
-    
-    module_function
-      def parse_defaults(_defaults, klass)
-        unless _defaults.blank?
-          defaults = {}
-          
-          _defaults.each do |key, value|
-            defaults[key.to_sym] = value.call(klass)
-          end  
-        end
-        
-        defaults
-      end
-      
-      def draw_route(route, method, url, target, defaults)
-        route.send(method, url, :to => target, :defaults => defaults) unless url.blank? || url.gsub(/\//, "").blank?
-      end
-  end
-end