dynamic_migrations 3.8.6 → 3.8.8

data/lib/dynamic_migrations/postgres/server/database/differences/to_migrations/schemas/tables/validations.rb

@@ -11,10 +11,10 @@ module DynamicMigrations
                 module Validations
                   def process_validations schema_name, table_name, configuration_validations, database_validations
                     # process all the validations
-                    log.info "    Processing Validations..."
+                    log.debug "    Processing Validations"
                     validation_names = (configuration_validations.keys + database_validations.keys).uniq
                     validation_names.each do |validation_name|
-                      log.info "    Processing Validation #{validation_name}..."
+                      log.debug "    Processing Validation #{validation_name}"
                       process_validation schema_name, table_name, validation_name, configuration_validations[validation_name] || {}, database_validations[validation_name] || {}
                     end
                   end
@@ -23,7 +23,7 @@ module DynamicMigrations
                     # If the validation exists in the configuration but not in the database
                     # then we have to create it.
                     if configuration_validation[:exists] == true && !database_validation[:exists]
-                      log.info "    Validation `#{validation_name}` exists in configuration but not in the database"
+                      log.debug "    Validation `#{validation_name}` exists in configuration but not in the database"
 
                       # a migration to create the validation
                       validation = @database.configured_schema(schema_name).table(table_name).validation(validation_name)
@@ -32,7 +32,7 @@ module DynamicMigrations
                     # If the schema exists in the database but not in the configuration
                     # then we need to delete it.
                     elsif database_validation[:exists] == true && !configuration_validation[:exists]
-                      log.info "    Validation `#{validation_name}` exists in database but not in the configuration"
+                      log.debug "    Validation `#{validation_name}` exists in database but not in the configuration"
 
                       # a migration to create the validation
                       validation = @database.loaded_schema(schema_name).table(table_name).validation(validation_name)
@@ -42,9 +42,9 @@ module DynamicMigrations
                     # but the definition (except description, which is handled seeprately below) is different
                     # then we need to update the definition.
                     elsif configuration_validation.except(:exists, :description).filter { |name, attributes| attributes[:matches] == false }.any?
-                      log.info "    Validation `#{validation_name}` exists in both configuration and the database"
+                      log.debug "    Validation `#{validation_name}` exists in both configuration and the database"
 
-                      log.info "      Validation `#{validation_name}` is different"
+                      log.debug "      Validation `#{validation_name}` is different"
                       # recreate the validation
                       original_validation = @database.loaded_schema(schema_name).table(table_name).validation(validation_name)
                       updated_validation = @database.configured_schema(schema_name).table(table_name).validation(validation_name)
@@ -53,10 +53,10 @@ module DynamicMigrations
                       if configuration_validation[:description][:matches] == false
                         # if the description was removed
                         if configuration_validation[:description].nil?
-                          log.info "      Validation `#{validation_name}` description exists in database but not in the configuration"
+                          log.debug "      Validation `#{validation_name}` description exists in database but not in the configuration"
                           @generator.remove_validation_comment updated_validation
                         else
-                          log.info "      Validation `#{validation_name}` does not match"
+                          log.debug "      Validation `#{validation_name}` does not match"
                           @generator.set_validation_comment updated_validation
                         end
                       end
@@ -64,15 +64,15 @@ module DynamicMigrations
                     # If the validation exists in both the configuration and database representations
                     # but the description is different then we need to update the description.
                     elsif configuration_validation[:description][:matches] == false
-                      log.info "    Validation `#{validation_name}` exists in both configuration and the database"
+                      log.debug "    Validation `#{validation_name}` exists in both configuration and the database"
 
                       validation = @database.configured_schema(schema_name).table(table_name).validation(validation_name)
                       # if the description was removed
                       if configuration_validation[:description].nil?
-                        log.info "      Validation `#{validation_name}` description exists in database but not in the configuration"
+                        log.debug "      Validation `#{validation_name}` description exists in database but not in the configuration"
                         @generator.remove_validation_comment validation
                       else
-                        log.info "      Validation `#{validation_name}` does not match"
+                        log.debug "      Validation `#{validation_name}` does not match"
                         @generator.set_validation_comment validation
                       end
                     end

data/lib/dynamic_migrations/postgres/server/database/differences/to_migrations/schemas/tables.rb

@@ -10,10 +10,10 @@ module DynamicMigrations
               module Tables
                 def process_tables schema_name, configuration_tables, database_tables
                   # process all the tables
-                  log.info "  Processing Tables..."
+                  log.debug "  Processing Tables"
                   table_names = (configuration_tables.keys + database_tables.keys).uniq
                   table_names.each do |table_name|
-                    log.info "  Processing Table #{table_name}..."
+                    log.debug "  Processing Table #{table_name}"
                     process_table schema_name, table_name, configuration_tables[table_name] || {}, database_tables[table_name] || {}
                   end
                 end
@@ -22,7 +22,7 @@ module DynamicMigrations
                   # If the table exists in the configuration but not in the database
                   # then we have to create it.
                   if configuration_table[:exists] == true && !database_table[:exists]
-                    log.info "  Table `#{table_name}` exists in configuration but not in the database"
+                    log.debug "  Table `#{table_name}` exists in configuration but not in the database"
 
                     # a migration to create the table
                     table = @database.configured_schema(schema_name).table(table_name)
@@ -35,7 +35,7 @@ module DynamicMigrations
                   # If the schema exists in the database but not in the configuration
                   # then we need to delete it.
                   elsif database_table[:exists] == true && !configuration_table[:exists]
-                    log.info "  Table `#{table_name}` exists in database but not in the configuration"
+                    log.debug "  Table `#{table_name}` exists in database but not in the configuration"
 
                     # we process everything else before we drop the table, because the other
                     # database objects are dependent on the table
@@ -48,15 +48,15 @@ module DynamicMigrations
                   # If the table exists in both the configuration and database representations
                   # but the description is different then we need to update the description.
                   elsif configuration_table[:description][:matches] == false
-                    log.info "  Table `#{table_name}` exists in both configuration and the database"
+                    log.debug "  Table `#{table_name}` exists in both configuration and the database"
 
                     table = @database.configured_schema(schema_name).table(table_name)
                     # if the description was removed
                     if configuration_table[:description].nil?
-                      log.info "    Table `#{table_name}` description exists in database but not in the configuration"
+                      log.debug "    Table `#{table_name}` description exists in database but not in the configuration"
                       @generator.remove_table_comment table
                     else
-                      log.info "    Table `#{table_name}` description does not match"
+                      log.debug "    Table `#{table_name}` description does not match"
                       @generator.set_table_comment table
                     end
 
@@ -64,7 +64,7 @@ module DynamicMigrations
                     process_dependents schema_name, table_name, configuration_table, database_table
 
                   else
-                    log.info "  Table `#{table_name}` exists in both configuration and the database"
+                    log.debug "  Table `#{table_name}` exists in both configuration and the database"
                     # process everything else
                     process_dependents schema_name, table_name, configuration_table, database_table
 

data/lib/dynamic_migrations/postgres/server/database/differences/to_migrations/schemas.rb

@@ -11,7 +11,7 @@ module DynamicMigrations
                 # if the schema exists in the configuration but not in the database
                 # then we have to create it
                 if configuration_schema[:exists] == true && !database_schema[:exists]
-                  log.info "Schema `#{schema_name}` exists in configuration but not in the database"
+                  log.debug "Schema `#{schema_name}` exists in configuration but not in the database"
 
                   # a migration to create the schema
                   schema = @database.configured_schema schema_name
@@ -26,7 +26,7 @@ module DynamicMigrations
                 # if the schema exists in the database but not in the configuration
                 # then we need to delete it
                 elsif database_schema[:exists] == true && !configuration_schema[:exists]
-                  log.info "Schema `#{schema_name}` exists in database but not in the configuration"
+                  log.debug "Schema `#{schema_name}` exists in database but not in the configuration"
                   # we process the tables and functions before we drop the schema
                   # as this will drop any dependencies on the schema
                   process_functions schema_name, {}, database_schema[:functions]
@@ -40,7 +40,7 @@ module DynamicMigrations
                 # if the schema exists in both the configuration and database representations
                 # then we just need to process the tables and functions
                 else
-                  log.info "Schema `#{schema_name}` exists in both configuration and the database"
+                  log.debug "Schema `#{schema_name}` exists in both configuration and the database"
                   process_functions schema_name, configuration_schema[:functions], database_schema[:functions]
                   process_enums schema_name, configuration_schema[:enums], database_schema[:enums]
                   process_tables schema_name, configuration_schema[:tables], database_schema[:tables]

data/lib/dynamic_migrations/postgres/server/database/differences/to_migrations.rb

@@ -40,19 +40,19 @@ module DynamicMigrations
 
             def migrations
               # process all the extensions
-              log.info "Processing Extensions..."
+              log.debug "Processing Extensions"
               extension_names = differences[:configuration][:extensions].keys
               extension_names.each do |extension_name|
-                log.info "Processing Extension `#{extension_name}`..."
+                log.debug "Processing Extension `#{extension_name}`"
                 process_extension extension_name, differences[:configuration][:extensions][extension_name], differences[:database][:extensions][extension_name]
               end
 
               # process all the schemas (we can fetch the schema names from either the
               # configuration or the database object)
-              log.info "Processing Schemas..."
+              log.debug "Processing Schemas"
               schema_names = differences[:configuration][:schemas].keys
               schema_names.each do |schema_name|
-                log.info "Processing Schema `#{schema_name}`..."
+                log.debug "Processing Schema `#{schema_name}`"
                 process_schema schema_name, differences[:configuration][:schemas][schema_name], differences[:database][:schemas][schema_name]
               end
 

data/lib/dynamic_migrations/postgres/server/database/differences.rb

@@ -33,18 +33,18 @@ module DynamicMigrations
           # return a hash representing any differenced betweek the loaded and configured
           # versions of the current database
           def to_h
-            log.info "Building differences between configured and loaded database structure..."
+            log.info "Building differences between configured and loaded database structure"
 
             # build progressively, so we can add logging around the two different opperations
             results = {}
 
-            log.info "Comparing configured database structure to loaded database structure..."
+            log.info "Comparing configured database structure to loaded database structure"
             results[:configuration] = {
               schemas: self.class.compare_schemas(@database.configured_schemas_hash, @database.loaded_schemas_hash),
               extensions: self.class.compare_extensions(@database.configured_extensions, @database.loaded_extensions)
             }
 
-            log.info "Comparing loaded database structure to configured database structure..."
+            log.info "Comparing loaded database structure to configured database structure"
             results[:database] = {
               schemas: self.class.compare_schemas(@database.loaded_schemas_hash, @database.configured_schemas_hash),
               extensions: self.class.compare_extensions(@database.loaded_extensions, @database.configured_extensions)
@@ -53,7 +53,7 @@ module DynamicMigrations
           end
 
           def self.compare_extensions extensions, comparison_extensions
-            log.info "Comparing Extensions..."
+            log.info "Comparing Extensions"
 
             result = {}
             # the extensions
@@ -76,7 +76,7 @@ module DynamicMigrations
           end
 
           def self.compare_schemas schemas, comparison_schemas
-            log.info "Comparing Schemas..."
+            log.info "Comparing Schemas"
 
             result = {}
             # the base schemas
@@ -118,7 +118,7 @@ module DynamicMigrations
           # an object which represents the provided `tables` and any differences
           # between it and the `comparison_tables`
           def self.compare_tables tables, comparison_tables
-            log.info "Comparing Tables..."
+            log.debug "Comparing Tables"
 
             result = {}
             # the base tables
@@ -143,7 +143,7 @@ module DynamicMigrations
           def self.compare_table table, comparison_table
             raise TableRequiredError if table.nil?
 
-            log.info "Comparing Table `#{table.name}`"
+            log.debug "Comparing Table `#{table.name}`"
 
             primary_key = table.has_primary_key? ? table.primary_key : nil
             if comparison_table
@@ -187,7 +187,7 @@ module DynamicMigrations
           # an object which represents the provided `functions` and any differences
           # between it and the `comparison_functions`
           def self.compare_functions functions, comparison_functions
-            log.info "Comparing Functions..."
+            log.debug "Comparing Functions"
 
             result = {}
             # the base functions
@@ -212,7 +212,7 @@ module DynamicMigrations
           # an object which represents the provided `enums` and any differences
           # between it and the `comparison_enums`
           def self.compare_enums enums, comparison_enums
-            log.info "Comparing Enums..."
+            log.debug "Comparing Enums"
 
             result = {}
             # the base enums
@@ -237,7 +237,7 @@ module DynamicMigrations
           # an object which represents the provided `columns` and any differences
           # between it and the `comparison_columns`
           def self.compare_columns columns, comparison_columns
-            log.info "Comparing Columns..."
+            log.debug "Comparing Columns"
 
             result = {}
             # the base columns
@@ -266,7 +266,7 @@ module DynamicMigrations
           # an object which represents the provided `triggers` and any differences
           # between it and the `comparison_triggers`
           def self.compare_triggers triggers, comparison_triggers
-            log.info "Comparing Triggers..."
+            log.debug "Comparing Triggers"
 
             result = {}
             # the base triggers
@@ -299,7 +299,7 @@ module DynamicMigrations
           # an object which represents the provided `unique_constraints` and any differences
           # between it and the `comparison_unique_constraints`
           def self.compare_unique_constraints unique_constraints, comparison_unique_constraints
-            log.info "Comparing Unique Constraints..."
+            log.debug "Comparing Unique Constraints"
 
             result = {}
             # the base unique_constraints
@@ -327,7 +327,7 @@ module DynamicMigrations
           # an object which represents the provided `indexes` and any differences
           # between it and the `comparison_indexes`
           def self.compare_indexes indexes, comparison_indexes
-            log.info "Comparing Indexes..."
+            log.debug "Comparing Indexes"
 
             result = {}
             # the base indexes
@@ -358,7 +358,7 @@ module DynamicMigrations
           # an object which represents the provided `validations` and any differences
           # between it and the `comparison_validations`
           def self.compare_validations validations, comparison_validations
-            log.info "Comparing Validations..."
+            log.debug "Comparing Validations"
 
             result = {}
             # the base validations
@@ -367,9 +367,7 @@ module DynamicMigrations
               result[name] = compare_record validation, comparison_validations[name], [
                 :normalized_check_clause,
                 :column_names,
-                :description,
-                :deferrable,
-                :initially_deferred
+                :description
               ]
             end
             # look for any validations in the comparison list which were not in the base list
@@ -387,7 +385,7 @@ module DynamicMigrations
           # an object which represents the provided `foreign_key_constraints` and any differences
           # between it and the `comparison_foreign_key_constraints`
           def self.compare_foreign_key_constraints foreign_key_constraints, comparison_foreign_key_constraints
-            log.info "Comparing Foreign Key Constraints..."
+            log.debug "Comparing Foreign Key Constraints"
 
             result = {}
             # the base foreign_key_constraints
@@ -428,13 +426,20 @@ module DynamicMigrations
             else
               type = base.class.name.split("::").last
               name = base.is_a?(Schema::Table::PrimaryKey) ? nil : base.name
-              log.info "  Comparing #{type} `#{name}`"
+              log.debug "  Comparing #{type} `#{name}`"
 
               result = {}
               method_list.each do |method_name|
-                log.info "    Comparing `#{method_name}`"
+                log.debug "    Comparing `#{method_name}`"
 
                 matches = (comparison && comparison.send(method_name) == base.send(method_name)) || false
+
+                unless matches
+                  log.debug "      Values are different"
+                  log.debug "        Base Value:  `#{base.send(method_name)}`"
+                  log.debug "        Other Value: `#{comparison.nil? ? "nil" : comparison.send(method_name)}`"
+                end
+
                 result[method_name] = {
                   value: base.send(method_name),
                   matches: matches

data/lib/dynamic_migrations/postgres/server/database/keys_and_unique_constraints_loader.rb

@@ -152,8 +152,8 @@ module DynamicMigrations
                 on_delete = nil
               end
 
-              deferrable = row["deferrable"] == "TRUE"
-              initially_deferred = row["initially_deferred"] == "TRUE"
+              deferrable = row["deferrable"] == "t"
+              initially_deferred = row["initially_deferred"] == "t"
 
               index_type = if row["index_type"].nil?
                 nil

data/lib/dynamic_migrations/postgres/server/database/loaded_schemas_builder.rb

@@ -60,7 +60,7 @@ module DynamicMigrations
 
                 # add any validations
                 table_validations&.each do |validation_name, validation_definition|
-                  table.add_validation validation_name, validation_definition[:columns], validation_definition[:check_clause], description: validation_definition[:description], deferrable: validation_definition[:deferrable], initially_deferred: validation_definition[:initially_deferred]
+                  table.add_validation validation_name, validation_definition[:columns], validation_definition[:check_clause], description: validation_definition[:description]
                 end
               end
             end

data/lib/dynamic_migrations/postgres/server/database/schema/enum.rb

@@ -19,6 +19,9 @@ module DynamicMigrations
             class ValueMustBeStringError < StandardError
             end
 
+            class EnumValueTooLongError < StandardError
+            end
+
             attr_reader :schema
             attr_reader :name
             attr_reader :values
@@ -47,7 +50,7 @@ module DynamicMigrations
 
               unless description.nil?
                 raise ExpectedStringError, description unless description.is_a? String
-                @description = description.strip
+                @description = description.strip.freeze
                 @description = nil if description == ""
               end
             end
@@ -61,7 +64,11 @@ module DynamicMigrations
                 raise ValueAlreadyExistsError, "Value `#{value}` already exists in enum `#{name}`"
               end
 
-              @values << value
+              if value.length > 63
+                raise EnumValueTooLongError, "Value `#{value}` must be less than 64 characters"
+              end
+
+              @values << value.freeze
             end
 
             # returns true if this enum has a description, otehrwise false

data/lib/dynamic_migrations/postgres/server/database/schema/function.rb

@@ -37,11 +37,11 @@ module DynamicMigrations
               unless definition.is_a?(String) && definition.strip != "" && definition.strip.end_with?("END;", "END")
                 raise ExpectedDefinitionError, "Definition must be a string, and end with `END;`. Definition provided:\n#{definition}"
               end
-              @definition = definition.strip
+              @definition = definition.strip.freeze
 
               unless description.nil?
                 raise ExpectedStringError, description unless description.is_a? String
-                @description = description.strip
+                @description = description.strip.freeze
                 @description = nil if description == ""
               end
             end

data/lib/dynamic_migrations/postgres/server/database/schema/table/column.rb

@@ -14,6 +14,9 @@ module DynamicMigrations
               class UnexpectedEnumError < StandardError
               end
 
+              class InvalidNameError < StandardError
+              end
+
               attr_reader :table
               attr_reader :name
               attr_reader :data_type
@@ -29,7 +32,8 @@ module DynamicMigrations
                 raise ExpectedTableError, table unless table.is_a? Table
                 @table = table
 
-                raise ExpectedSymbolError, name unless name.is_a? Symbol
+                raise InvalidNameError, "Unexpected name `#{name}`. Name should be a Symbol" unless name.is_a? Symbol
+                raise InvalidNameError, "The name `#{name}` is too long. Names must be less than 64 characters" unless name.length < 64
                 @name = name
 
                 raise ExpectedSymbolError, data_type unless data_type.is_a? Symbol
@@ -44,7 +48,7 @@ module DynamicMigrations
 
                 unless description.nil?
                   raise ExpectedStringError, description unless description.is_a? String
-                  @description = description.strip
+                  @description = description.strip.freeze
                   @description = nil if description == ""
                 end
 

data/lib/dynamic_migrations/postgres/server/database/schema/table/columns.rb

@@ -50,12 +50,6 @@ module DynamicMigrations
                 else
                   raise ModuleIncludedIntoUnexpectedTargetError, included_target
                 end
-                # sort the hash so that the columns are in alphabetical order by name
-                sorted_columns = {}
-                @columns.keys.sort.each do |name|
-                  sorted_columns[name] = @columns[name]
-                end
-                @columns = sorted_columns
                 # return the new column
                 new_column
               end

data/lib/dynamic_migrations/postgres/server/database/schema/table/foreign_key_constraint.rb

@@ -20,6 +20,9 @@ module DynamicMigrations
               class UnexpectedReferentialActionError < StandardError
               end
 
+              class InvalidNameError < StandardError
+              end
+
               attr_reader :table
               attr_reader :foreign_table
               attr_reader :name
@@ -64,12 +67,13 @@ module DynamicMigrations
                   add_column column, true
                 end
 
-                raise ExpectedSymbolError, name unless name.is_a? Symbol
+                raise InvalidNameError, "Unexpected name `#{name}`. Name should be a Symbol" unless name.is_a? Symbol
+                raise InvalidNameError, "The name `#{name}` is too long. Names must be less than 64 characters" unless name.length < 64
                 @name = name
 
                 unless description.nil?
                   raise ExpectedStringError, description unless description.is_a? String
-                  @description = description.strip
+                  @description = description.strip.freeze
                   @description = nil if description == ""
                 end
 

data/lib/dynamic_migrations/postgres/server/database/schema/table/index.rb

@@ -30,6 +30,9 @@ module DynamicMigrations
               class DuplicateColumnError < StandardError
               end
 
+              class InvalidNameError < StandardError
+              end
+
               attr_reader :table
               attr_reader :name
               attr_reader :unique
@@ -56,12 +59,13 @@ module DynamicMigrations
                   add_column column
                 end
 
-                raise ExpectedSymbolError, name unless name.is_a? Symbol
+                raise InvalidNameError, "Unexpected name `#{name}`. Name should be a Symbol" unless name.is_a? Symbol
+                raise InvalidNameError, "The name `#{name}` is too long. Names must be less than 64 characters" unless name.length < 64
                 @name = name
 
                 unless description.nil?
                   raise ExpectedStringError, description unless description.is_a? String
-                  @description = description.strip
+                  @description = description.strip.freeze
                   @description = nil if description == ""
                 end
 
@@ -70,7 +74,7 @@ module DynamicMigrations
 
                 unless where.nil?
                   raise ExpectedStringError, where unless where.is_a? String
-                  @where = where
+                  @where = where.freeze
                 end
 
                 raise UnexpectedIndexTypeError, type unless INDEX_TYPES.include?(type)

data/lib/dynamic_migrations/postgres/server/database/schema/table/primary_key.rb

@@ -20,6 +20,9 @@ module DynamicMigrations
               class DuplicateColumnError < StandardError
               end
 
+              class InvalidNameError < StandardError
+              end
+
               attr_reader :table
               attr_reader :name
               attr_reader :description
@@ -40,12 +43,13 @@ module DynamicMigrations
                   add_column column
                 end
 
-                raise ExpectedSymbolError, name unless name.is_a? Symbol
+                raise InvalidNameError, "Unexpected name `#{name}`. Name should be a Symbol" unless name.is_a? Symbol
+                raise InvalidNameError, "The name `#{name}` is too long. Names must be less than 64 characters" unless name.length < 64
                 @name = name
 
                 unless description.nil?
                   raise ExpectedStringError, description unless description.is_a? String
-                  @description = description.strip
+                  @description = description.strip.freeze
                   @description = nil if description == ""
                 end
               end

data/lib/dynamic_migrations/postgres/server/database/schema/table/trigger.rb

@@ -41,6 +41,9 @@ module DynamicMigrations
               class UnnormalizableActionConditionError < StandardError
               end
 
+              class InvalidNameError < StandardError
+              end
+
               attr_reader :table
               attr_reader :name
               attr_reader :event_manipulation
@@ -63,9 +66,8 @@ module DynamicMigrations
                 end
                 @table = table
 
-                unless name.is_a? Symbol
-                  raise ExpectedSymbolError, name
-                end
+                raise InvalidNameError, "Unexpected name `#{name}`. Name should be a Symbol" unless name.is_a? Symbol
+                raise InvalidNameError, "The name `#{name}` is too long. Names must be less than 64 characters" unless name.length < 64
                 @name = name
 
                 unless [:before, :after].include? action_timing
@@ -93,12 +95,12 @@ module DynamicMigrations
                 unless action_condition.nil? || action_condition.is_a?(String)
                   raise ExpectedStringError, action_condition
                 end
-                @action_condition = action_condition&.strip
+                @action_condition = action_condition&.strip&.freeze
 
                 unless parameters.is_a?(Array) && parameters.all? { |p| p.is_a? String }
                   raise UnexpectedParametersError, "unexpected parameters `#{parameters}`, currently only an array of strings is supported"
                 end
-                @parameters = parameters
+                @parameters = parameters.map(&:freeze)
 
                 unless [:row, :statement].include? action_orientation
                   raise UnexpectedActionOrientationError, action_orientation
@@ -128,7 +130,7 @@ module DynamicMigrations
 
                 unless description.nil?
                   raise ExpectedStringError, description unless description.is_a? String
-                  @description = description.strip
+                  @description = description.strip.freeze
                   @description = nil if description == ""
                 end
 
@@ -166,7 +168,7 @@ module DynamicMigrations
                 unless new_action_condition.nil? || new_action_condition.is_a?(String)
                   raise ExpectedStringError, new_action_condition
                 end
-                @action_condition = new_action_condition&.strip
+                @action_condition = new_action_condition&.strip&.freeze
               end
 
               def add_parameter new_parameter
@@ -224,7 +226,7 @@ module DynamicMigrations
                       $$ BEGIN END $$;
                     SQL
 
-                    temp_action_condition = action_condition
+                    temp_action_condition = action_condition.dup
                     # string replace any real enum names with their temp enum names
                     temp_enums.each do |temp_enum_name, enum|
                       temp_action_condition.gsub!("::#{enum.name}", "::#{temp_enum_name}")

data/lib/dynamic_migrations/postgres/server/database/schema/table/triggers.rb

@@ -17,14 +17,14 @@ module DynamicMigrations
               # returns the trigger object for the provided trigger name, and raises an
               # error if the trigger does not exist
               def trigger name
-                raise ExpectedSymbolError, name unless name.is_a? Symbol
+                raise Trigger::InvalidNameError, name unless name.is_a? Symbol
                 raise TriggerDoesNotExistError unless has_trigger? name
                 @triggers[name]
               end
 
               # returns true if this table has a trigger with the provided name, otherwise false
               def has_trigger? name
-                raise ExpectedSymbolError, name unless name.is_a? Symbol
+                raise Trigger::InvalidNameError, name unless name.is_a? Symbol
                 @triggers.key? name
               end