dynamic_migrations 3.8.0 → 3.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 437a84189a939e185f89db2de8395bc1fb8dc9f159b3948a97dcc5b04c4fedb7
-  data.tar.gz: 6e1df320ac06c0b0ca9d6aeb3abf684e47b9daac4ee1def93180de801f73125b
+  metadata.gz: 2641592d2902b2b4db711882300e45157cf45df12d3f19ceea84ff97e13f6fab
+  data.tar.gz: d6eb83a0f1d0631acc1474d18305e0828688210f7008dbddb460dc1b2cfaf668
 SHA512:
-  metadata.gz: c2ce93a8d273abfb0c2ede80b7564216a8409bcd8a43b8fe6c85043eed83d750f8a2b2e53996afdc241e13db9f6cdf2c3f52034a5e93965663684bc121237b54
-  data.tar.gz: bb3378cc475e8e3c16dd2d3a9a5754484da539d3ba1feb4839d2312c1f24cb147ea11534ba3a9bfbcda827bee4bc5ae18cc2c7a2b23bdd67c84a23503fc4fcab
+  metadata.gz: 48130e442efa9a4e2ab9763fe8e0cb1f35bca56691361e0d3c350813e89c31e1445f59ff76b981e560eb521e8dfb72822ac80c04c738203b62237ccc9690ecc1
+  data.tar.gz: 0a40ea04a41e2f072fe0f8ae9a163a1989c0e8c752b7078491ae5b75bbe18cfc3d3eebd777a61de2b4372297e78c54539d3a449b11a76771c19a86370d5fe588

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## [3.8.2](https://github.com/craigulliott/dynamic_migrations/compare/v3.8.1...v3.8.2) (2023-10-06)
+
+
+### Bug Fixes
+
+* fetch_normalized_check_clause_and_column_names was using column names from the validation instead of the table it belonged to ([5157205](https://github.com/craigulliott/dynamic_migrations/commit/5157205fc52cfbf062d61054bf12c117a5df5b57))
+
+## [3.8.1](https://github.com/craigulliott/dynamic_migrations/compare/v3.8.0...v3.8.1) (2023-10-06)
+
+
+### Bug Fixes
+
+* reusing exiting connection when with_connection is called (it was trying to open a new connection and caused an error) ([840a5cd](https://github.com/craigulliott/dynamic_migrations/commit/840a5cda04d6bc49d73160d2bad7271780027c84))
+
 ## [3.8.0](https://github.com/craigulliott/dynamic_migrations/compare/v3.7.0...v3.8.0) (2023-10-04)
 
 

data/lib/dynamic_migrations/postgres/server/database/connection.rb

@@ -33,19 +33,31 @@ module DynamicMigrations
             end
           end
 
+          def connected?
+            !@connection.nil?
+          end
+
           # Opens a connection to the database server, and yields the provided block
           # before automatically closing the connection again. This is useful for
           # executing one time queries against the database server.
           def with_connection &block
-            # create a temporary connection to the server
-            connect
+            # create a temporary connection to the server (unless we are already connected)
+            already_connected = connected?
+            unless already_connected
+              connect
+            end
+
             # perform work with the connection
             # todo: `yield connection` would have been preferred, but rbs/steep doesnt understand that syntax
             if block.is_a? Proc
               result = block.call connection
             end
-            # close the connection
-            disconnect
+
+            # close the connection (unless we were already connected)
+            if already_connected
+              disconnect
+            end
+
             # return whever was returned from within the block
             result
           end

data/lib/dynamic_migrations/postgres/server/database/schema/table/validation.rb

@@ -14,6 +14,9 @@ module DynamicMigrations
               class ExpectedArrayOfColumnsError < StandardError
               end
 
+              class ExpectedTableColumnsError < StandardError
+              end
+
               class DuplicateColumnError < StandardError
               end
 
@@ -122,6 +125,9 @@ module DynamicMigrations
               end
 
               def fetch_normalized_check_clause_and_column_names
+                if table.columns.empty?
+                  raise ExpectedTableColumnsError, "Can not normalize check clause or validation columnns because the table has no columns"
+                end
                 result = table.schema.database.with_connection do |connection|
                   # wrapped in a transaction just in case something here fails, because
                   # we don't want the temporary table to be persisted
@@ -130,7 +136,7 @@ module DynamicMigrations
                   # create the temp table and add the expected columns and constraint
                   connection.exec(<<~SQL)
                     CREATE TEMP TABLE validation_normalized_check_clause_temp_table (
-                      #{columns.map { |column| '"' + column.name.to_s + '" ' + column.temp_table_data_type.to_s }.join(", ")},
+                      #{table.columns.map { |column| '"' + column.name.to_s + '" ' + column.temp_table_data_type.to_s }.join(", ")},
                       CONSTRAINT #{name} CHECK (#{check_clause})
                     );
                   SQL

data/lib/dynamic_migrations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DynamicMigrations
-  VERSION = "3.8.0"
+  VERSION = "3.8.2"
 end

data/sig/dynamic_migrations/postgres/server/database/connection.rbs

@@ -7,6 +7,7 @@ module DynamicMigrations
 
           def connect: -> PG::Connection
           def connection: -> PG::Connection
+          def connected?: -> bool
           def disconnect: -> void
           def with_connection: -> untyped
 

data/sig/dynamic_migrations/postgres/server/database/schema/table/validation.rbs

@@ -36,6 +36,9 @@ module DynamicMigrations
               class ExpectedArrayOfColumnsError < StandardError
               end
 
+              class ExpectedTableColumnsError < StandardError
+              end
+
               class DuplicateColumnError < StandardError
               end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dynamic_migrations
 version: !ruby/object:Gem::Version
-  version: 3.8.0
+  version: 3.8.2
 platform: ruby
 authors:
 - Craig Ulliott
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-10-04 00:00:00.000000000 Z
+date: 2023-10-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pg