dynamic_migrations 3.5.0 → 3.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c2370c3373cb04ce64f20e48f15adf1f68cbacf17de79ca420f39f67c13536aa
-  data.tar.gz: 0d8d19007406180972f5a6304c01c0277079920bb8190705f2a246ef0975167a
+  metadata.gz: d618a9b98ed9b0f378f6e4342c57e6df554df34c600572a6aa55db61dbb32fad
+  data.tar.gz: a90d7e5fa28aa0f4dbc2d42a7545ed6207bc800baba766dd23c9bc0e73cfd0c6
 SHA512:
-  metadata.gz: de27b281b3e4494cfa5b3cc3835da3e71816c4a3b3e75bc92d96e2b69ae7e6169d9b32ebadc53c0f5e25d44378e81f46b26cc9db8cfb9c7bf97d009e4fc3eb3d
-  data.tar.gz: 79e609f4d4ce4272a8f82e4d11771faa05c9c380228e2587a96abb751fd9647d55f65f91e730ec0487ddc349cc6922f2e079782bcd355c17335a8f8d4c68caa7
+  metadata.gz: 33c0b803f4a4a01aff67b258ade285c2acf0420c0c611b918cf24405f5081497050bdcb726532b01fe4d832a086d15a4b37dc5a03c445772e7b6e863edd795c6
+  data.tar.gz: 7a00457cdb78107f62c43bd74647513817c1fbb0e4dbbc92bdc458aefc02030980fd074d03f2ada4399dd442f4152098024a492839fe98ccba2ad16ad4508356

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## [3.5.2](https://github.com/craigulliott/dynamic_migrations/compare/v3.5.1...v3.5.2) (2023-09-11)
+
+
+### Bug Fixes
+
+* accepting nil or false for existence check when calculating differences (because if the schema doesn't exist we wont have table objects to test against) ([c4112cc](https://github.com/craigulliott/dynamic_migrations/commit/c4112cccb5a887b78e15182cdb8bcfdbd80fd0c0))
+
+## [3.5.1](https://github.com/craigulliott/dynamic_migrations/compare/v3.5.0...v3.5.1) (2023-09-11)
+
+
+### Bug Fixes
+
+* missing primary key should be represented by nil when building differences, and added some more descriptive error messages ([491c1c2](https://github.com/craigulliott/dynamic_migrations/commit/491c1c2d7c2128f3f4ad3f2a21b0b52c67029185))
+
 ## [3.5.0](https://github.com/craigulliott/dynamic_migrations/compare/v3.4.1...v3.5.0) (2023-09-11)
 
 

data/lib/dynamic_migrations/postgres/generator/column.rb

@@ -92,7 +92,7 @@ module DynamicMigrations
           description = column.description
 
           if description.nil?
-            raise MissingDescriptionError
+            raise MissingDescriptionError, "Missing required description for column `#{column.name}` in table `#{column.table.schema.name}.#{column.table.name}`"
           end
 
           add_fragment schema: column.table.schema,

data/lib/dynamic_migrations/postgres/generator/foreign_key_constraint.rb

@@ -73,7 +73,7 @@ module DynamicMigrations
           description = foreign_key_constraint.description
 
           if description.nil?
-            raise MissingDescriptionError
+            raise MissingDescriptionError, "Missing required description for foreign_key_constraint `#{foreign_key_constraint.name}` in table `#{foreign_key_constraint.table.schema.name}.#{foreign_key_constraint.table.name}`"
           end
 
           add_fragment schema: foreign_key_constraint.table.schema,

data/lib/dynamic_migrations/postgres/generator/index.rb

@@ -89,7 +89,7 @@ module DynamicMigrations
           description = index.description
 
           if description.nil?
-            raise MissingDescriptionError
+            raise MissingDescriptionError, "Missing required description for index `#{index.name}` in table `#{index.table.schema.name}.#{index.table.name}`"
           end
 
           add_fragment schema: index.table.schema,

data/lib/dynamic_migrations/postgres/generator/table.rb

@@ -44,7 +44,7 @@ module DynamicMigrations
           description = table.description
 
           if description.nil?
-            raise MissingDescriptionError
+            raise MissingDescriptionError, "Missing required description for table `#{table.schema.name}.#{table.name}`"
           end
 
           add_fragment schema: table.schema,

data/lib/dynamic_migrations/postgres/generator/trigger.rb

@@ -93,7 +93,7 @@ module DynamicMigrations
           description = trigger.description
 
           if description.nil?
-            raise MissingDescriptionError
+            raise MissingDescriptionError, "Missing required description for trigger `#{trigger.name}` on table `#{trigger.table.schema.name}.#{trigger.table.name}`"
           end
 
           add_fragment schema: trigger.table.schema,

data/lib/dynamic_migrations/postgres/generator/unique_constraint.rb

@@ -67,7 +67,7 @@ module DynamicMigrations
           description = unique_constraint.description
 
           if description.nil?
-            raise MissingDescriptionError
+            raise MissingDescriptionError, "Missing required description for unique_constraint `#{unique_constraint.name}` in table `#{unique_constraint.table.schema.name}.#{unique_constraint.table.name}`"
           end
 
           add_fragment schema: unique_constraint.table.schema,

data/lib/dynamic_migrations/postgres/generator/validation.rb

@@ -75,7 +75,7 @@ module DynamicMigrations
           description = validation.description
 
           if description.nil?
-            raise MissingDescriptionError
+            raise MissingDescriptionError, "Missing required description for validation `#{validation.name}` in table `#{validation.table.schema.name}.#{validation.table.name}`"
           end
 
           add_fragment schema: validation.table.schema,

data/lib/dynamic_migrations/postgres/server/database/differences/to_migrations/schemas/tables/columns.rb

@@ -20,14 +20,14 @@ module DynamicMigrations
                   def process_column schema_name, table_name, column_name, configuration_column, database_column
                     # If the column exists in the configuration but not in the database
                     # then we have to create it.
-                    if configuration_column[:exists] == true && database_column[:exists] == false
+                    if configuration_column[:exists] == true && !database_column[:exists]
                       # a migration to create the column
                       column = @database.configured_schema(schema_name).table(table_name).column(column_name)
                       @generator.add_column column
 
                     # If the schema exists in the database but not in the configuration
                     # then we need to delete it.
-                    elsif configuration_column[:exists] == false && database_column[:exists] == true
+                    elsif database_column[:exists] == true && !configuration_column[:exists]
                       # a migration to create the column
                       column = @database.loaded_schema(schema_name).table(table_name).column(column_name)
                       @generator.remove_column column

data/lib/dynamic_migrations/postgres/server/database/differences/to_migrations/schemas/tables/foreign_key_constraints.rb

@@ -20,14 +20,14 @@ module DynamicMigrations
                   def process_foreign_key_constraint schema_name, table_name, foreign_key_constraint_name, configuration_foreign_key_constraint, database_foreign_key_constraint
                     # If the foreign_key_constraint exists in the configuration but not in the database
                     # then we have to create it.
-                    if configuration_foreign_key_constraint[:exists] == true && database_foreign_key_constraint[:exists] == false
+                    if configuration_foreign_key_constraint[:exists] == true && !database_foreign_key_constraint[:exists]
                       # a migration to create the foreign_key_constraint
                       foreign_key_constraint = @database.configured_schema(schema_name).table(table_name).foreign_key_constraint(foreign_key_constraint_name)
                       @generator.add_foreign_key_constraint foreign_key_constraint
 
                     # If the schema exists in the database but not in the configuration
                     # then we need to delete it.
-                    elsif configuration_foreign_key_constraint[:exists] == false && database_foreign_key_constraint[:exists] == true
+                    elsif database_foreign_key_constraint[:exists] == true && !configuration_foreign_key_constraint[:exists]
                       # a migration to create the foreign_key_constraint
                       foreign_key_constraint = @database.loaded_schema(schema_name).table(table_name).foreign_key_constraint(foreign_key_constraint_name)
                       @generator.remove_foreign_key_constraint foreign_key_constraint

data/lib/dynamic_migrations/postgres/server/database/differences/to_migrations/schemas/tables/indexes.rb

@@ -20,14 +20,14 @@ module DynamicMigrations
                   def process_index schema_name, table_name, index_name, configuration_index, database_index
                     # If the index exists in the configuration but not in the database
                     # then we have to create it.
-                    if configuration_index[:exists] == true && database_index[:exists] == false
+                    if configuration_index[:exists] == true && !database_index[:exists]
                       # a migration to create the index
                       index = @database.configured_schema(schema_name).table(table_name).index(index_name)
                       @generator.add_index index
 
                     # If the schema exists in the database but not in the configuration
                     # then we need to delete it.
-                    elsif configuration_index[:exists] == false && database_index[:exists] == true
+                    elsif database_index[:exists] == true && !configuration_index[:exists]
                       # a migration to create the index
                       index = @database.loaded_schema(schema_name).table(table_name).index(index_name)
                       @generator.remove_index index

data/lib/dynamic_migrations/postgres/server/database/differences/to_migrations/schemas/tables/triggers.rb

@@ -20,14 +20,14 @@ module DynamicMigrations
                   def process_trigger schema_name, table_name, trigger_name, configuration_trigger, database_trigger
                     # If the trigger exists in the configuration but not in the database
                     # then we have to create it.
-                    if configuration_trigger[:exists] == true && database_trigger[:exists] == false
+                    if configuration_trigger[:exists] == true && !database_trigger[:exists]
                       # a migration to create the trigger
                       trigger = @database.configured_schema(schema_name).table(table_name).trigger(trigger_name)
                       @generator.add_trigger trigger
 
                     # If the schema exists in the database but not in the configuration
                     # then we need to delete it.
-                    elsif configuration_trigger[:exists] == false && database_trigger[:exists] == true
+                    elsif database_trigger[:exists] == true && !configuration_trigger[:exists]
                       # a migration to create the trigger
                       trigger = @database.loaded_schema(schema_name).table(table_name).trigger(trigger_name)
                       @generator.remove_trigger trigger

data/lib/dynamic_migrations/postgres/server/database/differences/to_migrations/schemas/tables/unique_constraints.rb

@@ -20,14 +20,14 @@ module DynamicMigrations
                   def process_unique_constraint schema_name, table_name, unique_constraint_name, configuration_unique_constraint, database_unique_constraint
                     # If the unique_constraint exists in the configuration but not in the database
                     # then we have to create it.
-                    if configuration_unique_constraint[:exists] == true && database_unique_constraint[:exists] == false
+                    if configuration_unique_constraint[:exists] == true && !database_unique_constraint[:exists]
                       # a migration to create the unique_constraint
                       unique_constraint = @database.configured_schema(schema_name).table(table_name).unique_constraint(unique_constraint_name)
                       @generator.add_unique_constraint unique_constraint
 
                     # If the schema exists in the database but not in the configuration
                     # then we need to delete it.
-                    elsif configuration_unique_constraint[:exists] == false && database_unique_constraint[:exists] == true
+                    elsif database_unique_constraint[:exists] == true && !configuration_unique_constraint[:exists]
                       # a migration to create the unique_constraint
                       unique_constraint = @database.loaded_schema(schema_name).table(table_name).unique_constraint(unique_constraint_name)
                       @generator.remove_unique_constraint unique_constraint

data/lib/dynamic_migrations/postgres/server/database/differences/to_migrations/schemas/tables/validations.rb

@@ -20,14 +20,14 @@ module DynamicMigrations
                   def process_validation schema_name, table_name, validation_name, configuration_validation, database_validation
                     # If the validation exists in the configuration but not in the database
                     # then we have to create it.
-                    if configuration_validation[:exists] == true && database_validation[:exists] == false
+                    if configuration_validation[:exists] == true && !database_validation[:exists]
                       # a migration to create the validation
                       validation = @database.configured_schema(schema_name).table(table_name).validation(validation_name)
                       @generator.add_validation validation
 
                     # If the schema exists in the database but not in the configuration
                     # then we need to delete it.
-                    elsif configuration_validation[:exists] == false && database_validation[:exists] == true
+                    elsif database_validation[:exists] == true && !configuration_validation[:exists]
                       # a migration to create the validation
                       validation = @database.loaded_schema(schema_name).table(table_name).validation(validation_name)
                       @generator.remove_validation validation

data/lib/dynamic_migrations/postgres/server/database/differences.rb

@@ -136,7 +136,7 @@ module DynamicMigrations
               comparison_foreign_key_constraints = comparison_table.foreign_key_constraints_hash
               comparison_unique_constraints = comparison_table.unique_constraints_hash
             else
-              comparison_primary_key = {}
+              comparison_primary_key = nil
               comparison_columns = {}
               comparison_indexes = {}
               comparison_triggers = {}

data/lib/dynamic_migrations/postgres/server/database/loaded_schemas.rb

@@ -15,7 +15,7 @@ module DynamicMigrations
           def add_loaded_schema schema_name
             raise ExpectedSymbolError, schema_name unless schema_name.is_a? Symbol
             if has_loaded_schema? schema_name
-              raise(LoadedSchemaAlreadyExistsError, "Loaded schema #{schema_name} already exists")
+              raise LoadedSchemaAlreadyExistsError, "Loaded schema #{schema_name} already exists"
             end
             included_target = self
             if included_target.is_a? Database
@@ -36,8 +36,12 @@ module DynamicMigrations
           # returns the loaded schema object for the provided schema name, and raises an
           # error if the schema does not exist
           def loaded_schema schema_name
-            raise ExpectedSymbolError, schema_name unless schema_name.is_a? Symbol
-            raise LoadedSchemaDoesNotExistError unless has_loaded_schema? schema_name
+            unless schema_name.is_a? Symbol
+              raise ExpectedSymbolError, schema_name
+            end
+            unless has_loaded_schema? schema_name
+              raise LoadedSchemaDoesNotExistError, "Loaded schema `#{schema_name}` does not exist"
+            end
             @loaded_schemas[schema_name]
           end
 

data/lib/dynamic_migrations/postgres/server/database/schema/table/trigger.rb

@@ -88,7 +88,8 @@ module DynamicMigrations
                 end
                 @action_condition = action_condition&.strip
 
-                unless parameters.nil? || (parameters.is_a?(String) && parameters[/\A'[\w\d_ -]+'(, ?'[\w\d_ -]+')*\z/])
+                is_comma_sperated_list_of_strings = (parameters.is_a?(String) && parameters[/\A'[\w\d_ -]+'(, ?'[\w\d_ -]+')*\z/])
+                unless parameters.nil? || is_comma_sperated_list_of_strings
                   raise UnexpectedParametersError, "unexpected parameters `#{parameters}`, currently only a comma seeparated list of strings is supported"
                 end
                 @parameters = parameters&.strip

data/lib/dynamic_migrations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DynamicMigrations
-  VERSION = "3.5.0"
+  VERSION = "3.5.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dynamic_migrations
 version: !ruby/object:Gem::Version
-  version: 3.5.0
+  version: 3.5.2
 platform: ruby
 authors:
 - Craig Ulliott