dynamic_fields_for_rails 0.7.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 074819fc94eb72286ba9ac6047f8a849d75043f7
-  data.tar.gz: 9086d0757152a6c5030d04e7780ceb3b2066abcd
+SHA256:
+  metadata.gz: 4fb93a2e2de4bdf5c990fa45f0ef8e1a07ab99564fded98502037a3bf02b92a6
+  data.tar.gz: 6aed3f7be5c1a3c47fa6ee45a5fb02bd5a23de836689715b875e55aa0b736606
 SHA512:
-  metadata.gz: e29f998a3e97a339c23f85c17e063675321e5056eb52fbc2520c0b4f990869be1362276db006ec5b132ed7e94d18974834a48880ddce158664aaa91929751ca2
-  data.tar.gz: b9353d60f8b0e85be7ed1031ffc48f9ef10c874719ab47bb172ce5fd45fbf8e0389f54d4aad84834ce0367e6ac406fa834c2ba2c4dff2119ae8db6e737f3c7c3
+  metadata.gz: 8b9f8dc2cf26c34a8a160e0471a51766c36fc94f8f489ceeae21eb164d6b668a7af814b3307e36e479787af38bbebf64d90c640d86c11a460e8d55dfca406bd8
+  data.tar.gz: 35e0d9745b721606ae77b682546a12c3c466540d4a8e2e655eb906b6e3c808f6dad93208875ae3642c17a084bb6a15b5e5e897d74abc48a11271510d272a607b

data/.rubocop.yml

@@ -0,0 +1,87 @@
+# https://github.com/bbatsov/rubocop/blob/master/config/default.yml
+AllCops:
+  Exclude:
+    - 'node_modules/**/*'
+    - 'db/**/*'
+    - 'tmp/**/*'
+    - 'vendor/**/*'
+    - 'bin/**/*'
+    - 'log/**/*'
+    - 'Brewfile'
+    - 'Rakefile'
+
+Rails:
+  Enabled: true
+
+Style/Documentation:
+  Enabled: false # for now
+
+Style/Lambda:
+  Enabled: false
+
+Style/RaiseArgs:
+  Enabled: false
+
+Naming/FileName:
+  Enabled: false
+
+# User.all.map do |user|
+#   [user.name, user.children.map(&:names)]
+# end.flatten.map do |name|
+#   name.capitalize
+# end.join(", ")
+Style/MultilineBlockChain:
+  Enabled: false
+
+# [
+#   "foo",
+#   "bar",
+# ]
+Style/TrailingCommaInArrayLiteral:
+  Enabled: false
+
+Style/TrailingCommaInHashLiteral:
+  Enabled: false
+
+Layout/RescueEnsureAlignment:
+  Enabled: false
+
+Style/AccessModifierDeclarations:
+  EnforcedStyle: inline
+
+Metrics/LineLength:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+
+Metrics/MethodLength:
+  Max: 40
+
+Metrics/BlockLength:
+  Enabled: false
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Enabled: false
+
+Style/ParallelAssignment:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Max: 10
+
+# `fail` is seldom/never seen in Ruby code.
+# https://github.com/bbatsov/ruby-style-guide/issues/233
+Style/SignalException:
+  EnforcedStyle: only_raise
+
+# Would complain about `new_record?` otherwise
+Style/TrivialAccessors:
+  ExactNameMatch: true
+
+Rails/Delegate:
+  Exclude:
+    - lib/**/*

data/.ruby-version

@@ -0,0 +1 @@
+2.5.1

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in dynamic_fields_for_rails.gemspec

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/setup'
 Bundler::GemHelper.install_tasks
 

data/app/helpers/dynamic_fields_for_helper.rb

@@ -1,21 +1,24 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 module DynamicFieldsForHelper
   def link_to_add_fields(form, association, options = {}, &block)
     partial = options[:partial] || nil
     name = options[:name] || nil
     css_classes = options[:class] || nil
     target = options[:target] || nil
-
     new_object = form.object.send(association).klass.new
     id = new_object.object_id
+
     fields = form.fields_for(association, new_object, child_index: id) do |builder|
       if partial
-        render("#{form.object.class.name.downcase.pluralize}/#{partial}", fields: builder)
+        render("#{form.object.class.name.underscore.pluralize}/#{partial}", fields: builder)
       else
-        render("#{form.object.class.name.downcase.pluralize}/#{association.to_s.singularize}_fields", fields: builder)
+        render("#{form.object.class.name.underscore.pluralize}/#{association.to_s.singularize}_fields", fields: builder)
       end
     end
+
     css_classes = css_classes(DynamicFieldsForRails.add_css_classes, css_classes)
+
     if block_given?
       link_to('#', class: css_classes, data: { id: id, fields: fields.delete("\n"), target: target }, &block)
     else
@@ -30,20 +33,22 @@ module DynamicFieldsForHelper
     link = []
     link << fields.hidden_field(:_destroy) unless fields.object.new_record?
     css_classes = css_classes(DynamicFieldsForRails.delete_css_classes, css_classes)
+
     link << if block_given?
               link_to('#', class: css_classes, title: name, &block)
             else
               link_to(name, '#', class: css_classes)
             end
+
+    # rubocop:disable Rails/OutputSafety
     link.join('').html_safe
+    # rubocop:enable Rails/OutputSafety
   end
 
-  protected
-
-  def css_classes(default, css_class)
+  protected def css_classes(default, css_class)
     style_class = []
-    style_class << default unless default.blank?
-    style_class << css_class unless css_class.blank?
+    style_class << default if default.present?
+    style_class << css_class if css_class.present?
     style_class.join(' ')
   end
 end

data/dynamic_fields_for_rails.gemspec

@@ -1,27 +1,28 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'dynamic_fields_for_rails/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "dynamic_fields_for_rails"
+  spec.name          = 'dynamic_fields_for_rails'
   spec.version       = DynamicFieldsForRails::VERSION
-  spec.authors       = ["Marten Klitzke"]
-  spec.email         = ["m.klitzke@gmail.com"]
+  spec.authors       = ['Marten Klitzke']
+  spec.email         = ['m.klitzke@gmail.com']
   spec.description   = 'Dynamic fields helper for Rails.'
   spec.summary       = 'Helper for nested forms with dynamic fields.'
-  spec.homepage      = "https://github.com/mortik/dynamic_fields_for_rails"
-  spec.license       = "MIT"
+  spec.homepage      = 'https://github.com/mortik/dynamic_fields_for_rails'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake", '~> 0'
-  spec.add_development_dependency "mocha", '~> 0'
-  spec.add_development_dependency "sqlite3", '~> 0'
+  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'mocha', '~> 1'
+  spec.add_development_dependency 'rake', '~> 12'
+  spec.add_development_dependency 'sqlite3', '~> 1'
 
-  spec.add_dependency "rails", '>= 3.0.0', '< 6.0.0'
+  spec.add_dependency 'rails', '>= 3.0.0', '< 6.0.0'
 end

data/lib/dynamic_fields_for_rails/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DynamicFieldsForRails
-  VERSION = "0.7.0".freeze
+  VERSION = '1.0.0'
 end

data/lib/dynamic_fields_for_rails.rb

@@ -1,16 +1,20 @@
-require "dynamic_fields_for_rails/version"
+# frozen_string_literal: true
 
+require 'dynamic_fields_for_rails/version'
+
+# rubocop:disable Style/ClassVars
 module DynamicFieldsForRails
   class Engine < Rails::Engine
   end
 
   mattr_accessor :add_css_classes
-  @@add_css_classes = "add_fields"
+  @@add_css_classes = 'add_fields'
 
   mattr_accessor :delete_css_classes
-  @@delete_css_classes = "remove_fields"
+  @@delete_css_classes = 'remove_fields'
 
   def self.setup
     yield self
   end
 end
+# rubocop:enable Style/ClassVars

data/test/config/active_record.rb

@@ -1,4 +1,7 @@
+# frozen_string_literal: true
+
 # rubocop:disable ClassAndModuleChildren
+# rubocop:disable Style/ClassVars
 class ActiveRecord::Base
   mattr_accessor :shared_connection
   @@shared_connection = nil
@@ -7,4 +10,6 @@ class ActiveRecord::Base
     @@shared_connection || retrieve_connection
   end
 end
+# rubocop:enable Style/ClassVars
+# rubocop:enable ClassAndModuleChildren
 ActiveRecord::Base.shared_connection = ActiveRecord::Base.connection

data/test/dummy/Rakefile

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 
-require File.expand_path('../config/application', __FILE__)
+require File.expand_path('config/application', __dir__)
 require 'rake'
 
 Dummy::Application.load_tasks

data/test/dummy/app/controllers/application_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationController < ActionController::Base
   protect_from_forgery
 end

data/test/dummy/app/helpers/application_helper.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 module ApplicationHelper
 end

data/test/dummy/app/models/application_record.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+class ApplicationRecord < ActiveRecord::Base
+  self.abstract_class = true
+end

data/test/dummy/app/models/child.rb

@@ -1,2 +1,4 @@
-class Child < ActiveRecord::Base
+# frozen_string_literal: true
+
+class Child < ApplicationRecord
 end

data/test/dummy/app/models/parent.rb

@@ -1,4 +1,6 @@
-class Parent < ActiveRecord::Base
+# frozen_string_literal: true
+
+class Parent < ApplicationRecord
   has_many :children
   accepts_nested_attributes_for :children, allow_destroy: true
 end

data/test/dummy/config/application.rb

@@ -1,9 +1,11 @@
-require File.expand_path('../boot', __FILE__)
+# frozen_string_literal: true
 
-require "rails/all"
+require File.expand_path('boot', __dir__)
+
+require 'rails/all'
 
 Bundler.require
-require "dynamic_fields_for_rails"
+require 'dynamic_fields_for_rails'
 
 module Dummy
   class Application < Rails::Application
@@ -33,9 +35,11 @@ module Dummy
     # config.action_view.javascript_expansions[:defaults] = %w(jquery rails)
 
     # Configure the default encoding used in templates for Ruby 1.9.
-    config.encoding = "utf-8"
+    config.encoding = 'utf-8'
 
     # Configure sensitive parameters which will be filtered from the log file.
     config.filter_parameters += [:password]
+
+    config.active_record.sqlite3.represent_boolean_as_integer = true
   end
 end

data/test/dummy/config/boot.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 require 'rubygems'
-gemfile = File.expand_path('../../../../Gemfile', __FILE__)
+gemfile = File.expand_path('../../../Gemfile', __dir__)
 
 if File.exist?(gemfile)
   ENV['BUNDLE_GEMFILE'] = gemfile
@@ -7,4 +9,4 @@ if File.exist?(gemfile)
   Bundler.setup
 end
 
-$LOAD_PATH.unshift File.expand_path('../../../../lib', __FILE__)
+$LOAD_PATH.unshift File.expand_path('../../../lib', __dir__)

data/test/dummy/config/environment.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 # Load the rails application
-require File.expand_path('../application', __FILE__)
+require File.expand_path('application', __dir__)
 
 # Initialize the rails application
 Dummy::Application.initialize!

data/test/dummy/config/environments/development.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Dummy::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 

data/test/dummy/config/environments/production.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Dummy::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 
@@ -11,7 +13,7 @@ Dummy::Application.configure do
   config.action_controller.perform_caching = true
 
   # Specifies the header that your server uses for sending files
-  config.action_dispatch.x_sendfile_header = "X-Sendfile"
+  config.action_dispatch.x_sendfile_header = 'X-Sendfile'
 
   # For nginx:
   # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect'

data/test/dummy/config/environments/test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Dummy::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 

data/test/dummy/config/initializers/backtrace_silencers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # You can add backtrace silencers for libraries that you're using but don't wish to see in your backtraces.

data/test/dummy/config/initializers/inflections.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Add new inflection rules using the following format

data/test/dummy/config/initializers/mime_types.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Add new mime types for use in respond_to blocks:

data/test/dummy/config/initializers/secret_token.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Your secret key for verifying the integrity of signed cookies.
 # If you change this key, all old signed cookies will become invalid!
 # Make sure the secret is at least 30 characters and all random,
 # no regular words or you'll be exposed to dictionary attacks.
-Dummy::Application.config.secret_token = '5d8d9599457d5f2fa50c978d19da955350fa36c215f514e6b572b9d1d843b844d477d70fe02eacec84742e0f252cf4d93339762e5d57fed7146063faad77a030'
-Dummy::Application.config.secret_key_base = 'test_secret'
+Dummy::Application.config.secret_key_base = '5d8d9599457d5f2fa50c978d19da955350fa36c215f514e6b572b9d1d843b844d477d70fe02eacec84742e0f252cf4d93339762e5d57fed7146063faad77a030'

data/test/dummy/config/initializers/session_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 Dummy::Application.config.session_store :cookie_store, key: '_dummy_session'

data/test/dummy/config/routes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Dummy::Application.routes.draw do
   resources :parents
   # The priority is based upon order of creation:

data/test/dummy/config.ru

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This file is used by Rack-based servers to start the application.
 
 require ::File.expand_path('../config/environment', __FILE__)

data/test/dummy/db/migrate/20130423140255_create_parents.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CreateParents < ActiveRecord::Migration
   def change
     create_table :parents, &:timestamps

data/test/dummy/db/migrate/20130423140307_create_children.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CreateChildren < ActiveRecord::Migration
   def change
     create_table :children do |t|

data/test/dummy/db/schema.rb

@@ -1,4 +1,5 @@
-# encoding: UTF-8
+# frozen_string_literal: true
+
 # This file is auto-generated from the current state of the database. Instead
 # of editing this file, please use the migrations feature of Active Record to
 # incrementally modify your database, and then regenerate this schema definition.
@@ -12,14 +13,14 @@
 # It's strongly recommended to check this file into your version control system.
 
 ActiveRecord::Schema.define(version: 20_130_423_140_307) do
-  create_table "children", force: true do |t|
-    t.integer  "parent_id"
-    t.datetime "created_at", null: false
-    t.datetime "updated_at", null: false
+  create_table 'children', force: true do |t|
+    t.integer  'parent_id'
+    t.datetime 'created_at', null: false
+    t.datetime 'updated_at', null: false
   end
 
-  create_table "parents", force: true do |t|
-    t.datetime "created_at", null: false
-    t.datetime "updated_at", null: false
+  create_table 'parents', force: true do |t|
+    t.datetime 'created_at', null: false
+    t.datetime 'updated_at', null: false
   end
 end