dynamic-records-meritfront 3.0.23 → 3.0.26

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: abe695f1cafabc83e3776b7f2527ca1647102cf8cc3aafc45bae0a5a5adb288f
-  data.tar.gz: 44125e65532fc6aaee3de08f506194ea3a6718ae24434a5c45268f374fc4192d
+  metadata.gz: e61d44017d347ec7083448f67c2a3db1994f49b2a63c21d27c976c8a06c6b777
+  data.tar.gz: bbc308253515c6db53e9964701745fbbee832aee9acd7d4c1d64812b532955f3
 SHA512:
-  metadata.gz: d9eab130e60095e150b352098e32442377398c735920676a2221586e82996d1d7eeabfd2f081306d4d0cb48c211dc8951d216fe92a66b30adf16fa0648d72189
-  data.tar.gz: 1d5d4a226354ee08fd8bad951814f03bb0ca4199e5eea2c37516f76639beaf446a111d90cce8495ee4a01a92f0fbdda223f5a27e4f64296e7ca73f7f06dbf3e2
+  metadata.gz: f5a7ae8e89825cf74e31e99e4e422087f3eacc9bb290c727c49ec272c8a40f507d932d3e64f85ee43edf8366c6b2fe6121f3303204ff759e838aaa435ea46c55
+  data.tar.gz: d70bb9d0a4ab3972ad2f940f0606a1cad2b492ad5fc8daafa892d6014800513ae4d54d2d1d3d1f47d62c3b3bcd5f89c9100173e773cb042dceef4d0b5af4fbd4

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    dynamic-records-meritfront (3.0.23)
+    dynamic-records-meritfront (3.0.26)
       hashid-rails
 
 GEM
@@ -26,7 +26,7 @@ GEM
       concurrent-ruby (~> 1.0)
     minitest (5.17.0)
     rake (12.3.3)
-    tzinfo (2.0.5)
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
 
 PLATFORMS

data/README.md

@@ -315,6 +315,52 @@ the output:
    ...]}
 ```
 </details>
+
+<details>
+<summary>above example with relations (no need for dynamic_attach)</summary>
+#get list of users, those users friends, and who those users follow, all in one request.
+
+```ruby
+    friend_attach = attach_on: Proc.new {|users_friend|
+        users_friend.friended_to
+    }
+   
+   output = ApplicationRecord.instaload_sql([
+      User.instaload(%Q{
+              select id 
+	      from users
+	      where users.id = any (:user_ids) and users.created_at > :time
+	  }, table_name: :limited_users, relied_on: true),
+      User.instaload(%Q{
+         select friends.smaller_user_id as id, friends.bigger_user_id as friended_to
+         from friends
+	     inner join limited_users on limited_users.id = bigger_user_id
+         union
+         select friends.bigger_user_id as id, friends.smaller_user_id as friended_to
+	 from friends
+	     inner join limited_users ON limited_users.id = smaller_user_id
+      }, table_name: :users_friends, base_name: :limited_users, attach_on: attach_on),
+      ApplicationRecord.instaload(%Q{
+         SELECT follows.followable_id, follows.follower_id
+         FROM follows
+         INNER JOIN limited_users ON follows.follower_id = limited_users.id
+      }, table_name: :users_follows, base_name: :limited_users)
+   ], user_ids: uids, time: t)
+   
+   pp out['limited_users']
+
+```
+sql output: same as example above this example
+
+printed output (same as in dynamic attach example): 
+```ruby
+#<User id: 3, users_friends: [#<User id: 5, friended_to: 3>, #<User id: 6, friended_to: 3>, #<User id: 21, friended_to: 3>], users_follows: [{"followable_id"=>935, "follower_id"=>3}, {"followable_id"=>938, "follower_id"=>3}, ...]>,
+ #<User id: 14, users_friends: [#<User id: 9, friended_to: 14>, #<User id: 21, friended_to: 14>, ...], users_follows: [{"followable_id"=>936, "follower_id"=>14}, {"followable_id"=>937, "follower_id"=>14}, {"followable_id"=>938, "follower_id"=>14}, ...]>,
+ #<User id: 9, users_friends: [#<User id: 14, friended_to: 9>, #<User id: 22, friended_to: 9>, ...], users_follows: [{"followable_id"=>938, "follower_id"=>9}, {"followable_id"=>937, "follower_id"=>9}, ...]>,
+ #<User id: 19, users_friends: [#<User id: 1, friended_to: 19>, #<User id: 18, friended_to: 19>, ...], users_follows: [{"followable_id"=>935, "follower_id"=>19}, {"followable_id"=>936, "follower_id"=>19}, {"followable_id"=>938, "follower_id"=>19}, ...]>,
+ ```
+	
+</details>
 	
 #### self.instaload(sql, table_name: nil, relied_on: false, dont_return: false)
 A method used to prepare data for the instaload_sql method. It returns a hash of options.
@@ -470,6 +516,9 @@ v3.0.6
 - changed how variables are set for ActiveRecord objects, I gave up on figuring out what ActiveRecord is doing for *the most part* and i now just do a eval("self.#{parameter}=value") type deal. Works well. Allows you to override relations when doing polymorphic stuff which is a pretty big use case.
 - I am thinking of changing how arrays are handled as that is really the only postgresql based dependency here and that will allow the library to open up to other databases. Issue is all the code I have already written in my app dependant on such things.
 
+3.0.24
+- changed how questionable_attribute_set works again, this time by using attr_accessors on the singleton class. Seems to paper over the default reflections nicely which has been a huge issue. They use this weird delegate thing which has been throwing me off. Anyway, no more evals which is nice. This fixed an issue with dynamic attach one-to-many relations.
+
 ## Questions
 - Q: does the name of a sql operation have anything to do with prepared statements?
 - A: no, the prepared statement determines uniqueness in some other way, dont worry about collisions. The only issue with prepared statements that I can determine is when you write a statement where things change every time, thus preparing potentially infinite prepared statements. This can be alleviated by using sql arguments correctly. Using arguments correctly also will stop sql injection attacks so. You know. Do it properly. Dont just hard code them into the query.

data/lib/dynamic-records-meritfront/version.rb

@@ -1,5 +1,5 @@
 
 	module DynamicRecordsMeritfront
-	    VERSION = '3.0.23'
+	    VERSION = '3.0.26'
 	end
 	#this file gets overwritten automatically on minor updates, major ones need to be manually changed

data/lib/dynamic-records-meritfront.rb

@@ -1,7 +1,7 @@
 require "dynamic-records-meritfront/version"
 require 'hashid/rails'
 
-#this file contains multiple classes which should honestly be split up
+#this file contains multiple classes which should honestly be split up.
 
 module DynamicRecordsMeritfront
     extend ActiveSupport::Concern
@@ -22,7 +22,7 @@ module DynamicRecordsMeritfront
         #Note we defined here as it breaks early on as Rails.application returns nil
         PROJECT_NAME = Rails.application.class.to_s.split("::").first.to_s.downcase
         DYNAMIC_SQL_RAW = true
-
+        attr_accessor :dynamic_reflections
     end
 
     class DynamicSqlVariables
@@ -86,13 +86,11 @@ module DynamicRecordsMeritfront
             DateTime => ActiveModel::Type::DateTime,
             Time => ActiveModel::Type::Time,
             Float => ActiveModel::Type::Float,
-            NilClass => ActiveModel::Type::Boolean,
-            Array =>  Proc.new{ |first_el_class| ActiveRecord::ConnectionAdapters::PostgreSQL::OID::Array.new(DB_TYPE_MAPS[first_el_class].new) }
+		NilClass => ActiveModel::Type::Boolean,
+            Array =>  Proc.new{ |first_el_class| ActiveRecord::ConnectionAdapters::PostgreSQL::OID::Array.new(DB_TYPE_MAPS[first_el_class].new) } #this one was a mistake
         }
 
         def convert_to_query_attribute(name, v)
-            #yes its dumb I know dont look at me look at rails
-
             # https://stackoverflow.com/questions/40407700/rails-exec-query-bindings-ignored
             # binds = [ ActiveRecord::Relation::QueryAttribute.new(
             # 	"id", 6, ActiveRecord::Type::Integer.new
@@ -106,11 +104,7 @@ module DynamicRecordsMeritfront
 
             type = DB_TYPE_MAPS[v.class]
             if type.nil?
-                # if v.class == NilClass
-                #     raise StandardError.new("")
-                # else
-                    raise StandardError.new("#{name} (of value: #{v}, class: #{v.class}) unsupported class for ApplicationRecord#headache_sql")
-                # end
+                raise StandardError.new("#{name} (of value: #{v}, class: #{v.class}) unsupported class for ApplicationRecord#headache_sql")
             elsif type.class == Proc
                 a = v[0]
                 # if a.nil?
@@ -168,35 +162,86 @@ module DynamicRecordsMeritfront
 
     def questionable_attribute_set(atr, value, as_default: false, push: false)
         #this is needed on initalization of a new variable after the actual thing has been made already.
+        #this is used for attaching records to other records in one-to-one or one-to-many
+
+        #basically the way this works is by using singletons to paper over the fact that normal reflections
+        #even exist. We dont integrate at all with their patterns as they use some crazy delegation stuff
+        #that messes just about everything up.
+
+        #man i thought i was meta coding, these association people just want to see the world burn.
+
+        #keeping the old code commented for a while because this area keeps breaking and i want a log of what i have tried.
+
+        self.dynamic_reflections ||= []
+
+        unless dynamic_reflections.include?(atr.to_s)
+            self.dynamic_reflections << atr.to_s
+            singleton_class.instance_eval do 
+                attr_accessor atr.to_sym
+            end
+        end
+    #    # if _reflections.keys.include? atr.to_s
+    #     has_method = methods.include?(atr.to_sym)
+    #     
+    #     DevScript.ping(has_method)
+    #     override = (not(has_method) or (
+    #         _reflections.keys.include? atr.to_s
+    #         and not
+            
+    #     )
+    #     DevScript.ping(override)
+
+    #     if override
+            
+            
+    #     end
+        #elsif
+                
+        #end
 
-        #note that the below is the value lookup for ActiveModel, but values seems to have all the database columns
-        #in it anyways
-        #
-        # def key?(name)
-        #     (values.key?(name) || types.key?(name) || @attributes.key?(name)) && self[name].initialized?
-        # end
-        raise StandardError.new('bad options') if as_default and push
         if as_default
-            unless self.respond_to? atr
-                #make sure its accesible in some way
-                values = @attributes.instance_variable_get(:@values)
-                if not values.keys.include?(atr)
-                    values[atr] = value
-                end
+            if self.method(atr.to_sym).call().nil?
+                self.method("#{atr}=".to_sym).call(value)
+                # DevScript.ping("atr #{atr} def #{value}")
             end
+        elsif push
+            self.method(atr.to_sym).call().push value
+            # DevScript.ping("atr #{atr} push #{value}")
         else
-            #no getter/setter methodsout, probably catches missing methods and then redirects to attributes. Lots of magic.
-            #   After multiple attempts, I gave up, so now we use eval. I guess I cant be too mad about magic as
-            #   that seems to be my bread and butter. Hope eval doesnt make it go too slow. Guess everything is evaled
-            #   on some level though?
-            s = self    #afraid self will be a diffrent self in eval. Possibly depending on parser. IDK. Just seemed risky.
-            if push
-                eval "s.#{atr} << value"
-            else
-                eval "s.#{atr} = value"
-            end
+            self.method("#{atr}=".to_sym).call(value)
+            # DevScript.ping("atr #{atr} set #{value}")
         end
 
+#        raise StandardError.new('bad options') if as_default and push
+#        if as_default
+#            unless self.respond_to? atr
+#                #make sure its accesible in some way
+#                values = @attributes.instance_variable_get(:@values)
+#                if not values.keys.include?(atr)
+#                    values[atr] = value
+#                end
+#            end
+#        else
+#            if self.reflections.keys.include? atr.to_s
+#		
+#            else
+#                values ||= @attributes.instance_variable_get(:@values)
+#                values[atr] << value
+#                
+#            
+#            end
+#            #no getter/setter methodsout, probably catches missing methods and then redirects to attributes. Lots of magic.
+#            #   After multiple attempts, I gave up, so now we use eval. I guess I cant be too mad about magic as
+#            #   that seems to be my bread and butter. Hope eval doesnt make it go too slow. Guess everything is evaled
+#            #   on some level though?
+#            s = self    #afraid self will be a diffrent self in eval. Possibly depending on parser. IDK. Just seemed risky.
+#            if push
+#                eval "s.#{atr} << value"
+#            else
+#                eval "s.#{atr} = value"
+#            end
+#        end
+
         # atr = atr.to_s
         # setter = "#{atr}="
         # if respond_to?(setter)
@@ -232,6 +277,9 @@ module DynamicRecordsMeritfront
         #basically the same as the upstream active record function (as of october 25 2022 on AR V7.0.4)
         #except that I changed self.class.attribute_names -> self.attribute_names to pick up our
         #dynamic insanity. Was this a good idea? Well I guess its better than not doing it
+
+        #I also added dynamic_reflections
+
         inspection = if defined?(@attributes) && @attributes
             self.attribute_names.filter_map do |name|
             if _has_attribute?(name)
@@ -242,7 +290,16 @@ module DynamicRecordsMeritfront
             "not initialized"
         end
 
-        "#<#{self.class} #{inspection}>"
+        self.dynamic_reflections ||= []
+        dyna = dynamic_reflections.map{|dr|
+            [dr, self.method(dr.to_sym).call()]
+        }.to_h
+
+        if dyna.any?
+            "#<#{self.class} #{inspection} | #{dyna.to_s}>"
+        else
+            "#<#{self.class} #{inspection} >"
+        end
     end
 
     module ClassMethods
@@ -895,8 +952,9 @@ module DynamicRecordsMeritfront
 
     #just for ease of use
     def headache_preload(records, associations)
-            self.class.headache_preload(records, associations)
+        self.class.headache_preload(records, associations)
     end
+
     def safe_increment(col, val) #also used in follow, also used in comment#kill
         self.class.where(id: self.id).update_all("#{col} = #{col} + #{val}")
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dynamic-records-meritfront
 version: !ruby/object:Gem::Version
-  version: 3.0.23
+  version: 3.0.26
 platform: ruby
 authors:
 - Luke Clancy
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-02-02 00:00:00.000000000 Z
+date: 2023-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hashid-rails