dwf 0.1.10 → 0.1.11

data/spec/dwf/workflow_spec.rb

@@ -2,22 +2,23 @@
 
 require 'spec_helper'
 require 'mock_redis'
-class AItem < Dwf::Item; end
-
-class BItem < Dwf::Item; end
-
-class CItem < Dwf::Item; end
+AItem = Class.new(Dwf::Item)
+BItem = Class.new(Dwf::Item)
+CItem = Class.new(Dwf::Item)
+SWorkflow = Class.new(Dwf::Workflow)
 
 describe Dwf::Workflow, workflow: true do
   let(:workflow_id) { SecureRandom.uuid }
   let(:item_id) { SecureRandom.uuid }
+  let(:item) { nil }
   let(:client) do
     double(
       persist_workflow: nil,
       persist_job: nil,
       build_workflow_id: workflow_id,
       build_job_id: item_id,
-      find_workflow: nil
+      find_workflow: nil,
+      find_node: item
     )
   end
   before do
@@ -90,6 +91,7 @@ describe Dwf::Workflow, workflow: true do
 
     before do
       workflow.run AItem, after: BItem, before: CItem
+      workflow.run SWorkflow, after: AItem
     end
 
     it do
@@ -102,6 +104,10 @@ describe Dwf::Workflow, workflow: true do
         {
           from: "AItem|#{item_id}",
           to: CItem.to_s
+        },
+        {
+          from: AItem.to_s,
+          to: "SWorkflow|#{workflow_id}"
         }
       ]
       expect(workflow.dependencies).to match_array expected
@@ -134,25 +140,26 @@ describe Dwf::Workflow, workflow: true do
     before do
       workflow.run AItem
       workflow.run BItem, after: AItem
-      workflow.run CItem, after: BItem
+      workflow.run SWorkflow, after: BItem
+      workflow.run CItem, after: SWorkflow
 
       workflow.send(:setup)
     end
 
     it do
-      job_a = workflow.find_job('AItem')
+      job_a = workflow.find_job("AItem")
 
       expect(job_a.incoming).to be_empty
       expect(job_a.outgoing).to eq ["BItem|#{item_id}"]
 
       job_b = workflow.find_job('BItem')
 
-      expect(job_b.incoming).to eq ['AItem']
-      expect(job_b.outgoing).to eq ["CItem|#{item_id}"]
+      expect(job_b.incoming).to eq ["AItem|#{item_id}"]
+      expect(job_b.outgoing).to eq ["SWorkflow|#{workflow_id}"]
 
       job_c = workflow.find_job('CItem')
 
-      expect(job_c.incoming).to eq ['BItem']
+      expect(job_c.incoming).to eq ["SWorkflow|#{workflow_id}"]
       expect(job_c.outgoing).to be_empty
     end
   end
@@ -160,11 +167,11 @@ describe Dwf::Workflow, workflow: true do
   describe '#callback_type' do
     let!(:workflow) { described_class.new }
 
-    it {
+    it do
       expect(workflow.callback_type).to eq described_class::BUILD_IN
       workflow.callback_type = described_class::SK_BATCH
       expect(workflow.callback_type).to eq described_class::SK_BATCH
-    }
+    end
   end
 
   describe '#reload' do
@@ -181,4 +188,162 @@ describe Dwf::Workflow, workflow: true do
 
     it { expect(client).to have_received(:find_workflow).with(workflow_id) }
   end
+
+  describe '#parents_succeeded?' do
+    let(:incoming) { ["A|#{SecureRandom.uuid}"] }
+    let!(:workflow) do
+      flow = described_class.new
+      flow.parent_id = SecureRandom.uuid
+      flow.incoming = incoming
+      flow
+    end
+    let(:item) do
+      Dwf::Item.new(
+        workflow_id: SecureRandom.uuid,
+        id: SecureRandom.uuid,
+        finished_at: finished_at
+      )
+    end
+
+    context 'parent jobs already finished' do
+      let(:finished_at) { Time.now.to_i }
+
+      it do
+        expect(workflow.parents_succeeded?).to be_truthy
+        expect(client).to have_received(:find_node)
+          .with(incoming.first, workflow.parent_id)
+      end
+    end
+
+    context 'parent jobs havent finished yet' do
+      let(:finished_at) { nil }
+
+      it do
+        expect(workflow.parents_succeeded?).to be_falsy
+        expect(client)
+          .to have_received(:find_node)
+          .with(incoming.first, workflow.parent_id)
+      end
+    end
+  end
+
+  describe '#sub_workflow?' do
+    let!(:workflow) { described_class.new }
+    let!(:sub_workflow) do
+      flow = described_class.new
+      flow.parent_id = workflow.id
+      flow
+    end
+
+    specify do
+      expect(workflow.sub_workflow?).to be_falsy
+      expect(sub_workflow.sub_workflow?).to be_truthy
+    end
+  end
+
+  describe '#payloads' do
+    let!(:item) do
+      Dwf::Item.new(
+        workflow_id: SecureRandom.uuid,
+        id: SecureRandom.uuid,
+        output_payload: 1
+      )
+    end
+    let(:workflow) { described_class.new }
+
+    context 'when workflow is main flow' do
+      it { expect(workflow.payloads).to be_nil }
+    end
+
+    context 'when workflow is sub flow' do
+      before do
+        workflow.incoming = incoming
+        workflow.parent_id = SecureRandom.uuid
+      end
+
+      context 'when incoming blank' do
+        let(:incoming) { [] }
+        it { expect(workflow.payloads).to be_nil }
+      end
+
+      context 'when incoming present' do
+        let(:incoming) { ["Dwf::Item|#{SecureRandom.uuid}", "Dwf::Workflow|#{workflow_id}"] }
+        it do
+          expected_payload = [
+            {
+              class: item.class.name,
+              id: item.name,
+              output: 1
+            }
+          ]
+          expect(workflow.payloads).to eq expected_payload
+          expect(client).to have_received(:find_node).with(incoming.first, workflow.parent_id)
+        end
+      end
+    end
+  end
+
+  describe '#left?' do
+    let(:workflow) { described_class.new }
+    before { workflow.outgoing = outgoing }
+
+    context 'when item has outgoing item' do
+      let(:outgoing) { ["Dwf::Item|#{SecureRandom.uuid}"] }
+      it { expect(workflow.leaf?).to be_falsy }
+    end
+
+    context 'when item does not have outgoing item' do
+      let(:outgoing) { [] }
+      it { expect(workflow.leaf?).to be_truthy }
+    end
+  end
+
+  describe '#leaf_nodes' do
+    let!(:workflow) { described_class.new }
+    before do
+      workflow.run AItem
+      workflow.run BItem, after: AItem
+      workflow.run SWorkflow, after: BItem
+      workflow.run CItem, after: SWorkflow
+
+      workflow.send(:setup)
+    end
+
+    specify do
+      expect(workflow.leaf_nodes.count).to eq 1
+      expect(workflow.leaf_nodes.first).to be_kind_of CItem
+    end
+  end
+
+  describe '#output_payloads' do
+    let!(:workflow) { described_class.new }
+    before do
+      allow_any_instance_of(CItem).to receive(:output_payload).and_return 1
+      workflow.run AItem
+      workflow.run BItem, after: AItem
+      workflow.run SWorkflow, after: BItem
+      workflow.run CItem, after: SWorkflow
+
+      workflow.send(:setup)
+    end
+
+    it { expect(workflow.output_payload).to eq [1] }
+  end
+
+  describe '#callback_type=' do
+    let!(:workflow) { described_class.new }
+    before do
+      workflow.run AItem
+      workflow.run BItem, after: AItem
+
+      workflow.send(:setup)
+      workflow.callback_type = described_class::SK_BATCH
+    end
+
+    specify do
+      expect(workflow.callback_type).to eq described_class::SK_BATCH
+      job_callback_types = workflow.jobs.map(&:callback_type).uniq
+      expect(job_callback_types).to eq [described_class::SK_BATCH]
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,4 +1,7 @@
 require 'dwf'
+require 'simplecov'
+
+SimpleCov.start
 # This file was generated by the `rspec --init` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
 # The generated `.rspec` file contains `--require spec_helper` which will cause

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dwf
 version: !ruby/object:Gem::Version
-  version: 0.1.10
+  version: 0.1.11
 platform: ruby
 authors:
 - dthtien
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-09-12 00:00:00.000000000 Z
+date: 2021-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 11.1.3
+- !ruby/object:Gem::Dependency
+  name: mock_redis
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.27.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.27.2
 - !ruby/object:Gem::Dependency
   name: redis
   requirement: !ruby/object:Gem::Requirement
@@ -53,33 +67,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.2'
 - !ruby/object:Gem::Dependency
-  name: mock_redis
+  name: sidekiq
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.27.2
-  type: :development
+        version: 6.2.0
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.27.2
+        version: 6.2.0
 - !ruby/object:Gem::Dependency
-  name: sidekiq
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 6.2.0
-  type: :runtime
+        version: '0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 6.2.0
+        version: '0'
 description: Workflow
 email:
 - tiendt2311@gmail.com
@@ -100,6 +114,7 @@ files:
 - lib/dwf.rb
 - lib/dwf/callback.rb
 - lib/dwf/client.rb
+- lib/dwf/concerns/checkable.rb
 - lib/dwf/configuration.rb
 - lib/dwf/errors.rb
 - lib/dwf/item.rb