duty_calculator 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3074281a85d5dd3f9b02fa22f529ec9950650a2f
-  data.tar.gz: ea02f8be01351e59884132c5b09327958bdb0c79
+  metadata.gz: acd45bb6bd3eb0e883c0661940510ecd5ca4eb69
+  data.tar.gz: d266474849fcd13a2bf9f133e3ccdccbc992fe32
 SHA512:
-  metadata.gz: b10a1295f4f29c9f5590024754a99bd93d96fb55932f011f6683fe0a1be2bbb9579426ec067fd3a50e61667ec5a96c56393b903c6e3b8b16dc13f7e5cda30615
-  data.tar.gz: 99923120a6705604b59beb285d78e984e2f0ce16baad6c2068f2c74b3aebe562f8be1bf070d68609c571e78728d9f96b4dc4d525cbbf32434205af9439965095
+  metadata.gz: ecc1d5b1e5dbdb6415bd948f61b54ccef4a2401b68bdf89169bc86a18002a2e1c0aacf52ff5057019082ca40015c1d64d80688f92524fa60b5f95b13fe1e48a3
+  data.tar.gz: 51e901b315355add0af9686f533f4f893790fede47c5c8e8183a9fa929a71e6106e40c88ad2f2bccfde4256385c01987b0eb405f2fe3a56c2ba9627e590972b7

data/lib/duty_calculator.rb

@@ -1,10 +1,11 @@
-require "duty_calculator/version"
 require "duty_calculator/configuration"
 require "duty_calculator/currency"
 require "duty_calculator/category"
 require "duty_calculator/calculation"
-require "duty_calculator/response"
+require "duty_calculator/dootie"
 require "duty_calculator/error_messages"
+require "duty_calculator/response"
+require "duty_calculator/version"
 
 require "faraday"
 require "faraday_middleware"

data/lib/duty_calculator/calculation.rb

@@ -1,5 +1,6 @@
 require "duty_calculator/client"
 require "duty_calculator/response"
+require "duty_calculator/dootie"
 require "addressable/uri"
 module DutyCalculator
   class Calculation
@@ -37,12 +38,17 @@ module DutyCalculator
 
     def self.get(params={})
       transformed_params = transform_params(validate_params(params))
+      # initialize connection
       conn = DutyCalculator::Client.new
+
       resp = conn.get "#{DutyCalculator::Client.api_base}/calculation", transformed_params
       hashed_resp = DutyCalculator::Response.new(resp.to_hash)
       resp = Hashie::Mash.new(hashed_resp)
-      raise Exception, "Duty Calculator Error: #{DutyCalculator::ErrorMessages.for_code(resp.body.error.code)}" if resp.body.error
-      raise Exception, "HTTP Status Code #{resp.status}" if resp.status.to_i != 200
+
+      if resp.body["error"]
+        return DutyCalculator::Dootie.new({message: "[DutyCalculator][Error]:", error: resp.body["error"]})
+      end
+
       resp.body.duty_calculation
     end
   end

data/lib/duty_calculator/client.rb

@@ -10,7 +10,7 @@ module DutyCalculator
         faraday.use Faraday::Response::ParseXml
         faraday.use Faraday::Response::Mashify
         faraday.use Faraday::Response::RaiseError unless DutyCalculator.configuration.debug
-        faraday.response :logger if DutyCalculator.configuration.debug
+        faraday.response :logger, DutyCalculator.configuration.logger
 
         faraday.adapter ::Faraday.default_adapter
       end

data/lib/duty_calculator/configuration.rb

@@ -1,10 +1,11 @@
 require "yaml"
-
+require 'logger'
 require "duty_calculator"
 
 module DutyCalculator
   class Configuration
-    attr_accessor :api_root, :api_version, :api_key, :api_base, :sandbox, :debug
+    attr_accessor :api_root, :api_version, :api_key, :api_base, :sandbox, :debug, :logger
+
 
     def initialize
       defaults = load_defaults
@@ -12,6 +13,7 @@ module DutyCalculator
       @api_version = defaults[:api_version]
       @sandbox = defaults[:sandbox]
       @debug = defaults[:debug]
+      @logger = ::Logger.new(STDOUT)
     end
 
     private

data/lib/duty_calculator/dootie.rb

@@ -0,0 +1,19 @@
+# encoding: utf-8
+module DutyCalculator
+  class Dootie < StandardError
+    def initialize(data=nil)
+      @data = data
+      @default_message = "[DutyCalculator][Error]: ¯\\_(ツ)_/¯"
+    end
+
+    def to_s
+      msg = []
+      msg << @data[:message] || @default_message
+      msg << "Error Code: #{@data[:error][:code]}"
+      msg << DutyCalculator::ErrorMessages.for_code(@data[:error][:code]) if @data[:error][:code]
+      msg.to_s
+    end
+  end
+
+  class NotImplemented < Dootie; end
+end

data/lib/duty_calculator/error_messages.rb

@@ -10,7 +10,8 @@ module DutyCalculator
               "4061" => "Account does not support called service: Classification service - get HS codes, duty & tax rates and import restrictions",
               "4062" => "Account does not support called service: Documents service",
               "4063" => "Account does not support called operation: Classification service - get DutyCalculator item ID",
-              "4064" => "Account does not support called operation: Reporting service","4401" => "Parameter is missing",
+              "4064" => "Account does not support called operation: Reporting service",
+              "4401" => "Parameter is missing",
               "4421" => "Bad parameter: shipping cost can't be empty",
               "4422" => "Bad parameter: shipment weight can't be empty",
               "4423" => "Bad parameter: imported weight can't be empty",
@@ -19,7 +20,8 @@ module DutyCalculator
               "4426" => "Bad parameter: both category and description for reference <product reference> can't be empty",
               "4427" => "Bad parameter: SKU for reference <product reference> can't be empty",
               "4428" => "Bad parameter: HS code for reference <product reference> can't be empty",
-              "4429" => "Bad parameter: description for reference <product reference> can't be empty","4701" => "Bad parameter: <parameter name> is invalid",
+              "4429" => "Bad parameter: description for reference <product reference> can't be empty",
+              "4701" => "Bad parameter: <parameter name> is invalid",
               "4721" => "Classification for the selected import to country is not possible",
               "4722" => "Bad parameter: country from code",
               "4723" => "Bad parameter: country to code",

data/lib/duty_calculator/version.rb

@@ -1,3 +1,3 @@
 module DutyCalculator
-  VERSION = "0.0.6"
+  VERSION = "0.0.7"
 end

data/spec/duty_calculator/dootie_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+module DutyCalculator
+  describe Dootie do
+    context "Status Codes From API" do
+      let(:params) do
+        {
+            from: "US",
+            to: "CA",
+            shipping_mode: "USPS",
+            insurance: 0.0,
+            currency: "USD",
+            origin: "US",
+            reference: "ORD12345",
+            preferential_rates: 0,
+            detailed_result: 1,
+            incl_hs_codes: 1,
+            shipping: 10.0,
+            cat: ["9999999999999999999992"],
+            hs: ["9019100020"],
+            country_of_hs_code: ["CN"],
+            desc: ["Hydrotherapy Spa Bath"],
+            weight: ["1.0"],
+            weight_unit: ["lb"],
+            value: [ "1234.00" ],
+            sku: [ "300101" ],
+            qty: [ 1 ],
+            commercial_importer: 0,
+            classify_by: 'cat',
+        }
+      end
+      it "returns a DutyCalculator error from code for bad api key" do
+        DutyCalculator.configure do |config|
+          config.api_key = ""
+          config.sandbox = true
+          config.debug = true
+        end
+        VCR.use_cassette('dootie__status_codes_from_api_1') do
+          duty_calculation = DutyCalculator::Calculation.get(params)
+          expect(duty_calculation.class).to eq(DutyCalculator::Dootie)
+          expect(duty_calculation.message).to include('Client id is invalid or missing')
+        end
+      end
+      it "returns a DutyCalculator error about a bad category" do
+        DutyCalculator.configure do |config|
+          config.api_key = 'DUTY_CALC'
+          config.sandbox = true
+          config.debug = true
+        end
+        VCR.use_cassette('dootie__status_codes_from_api_2') do
+          duty_calculation = DutyCalculator::Calculation.get(params)
+          expect(duty_calculation.class).to eq(DutyCalculator::Dootie)
+          expect(duty_calculation.message).to include('4747')
+          expect(duty_calculation.message).to include('could not be autoclassified')
+        end
+      end
+    end
+  end
+end

data/spec/vcr/dootie__status_codes_from_api_1.yml

@@ -0,0 +1,49 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://www.dutycalculator.com/api2.1/sandbox/calculation?cat%5B%5D=9999999999999999999992&classify_by=cat&commercial_importer=0&country_of_hs_code%5B%5D=CN&currency=USD&desc%5B%5D=Hydrotherapy%20Spa%20Bath&detailed_result=1&from=US&hs%5B%5D=9019100020&incl_hs_codes=1&insurance=0.0&origin=US&preferential_rates=0&qty%5B%5D=1&reference=ORD12345&shipping=10.0&shipping_mode=USPS&sku%5B%5D=300101&to=CA&value%5B%5D=1234.00&weight%5B%5D=1.0&weight_unit%5B%5D=lb
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Faraday v0.9.1
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 400
+      message: Bad Request
+    headers:
+      Server:
+      - nginx/1.6.1
+      Date:
+      - Wed, 01 Apr 2015 18:33:37 GMT
+      Content-Type:
+      - application/xml
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+      X-Powered-By:
+      - PHP/5.5.9-1ubuntu4.5
+      Set-Cookie:
+      - DebugLevel=0; expires=Fri, 01-May-2015 18:33:37 GMT; Max-Age=2592000; path=/
+      - PHPSESSID=2r0e1sofgbpetuhrks0nm273o0; path=/
+      Expires:
+      - Thu, 19 Nov 1981 08:52:00 GMT
+      Cache-Control:
+      - no-store, no-cache, must-revalidate, post-check=0, pre-check=0
+      Pragma:
+      - no-cache
+    body:
+      encoding: UTF-8
+      string: |
+        <?xml version="1.0" encoding="UTF-8"?>
+        <error><code>4046</code><message>Client id is invalid or missing</message></error>
+    http_version: 
+  recorded_at: Wed, 01 Apr 2015 18:31:08 GMT
+recorded_with: VCR 2.9.3

data/spec/vcr/dootie__status_codes_from_api_2.yml

@@ -0,0 +1,49 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://www.dutycalculator.com/api2.1/sandbox/DUTY_CALC/calculation?cat%5B%5D=9999999999999999999992&classify_by=cat&commercial_importer=0&country_of_hs_code%5B%5D=CN&currency=USD&desc%5B%5D=Hydrotherapy%20Spa%20Bath&detailed_result=1&from=US&hs%5B%5D=9019100020&incl_hs_codes=1&insurance=0.0&origin=US&preferential_rates=0&qty%5B%5D=1&reference=ORD12345&shipping=10.0&shipping_mode=USPS&sku%5B%5D=300101&to=CA&value%5B%5D=1234.00&weight%5B%5D=1.0&weight_unit%5B%5D=lb
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Faraday v0.9.1
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 400
+      message: Bad Request
+    headers:
+      Server:
+      - nginx/1.6.1
+      Date:
+      - Wed, 01 Apr 2015 18:33:37 GMT
+      Content-Type:
+      - application/xml
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+      X-Powered-By:
+      - PHP/5.5.9-1ubuntu4.5
+      Set-Cookie:
+      - DebugLevel=0; expires=Fri, 01-May-2015 18:33:37 GMT; Max-Age=2592000; path=/
+      - PHPSESSID=njctv8db05jj19cpk6p42qm621; path=/
+      Expires:
+      - Thu, 19 Nov 1981 08:52:00 GMT
+      Cache-Control:
+      - no-store, no-cache, must-revalidate, post-check=0, pre-check=0
+      Pragma:
+      - no-cache
+    body:
+      encoding: UTF-8
+      string: |
+        <?xml version="1.0" encoding="UTF-8"?>
+        <error><code>4747</code><message>Reference 0 could not be autoclassified</message></error>
+    http_version: 
+  recorded_at: Wed, 01 Apr 2015 18:31:08 GMT
+recorded_with: VCR 2.9.3

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: duty_calculator
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Thomas Hanley
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-31 00:00:00.000000000 Z
+date: 2015-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -160,17 +160,21 @@ files:
 - lib/duty_calculator/client.rb
 - lib/duty_calculator/configuration.rb
 - lib/duty_calculator/currency.rb
+- lib/duty_calculator/dootie.rb
 - lib/duty_calculator/error_messages.rb
 - lib/duty_calculator/response.rb
 - lib/duty_calculator/version.rb
 - spec/duty_calculator/calculation_spec.rb
 - spec/duty_calculator/configuration_spec.rb
 - spec/duty_calculator/currency_spec.rb
+- spec/duty_calculator/dootie_spec.rb
 - spec/duty_calculator/response_spec.rb
 - spec/spec_helper.rb
 - spec/support/vcr.rb
 - spec/vcr/calculate__nice_hash_for_multiple_products.yml
 - spec/vcr/calculate__nice_hash_for_single_product.yml
+- spec/vcr/dootie__status_codes_from_api_1.yml
+- spec/vcr/dootie__status_codes_from_api_2.yml
 homepage: https://github.com/tjhanley/duty-calculator
 licenses:
 - MIT
@@ -199,8 +203,11 @@ test_files:
 - spec/duty_calculator/calculation_spec.rb
 - spec/duty_calculator/configuration_spec.rb
 - spec/duty_calculator/currency_spec.rb
+- spec/duty_calculator/dootie_spec.rb
 - spec/duty_calculator/response_spec.rb
 - spec/spec_helper.rb
 - spec/support/vcr.rb
 - spec/vcr/calculate__nice_hash_for_multiple_products.yml
 - spec/vcr/calculate__nice_hash_for_single_product.yml
+- spec/vcr/dootie__status_codes_from_api_1.yml
+- spec/vcr/dootie__status_codes_from_api_2.yml