durran-carrierwave 0.3.2.3 → 0.4.3

data/spec/compatibility/paperclip_spec.rb

@@ -4,6 +4,15 @@ require File.dirname(__FILE__) + '/../spec_helper'
 
 require 'carrierwave/orm/activerecord'
 
+module Rails
+  def self.root
+    File.expand_path(File.join('..'), File.dirname(__FILE__))
+  end
+  def self.env
+    "test"
+  end
+end unless defined?(Rails)
+
 describe CarrierWave::Compatibility::Paperclip do
 
   before do
@@ -21,12 +30,12 @@ describe CarrierWave::Compatibility::Paperclip do
 
   describe '#store_path' do
     it "should mimics paperclip default" do
-      @uploader.store_path("monkey.png").should == CarrierWave.config[:root] + "/public/system/monkeys/23/original/monkey.png"
+      @uploader.store_path("monkey.png").should == CarrierWave::Uploader::Base.root + "/system/monkeys/23/original/monkey.png"
     end
 
     it "should interpolate the root path" do
       @uploader.stub!(:paperclip_path).and_return(":rails_root/foo/bar")
-      @uploader.store_path("monkey.png").should == CarrierWave.config[:root] + "/foo/bar"
+      @uploader.store_path("monkey.png").should == Rails.root + "/foo/bar"
     end
 
     it "should interpolate the attachment" do

data/spec/mount_spec.rb

@@ -31,7 +31,6 @@ describe CarrierWave::Mount do
         end
       end
 
-      @instance.image_uploader.should be_an_instance_of(@uploader)
       @instance.image = stub_file('test.jpg')
       @instance.image.should be_an_instance_of(@uploader)
     end
@@ -39,34 +38,10 @@ describe CarrierWave::Mount do
     it "should inherit uploaders to subclasses" do
       @subclass = Class.new(@class)
       @subclass_instance = @subclass.new
-      @subclass_instance.image_uploader.should be_an_instance_of(@uploader)
       @subclass_instance.image = stub_file('test.jpg')
       @subclass_instance.image.should be_an_instance_of(@uploader)
     end
     
-    describe '#image_uploader' do
-      it "should return the uploader" do
-        @instance.image_uploader.should be_an_instance_of(@uploader)
-      end
-    end
-    
-    describe '#image_uploader=' do
-      it "should set the uploader" do
-        @my_uploader = @uploader.new
-        @instance.image_uploader = @my_uploader
-        @instance.image_uploader.should == @my_uploader
-      end
-
-      it "should use the set uploader" do
-        @my_uploader = @uploader.new
-        @my_uploader.store!(stub_file('test.jpg'))
-        @instance.image_uploader = @my_uploader
-        @instance.image_uploader.should == @my_uploader
-        @instance.image.should == @my_uploader
-        @instance.image.current_path.should == public_path('uploads/test.jpg')
-      end
-    end
-    
     describe '#image' do
       
       it "should return a blank uploader when nothing has been assigned" do

data/spec/orm/datamapper_spec.rb

@@ -2,47 +2,54 @@
 
 require File.dirname(__FILE__) + '/../spec_helper'
 
+require 'dm-core'
+require 'dm-validations'
 require 'carrierwave/orm/datamapper'
 
 DataMapper.setup(:default, 'sqlite3::memory:')
 
 describe CarrierWave::DataMapper do
-  
+
   before do
     uploader = Class.new(CarrierWave::Uploader::Base)
-    
+
     @class = Class.new
     @class.class_eval do
       include DataMapper::Resource
 
       storage_names[:default] = 'events'
-      
-      property :id, Integer, :key => true
-      property :image, String
-      
+
+      property :id, DataMapper::Types::Serial
+
+      # auto validation off currently for inferred type
+      # validation. issue is that validations are done on
+      # the value returned by model#property_name which is overloaded
+      # by carrierwave. pull request in @dm-more to remedy this.
+      property :image, String, :auto_validation => false
+
       mount_uploader :image, uploader
     end
-    
+
     @class.auto_migrate!
-    
+
     @uploader = uploader
-    
+
     @event = @class.new
   end
-  
+
   describe '#image' do
-    
+
     it "should return blank uploader when nothing has been assigned" do
       @event.image.should be_blank
     end
-    
+
     it "should return blank uploader when an empty string has been assigned" do
       repository(:default).adapter.query("INSERT INTO events (image) VALUES ('')")
       @event = @class.first
-      
+
       @event.image.should be_blank
     end
-    
+
     it "should retrieve a file from the storage if a value is stored in the database" do
       repository(:default).adapter.query("INSERT INTO events (image) VALUES ('test.jpg')")
       @event = @class.first
@@ -51,82 +58,64 @@ describe CarrierWave::DataMapper do
       @event.reload
       @event.image.should be_an_instance_of(@uploader)
     end
-    
+
     it "should set the path to the store dir" do
       @event.attribute_set(:image, 'test.jpeg')
       @event.save
       @event.reload
       @event.image.current_path.should == public_path('uploads/test.jpeg')
     end
-  
+
   end
-  
+
   describe '#image=' do
-    
+
     it "should cache a file" do
       @event.image = stub_file('test.jpeg')
       @event.image.should be_an_instance_of(@uploader)
     end
-    
+
     it "should write nothing to the database, to prevent overriden filenames to fail because of unassigned attributes" do
       @event.attribute_get(:image).should be_nil
     end
-    
+
     it "should copy a file into into the cache directory" do
       @event.image = stub_file('test.jpeg')
       @event.image.current_path.should =~ /^#{public_path('uploads/tmp')}/
     end
-    
+
     it "should do nothing when nil is assigned" do
       @event.image = nil
       @event.image.should be_blank
     end
-    
+
     it "should do nothing when an empty string is assigned" do
       @event.image = ''
       @event.image.should be_blank
     end
-    
+
   end
-  
+
   describe '#save' do
-    
+
     it "should do nothing when no file has been assigned" do
       @event.save
       @event.image.should be_blank
     end
-    
+
     it "should copy the file to the upload directory when a file has been assigned" do
       @event.image = stub_file('test.jpeg')
       @event.save
       @event.image.should be_an_instance_of(@uploader)
       @event.image.current_path.should == public_path('uploads/test.jpeg')
     end
-    
-    # it "should do nothing when a validation fails" do
-    #   pending "how do we test with and without dm-validations?"
-    #   @class.validate { |r| r.errors.add :textfile, "FAIL!" }
-    #   @event.image = stub_file('test.jpeg')
-    #   @event.save
-    #   @event.image.should be_an_instance_of(@uploader)
-    #   @event.image.current_path.should =~ /^#{public_path('uploads/tmp')}/
-    # end
-    
+
     it "should assign the filename to the database" do
       @event.image = stub_file('test.jpeg')
       @event.save
       @event.reload
       @event.attribute_get(:image).should == 'test.jpeg'
     end
-    
-    # it "should assign the filename before validation" do
-    #   pending "how do we test with and without dm-validations?"
-    #   @class.validate { |r| r.errors.add_to_base "FAIL!" if r[:image].nil? }
-    #   @event.image = stub_file('test.jpeg')
-    #   @event.save
-    #   @event.reload
-    #   @event.attribute_get(:image).should == 'test.jpeg'
-    # end
 
     it "should remove the image if remove_image? returns true" do
       @event.image = stub_file('test.jpeg')
@@ -138,14 +127,32 @@ describe CarrierWave::DataMapper do
       @event.attribute_get(:image).should == ''
     end
 
+    describe "with validations" do
+      it "should do nothing when a validation fails" do
+        @class.validates_with_block(:textfile) { [false, "FAIL!"] }
+        @event.image = stub_file('test.jpeg')
+        @event.save
+        @event.image.should be_an_instance_of(@uploader)
+        @event.image.current_path.should =~ /^#{public_path('uploads/tmp')}/
+      end
+
+      it "should assign the filename before validation" do
+        @class.validates_with_block(:image) { [false, "FAIL!"] if self.image.nil? }
+        @event.image = stub_file('test.jpeg')
+        @event.save
+        @event.reload
+        @event.attribute_get(:image).should == 'test.jpeg'
+      end
+    end
+
   end
 
   describe '#destroy' do
-    
+
     it "should do nothing when no file has been assigned" do
       @event.destroy
     end
-    
+
     it "should remove the file from the filesystem" do
       @event.image = stub_file('test.jpeg')
       @event.save.should be_true
@@ -157,5 +164,5 @@ describe CarrierWave::DataMapper do
     end
 
   end
-  
+
 end

data/spec/orm/mongoid_spec.rb

@@ -0,0 +1,206 @@
+# encoding: utf-8
+require File.dirname(__FILE__) + '/../spec_helper'
+
+require 'carrierwave/orm/mongoid'
+
+connection = Mongo::Connection.new
+Mongoid.database = connection.db("carrierwave_test")
+
+describe CarrierWave::Mongoid do
+
+  before do
+    uploader = Class.new(CarrierWave::Uploader::Base)
+    
+    @class = Class.new
+    @class.class_eval do
+      include Mongoid::Document
+      mount_uploader :image, uploader
+    end
+    
+    @uploader = uploader
+  end
+
+  after do
+    @class.collection.drop
+  end
+
+  describe '#image' do
+
+    context "when nothing is assigned" do
+
+      before do
+        @document = @class.new
+      end
+
+      it "returns a blank uploader" do
+        @document.image.should be_blank
+      end
+
+    end
+
+    context "when an empty string is assigned" do
+
+      before do
+        @document = @class.new(:image_filename => "")
+        @document.save
+      end
+
+      it "returns a blank uploader" do
+        @saved_doc = @class.find(:first)
+        @saved_doc.image.should be_blank
+      end
+
+    end
+
+    context "when a filename is saved in the database" do
+
+      before do
+        @document = @class.new(:image_filename => "test.jpg")
+        @document.save
+        @doc = @class.find(:first)
+      end
+
+      it "returns an uploader" do
+        @doc.image.should be_an_instance_of(@uploader)
+      end
+
+      it "sets the path to the store directory" do
+        @doc.image.current_path.should == public_path('uploads/test.jpg')
+      end
+
+    end
+
+  end
+
+  describe '#image=' do
+
+    before do
+      @doc = @class.new
+    end
+
+    context "when nil is assigned" do
+
+      it "does not set the value" do
+        @doc.image = nil
+        @doc.image.should be_blank
+      end
+
+    end
+
+    context "when an empty string is assigned" do
+
+      it "does not set the value" do
+        @doc.image = ''
+        @doc.image.should be_blank
+      end
+
+    end
+
+    context "when a file is assigned" do
+
+      it "should cache a file" do
+        @doc.image = stub_file('test.jpeg')
+        @doc.image.should be_an_instance_of(@uploader)
+      end
+
+      it "should write nothing to the database, to prevent overriden filenames to fail because of unassigned attributes" do
+        @doc.image_filename.should be_nil
+      end
+
+      it "should copy a file into into the cache directory" do
+        @doc.image = stub_file('test.jpeg')
+        @doc.image.current_path.should =~ /^#{public_path('uploads\/tmp')}/
+      end
+
+    end
+
+  end
+
+  describe "#save" do
+
+    before do
+      @doc = @class.new
+    end
+
+    context "when no file is assigned" do
+
+      it "image is blank" do
+        @doc.save
+        @doc.image.should be_blank
+      end
+
+    end
+
+    context "when a file is assigned" do
+
+      it "copies the file to the upload directory" do
+        @doc.image = stub_file('test.jpg')
+        @doc.save
+        @doc.image.should be_an_instance_of(@uploader)
+        @doc.image.current_path.should == public_path('uploads/test.jpg')
+      end
+
+      it "saves the filename in the database" do
+        @doc.image = stub_file('test.jpg')
+        @doc.save
+        @doc.image_filename.should == 'test.jpg'
+      end
+
+      context "when remove_image? is true" do
+
+        it "removes the image" do
+          @doc.image = stub_file('test.jpeg')
+          @doc.save
+          @doc.remove_image = true
+          @doc.save
+          @doc.image.should be_blank
+          @doc.image_filename.should == ''
+        end
+
+      end
+
+    end
+
+  end
+
+  describe '#destroy' do
+
+    before do
+      @doc = @class.new
+    end
+
+    describe "when file assigned" do
+
+      it "removes the file from the filesystem" do
+        @doc.image = stub_file('test.jpeg')
+        @doc.save.should be_true
+        File.exist?(public_path('uploads/test.jpeg')).should be_true
+        @doc.image.should be_an_instance_of(@uploader)
+        @doc.image.current_path.should == public_path('uploads/test.jpeg')
+        @doc.destroy
+        File.exist?(public_path('uploads/test.jpeg')).should be_false
+      end
+
+    end
+
+    describe "when file is not assigned" do
+
+      it "deletes the instance of @class after save" do
+        @doc.save
+        @class.count.should eql(1)
+        @doc.destroy
+      end
+
+      it "deletes the instance of @class after save and then re-looking up the instance" do
+        @doc.save
+        @class.count.should eql(1)
+        @doc = @class.first
+        @doc.destroy
+      end
+
+    end
+
+  end
+
+
+end