duration.rb 0.3.4 → 0.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 38154d0b4ffc022c025fb1ab7e8cc138bd3de4c9fdf9647470833c67b6ed654e
-  data.tar.gz: b6757bd78e018cb8d28df7c1e06c90916ac848e5b0720ef8d2d62c04f9224a44
+  metadata.gz: c8bbc565cb16fb074e951bca1f185eb80259d0d1319e64b494c278378ee1c43d
+  data.tar.gz: b050be4911300967ed38138c2ffb24053814b47d1ece73cc9592082cb500324d
 SHA512:
-  metadata.gz: 6ee50579a2597c396281ce00aba23b6b558f853309d7fe976dd164a0dbfb992f5f4a574d54764f114e5b89b078cd80c2c1db89f4dafd07e036eb5692cc9309df
-  data.tar.gz: cd7cc3d6a4d011d2dd50d46f1841fd04e6c004d58e8fff8206d172bdb19b5141da54f66f681e9038a69f99a25e71bb4de99e4a6deb41a2749e7e6d68dd114be2
+  metadata.gz: 488c5e1b613abde3bd4a1fe8a50696dc0aee0dbb7f597e0c03e4b46a67a5d515e0720fe583cf66501c822818ea7b5ed7553bd9288cd3b2c74b0531ec1e67265c
+  data.tar.gz: ca417f99691e7dece350937b0b407c44d24fe22aabcefe4327a58394dd1b3ec9dc1af3156b62a914f8334e272303fe491fc6d9c4755d9b685c20217105b08ba8

data/CHANGELOG

@@ -0,0 +1,15 @@
+# CHANGELOG
+
+## 20260717
+
+0.3.5: Months conversion constant bug fix.
+
+1. ~ Duration::Weeks#to_months: The constant asserted a year of 52 weeks, which is 364 days rather than 365.2425, so every conversion through months was short by 1.2425 days a year before months were reached at all. The Gregorian mean month of 2629746 seconds is used instead, against 604800 seconds per week. 12.months.to_days now gives 365.2425 rather than 364.0, and 2.months.to_days gives 60.873749999999994 rather than 60.666666666666664.
+2. ~ Duration::Months#to_weeks: The same constant, in the other direction.
+3. ~ test/Duration/Milliseconds_test.rb, test/Duration/Seconds_test.rb, test/Duration/Minutes_test.rb, test/Duration/Hours_test.rb, test/Duration/Days_test.rb, test/Duration/Weeks_test.rb: The to_months expectations, each of which encoded the old constant.
+4. ~ test/Duration/Months_test.rb: The conversion expectations, each of which encoded the old constant.
+5. ~ test/Duration/Months_test.rb: /must_equal/must_be_close_to/ for the milliseconds and seconds conversions, since 2.months.to_milliseconds arrives at 5259491999.999999 rather than 5259492000.0. The conversion chains through Float, and the drift is inherent to holding a Float rather than anything introduced here. The mean month is an exact number of seconds, so the expectations are exact and it is only the arithmetic which cannot reach them.
+6. + README.md: A note that the Months conversions are a statistical mean, and that ago() and hence() on Months are not calendar-correct, since a corrected constant is still only an average.
+7. + CHANGELOG
+8. ~ duration.rb.gemspec: spec.files to include CHANGELOG.
+9. ~ Duration::VERSION: /0.3.4/0.3.5/

data/README.md

@@ -87,6 +87,25 @@ $ gem install duration.rb
 7.months.hence                  # => #<Time:> (now + 7.months.to_seconds.to_f)
 ```
 
+### A Note on Months
+
+`Months` is the odd one out. Every other unit is a fixed quantity with an exact
+ratio to every other, but a month is a calendar operation whose length depends
+on which month. The conversions use the Gregorian mean month (2629746 seconds),
+so they are honest only as a statistical average:
+
+```ruby
+12.months.to_days               # => 365.2425, the Gregorian mean year
+```
+
+Two actual calendar months are anywhere from 59 to 62 days, while the mean gives
+about 60.87 — no particular pair of months. No single constant can be right.
+
+For the same reason `ago` and `hence` are not calendar-correct on `Months`: one
+month before the 15th of March is the 15th of February to a calendar, but the
+mean lands on the 12th. Where the calendar matters, reach for a date-anchored
+type such as month.rb.
+
 ## Contributing
 
 1. Fork it (https://github.com/thoran/duration.rb/fork)

data/duration.rb.gemspec

@@ -17,6 +17,7 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '>= 2.5'
 
   spec.files = [
+    'CHANGELOG',
     'duration.rb.gemspec',
     'Gemfile',
     Dir['lib/**/*.rb'],

data/lib/Duration/Months.rb

@@ -29,7 +29,8 @@ module Duration
     end
 
     def to_weeks
-      Duration::Weeks.new(@months / 12 * 52)
+      # A month is the Gregorian mean: 2629746 seconds against 604800 per week.
+      Duration::Weeks.new(@months * 2629746 / 604800.0)
     end
 
     def to_months

data/lib/Duration/VERSION.rb

@@ -1,3 +1,3 @@
 module Duration
-  VERSION = '0.3.4'
+  VERSION = '0.3.5'
 end

data/lib/Duration/Weeks.rb

@@ -34,7 +34,8 @@ module Duration
     end
 
     def to_months
-      Duration::Months.new(@weeks / 52 * 12)
+      # A month is the Gregorian mean: 2629746 seconds against 604800 per week.
+      Duration::Months.new(@weeks * 604800 / 2629746.0)
     end
 
     def to_i

data/test/Duration/Days_test.rb

@@ -49,7 +49,7 @@ describe Duration::Days do
     it "converts to months" do
       months = @days.to_months
       _(months).must_be_instance_of Duration::Months
-      _(months.to_f).must_be_close_to 0.06593, 0.00001
+      _(months.to_f).must_be_close_to 0.065710, 0.00001
     end
 
     it "returns itself for to_days" do

data/test/Duration/Hours_test.rb

@@ -49,7 +49,7 @@ describe Duration::Hours do
     it "converts to months" do
       months = subject.to_months
       _(months).must_be_instance_of Duration::Months
-      _(months.to_f).must_be_close_to 0.004120, 0.000001
+      _(months.to_f).must_be_close_to 0.004107, 0.000001
     end
 
     it "returns itself for to_hours" do

data/test/Duration/Milliseconds_test.rb

@@ -49,7 +49,7 @@ describe Duration::Milliseconds do
     it "converts to months" do
       months = subject.to_months
       _(months).must_be_instance_of Duration::Months
-      _(months.to_f).must_be_close_to 1.907814e-6, 0.000001
+      _(months.to_f).must_be_close_to 1.901337e-6, 0.000001
     end
 
     it "returns itself for to_milliseconds" do

data/test/Duration/Minutes_test.rb

@@ -49,7 +49,7 @@ describe Duration::Minutes do
     it "converts to months" do
       months = subject.to_months
       _(months).must_be_instance_of Duration::Months
-      _(months.to_f).must_be_close_to 0.00206, 0.000001
+      _(months.to_f).must_be_close_to 0.002053, 0.000001
     end
 
     it "returns itself for to_minutes" do

data/test/Duration/Months_test.rb

@@ -19,37 +19,37 @@ describe Duration::Months do
     it "converts to milliseconds" do
       ms = subject.to_milliseconds
       _(ms).must_be_instance_of Duration::Milliseconds
-      _(ms.to_f).must_equal 5241600000.0
+      _(ms.to_f).must_be_close_to 5259492000.0, 0.001
     end
 
     it "converts to seconds" do
       secs = subject.to_seconds
       _(secs).must_be_instance_of Duration::Seconds
-      _(secs.to_f).must_equal 5241600.0
+      _(secs.to_f).must_be_close_to 5259492.0, 0.001
     end
 
     it "converts to minutes" do
       mins = subject.to_minutes
       _(mins).must_be_instance_of Duration::Minutes
-      _(mins.to_f).must_equal 87360.0
+      _(mins.to_f).must_be_close_to 87658.2, 0.1
     end
 
     it "converts to hours" do
       hours = subject.to_hours
       _(hours).must_be_instance_of Duration::Hours
-      _(hours.to_f).must_equal 1456.0
+      _(hours.to_f).must_be_close_to 1460.97, 0.01
     end
 
     it "converts to days" do
       days = subject.to_days
       _(days).must_be_instance_of Duration::Days
-      _(days.to_f).must_be_close_to 60.66, 0.01
+      _(days.to_f).must_be_close_to 60.87375, 0.01
     end
 
     it "converts to weeks" do
       weeks = subject.to_weeks
       _(weeks).must_be_instance_of Duration::Weeks
-      _(weeks.to_f).must_be_close_to 8.66, 0.01
+      _(weeks.to_f).must_be_close_to 8.69625, 0.01
     end
 
     it "returns itself for to_months" do

data/test/Duration/Seconds_test.rb

@@ -49,7 +49,7 @@ describe Duration::Seconds do
     it "converts to months" do
       months = subject.to_months
       _(months).must_be_instance_of Duration::Months
-      _(months.to_f).must_be_close_to 3.4340659e-05, 0.00000001
+      _(months.to_f).must_be_close_to 3.422384e-05, 0.00000001
     end
 
     it "returns itself for to_seconds" do

data/test/Duration/Weeks_test.rb

@@ -49,7 +49,7 @@ describe Duration::Weeks do
     it "converts to months" do
       months = subject.to_months
       _(months).must_be_instance_of Duration::Months
-      _(months.to_f).must_be_close_to 0.4615384, 0.0000001
+      _(months.to_f).must_be_close_to 0.459968, 0.000001
     end
 
     it "returns itself for to_weeks" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: duration.rb
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.5
 platform: ruby
 authors:
 - thoran
@@ -15,6 +15,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- CHANGELOG
 - Gemfile
 - README.md
 - duration.rb.gemspec
@@ -57,7 +58,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.0
+rubygems_version: 4.0.16
 specification_version: 4
 summary: Objects for handling durations of time.
 test_files: []