durable_decorator 0.0.8 → 0.0.9

data/README.md

@@ -4,6 +4,7 @@
 
 [![Build Status](https://travis-ci.org/jumph4x/durable_decorator.png)](https://travis-ci.org/jumph4x/durable_decorator)
 [![Code Climate](https://codeclimate.com/github/jumph4x/durable_decorator.png)](https://codeclimate.com/github/jumph4x/durable_decorator)
+[![Dependency Status](https://gemnasium.com/jumph4x/durable_decorator.png)](https://gemnasium.com/jumph4x/durable_decorator)
 
 This is a project for modifying the behavior of gems outside of your reach. You may be using a large Rails Engine and be wanting to simply decorate some existing behavior, but at the same time you want to inherit original behavior. 
 
@@ -77,6 +78,29 @@ DurableDecorator::TamperedDefinitionError: Method SHA mismatch, the definition h
 
 DurableDecorator also maintains explicit versions of each method overriden by creating aliases with appended SHAs of the form ```some_method_1234abcd``` so you can always target explicit method versions without relying on ```some_method_original```.
 
+DurableDecorator maintains 3 versions of aliases to previous method versions, 2 of which are short-SHA versions, akin to Github:
+```ruby
+DurableDecorator::Base.determine_sha('ExampleClass#no_param_method')
+# => 'ba3114b2d46caa684b3f7ba38d6f74b2'
+
+ExampleClass.class_eval do
+  durably_decorate :string_method do
+    "new"
+  end
+end
+
+# 3 explicit aliases preserve access to the original method based on it's original SHA:
+# 4-char SHA, 6-char SHA and the full SHA suffix
+
+instance = ExampleClass.new
+instance.string_method_ba31
+# => "original"
+instance.string_method_ba3114
+# => "original"
+instance.string_method_ba3114b2d46caa684b3f7ba38d6f74b2
+# => "original"
+```
+
 ### No more suprise monkey patching
 Once you decorate the method and seal it with its SHA, if some gem tries to come in and overwrite your work **BEFORE** decorate-time, DurableDecorator will warn you. Similarly, expect to see an exception bubble up if the definition of the original method has changed and requires a review and a re-hash. 
 

data/durable_decorator.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "method_source"
   spec.add_dependency "logging"
-  spec.add_dependency "activesupport"
+  #spec.add_dependency "activesupport"
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"

data/lib/durable_decorator/base.rb

@@ -3,7 +3,6 @@ require 'digest/sha1'
 module DurableDecorator
   class Base
     class << self
-      DECORATION_MODES = ['strict']
       REDEFINITIONS = {}
 
       def reset!
@@ -32,33 +31,13 @@ module DurableDecorator
       def existing_method clazz, method_name, meta, &block
         return if redefined? clazz, method_name, &block
 
-        old_method = validate_existing_definition clazz, method_name
-        validate_method_arity clazz, method_name, old_method, &block
-        validate_decoration_meta clazz, method_name, old_method, meta
+        old_method = Validator.validate_existing_definition clazz, method_name
+        Validator.validate_method_arity clazz, method_name, old_method, &block
+        Validator.validate_decoration_meta clazz, method_name, old_method, meta
 
         old_method
       end
 
-      def validate_decoration_meta clazz, method_name, old_method, meta
-        return unless meta
-
-        chill_meta = Util.symbolized_hash(meta)
-
-        raise InvalidDecorationError, "The hash provided to the decorator is invalid" unless DECORATION_MODES.include? chill_meta[:mode] and chill_meta[:sha] and !chill_meta[:sha].empty?
-        raise TamperedDefinitionError, "Method SHA mismatch, the definition has been tampered with" unless Util.method_sha(old_method) == chill_meta[:sha]
-      end
-
-      def validate_method_arity clazz, method_name, old_method, &block
-        raise BadArityError, "Attempting to override #{clazz}'s #{method_name} with incorrect arity." if block.arity != old_method.arity and block.arity > 0 # See the #arity behavior disparity between 1.8- and 1.9+
-      end
-
-      def validate_existing_definition clazz, method_name
-        begin
-          clazz.instance_method(method_name)
-        rescue NameError => e
-          raise UndefinedMethodError, "#{clazz}##{method_name} is not defined."
-        end
-      end
 
       def redefine_method clazz, method_name, &block
         clazz.class_eval do
@@ -116,7 +95,7 @@ module DurableDecorator
       end
 
       def determine_sha target
-        raise "Please provide a fully qualified method name: Module::Clazz#instance_method or ::clazz_method" unless target.match(/\.|#/)
+        raise "Please provide a fully qualified method name: Module::Clazz#instance_method or ::clazz_method" unless target && target.match(/\.|#/)
 
         class_name, separator, method_name = target.match(/(.*)(\.|#)(.*)/)[1..3]
         clazz = Constantizer.constantize(class_name)

data/lib/durable_decorator/validator.rb

@@ -0,0 +1,29 @@
+module DurableDecorator
+  class Validator
+    class << self
+      DECORATION_MODES = ['strict']
+
+      def validate_decoration_meta clazz, method_name, old_method, meta
+        return unless meta
+
+        chill_meta = Util.symbolized_hash(meta)
+
+        raise InvalidDecorationError, "The hash provided to the decorator is invalid" unless DECORATION_MODES.include? chill_meta[:mode] and chill_meta[:sha] and !chill_meta[:sha].empty?
+        raise TamperedDefinitionError, "Method SHA mismatch, the definition has been tampered with" unless Util.method_sha(old_method) == chill_meta[:sha]
+      end
+
+      def validate_method_arity clazz, method_name, old_method, &block
+        raise BadArityError, "Attempting to override #{clazz}'s #{method_name} with incorrect arity." if block.arity != old_method.arity and block.arity > 0 # See the #arity behavior disparity between 1.8- and 1.9+
+      end
+
+      def validate_existing_definition clazz, method_name
+        begin
+          clazz.instance_method(method_name)
+        rescue NameError => e
+          raise UndefinedMethodError, "#{clazz}##{method_name} is not defined."
+        end
+      end
+    end
+  end
+end
+

data/lib/durable_decorator/version.rb

@@ -1,3 +1,3 @@
 module DurableDecorator
-  VERSION = "0.0.8"
+  VERSION = "0.0.9"
 end

data/lib/durable_decorator.rb

@@ -9,6 +9,7 @@ require "durable_decorator/version"
 require "durable_decorator/constantizer"
 require "durable_decorator/base"
 require "durable_decorator/util"
+require "durable_decorator/validator"
 
 # errors
 require "durable_decorator/bad_arity_error"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: durable_decorator
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-20 00:00:00.000000000 Z
+date: 2013-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: method_source
@@ -43,22 +43,6 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -130,6 +114,7 @@ files:
 - lib/durable_decorator/tampered_definition_error.rb
 - lib/durable_decorator/undefined_method_error.rb
 - lib/durable_decorator/util.rb
+- lib/durable_decorator/validator.rb
 - lib/durable_decorator/version.rb
 - spec/durable_decorator_spec.rb
 - spec/example_class.rb