dumb_delegator 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 8524fe928dd6b0408756da095f04ea57e1036e6f
-  data.tar.gz: a39869c5c1b01db9a97f8809619dd6774986e27d
+SHA256:
+  metadata.gz: 63674a3e04272740045c64f5cd122fb431c333be76ffb7f5364067e28f31ef44
+  data.tar.gz: 8b6ad9d8f119f2e8092e9fd5027ea076a41420ab76ea3555587577a12b234027
 SHA512:
-  metadata.gz: 82918496afa98bd4571110957ea147c93d23af57ba12d686e4fab24ad5e756e390a4815cf81ad95a3be64c0eed17b534bbe509e18086ac07a2033a17eafeb650
-  data.tar.gz: 086cec5a4ccd5e2d7450c892e3a42995cefa323ef6ffdcab7263b1637edf68c008b82e9bca2cc0ab9e6d3ce8dfa1a1dd3914aa2f565537a58ee526ca2d58cbe9
+  metadata.gz: e5c94e20a372ff9fb834e9efe3b9bf922bc3539af15bab58aafa1fd5d8403a31b8de7728d7a6fdd7d8a90558333a2b326b866549156af3405049d811ac9b9bce
+  data.tar.gz: 180f72c3eb297c0ea3e14f36dd87d9c13951316371f4d3d0c6eeb70e09812b4d7ee509fae5515e4559be3969612fced9da7adaa4cb5b2c4ea8459d9b77c179fd

data/.travis.yml

@@ -1,12 +1,29 @@
 language: ruby
+dist: xenial
+env:
+  global:
+    - CC_TEST_REPORTER_ID=de7062a4090ce5638b515a2cf9f2ab619de3e3f4ff439dc6cdad025c7a8d6b76
 rvm:
   - 1.9.3
-  - 2.0.0
-  - 2.1.4
+  - 2.0
+  - 2.1
+  - 2.2
+  - 2.3
+  - 2.4
+  - 2.5
+  - 2.6
+  - 2.7
   - jruby-19mode
-  - rbx-2
-  - rbx
-  - rbx-2
-addons:
-  code_climate:
-    repo_token: aa3e0e1258e480f3446dd626e825c0a93153fce83ee0cc2f007096546389c882
+  - jruby
+cache: bundler
+before_install:
+  - gem update --system --conservative || (gem i "rubygems-update:~>2.7" --no-document && update_rubygems) # see: https://github.com/rubygems/rubygems/issues/2534#issuecomment-448843746
+  - gem update bundler --conservative
+before_script:
+  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+  - chmod +x ./cc-test-reporter
+  - ./cc-test-reporter before-build
+script:
+  - bundle exec rake spec
+after_script:
+  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT

data/CHANGELOG.md

@@ -0,0 +1,13 @@
+# Change Log
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
+
+## [Unreleased]
+
+## [0.8.1] 2020-01-25
+### Changed
+  - Explicitly Require Ruby >= 1.9.3
+
+### Added
+  - This CHANGELOG file.

data/Gemfile

@@ -3,4 +3,4 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in dumb_delegator.gemspec
 gemspec
 
-gem 'codeclimate-test-reporter', :group => :test, :require => nil
+gem "simplecov", :group => :test, :require => nil

data/README.md

@@ -1,19 +1,19 @@
 # DumbDelegator
 
-[![Gem Version](http://img.shields.io/gem/v/dumb_delegator.svg)](https://rubygems.org/gems/dumb_delegator)
-[![Build Status](https://img.shields.io/travis/stevenharman/dumb_delegator.svg)](https://travis-ci.org/stevenharman/dumb_delegator)
-[![Code Climate](http://img.shields.io/codeclimate/github/stevenharman/dumb_delegator.svg)](https://codeclimate.com/github/stevenharman/dumb_delegator)
-[![Dependency Status](https://img.shields.io/gemnasium/stevenharman/dumb_delegator.svg)](https://gemnasium.com/stevenharman/dumb_delegator)
+[![Gem Version](https://badge.fury.io/rb/dumb_delegator.svg)](https://badge.fury.io/rb/dumb_delegator)
+[![Build Status](https://travis-ci.org/stevenharman/dumb_delegator.svg?branch=master)](https://travis-ci.org/stevenharman/dumb_delegator)
+[![Maintainability](https://api.codeclimate.com/v1/badges/b684cbe08af745cbe957/maintainability)](https://codeclimate.com/github/stevenharman/dumb_delegator/maintainability)
+[![Test Coverage](https://api.codeclimate.com/v1/badges/b684cbe08af745cbe957/test_coverage)](https://codeclimate.com/github/stevenharman/dumb_delegator/test_coverage)
 
-Ruby provides the `delegate` standard library. However, we found that it is not
-appropriate for many use cases that require nearly every call to be proxied.
 
-For instance, Rails uses `#class` and `#instance_of?` to introspect on model
-classes when generating forms and URL helpers. These methods are not forwarded
-when using `Delegator` or `SimpleDelegator`.
+Ruby provides the `delegate` standard library.
+However, we found that it is not appropriate for cases that require nearly every call to be proxied.
+
+For instance, Rails uses `#class` and `#instance_of?` to introspect on model classes when generating forms and URL helpers.
+These methods are not forwarded when using `Delegator` or `SimpleDelegator`.
 
 ```ruby
-require 'delegate'
+require "delegate"
 
 class MyAwesomeClass
   # ...
@@ -22,14 +22,14 @@ end
 o = MyAwesomeClass.new
 d = SimpleDelegator.new(o)
 
-d.class                # => SimpleDelegator
-d.is_a? MyAwesomeClass # => false
+d.class                #=> SimpleDelegator
+d.is_a? MyAwesomeClass #=> false
 ```
 
-`DumbDelegator`, on the other hand, forwards almost ALL the things:
+`DumbDelegator`, on the other hand, forwards almost ALL THE THINGS:
 
 ```ruby
-require 'dumb_delegator'
+require "dumb_delegator"
 
 class MyAwesomeClass
   # ...
@@ -38,25 +38,23 @@ end
 o = MyAwesomeClass.new
 d = DumbDelegator.new(o)
 
-d.class                # => MyAwesomeClass
-d.is_a? MyAwesomeClass # => true
+d.class                #=> MyAwesomeClass
+d.is_a? MyAwesomeClass #=> true
 ```
 
 ## Usage
 
 ### Rails Model Decorator
 
-There are [many decorator
-implementations](http://robots.thoughtbot.com/post/14825364877/evaluating-alternative-decorator-implementations-in)
-in Ruby. One of the simplest is "SimpleDelegator + super + getobj," but it has
-the drawback of confusing Rails. It is necessary to redefine `class`. We've
-also observed the need to redefine `instance_of?` for URL helpers.
+There are [many decorator implementations](http://robots.thoughtbot.com/post/14825364877/evaluating-alternative-decorator-implementations-in) in Ruby.
+One of the simplest is "`SimpleDelegator` + `super` + `__getobj__`," but it has the drawback of confusing Rails.
+It is necessary to redefine `#class`.
+We've also observed the need to redefine `#instance_of?` for URL helpers.
 
-With `DumbDelegator`, there's not a need for this hackery because nearly every
-possible method is delegated:
+With `DumbDelegator`, there's not a need for this hackery because nearly every possible method is delegated:
 
 ```ruby
-require 'dumb_delegator'
+require "dumb_delegator"
 
 class Coffee
   def cost
@@ -64,7 +62,7 @@ class Coffee
   end
 
   def origin
-    'Colombia'
+    "Colombia"
   end
 end
 
@@ -81,17 +79,17 @@ class Sugar < DumbDelegator
 end
 
 coffee = Coffee.new
-Sugar.new(Milk.new(coffee)).cost   # 2.6
-Sugar.new(Sugar.new(coffee)).cost  # 2.4
-Milk.new(coffee).origin            # Colombia
-Sugar.new(Milk.new(coffee)).class  # Coffee
+Sugar.new(Milk.new(coffee)).cost   #=> 2.6
+Sugar.new(Sugar.new(coffee)).cost  #=> 2.4
+Milk.new(coffee).origin            #=> Colombia
+Sugar.new(Milk.new(coffee)).class  #=> Coffee
 ```
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
-    gem 'dumb_delegator'
+    gem "dumb_delegator"
 
 And then execute:
 

data/dumb_delegator.gemspec

@@ -2,8 +2,11 @@
 require File.expand_path('../lib/dumb_delegator/version', __FILE__)
 
 Gem::Specification.new do |gem|
+  gem.name = "dumb_delegator"
+  gem.version = DumbDelegator::VERSION
+  gem.required_ruby_version = ">= 1.9.3"
   gem.authors       = ['Andy Lindeman', 'Steven Harman']
-  gem.email         = ['alindeman@gmail.com', 'steveharman@gmail.com']
+  gem.email         = ['alindeman@gmail.com', 'steven@harmanly.com']
   gem.description   = %q{Delegator class that delegates ALL the things}
   gem.summary       = <<-EOD
     Delegator and SimpleDelegator in Ruby's stdlib are somewhat useful, but they pull in most of Kernel. This is not appropriate for many uses; for instance, delegation to Rails models.
@@ -12,11 +15,8 @@ Gem::Specification.new do |gem|
 
   gem.files         = `git ls-files`.split($\)
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
-  gem.name          = 'dumb_delegator'
   gem.require_paths = ['lib']
-  gem.version       = DumbDelegator::VERSION
 
-  gem.add_development_dependency 'pry'
   gem.add_development_dependency 'rake', '~> 10.0'
-  gem.add_development_dependency 'rspec', '~> 3.1'
+  gem.add_development_dependency 'rspec', '~> 3.4'
 end

data/lib/dumb_delegator/version.rb

@@ -1,3 +1,3 @@
 class DumbDelegator < ::BasicObject
-  VERSION = '0.8.0'
+  VERSION = "0.8.1"
 end

data/spec/dumb_delegator_spec.rb

@@ -1,78 +1,103 @@
 require 'spec_helper'
 
 describe DumbDelegator do
-  subject(:dummy) { described_class.new(target) }
-  let(:target) { double }
+  subject(:dummy) { Wrapper.new(target) }
+  let(:target) { Target.new }
 
-  it 'delegates to the target object' do
-    expect(target).to receive(:foo)
-    dummy.foo
+  class Wrapper < DumbDelegator
+    def wrapper_method
+      "Method only on wrapper."
+    end
+
+    def common_method
+      ["Method on wrapper.", super].join(" ")
+    end
   end
 
-  it 'delegates to the target object with arguments' do
-    expect(target).to receive(:foo).with(:bar)
+  class Target
+    def common_method
+      "Method on target."
+    end
+
+    def target_method
+      "Method only on target."
+    end
+
+    def query(*args)
+      "queried with #{args}"
+    end
 
-    dummy.foo(:bar)
+    def with_block(&block)
+      block.call
+    end
   end
 
-  it 'delegates to the target object with a block' do
-    bar_block = proc { 'bar' }
-    expect(target).to receive(:foo) { |&block| expect(block).to eq(bar_block) }
+  it "delegates to the target object" do
+    expect(dummy.target_method).to eq("Method only on target.")
+  end
 
-    dummy.foo(&bar_block)
+  it "delegates to the target object with arguments" do
+    result = dummy.query("some_key", 42)
+
+    expect(result).to eq(%(queried with ["some_key", 42]))
   end
 
-  it 'does not delegate if the target does not respond_to? the message' do
-    allow(target).to receive(:foo)
-    allow(target).to receive(:respond_to?).with(:foo).and_return(false)
+  it "delegates to the target object with a block" do
+    result = dummy.with_block { "block called!" }
+
+    expect(result).to eq("block called!")
+  end
 
+  it "errors if the method is not defined on the wrapper nor the target" do
     expect {
-      dummy.foo
+      dummy.no_such_method
     }.to raise_error(NoMethodError)
   end
 
-  it 'responds to methods defined by child classes that add behavior' do
-    expect(target).to receive(:foo).never
-    def dummy.foo
-      'bar'
-    end
+  it "responds to methods defined by child classes" do
+    expect(target).to receive(:wrapper_method).never
 
-    dummy.foo
+    expect(dummy.wrapper_method).to eq("Method only on wrapper.")
   end
 
-  it 'delegates methods defined on Object' do
-    expect(target).to receive(:class)
-    dummy.class
+  it "responds to methods defined by child classes, and can super up to target" do
+    expect(dummy.common_method).to eq("Method on wrapper. Method on target.")
   end
 
-  it 'delegates is_a?' do
-    expect(target).to receive(:is_a?)
-    dummy.is_a?
+  it "delegates methods defined on Object" do
+    expect(dummy.class).to eq(Target)
   end
 
-  it 'delegates methods defined on Kernel' do
-    expect(target).to receive(:print)
-    dummy.print
+  it "delegates methods defined on Kernel" do
+    expect(target).to receive(:nil?)
+    dummy.nil?
   end
 
-  it 'delegates !' do
-    expect(target).to receive(:!)
-    !dummy
+  it "delegates bang (!) operator" do
+    allow(target).to receive(:!) { "bang!" }
+    expect(!dummy).to eq("bang!")
   end
 
-  it 'delegates !=' do
-    expect(target).to receive(:!=)
-    dummy != 1
+  it "delegates object inequivalence" do
+    allow(target).to receive(:!=).and_call_original
+
+    expect(dummy != target).to be false
+  end
+
+  it "delegates object equivalence" do
+    expect(dummy).to eql(target)
+    expect(dummy == target).to be true
   end
 
-  it 'delegates ==' do
-    expect(target).to receive(:==)
-    dummy == 1
+  it "delegates class checks" do
+    expect(dummy.is_a?(Target)).to be(true)
+    expect(dummy.kind_of?(Target)).to be(true) # rubocop:disable Style/ClassCheck
+    expect(dummy.instance_of?(Target)).to be(true)
   end
 
-  it 'delegates ==' do
-    expect(target).to receive(:==)
-    dummy == 1
+  it "delegates ===" do
+    pending("Implement #=== on DumbDelegator")
+    expect(dummy === Target).to be true
   end
 
   it 'delegates instance_eval' do
@@ -119,18 +144,16 @@ describe DumbDelegator do
       end
     end
 
-    context 'subclasses of DumbDelegator' do
-      subject(:dummy) { Class.new(DumbDelegator) { def foobar; end }.new([]) }
-
-      it 'respond to methods defined on the subclass' do
-        expect(dummy.respond_to?(:foobar)).to be true
+    context "subclasses of DumbDelegator" do
+      it "respond to methods defined on the subclass" do
+        expect(dummy).to respond_to(:target_method)
       end
     end
   end
 
-  describe '#__getobj__' do
-    it 'returns the target object' do
-      expect(dummy.__getobj__).to equal target
+  describe "#__getobj__" do
+    it "returns the target object" do
+      expect(dummy.__getobj__).to equal(target)
     end
   end
 

data/spec/spec_helper.rb

@@ -1,10 +1,9 @@
-if ENV['CODECLIMATE_REPO_TOKEN']
-  require 'codeclimate-test-reporter'
-  CodeClimate::TestReporter.start
+if ENV["CODECLIMATE_REPO_TOKEN"]
+  require "simplecov"
+  SimpleCov.start
 end
 
 require File.expand_path('../lib/dumb_delegator', File.dirname(__FILE__))
-require 'pry'
 
 RSpec.configure do |config|
   config.run_all_when_everything_filtered = true

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dumb_delegator
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Andy Lindeman
@@ -9,22 +9,8 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-25 00:00:00.000000000 Z
+date: 2020-01-26 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -45,18 +31,18 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.4'
 description: Delegator class that delegates ALL the things
 email:
 - alindeman@gmail.com
-- steveharman@gmail.com
+- steven@harmanly.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -64,6 +50,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md
@@ -84,15 +71,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.2
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Delegator and SimpleDelegator in Ruby's stdlib are somewhat useful, but they
@@ -101,4 +87,3 @@ summary: Delegator and SimpleDelegator in Ruby's stdlib are somewhat useful, but
 test_files:
 - spec/dumb_delegator_spec.rb
 - spec/spec_helper.rb
-has_rdoc: