ductwork 1.3.0 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 94c5c2250e4a96fee3aaeac379ec1ee58ac85e6aa5c2f0ccffc67c9e66d4499d
-  data.tar.gz: ac6aac4135803b6d0712db4b4491202b64280a506a3101baba6563f549e5ee9d
+  metadata.gz: 9ef52f554cf6549026270cbe5f80e7d7b84b01824b5839d1c5161e1080bdc94a
+  data.tar.gz: 7c83791f6a2a555babc3fda4774e2ef5cbd4e821c180b4a8f8627c900c366f76
 SHA512:
-  metadata.gz: d7305c2c9a26693cfa92dce562016420aafe4d745cb3efb4450b5192a8c036d7db5d96023b71979bd15c817059c2f8f2933f974a441066ec891cb2132d802c99
-  data.tar.gz: 54dfdadfcafe3e1e4a214f5d11599e87bc3b114387702b426aad5c146ec7ca2042c42e0fa001cd0d598e11b515a342f8f01d5ac3b96a4f6b982d6579f93b50a7
+  metadata.gz: 2492fab3347973f79cd0e2e7d63fa2850ed44567e9ce8ec3370bdb6f7041ee744c2ea01c065d403c379ac85c0f3cc80d2ed2d30409cb1644775e0a67cb6dab4d
+  data.tar.gz: 9d3640e4e883e215fbfc0c37acbdbf0fca432b38bb93d9926f8916649486fa442029e22c7ac22713946243c6c8f823fb204d5e36312dfa3bf797fa370953ce85

data/.claude/skills/audit-common/accepted-tradeoffs.md

@@ -96,11 +96,6 @@ its place through divergent behavior rather than labeling. Cause metadata
 lives on `Branch#halt_reason` instead. Pipeline and Run states stay
 `in_progress`, `completed`, `halted`.
 
-## 7. `Ductwork.validate!` is not run at boot
-
-It runs in host-application specs, deliberately, for developer experience. Do
-not recommend moving it to boot-time or engine initialization.
-
 ---
 
 # Known Open — report only with new information

data/CHANGELOG.md

@@ -1,5 +1,24 @@
 # Ductwork Changelog
 
+## [1.5.0]
+
+- fix: re-enqueue the failed step when reviving a branch halted with `job_crashes_exhausted` - revive re-advanced it as if the job had succeeded, passing a missing return value downstream
+- fix: copy each succeeded step's job when reviving a pipeline so a `combine` or `collapse` after the revive receives every sibling's return value - the copied steps had no jobs, so the fan-in silently dropped siblings that had already completed
+- feat: redesign the dashboard with top-level navigation, an overview of halted pipelines and pipelines by class, status tabs with counts, compact expandable step and error rows, and a phone layout
+- feat: draw the workflow on the dashboard's pipeline page in place of the raw definition, with each node showing its step counts by status, retried and crash-recovered steps, and halt reasons, and linking to the matching steps
+- feat: add a node filter to the steps list on the dashboard's pipeline page and show the page position, disabling the next button on the last page
+- fix: stop the dashboard's runtime timer on halted runs and failed steps
+- fix: print error backtraces once on the dashboard - they were followed by a dump of the same lines as an array
+- fix: count dashboard errors per run instead of per pipeline, without loading every step of every listed run
+- fix: filter the dashboard's pipeline page steps by `klass` - the shared filter queried `pipeline_klass`, which only exists on runs, so choosing a class raised `ActiveRecord::StatementInvalid`
+- fix: order the steps list by `started_at` then `id` so steps sharing a timestamp are not repeated or skipped between pages
+- fix: clamp the dashboard's page number at zero - the previous link on the first page pointed at `page=-1`, a negative `OFFSET` that PostgreSQL rejects
+- chore: replace the dashboard's vendored Pico and flexboxgrid stylesheets with a single stylesheet and remove all inline styles
+
+## [1.4.0]
+
+- feat: validate steps and pipelines/workflows during boot of main process
+
 ## [1.3.0]
 
 - feat: add more `MigrationHelper` methods for swapping and updating the availability claim index

data/app/assets/javascripts/ductwork/application.js

@@ -1,53 +1,62 @@
-document.addEventListener('DOMContentLoaded', function() {
-  const timerElements = document.querySelectorAll('[data-started-at]');
-
-  timerElements.forEach(function(element) {
-    const startedAt = new Date(element.dataset.startedAt);
-    const displayElement = element.querySelector('#elapsed-timer');
-
-    function updateTimer() {
-      const now = new Date();
-      const elapsed = Math.floor(Math.abs(now - startedAt) / 1000);
-
-      const hours = Math.floor(elapsed / 3600);
-      const minutes = Math.floor((elapsed % 3600) / 60);
-      const seconds = elapsed % 60;
+function formatElapsed(milliseconds) {
+  const elapsed = Math.floor(Math.max(milliseconds, 0) / 1000);
+  const hours = Math.floor(elapsed / 3600);
+  const minutes = Math.floor((elapsed % 3600) / 60);
+  const seconds = elapsed % 60;
+  const parts = [];
+
+  if (hours > 0) parts.push(`${hours}h`);
+  if (minutes > 0) parts.push(`${minutes}m`);
+  if (seconds > 0 || parts.length === 0) parts.push(`${seconds}s`);
+
+  return parts.join(' ');
+}
+
+function startTimers() {
+  const timers = document.querySelectorAll('[data-started-at]');
+
+  function tick() {
+    timers.forEach(function(timer) {
+      timer.textContent = formatElapsed(Date.now() - new Date(timer.dataset.startedAt));
+    });
+  }
 
-      const hoursStr = hours == 0 ? '' : `${String(hours)}h `;
-      const minutesStr = minutes == 0 ? '' : `${String(minutes)}m `;
-      const secondsStr = seconds == 0 ? '' : `${String(seconds)}s`;
+  if (timers.length > 0) {
+    tick();
+    setInterval(tick, 1000);
+  }
+}
 
-      if (now > startedAt) {
-        displayElement.textContent = hoursStr + minutesStr + secondsStr;
-      } else {
-        displayElement.textContent = 'In ' + hoursStr + minutesStr + secondsStr;
-      }
-    }
+function linkRows() {
+  document.querySelectorAll('tr[data-href]').forEach(function(row) {
+    row.addEventListener('click', function(event) {
+      const selectingText = !window.getSelection().isCollapsed;
 
-    updateTimer();
-    setInterval(updateTimer, 1000);
-  });
+      if (selectingText || event.target.closest('a')) return;
 
-  document.querySelectorAll('[data-href]').forEach(function(element) {
-    element.addEventListener('click', function() {
-      window.location.href = element.dataset.href;
+      window.location.href = row.dataset.href;
     });
   });
+}
 
-  document.querySelectorAll('[data-open-modal]').forEach(function(element) {
-    element.addEventListener('click', function() {
-      const modalId = element.dataset.openModal;
-
-      document.getElementById(modalId).setAttribute('open', '');
-    });
+function closeMenus(except) {
+  document.querySelectorAll('details.menu[open]').forEach(function(menu) {
+    if (menu !== except) menu.removeAttribute('open');
   });
+}
 
-  document.querySelectorAll('[data-close-modal]').forEach(function(element) {
-    element.addEventListener('click', function() {
-      const modalId = element.dataset.closeModal;
+function dismissMenus() {
+  document.addEventListener('click', function(event) {
+    closeMenus(event.target.closest('details.menu'));
+  });
 
-      document.getElementById(modalId).removeAttribute('open');
-    });
+  document.addEventListener('keydown', function(event) {
+    if (event.key === 'Escape') closeMenus();
   });
-});
+}
 
+document.addEventListener('DOMContentLoaded', function() {
+  startTimers();
+  linkRows();
+  dismissMenus();
+});