ductwork 1.1.1 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd349349c33899f1c8cdcf97339176dd72fb6397df4dbccba7445946337810b1
-  data.tar.gz: 39560169d62cd46193221f6d74f00524b39314bc470787213f891260bcc5a3db
+  metadata.gz: 402e7de6f5703214be13a443e54a5b74f113500a22ad42727db969a7bcb39b69
+  data.tar.gz: 9889dd598476068548da0f6cf9e63cf94f72e6e124b837d3abe2994de6a2770f
 SHA512:
-  metadata.gz: 62b5cc64d92c9b5caf225624bb51a252d550f48bbcbc4f5a73ffc19e464964477f41bceec74a654c783859890fcfab84305327abdf4685fa460ffbeb6e35fdff
-  data.tar.gz: 0d4483bcd3dce63092438c392cc6089f9b8ad9a8e5730cb133fbc7bacd22d0a82ff6afdabb285c447593afcc13979d3f74df3d57801861eb13815d91d5744a46
+  metadata.gz: 2eb520b852ff56484b7afd3f89a525f4e444ba2a04a03ff3d97152bdad625cf5d393a2500a72bcdd2ca8a4122f726caaadcd8aa4c626e70e8ba6397ec84bd5df
+  data.tar.gz: 8667ad5225297be4b5c98383fbe0ad3766e18a33391912d110e9aae94bcaa5c9949089fb2c8f4eb0d6f0f17c8588626e82e6c7abe90aa0293a2081dffe8aef82

data/CHANGELOG-PRO.md

@@ -1,7 +1,20 @@
 # Ductwork Pro Changelog
 
-## [1.1.1] (Unreleased)
+## [1.1.2]
 
+- fix: remove unnecessary setting of configuration object during class-level evaluation - this catches up with OSS changes
+- fix: pass extra step id argument when instantiating steps during execution - this catches up with current OSS changes
+
+## [1.1.1]
+
+- fix: use `Ductwork::DatabaseClock` instead of `Time.current` for every `started_at` Pro stamps, mirroring the OSS fix
+- fix: evaluate the step-timeout deadline in the database (`DatabaseClock.ago_sql`) instead of subtracting `attempt.started_at` from the worker's `Time.current`, so an NTP correction mid-job cannot stretch or collapse a step's timeout
+- fix: temporarily handle multiple return types from `Branch.with_latest_claimed` - this is a result of changes in OSS from v1.1.0 and v1.1.1
+- fix: log the claimed job/branch of a dead thread before the restart clears it
+- fix: add rubocop cop for ensuring `updated_at` is updated (copied from OSS)
+- fix: explicitly set `updated_at` for queries that update the record directly
+- fix: mirror OSS `halt_branch_and_resolve_run_without_rescue!` implementation
+- fix: walk the `collapse` fan-in with an explicit keyset scan so each batch is one indexed range seek, instead of a per-batch subquery plus a second `in_batches` query that re-ran the whole scope
 - fix: don't use `unique_by` argument for `insert_all` for mysql and trilogy database adapters
 
 ## [1.1.0]

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Ductwork Changelog
 
+## [1.2.0]
+
+- feat: add `add_availability_claim_index` and `remove_availability_claim_index` to `Ductwork::MigrationHelper`, which own the adapter-specific shape and the name of the availability claim index
+- chore: build the availability claim index through the new migration helpers
+
+## [1.1.2]
+
+- fix: lazily create configuration
+- fix: prevent step's idempotency key from returning `nil`
+
 ## [1.1.1]
 
 - fix: use database clock instead of `Time.current` to avoid clock skew in `Branch#latest_step` paths

data/lib/ductwork/engine.rb

@@ -20,7 +20,6 @@ module Ductwork
     end
 
     initializer "ductwork.configure" do
-      Ductwork.configuration ||= Ductwork::Configuration.new
       Ductwork.logger ||= Ductwork::Configuration::DEFAULT_LOGGER
     end
   end

data/lib/ductwork/migration_helper.rb

@@ -2,6 +2,29 @@
 
 module Ductwork
   module MigrationHelper
+    AVAILABILITY_CLAIM_INDEX_NAME = "index_ductwork_availabilities_on_claim_latest"
+
+    def add_availability_claim_index(extra_columns: [], where_extra: nil)
+      if mysql?
+        add_index :ductwork_availabilities,
+                  [:pipeline_klass, :completed_at, *extra_columns, :started_at],
+                  name: AVAILABILITY_CLAIM_INDEX_NAME
+      else
+        predicate = ["completed_at IS NULL", where_extra].compact.join(" AND ")
+
+        add_index :ductwork_availabilities,
+                  %i[pipeline_klass started_at],
+                  name: AVAILABILITY_CLAIM_INDEX_NAME,
+                  where: predicate
+      end
+    end
+
+    def remove_availability_claim_index
+      remove_index :ductwork_availabilities,
+                   name: AVAILABILITY_CLAIM_INDEX_NAME,
+                   if_exists: true
+    end
+
     def create_ductwork_table(table_name, &block)
       if postgresql?
         create_table table_name, id: :uuid, &block

data/lib/ductwork/models/execution.rb

@@ -29,7 +29,7 @@ module Ductwork
         job_klass: job.klass
       )
       args = JSON.parse(job.input_args)["args"]
-      instance = Object.const_get(job.klass).build_for_execution(job.step.run_id, *args)
+      instance = Object.const_get(job.klass).build_for_execution(job.step.run_id, job.step.id, *args)
       create_attempt!(started_at: Time.current)
       output_payload = nil
 

data/lib/ductwork/models/step.rb

@@ -40,23 +40,22 @@ module Ductwork
          converge: "converge",
          dampen: "dampen"
 
-    def self.build_for_execution(run_id, *, **)
+    def self.build_for_execution(run_id, idempotency_key, *, **)
       instance = allocate
       instance.instance_variable_set(:@run_id, run_id)
+      instance.instance_variable_set(:@idempotency_key, idempotency_key)
       instance.send(:initialize, *, **)
       instance
     end
 
-    alias_attribute :idempotency_key, :id
-
     def run_id
       @run_id || (@attributes && super)
     end
 
-    # The result_type of the most recent execution to finish for this step's
-    # job, used to distinguish *why* a step failed (e.g. `errored!` writes
-    # "failure", `crashed!` writes "process_crashed"). Returns nil when no
-    # execution has produced a result yet.
+    def idempotency_key
+      @idempotency_key || (@attributes && id)
+    end
+
     def terminal_result_type
       return if job.blank?
 

data/lib/ductwork/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ductwork
-  VERSION = "1.1.1"
+  VERSION = "1.2.0"
 end

data/lib/ductwork.rb

@@ -11,8 +11,12 @@ require "zeitwerk"
 
 module Ductwork
   class << self
-    attr_accessor :app_executor, :configuration, :loader, :logger
-    attr_writer :defined_pipelines, :hooks
+    attr_accessor :app_executor, :loader, :logger
+    attr_writer :configuration, :defined_pipelines, :hooks
+
+    def configuration
+      @configuration ||= Ductwork::Configuration.new
+    end
 
     def eager_load
       loader.eager_load

data/lib/generators/ductwork/install/templates/db/create_ductwork_availabilities.rb

@@ -26,15 +26,6 @@ class CreateDuctworkAvailabilities < Ductwork::Migration
     add_index :ductwork_availabilities, :execution_id, unique: true
     add_index :ductwork_availabilities, %i[id process_id]
 
-    if mysql?
-      add_index :ductwork_availabilities,
-                %i[pipeline_klass completed_at started_at],
-                name: "index_ductwork_availabilities_on_claim_latest"
-    else
-      add_index :ductwork_availabilities,
-                %i[pipeline_klass started_at],
-                name: "index_ductwork_availabilities_on_claim_latest",
-                where: "completed_at IS NULL"
-    end
+    add_availability_claim_index
   end
 end

data/lib/generators/ductwork/update/templates/db/denormalize_pipeline_klass_on_availabilities.rb

@@ -11,17 +11,7 @@ class DenormalizePipelineKlassOnAvailabilities < Ductwork::Migration
       .update_all(pipeline_klass: "Pipeline")
 
     change_column_null :ductwork_availabilities, :pipeline_klass, false
-    remove_index :ductwork_availabilities, name: "index_ductwork_availabilities_on_claim_latest"
-
-    if mysql?
-      add_index :ductwork_availabilities,
-                %i[pipeline_klass completed_at started_at],
-                name: "index_ductwork_availabilities_on_claim_latest"
-    else
-      add_index :ductwork_availabilities,
-                %i[pipeline_klass started_at],
-                name: "index_ductwork_availabilities_on_claim_latest",
-                where: "completed_at IS NULL"
-    end
+    remove_availability_claim_index
+    add_availability_claim_index
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ductwork
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.0
 platform: ruby
 authors:
 - Tyler Ewing